Thank you, Mike. I was kind of frustrated by exactly what you point out.
With the "set +x," I worried that it would reset $?, but I didn't bother to check. --Mark On Wed, 30 Jul 2008, Mike Kupfer wrote: > Date: Wed, 30 Jul 2008 20:00:29 -0700 > From: Mike Kupfer <Mike.Kupfer at Sun.COM> > To: Mark J. Nelson <Mark.J.Nelson at Sun.COM> > Cc: scm-migration-dev at opensolaris.org > Subject: Re: [scm-migration-dev] quick review for followup putback for wx2hg > changes > >> set -x >> hg init $ws/$dir >> - ( cd $ws/$dir; hg pull -u "$primary_twin"/$dir ) >> + ( cd $ws/$dir; hg pull -u -r $rev "$primary_twin"/$dir ) >> + if (( $? != 0 )); then >> + warn "Unable to clone $primary_twin/$dir" >> + rev_warning=y >> + fi >> set +x > > I think that having the "set -x" active for the exit status check and > warning will be noisy, but I don't think it's critical. > > Man, I missed a couple things in my review yesterday (the pull was > missing -r, $hgrev was bogus)... :-( Glad you caught them. > > Anyway, looks good other than that. > > mike >
