Hey all, Could someone please review: 419 cdm shouldn't willingly create a changeset that does nothing (in reci) 436 cdm should remove undo data after reci
Webrev: http://cr.opensolaris.org/~richlowe/scm_419 Bugs: http://bugs.grommit.com/show_bug.cgi?id=419 http://bugs.grommit.com/show_bug.cgi?id=436 Evaluation is included in the comments of both bugs. I'd appreciate people keeping an eye on the logic involved, as well as the code to implement it (I'm pretty sure that doesn't need to be stated, but just in case). We need to nest the try/except within the try/finally due to a python limitation, python 2.4 (the version currently in Nevada) doesn't accept try/except/finally as a single block. Python 2.5 does, however (so while you may see it done, we can't do it). -- Rich
