Dave has been running builds since we switched over, and only one glitch
has been noticed:

6734627 protocmp complains about opt/SUNWdtrt/README after TW -> Hg switch

http://cr.opensolaris.org/~jbeck/SUNWdtrt-Makefile/

Note that bugs.opensolaris.org is not showing this, so I cut-and-pasted the
Description text into the webrev.

But while trying to generate the webrev for this, I ran into this problem:

[elpaso:78] webrev
   SCM detected: mercurial
 File list from: hg-active -p ssh://onnv.sfbay.sun.com//export/onnv-clone 
...option -o not recognized
usage: hg-active [-p parent] -w workspace
/usr/bin/nawk: can't open file /tmp/686933.active
 source line number 6
 Done.
Can't open /tmp/686933.active
^C
[elpaso:79] 

This seems to fix it:

--- /usr/src/tools/scripts/webrev.sh    Wed Aug  6 16:09:56 2008
+++ /export/home/jbeck/bin/webrev       Wed Aug  6 17:10:13 2008
@@ -1389,7 +1389,7 @@
        typeset parent=$2
 
        TMPFLIST=/tmp/$$.active
-       $HG_ACTIVE -w $child -p $parent -o $TMPFLIST
+       $HG_ACTIVE -w $child -p $parent | grep -v HG_PARENT= > $TMPFLIST
        wxfile=$TMPFLIST
 }
 
But since I don't know the intent of hg_active, I'm not sure if perhaps
the lack of support for -o in that script is the real bug, though either
way the "| grep -v HG_PARENT=" seems needed.

If I could please get a reviewer for the former and someone to comment
on the latter ("looks good", "no, you should do X instead"), I would
appreciate it.

-- John

http://blogs.sun.com/jbeck

Reply via email to