John Beck <jbeck at eng.sun.com> writes: > Dave has been running builds since we switched over, and only one glitch > has been noticed: > > 6734627 protocmp complains about opt/SUNWdtrt/README after TW -> Hg switch > > http://cr.opensolaris.org/~jbeck/SUNWdtrt-Makefile/ > > Note that bugs.opensolaris.org is not showing this, so I cut-and-pasted the > Description text into the webrev. > > But while trying to generate the webrev for this, I ran into this problem: > > [elpaso:78] webrev > SCM detected: mercurial > File list from: hg-active -p ssh://onnv.sfbay.sun.com//export/onnv-clone > ...option -o not recognized > usage: hg-active [-p parent] -w workspace > /usr/bin/nawk: can't open file /tmp/686933.active > source line number 6 > Done. > Can't open /tmp/686933.active > ^C > [elpaso:79] > > This seems to fix it: > > --- /usr/src/tools/scripts/webrev.sh Wed Aug 6 16:09:56 2008 > +++ /export/home/jbeck/bin/webrev Wed Aug 6 17:10:13 2008 > @@ -1389,7 +1389,7 @@ > typeset parent=$2 > > TMPFLIST=/tmp/$$.active > - $HG_ACTIVE -w $child -p $parent -o $TMPFLIST > + $HG_ACTIVE -w $child -p $parent | grep -v HG_PARENT= > $TMPFLIST > wxfile=$TMPFLIST > }
As Dan points out, you really don't want to do that. The need for -o stems from the junk that Hg will shove down stdout in some fairly common cases (the trust warning, motd on the machine your parent is one...). You would think that we could remove /^remote:/ there, where you remove HG_PARENT, but that will, no doubt, lead to someone using a checkin comment beginning 'remote:' in the future, and getting really confused, and then really angry. (of course, with that not posing a problem, nobody will ever try it. It always works out that way). I'm sorry that the update to hg-active caused problems. Something that maybe worth fixing is to attempt to find hg-active (and other stuff?) in $TOOLS_ROOT or similar places (or, perhaps, where webrev is being run from?) -- Rich
