Mike Kupfer <mike.kupfer at sun.com> writes: > I looked at the held-for-moderation queue for > onnv-notify at opensolaris.org this evening, and I noticed that it > contained several emails about setting the tag for the biweekly build. > The one funny thing about the messsages was that they all appeared to be > from someone in Russia. Other than that, they looked perfectly legit. > > After poking around some more, I figured out that there is a "daemon" > account on os.o, and its email address is this one in Russia. Since the > tag changesets are being done as daemon at elpaso, they're getting mapped > to that email address. > > Now, is this just a temporary issue, one that will go away when we move > the gate to Mercurial? Or do we need to think some more about automated > gate activity?
That's actually a more generic problem regarding the way the email lookup works (this is a result of the hack referred to on IRC), we lookup based on the username *from a changeset*, rather than that of the user putting back (because that's always the same account, for ON, right now). In the future, the notifications should, in my view, be From: the using who putback, not the author of the changesets they putback. This would deal with that. For a workaround, the best I can come up with is a blacklist (or, more accurately, a list of more-specific mappings), that take precedence over the lookup. daemon => <something real>, etc. However, I consider not getting mail for the tags to be a feature. -- Rich
