Could I get some codereview for my fix for:
159 findunref needs to learn about mercurial

http://cr.opensolaris.org/~stevel/159_findunref/

Notable changes:
o I split the exception_list up into common, open, and closed lists
o findunref can now load from multiple exception lists

Other notes:
o nightly.sh:2795, you can see where I pass the findunref output through
   sed to get the output to look like the form of the old findunref
   output, that is to say, the usr/closed output will look like:
        ../closed/cmd/foo
   and the usr/src output will look like:
        ./uts/foo
   I'm open to changing that.  I just made it that way to maintain
uniformity for now.  I personally think it makes more sense to have it
be usr/closed/cmd/foo and usr/src/cmd/foo, but whatever.  Your comments
on this point would be appreciated.

For anyone interested, I have an unref-i386.out generated from a full
nightly build here if you wish to peruse the output:
http://cr.opensolaris.org/~stevel/159_findunref/unref-i386.out

cheers,
steve
-- 
stephen lau // stevel at sun.com | 650.786.0845 | http://whacked.net
opensolaris // solaris kernel development

Reply via email to