Mike Kupfer wrote: >>>>>> "stevel" == Stephen Lau <stevel at sun.com> writes: > >>> Third, I found the code overall to be a bit sparsely commented. For >>> example, I think it would be helpful to document that >>> ExceptionList.match() takes a glob pattern. > > stevel> I went through and hopefully added sufficient comments/docs. > stevel> Let me know if anything seems insufficiently documented. > > Is there new webrev? The stuff on cr.opensolaris.org is Tuesday's > version, still.
I've updated and uploaded it now... >>> - line 59: why not just line.strip()? > > stevel> I preferred the symmetry of lstrip() especially since we also > stevel> call rstrip(). It makes it more obvious this way which one does > stevel> what. > > But isn't line.strip() equivalent to line.lstrip().rstrip()? Why invoke > two methods? Hrm, for some reason I thought strip() was just rstrip(), but you're right. I've fixed this now. cheers, steve -- stephen lau // stevel at sun.com | 650.786.0845 | http://whacked.net opensolaris // solaris kernel development
