Bill Sommerfeld <sommerfeld at sun.com> writes: > a couple comments: > > The build taskid should wind up in a file somewhere accessible before > nightly starts anything time-consuming like make clobber or bringover; > the cleanest way to kill a mistakenly-started build is with pkill -T -- > though maybe the way to do this is by putting the taskid into the lock > file..
I'd like to do both, actually, since yes, that's how I kill them off too, and pkill -T $(<lockfile) is so much more pleasant. > Also, it might make sense to put the tool version output you relocated > into a second temporary file that gets prepended to $mail_msg_file, so > that the tool versions show up early in the output (on a related note, I > think it would make sense to use a similar technique to truncate the > list of files updated in the bringover output at a few hundred lines, > but that's not this bug). I agree. > (by "bringover" I of course am also referring to the equivalent with > other SCM systems..) Mercurial doesn't list the files when it brings over, I've been tempted to adjust nightly such that it did so, but as yet, haven't. If we do, the output trimming would certainly make sense. -- Rich
