Richard Lowe <richlowe at richlowe.net> writes: > Hey all, > > Could I get some review for: > > 288 "nightly won't do a full bringover+build if BRINGOVER_WS is not > filesystem-accessible " > > webrev is at http://cr.opensolaris.org/~richlowe/scm_288
And has now been updated to, I think, deal with Bill's comments. Anyone care to take another look? > Fixed exactly in the way Bill described (moving the version checks to > after the bringover, and clobber, so we always have $SRC/Makefile) > > Bill mentioned these two in specific as things not to re-break > > 6266590 nightly misbehaving when kicked-off from empty ws > 6232357 nightly can run through the air for hours before looking down > > The latter is broken due to: > CR 6577894 nightly spends hours chasing shadows if primary compiler path is > wrong > > But should not be more broken by the nightly changes, please be > sure to keep that in mind when reviewing, however. > > This works in the cases I've tried (with Hg): > bringover+build in non-existing WS > bringover+build into existing, but empty directory (to become the WS). > updating bringover+build > > I can't imagine it failing with TeamWare, but if someone is equipt to > check that'd be great. > > -- Rich
