Mike Kupfer wrote:
> 162a148,151
> > # If no subtree is given, then we need to walk from our current
> dir
> > if not subtree:
> > subtree = "./"
> >
> 164a154
> > dirpath = dirpath.replace('./', '', 1)
>
> Shouldn't this also get applied to walk_scm_none?
Yup, done.
> 173c163
> < yield fname
> ---
> > yield dirpath + "/" + fname
>
> Might as well use os.path.join here, since that's what's used everywhere
> else.
Yup, done.
>
> 177 '''
> 178 if os.path.isdir(os.path.join(ws, 'SCCS')):
> 179 return walk_scm_sccs
> 180 else:
> 181 return walk_scm_none
> 182 '''
>
>
> Don't forget to delete this prior to putback.
Ah forgot about that, thanks.
> Otherwise looks good.
'k. I'll push it this afternoon.
thanks for the review!
cheers,
steve
--
stephen lau // stevel at sun.com | 650.786.0845 | http://whacked.net
opensolaris // solaris kernel development
