Richard Lowe writes: > 417 cdm should sort hg nits output by filename > > http://cr.opensolaris.org/~richlowe/scm_417
The changes themselves look good and complete. There seem to be other places (such as cdm_renamed and cdm_turdchk) where the user can get an unsorted view of the active list. I get why we're doing this with 'nits', but are there other cases that should be fixed? A somewhat off-topic comment: should we really call merge errors 'turds'? I know that's what the gatekeepers call the problem, but our developer tools haven't previously used that word, as far as I know. At least in some places, I think that scatological term might be somewhat (and needlessly) offensive. (As for the filter itself, a nit: using a double-negative -- as in 'unmodified=False' -- seems as though it makes the code a bit harder to read. But making a readability comment in Python code is probably raising a moot point anyway. :->) -- James Carlson, Solaris Networking <james.d.carlson at sun.com> Sun Microsystems / 35 Network Drive 71.232W Vox +1 781 442 2084 MS UBUR02-212 / Burlington MA 01803-2757 42.496N Fax +1 781 442 1677
