I need a code review, please, for

> 6781574 transition to mercurial has brought CR 4800126 back to life

The Mercurial transition inadvertently regressed the pkgdefs makefiles 
when I failed to generalize the "is  under source code control?" test 
for generated files.

Caveat 1: this test will only fire when the file would be generated due 
to changes in its dependencies.  That's nothing new, it was already true 
for DATAFILES, I just carried it over to copyright.

Caveat 2: I only generalized for Mercurial and Teamware, not Subversion 
or rcs.  But I did write a short comment to make it easier for anybody 
else that cared enough to do so.

http://cr.opensolaris.org/~mjnelson/webrev.6781574/

--Mark

Reply via email to