Mark J. Nelson writes: > I need a code review, please, for > > > 6781574 transition to mercurial has brought CR 4800126 back to life > > The Mercurial transition inadvertently regressed the pkgdefs makefiles > when I failed to generalize the "is under source code control?" test > for generated files. > > Caveat 1: this test will only fire when the file would be generated due > to changes in its dependencies. That's nothing new, it was already true > for DATAFILES, I just carried it over to copyright. > > Caveat 2: I only generalized for Mercurial and Teamware, not Subversion > or rcs. But I did write a short comment to make it easier for anybody > else that cared enough to do so. > > http://cr.opensolaris.org/~mjnelson/webrev.6781574/
As I noted in a previous email message, the test being performed actually returns inverted status -- it should be called NOT_UNDER_SCM rather than IS_UNDER_SCM. Other than that nit, the change looks good to me, and thanks for getting this! -- James Carlson, Solaris Networking <james.d.carlson at sun.com> Sun Microsystems / 35 Network Drive 71.232W Vox +1 781 442 2084 MS UBUR02-212 / Burlington MA 01803-2757 42.496N Fax +1 781 442 1677
