Danek Duvall writes:
> http://cr.opensolaris.org/~dduvall/sfw-mercurial-1.0/
METADATA
Just a nit, but it seems that Norm Jacobs is the only one following
this "new" format you're using. Everyone else has this:
Owner: Joe User <email at domain.org>
License: MUMBLEFROTZ
Notes on the porting job (or lack thereof) here.
... and the gate readme seems to singularly unhelpful in guidance.
Is there any rhyme or reason to what we're doing here? Or are these
files just for fun? ;-}
5: I think this should say "GPLv2," not just "GPL." (Assuming
that's the license in use. I don't really care, but apparently
legal is in a tizzy about the license versioning.)
pkginfo.tmpl
40: (nit, and I understand why you wouldn't want to change it) I
wish we didn't put the version number into both the title and
the package version. This is handled haphazardly in SFW -- some
packages have DESC="... version" and others do not. It's a bit
of a mess.
Makefile and prototype_com:
I'm a little surprised that favicon.ico goes away and doesn't
reappear in the templates/static directory.
Doesn't usr/demo/mercurial/hgwebdir.fcgi need to be executable in
order to be useful?
Files that seem to be missing from prototype_com:
usr/lib/python2.4/vendor-packages/hgext/color.py
usr/lib/python2.4/vendor-packages/hgext/color.pyc
Other than that, I assume you've built this, created new packages, and
installed them locally for a test.
--
James Carlson, Solaris Networking <james.d.carlson at sun.com>
Sun Microsystems / 35 Network Drive 71.232W Vox +1 781 442 2084
MS UBUR02-212 / Burlington MA 01803-2757 42.496N Fax +1 781 442 1677
