James Carlson <james.d.carlson at Sun.COM> writes: > Danek Duvall writes: >> http://cr.opensolaris.org/~dduvall/sfw-mercurial-1.0/ > > METADATA > > Just a nit, but it seems that Norm Jacobs is the only one following > this "new" format you're using. Everyone else has this: > > Owner: Joe User <email at domain.org> > License: MUMBLEFROTZ > > Notes on the porting job (or lack thereof) here. > > ... and the gate readme seems to singularly unhelpful in guidance. > Is there any rhyme or reason to what we're doing here? Or are these > files just for fun? ;-} > > 5: I think this should say "GPLv2," not just "GPL." (Assuming > that's the license in use. I don't really care, but apparently > legal is in a tizzy about the license versioning.) > > pkginfo.tmpl > > 40: (nit, and I understand why you wouldn't want to change it) I > wish we didn't put the version number into both the title and > the package version. This is handled haphazardly in SFW -- some > packages have DESC="... version" and others do not. It's a bit > of a mess. > > Makefile and prototype_com: > > I'm a little surprised that favicon.ico goes away and doesn't > reappear in the templates/static directory. >
The favicon is gone, in the local test I did with 'hg serve' it looks to be replaced with one of the other logo images. -- Rich
