Mike Kupfer <mike.kupfer at sun.com> writes:

> A couple minor issues; otherwise looks good.
>
> - cdm.py (line 49), hg-active.py (line 42): why "as Version"?  We
>   don't do that for the other import statements.

I'll change to 'from onbld.Scm import Version', I'm not sure why I did it
the other way.

> - Version.py (line 28): nit: "mercurial" should be capitalized.

Ok.

Do we want to list 1.0 as "good" for our purposes now?  I was hoping
to do that in two chunks, but given _88 closes tonight, it may be best
to do it now? 

-- Rich

Reply via email to