> I'd like code review for: > 480 INS.pyfile's comment about python and mtime is slightly wrong (nit) > 485 onnv-scm SUNWonbld needs copyright update > 486 findunref and hg-active should be GPLv2 > > Webrev is: http://cr.opensolaris.org/~richlowe/scm_480 > > Mark, did I get the #485 right, does the order in LICENSFILES matter? > Bonnie, I'm Cc'ing you to make doubly sure that I got #486 right. > > The description of #480 has links to the related code in python > itself.
480: Wasn't there something about granularity here, too? I.e. seconds, as opposed to something smaller? 485: This isn't really a separate bug, it's part of the fix for 486. Otherwise, this looks correct. Longer answer: technically, this stuff should be in reverse chronological order, but that's kind of insane as far as extracting copyrights, so I didn't. So you need not bother. :) 486: I'll defer on this one. Obviously, if it's wrong, then 485 should be revisited for consistency. --Mark
