"Mark J. Nelson" <Mark.J.Nelson at Sun.COM> writes: >> I'd like code review for: >> 480 INS.pyfile's comment about python and mtime is slightly wrong (nit) >> 485 onnv-scm SUNWonbld needs copyright update >> 486 findunref and hg-active should be GPLv2 >> >> Webrev is: http://cr.opensolaris.org/~richlowe/scm_480 >> >> Mark, did I get the #485 right, does the order in LICENSFILES matter? >> Bonnie, I'm Cc'ing you to make doubly sure that I got #486 right. >> >> The description of #480 has links to the related code in python >> itself. > > 480: Wasn't there something about granularity here, too? > I.e. seconds, as opposed to something smaller?
Danek and I talked about that, in a brief discussion on the pkg list. I'm utterly confused by what he's telling me as compared to what the code is doing. >From talking to Danek just now, I think we suspect the current comment is correct. I've been thinking about this more closely, and it's possible that my understanding of what was said is backwards, if the granularity is such that the new mtime is *within* (rather than beyond a second), it may not trigger. > 485: This isn't really a separate bug, it's part of the fix for Yes, it is. Since we have GPLv2 code in there anyway (WorkSpace, cdm, Backup,...) Regardless of #486, #485 is necessary. > 486. Otherwise, this looks correct. Longer answer: technically, this > stuff should be in reverse chronological order, but that's kind of > insane as far as extracting copyrights, so I didn't. So you need not > bother. :) > > 486: I'll defer on this one. Obviously, if it's wrong, then 485 > should be revisited for consistency. As above, #486 and #485 are entirely separate. If #486 is wrong, I act surprised, then I remove just #486 from this wad. -- Rich
