Mike Kupfer <mike.kupfer at sun.com> writes: > Rich or Jim, could one of you please take a look at my changes for 264? > (Of course, anyone on scm-migration-dev is welcome to comment.) > > Webrev is at http://cr.opensolaris.org/~kupfer/264/, and a PDF of the > updated man page is at http://cr.opensolaris.org/~kupfer/nightly.1.pdf. >
The results of a fairly quick glance, I'll try and take a closer look in the next few days. nightly.sh: 348: It'd be good to comment what the else branch is doing (support for copy_source'ing a subdirectory of usr/closed, I think). 309: It may be better to pass a pattern (or -I <dir>) to hg locate, rather than list the whole thing and grep for portions. 2322: It's kinda sad that we'll lose the version information if nightly is run from onnv-tools, rather than installed on the build machine, but I don't see a nice way around that other than a filter when 'building' it. nightly.1: 272: Internally, both $CODEMGR_WS and $CODEMGR_WS/usr/closed will contain .hg/ this should probably be explicit (as self evident as it may seem) 311: It may still (and I think should still) differ from the parent in the general case, since the clone will still exist (and as far as having nightly bring it over, the moving local tag solution doesn't work as you'd hope). If someone who remembers more of nroff than I do would review the markup changes, that'd be great, if not I'll go through it with documentation in hand. -- Rich
