Mike Kupfer writes:
> Rich or Jim, could one of you please take a look at my changes for 264?
> (Of course, anyone on scm-migration-dev is welcome to comment.)
>
> Webrev is at http://cr.opensolaris.org/~kupfer/264/, and a PDF of the
> updated man page is at http://cr.opensolaris.org/~kupfer/nightly.1.pdf.
nightly.1
277: s/which/that/ (It's a restrictive relative clause ... and
one of my pet peeves. :-/)
421: I like that this is in the past.
nightly.sh
279,2326: no need to escape end-of-line when line ends with pipe
character. (Thanks for removing the {} swill, though.)
285: this is a little odd. We go out of our way to support $DEST
with embedded spaces at line 283, but then fall over here. It'd be
good to be more consistent.
344: can this mkdir fail?
346,350: should these ";" actually be "&&" instead? What happens if
the "cd" fails?
513: do any of the other make default rules do inadvertent things
with svn or hg? (Any chance of inadvertent SCM invocation during
the build?)
515,516: I'd put the >> at the end of the first line and omit "\".
2230: as long as you're here, you might use "function" (?).
(Actually, I'm not too wild about the ksh "function" feature, but
you used it at line 313 for new code.)
2327,2329: might be clearer (less duplication) to pipe 'fi' at 2330
through tee.
2331: does "" do something here?
2491: I had thought that the SCCSHELPER thing was about files that
were _modified_ during the "source delivery" build, not just
removed. But it's been a long time since I've done such a build, so
I might not be remembering this right.
--
James Carlson, Solaris Networking <james.d.carlson at sun.com>
Sun Microsystems / 35 Network Drive 71.232W Vox +1 781 442 2084
MS UBUR02-212 / Burlington MA 01803-2757 42.496N Fax +1 781 442 1677
