On Wed, 2006-12-20 at 06:01 -0800, Robert Hudson wrote: > > - I reworked BugTracker.pm:split_comment_sections and > > TestDirector.pm:integration_get_bugs. I'm boycotting the for > > loop movement. I also changed the loops from: > > > > ( .. <= .. ) > > > > to > > > > ( .. < .. ) > > > > I think we were getting one more element. I hope again that I > > didn't break anything. > > The while loop in BugTracker.pm:split_comment_sections will need to have > the <= or it will miss the last comment in the text. (just tested it) > :-)
I don't understand the logic behind it, since we start from zero. But if it works for you, <= it is. Thanks. > > - Minor things: Do we need the extra testdirector_config > > indirection in TestDirector.conf ? And the configuration > > values prefixed with "tdc_" ? > > Don't worry about them now, but I'll probably rename the later. > > I put the Test Director settings with an extra indirection in case you > wanted to make the configuration more generic and store all the specific > settings for all the Bug Tracking systems in the same conf file. I also > used the prefix tdc_ so that I could tell which file was Test Director > specific and user configured. (But it's your product, so feel free to > change it if you wish, wouldn't worry me either way.) Thanks. I'll keep them for now. > > What happens when some configuration variables are blank in > > the .conf file ? Should we worry about them yet ? > > The code should handle this OK and not do the lookup and mark the value > as an empty string. > > > - I'm still updating the documentation. I'm not sure I want > > to include the explanations to all the tdc_* fields. I'd > > rather include those in the .conf file itself, only because > > they seem to be self-explanatory. > > How do you feel about this ?I'd also like to remove version, > > database_username, and database_password from the > > configuration documentation in section 6.4. > > I agree that we may not need the test director conf file broken down in > the documentation, but I think a reference to it would be required. I added the reference to it. > However I do think that the description of the setting in the > Daemon.conf file are required as these are not really obvious. I agree, and I have listed most of them. My question is are 'version', 'database_user', and 'database_password' non-obvious ? Perhaps 'version' is obvious and could be removed. Are there multiple types of users for Test Director ? e.g. one user/password for the application, and other user/passwords for the actual users ? So in a sense, does the current documentation of these two fields recommend that the application user/password are used ? > I have done some more testing for the merge functionality. I have come > across a couple of problems: > > Using Subversion/Windows the script tries to read an env variable USER > which is not set so the script exists. This is a bug. It's also a bug in the VDD Generator. Thanks. I'll take care of it. http://bugzilla.mkgnu.net/show_bug.cgi?id=911 > I then for test purposes set the env variable to my user and tried > again, this printed out the attached file (but did not merge). I wasn't > sure as to what state of completion this was in. The tool does not merge yet; just reports what was received. Marek is working on this. From the log message you showed it seems that integration_get_bugs reports a lot of things correctly. A couple of fields are missing, and the affected_files key was not implemented correctly: http://bugzilla.mkgnu.net/show_bug.cgi?id=895#c33 Marek, how is the work on the merger going ? _______________________________________________ scmbug-users mailing list [email protected] http://lists.mkgnu.net/cgi-bin/mailman/listinfo/scmbug-users
