On Tue, 2007-04-10 at 09:20 -0600, Dale King wrote:
> Even better than having configuration for this one feature, just make
> the entire message configurable so you can say something like:
> 
> bug-comment-format =
> "%LOGMESSAGE%
> 
> http://myserver/viewvc/svn?view=rev&revision=%NEWREV%
> 
> %CHANGES%"
> 
> You can define various tokens than can be used, e.g. %USER%, %DATE%,
> %PREVIOUSREV%
> 
> But is this compatible with CVS? Actually how does scmbug work with CVS?
> Does it do a separate comment for each file committed? How else do you
> know how to group the files into one comment? If it does a separate
> comment for each file than perhaps this is still compatible.

No, it does a single comment for all files in "the same directory". CVS
triggers its hooks per directory. But what you propose is possible for
Subversion and CVS. Perhaps you won't supply:

bug-comment-format =
"%LOGMESSAGE%

http://myserver/viewvc/svn?view=rev&revision=%NEWREV%

%CHANGES%"

but instead supply:



bug-comment-format =
"%LOGMESSAGE%
%CHANGES%
%CHANGES_WITH_URL%"

bug-comment-viewscm-url="http://myserver/viewvc/svn?view=%FILE%revision=
%NEWREV%"


since %CHANGES_WITH_URL% will unroll to something like:


http://myserver/viewvc/svn?view=system/doc/manual/about.sgml&revision=1.8
http://myserver/viewvc/svn?view=system/doc/manual/bugtracking-backends.sgml&revision=1.8
http://myserver/viewvc/svn?view=system/doc/manual/conventions.sgml&revision=1.1


while %CHANGES% will unroll to:


1.7 --> 1.8 Scmbug:system/doc/manual/about.sgml
1.7 --> 1.8 Scmbug:system/doc/manual/bugtracking-backends.sgml
NONE --> 1.1 Scmbug:system/doc/manual/conventions.sgml

It's not as visually appealing, but certainly possible.

> -----Original Message-----
> From: Kristis Makris [mailto:[EMAIL PROTECTED] 
> Sent: Tuesday, April 10, 2007 11:01 AM
> To: Dale King
> Cc: [email protected]
> Subject: RE: [scmbug-users] Add configuration for format of
> thecommitmessage added to bug system
> 
> On Tue, 2007-04-10 at 08:17 -0600, Dale King wrote:
> > So you are you saying that Bugzilla does not support putting links at
> > all in the comments? That doesn't seem to be true based on the
> comments
> > that have links in them in the bugs you refer to.
> 
> No. Bugzilla supports putting links. But it will always list links as
> "http://..."; Instead of listing them in blue color as "rev 1031". We are
> trying to built something more usable and visually appealing.
> 
> This is explained in more detail in:
> 
> http://bugzilla.mkgnu.net/show_bug.cgi?id=266#c5
> 
> > Or is it that it will not support certain types of links like where
> the
> > link text is something other than the target.
> > 
> > It seems you are trying to keep the list of file changes and have
> parts
> > of that text be links. I don't really care about that. I would be more
> > than happy with:
> > 
> >   This is a log message. Changed the frobnoozle.
> > 
> >   http://myserver/viewvc/svn?view=rev&revision=1234
> > 
> > I don't care if the list of changes is in the comment, you can get
> that
> > from the link. But you could leave the list; just leave it as plain
> > text.
> 
> I see your point.
> 
> > It seems that Bugzilla does support links, perhaps only by detecting
> > text that is http:// but that would be good enough for this.
> > 
> > Something like this could be easily configurable in scmbug using
> > something similar to the bugtraq URL scheme. You just specify a
> pattern
> > like:
> > 
> >    http://myserver/viewvc/svn?view=rev&revision=%REVISION%
> > 
> > If the pattern is not specified then you leave out the link from the
> > comment.
> > 
> > I realize that this scheme really only works for subversion and not
> CVS,
> > since CVS doesn't have the global revision number. You could probably
> do
> > something similar with CVS with a link per file.
> 
> I see what you mean. Yes, this is certainly possible. 
> 
> > -----Original Message-----
> > From: Kristis Makris [mailto:[EMAIL PROTECTED] 
> > Sent: Tuesday, April 10, 2007 1:56 AM
> > To: Dale King
> > Cc: [email protected]
> > Subject: Re: [scmbug-users] Add configuration for format of the
> > commitmessage added to bug system
> > 
> > Hi Dale,
> > 
> > On Wed, 2007-04-04 at 17:27 -0600, Dale King wrote:
> > > The format of the message added to Bugzilla is hardcoded. It needs
> to
> > > be configurable. Currently it is the log message and a list of files
> > > changed.
> > 
> > You are right. I don't think it has become important enough to make it
> > configurable yet.
> >  
> > > In our case we will use it to integrate between Subversion and
> > > Bugzilla. I would like to have it be the log message and a link to
> the
> > > revision in the ViewVC browser for the repository, which will itself
> > > contain a browsable list of changes.
> > 
> > You are referring to autolinkification:
> > 
> > http://bugzilla.mkgnu.net/show_bug.cgi?id=266
> > 
> > The main problem is that even if you manually try to customize it now,
> > Bugzilla still **will not** setup the url links if you use something
> > like <a href="http://some.thing";>Rev 25</a>. This is a security
> feature
> > that prevents from cross-site scripting. 
> > 
> > Bugzilla should be modified to support automatically producing these
> > links in comments that match our "integration" format. Their current
> > status of this feature is at:
> > 
> > https://bugzilla.mozilla.org/show_bug.cgi?id=314097#c13
> > 
> > Perhaps you could help us out here by ... requesting it from Bugzilla
> > too ??!!
> > 
> 

_______________________________________________
scmbug-users mailing list
[email protected]
http://lists.mkgnu.net/cgi-bin/mailman/listinfo/scmbug-users

Reply via email to