[scmbug-users] Version 0-22-0 A couple more tweaks

[Robert Hudson]

Hi Kristis,

I've done a little more testing today and have found the following tweaks, 
please would you be able to apply these?

Integration.pm
==============

Function process_activity_commit():
        There is a return without disconnecting from the DB
        

TestDirectorUtils.pm
====================

Function get_users_email():
        Add
                    if( !defined($custUser) ) {
                        return "Unknown";
                    }
        
        Just before:
                    return $custUser->email;


Function last_lock_user():
        Change
                    $lock_username = $lock_err[ $number_of_lock_err ];
        To
                    $lock_username = $lock_err[ $number_of_lock_err - 1 ];


TestDirector.pm
===============

Function integration_get_bug_reporter_email():
        Change
            my $username = $self->td_get_bug_value( $bugid, "get_users_email", 
$self->td_bug_reporter_tag() );
        To
            my $username = $self->td_get_bug_value( $bugid, "get_bug_values", 
$self->td_bug_reporter_tag() );


Daemon.pm
=========
The connection string is comming out currupted in the log:
        Tue Oct  9 12:46:29 2007 10.100.83.129:1486 Processing connection from 
        dS
        Tue Oct  9 12:46:34 2007 10.100.83.129:1486 Connection from 
        dS processed

This is because it is trying to print the host name from the socket structure 
that is actually never set.
If you switch this to the IP address it works a treat:
        From:
            logmsg ( $DAEMON_LOG_ACTIVITY, "Processing connection from 
$connection_host_name\n", $request);
            logmsg( $DAEMON_LOG_ACTIVITY, "Connection from 
$connection_host_name processed\n", $request);
        To:
            logmsg ( $DAEMON_LOG_ACTIVITY, "Processing connection from 
$connection_ip_address\n", $request);
            logmsg( $DAEMON_LOG_ACTIVITY, "Connection from 
$connection_ip_address processed\n", $request);
This is in a couple of places.


I hope that this is OK?

I still haven't got around to messing about with the auto-bug-resolution yet.

Thanks

Rob

_______________________________________________
scmbug-users mailing list
scmbug-users@lists.mkgnu.net
http://lists.mkgnu.net/cgi-bin/mailman/listinfo/scmbug-users