Hi Robert, I was unavailable for a while -- sorry.

On Tue, 2007-10-09 at 08:15 -0700, Robert Hudson wrote:
> Hi Kristis,
> 
> I've done a little more testing today and have found the following tweaks, 
> please would you be able to apply these?
> 
> Integration.pm
> ==============
> 
> Function process_activity_commit():
>       There is a return without disconnecting from the DB

Applied:

http://bugzilla.mkgnu.net/show_bug.cgi?id=547#c71

> TestDirectorUtils.pm
> TestDirector.pm
> ===============

Applied:

http://bugzilla.mkgnu.net/show_bug.cgi?id=895#c88

> 
> Daemon.pm
> =========
> The connection string is comming out currupted in the log:
>       Tue Oct  9 12:46:29 2007 10.100.83.129:1486 Processing connection from 
>       dS
>       Tue Oct  9 12:46:34 2007 10.100.83.129:1486 Connection from 
>       dS processed

This is certainly a bug.

> This is because it is trying to print the host name from the socket structure 
> that is actually never set.

But why isn't it set ? The call to spawn_child seems ok to me. I'm
trying to understand why it isn't being set. And I was shooting for a
host name, not just an IP address.

Oh well, maybe I should just apply and forget about it.

> If you switch this to the IP address it works a treat:
>       From:
>           logmsg ( $DAEMON_LOG_ACTIVITY, "Processing connection from 
> $connection_host_name\n", $request);
>           logmsg( $DAEMON_LOG_ACTIVITY, "Connection from 
> $connection_host_name processed\n", $request);
>       To:
>           logmsg ( $DAEMON_LOG_ACTIVITY, "Processing connection from 
> $connection_ip_address\n", $request);
>           logmsg( $DAEMON_LOG_ACTIVITY, "Connection from 
> $connection_ip_address processed\n", $request);
> This is in a couple of places.

Where ?

> I hope that this is OK?

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
scmbug-users mailing list
[email protected]
http://lists.mkgnu.net/cgi-bin/mailman/listinfo/scmbug-users

Reply via email to