Kristis Makris wrote: > I use this feature too. I'd like to see such a support in Scmbug though > to be implemented in a more generic way that can be applied to all > Scmbug bug-tracking backends. Practically, this means I'd rather we did > NOT parse in the bug-tracking backend the log comment to extract the > worktime; this should be done in the glue. That said, your patch > contains a lot of the logic to do this and can be reworked to fit a more > general solution.
I agree completely. I was in a hurry to get WORKTIME functional in our environment hence the somewhat sloppy approach. The only thing I might add is that it seems to make sense to have the WORKTIME value added along with a relevant bug comment (as my patch does). If it is preferable to not parse in the bug tracking backend then perhaps the WORKTIME keyword and value and bug comments need to be aggregated earlier on in the processing (I mentioned this again at the end of the email). >> We did not bother to implement worktime on a per-bug basis. It is >> assumed that it will be applied to the comment for the specified bug or >> bugs. It doesn't make much sense to add time spent without a comment >> and we don't want to encourage people to add time worked on unrelated >> commits. > > It is not unreasonable to commit a changeset that fixes multiple bugs. > e.g. one bug is created to describe a general problem, and additional > bugs may have also been created to report other issues that might be > side-effects of the first bug. Given this possibility, how do you > envision applying the worktime in such a situation in a single commit > message ? > > Would it be useful if worktime was implemented on a per-bug basis ? I'm sure it would be. In our specific usage we're pretty reserved with our commits (we have a commit early, commit often approach) so they rarely concern more then a couple of bugs at a time and usually only one. You might use something like: bug 123: Fixed foo() bug 456: Fixed bar() worktime 123: 1.5 worktime 456: 0.4 (Does scmbug even allow two bug comments in one commit?) Obviously the time units would have to be agreeable with whatever the bug tracking system expected. In Bugzilla's case these are hours but I suppose others might track in terms of minutes (I do not know for sure, I am just speculating). With regards to Bugzilla, I do not like to see hours worked added to a bug without a comment to explain what that time was spent on so it might make sense for a bug comment to be REQUIRED for every worktime entry. This is how we operate locally. Matt -- Matt Adams Development & Network Services Cypress Interactive http://cypressinteractive.com, http://edsuite.com _______________________________________________ scmbug-users mailing list [email protected] http://lists.mkgnu.net/cgi-bin/mailman/listinfo/scmbug-users
