Hi,

Since the introduction of "up_to_3_4" version type in Bugzilla module we
have this:
...
    } elsif ( $major == 3 &&
                  ($minor == 2 || $minor == 4 || $minor == 6)) {
        $self->{ version_type } = "up_to_3_4";
    }
...

Which most likely should be:
...
    } elsif ( $major == 3 &&
                  ($minor == 2 || $minor == 4)) {
        $self->{ version_type } = "up_to_3_4";
    }
...


I'm also thinking about following: such addition of new version type affects
too much (i.e. even sections which don't refer to changes in the particular
Bugzilla version). Wouldn't it be better instead in version-specific checks
to just use something like
is_version_{less_than|equal|greater_than|..._or_equal,etc}( major, minor,
patch ).

Regards,
Yavor
_______________________________________________
scmbug-users mailing list
[email protected]
http://lists.mkgnu.net/cgi-bin/mailman/listinfo/scmbug-users

Reply via email to