On Mon, 2012-07-30 at 16:01 -0400, Gary Oberbrunner wrote: > Paweł is talking about this pull request: > https://bitbucket.org/scons/scons/pull-request/25/gettext-tool-integrated > which allows SCons users to call gettext in their projects. > > Paweł, it just depends on my time to review. I know you've put a lot > of time into it so I will do my best. (Other devs: can someone review > pull request #25?)
I had a quick look just to get a view of the scale of the problem, and I can tell it needs more work than I can do this week, perhaps next. Given my look was quick, I thought I spotted commented out redundent code being added to by new code that was equally redundant. More investigation needed but indicative that either: — the code needs more work. — the BitBucket UI for looking over changes needs some attention. or both :-) -- Russel. ============================================================================= Dr Russel Winder t: +44 20 7585 2200 voip: sip:[email protected] 41 Buckmaster Road m: +44 7770 465 077 xmpp: [email protected] London SW11 1EN, UK w: www.russel.org.uk skype: russel_winder
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Scons-dev mailing list [email protected] http://two.pairlist.net/mailman/listinfo/scons-dev
