W dniu 31.07.2012 09:48, Russel Winder pisze:
On Mon, 2012-07-30 at 16:01 -0400, Gary Oberbrunner wrote:
Paweł is talking about this pull request:
https://bitbucket.org/scons/scons/pull-request/25/gettext-tool-integrated
which allows SCons users to call gettext in their projects.
Paweł, it just depends on my time to review. I know you've put a lot
of time into it so I will do my best. (Other devs: can someone review
pull request #25?)
I had a quick look just to get a view of the scale of the problem, and I
can tell it needs more work than I can do this week, perhaps next.
Given my look was quick, I thought I spotted commented out redundent
code being added to by new code that was equally redundant.
I'm not sure if you're talking about same thing I'm thinking about, but
do you mean these changes?
https://bitbucket.org/ptomulik/scons/changeset/e58502f5437b48f023ad045ff1eb88e5ad0bbff4
More
investigation needed but indicative that either:
— the code needs more work.
I don't deny that :)
— the BitBucket UI for looking over changes needs some attention.
or both :-)
Regards!
--
Pawel Tomulik
_______________________________________________
Scons-dev mailing list
[email protected]
http://two.pairlist.net/mailman/listinfo/scons-dev
