On Fri, Aug 24, 2018 at 10:28 AM, Kevin O'Connor <ke...@koconnor.net> wrote: > On Fri, Aug 24, 2018 at 09:48:27AM -0400, Chris wrote: >> On Fri, Aug 24, 2018 at 9:28 AM, Chris <coderi...@gmail.com> wrote: >> > So far it has worked on the first attempt every time. So it needs only >> > the delay and nothing else. >> > >> > I still need to test with all my SD cards. Though I only have a 64GB >> > Sandisk and a handful of 32GB Samsung. The question is whether or not >> > the delay is dependent on the card type or if it's just the controller >> > that needs to stabilize. >> >> OK, I tested all the cards I have and everything works. Attached is >> the simplified patch. Hopefully someone can test other cards. I'm >> interested to know if 128+GB and 16GB works. > > Thanks. If you increase SDHCI_POWER_ON_TIME instead, does that also > work? > > -Kevin
Yes. Seems to work the same so far using the same delay (5). Chris
diff --git a/src/hw/sdcard.c b/src/hw/sdcard.c index 6410340..ab7007b 100644 --- a/src/hw/sdcard.c +++ b/src/hw/sdcard.c @@ -128,7 +128,7 @@ struct sdhci_s { // SDHCI timeouts #define SDHCI_POWER_OFF_TIME 1 -#define SDHCI_POWER_ON_TIME 1 +#define SDHCI_POWER_ON_TIME 5 #define SDHCI_CLOCK_ON_TIME 1 // 74 clock cycles #define SDHCI_POWERUP_TIMEOUT 1000 #define SDHCI_PIO_TIMEOUT 1000 // XXX - this is just made up
_______________________________________________ SeaBIOS mailing list SeaBIOS@seabios.org https://mail.coreboot.org/mailman/listinfo/seabios