[jira] [Commented] (CASSANDRA-13655) Range deletes in a CAS batch are ignored

2017-08-30 Thread Jeff Jirsa (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-13655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16147711#comment-16147711
 ] 

Jeff Jirsa commented on CASSANDRA-13655:


Unit tests are happy. DTests have the typical flakey tests + some failures that 
look environmental in 3.0 and 3.11, but trunk didnt run at all. The cqlsh copy 
dtests failed on both 3.0 and 3.11, and they both show a single failure in the 
last dozen runs, so that seems odd and I'll check that on the next run.

URLs will be:

https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/247/testReport/
https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/248/testReport/
https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/249/testReport/




> Range deletes in a CAS batch are ignored
> 
>
> Key: CASSANDRA-13655
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13655
> Project: Cassandra
>  Issue Type: Bug
>  Components: CQL
>Reporter: Jeff Jirsa
>Assignee: Jeff Jirsa
>Priority: Blocker
> Fix For: 3.0.x, 3.11.x, 4.x
>
>
> Range deletes in a CAS batch are ignored 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-13655) Range deletes in a CAS batch are ignored

2017-08-30 Thread Sylvain Lebresne (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-13655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16146779#comment-16146779
 ] 

Sylvain Lebresne commented on CASSANDRA-13655:
--

If CI's happy, +1 from me, thanks.

> Range deletes in a CAS batch are ignored
> 
>
> Key: CASSANDRA-13655
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13655
> Project: Cassandra
>  Issue Type: Bug
>  Components: CQL
>Reporter: Jeff Jirsa
>Assignee: Jeff Jirsa
>Priority: Blocker
> Fix For: 3.0.x, 3.11.x, 4.x
>
>
> Range deletes in a CAS batch are ignored 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-13655) Range deletes in a CAS batch are ignored

2017-08-29 Thread Jeff Jirsa (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-13655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16146064#comment-16146064
 ] 

Jeff Jirsa commented on CASSANDRA-13655:


Thank you both, sorry for the delay. Have pushed up a commit to each branch to 
address your collective comments. CircleCI is queued up, dtests are running. 

|| Branch || Unit Tests || Dtests ||
| [3.0|https://github.com/jeffjirsa/cassandra/tree/cassandra-3.0-13655] | 
[circle|https://circleci.com/gh/jeffjirsa/cassandra/tree/cassandra-3.0-13655] | 
[asf 
jenkins|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/226/]
 |
| [3.11|https://github.com/jeffjirsa/cassandra/tree/cassandra-3.11-13655] | 
[circle|https://circleci.com/gh/jeffjirsa/cassandra/tree/cassandra-3.11-13655] 
| [asf 
jenkins|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/227/]
 |
| [trunk|https://github.com/jeffjirsa/cassandra/tree/cassandra-13655] | 
[circle|https://circleci.com/gh/jeffjirsa/cassandra/tree/cassandra-13655] | 
[asf 
jenkins|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/228/]
 |


> Range deletes in a CAS batch are ignored
> 
>
> Key: CASSANDRA-13655
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13655
> Project: Cassandra
>  Issue Type: Bug
>  Components: CQL
>Reporter: Jeff Jirsa
>Assignee: Jeff Jirsa
>Priority: Blocker
> Fix For: 3.0.x, 3.11.x, 4.x
>
>
> Range deletes in a CAS batch are ignored 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-13655) Range deletes in a CAS batch are ignored

2017-08-18 Thread Sylvain Lebresne (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-13655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16132176#comment-16132176
 ] 

Sylvain Lebresne commented on CASSANDRA-13655:
--

Sorry for the delay getting to this. It's definitively an oversight that range 
deletions are ignored for CAS. The patch lgtm, with just the following minor 
remarks:
* I'd rename {{CQL3CasRequest.SliceUpdate}} (and related {{addSliceUpdate()}} 
method) to {{RangeDeletion}} or something of the like. {{SliceUpdate}} is 
unnecessarily imprecise for what it is (I personally wouldn't merge it to 
{{RowUpdate}} however; having some private {{AbstractUpdate}} to combine the 3 
common fields is an option but I'm honestly not sure it's worth the trouble).
* I agree with [~jay.zhuang]'s point #2 above, about moving the checks to a 
{{ModificationStatement.hasSlices()}} method. This is, after all, the 
conditions that are necessary to check before calling 
{{ModificationStatement.createSlices()}} so it would make it more explicit and 
we won't forget to change one of the 2 places if things evolve.
* It doesn't seem {{ModificationStatement.toSlices}} needs to be made package 
protected, it can stay private.
* There is a misplaced bracket 
[here|https://github.com/jeffjirsa/cassandra/commit/c2e3941352c1da31ba28f657974918ae46e81c97#diff-bee3b222530d9e0c5190e6773f62R462].

> Range deletes in a CAS batch are ignored
> 
>
> Key: CASSANDRA-13655
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13655
> Project: Cassandra
>  Issue Type: Bug
>  Components: CQL
>Reporter: Jeff Jirsa
>Assignee: Jeff Jirsa
>Priority: Blocker
> Fix For: 3.0.x, 3.11.x, 4.x
>
>
> Range deletes in a CAS batch are ignored 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-13655) Range deletes in a CAS batch are ignored

2017-07-21 Thread Jeff Jirsa (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-13655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16097044#comment-16097044
 ] 

Jeff Jirsa commented on CASSANDRA-13655:


For #1, it should be an easy change, but I'll check to see if it somehow 
complicates things. I sort of like it the way it is, in case they eventually 
diverge, but perhaps that's planning for a future that may never happen.

I'm not thrilled about #2, to be honest. I'd prefer to leave them as distinct 
checks. 


> Range deletes in a CAS batch are ignored
> 
>
> Key: CASSANDRA-13655
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13655
> Project: Cassandra
>  Issue Type: Bug
>  Components: CQL
>Reporter: Jeff Jirsa
>Assignee: Jeff Jirsa
>Priority: Critical
> Fix For: 3.0.x, 3.11.x, 4.x
>
>
> Range deletes in a CAS batch are ignored 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-13655) Range deletes in a CAS batch are ignored

2017-07-11 Thread Jay Zhuang (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-13655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16083477#comment-16083477
 ] 

Jay Zhuang commented on CASSANDRA-13655:


Tried the patch locally, looks good to me, a few minor comments:
1. Would it be better to combine {{SliceUpdate}} and {{RowUpdate}}?
2. How about having a function for these 3 checks (like 
{{ModificationStatement.hasSlices()}} or a better name): 
[BatchStatement.java:420 | 
https://github.com/jeffjirsa/cassandra/commit/b9a6be6f5fc867718907d1abae124137d4f1cb45#diff-bee3b222530d9e0c5190e6773f62R420]
 and here: [ModificationStatement.java:629| 
https://github.com/jeffjirsa/cassandra/blob/cassandra-3.0-13655/src/java/org/apache/cassandra/cql3/statements/ModificationStatement.java#L629]

> Range deletes in a CAS batch are ignored
> 
>
> Key: CASSANDRA-13655
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13655
> Project: Cassandra
>  Issue Type: Bug
>  Components: CQL
>Reporter: Jeff Jirsa
>Assignee: Jeff Jirsa
>Priority: Critical
> Fix For: 3.0.x, 3.11.x, 4.x
>
>
> Range deletes in a CAS batch are ignored 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-13655) Range deletes in a CAS batch are ignored

2017-07-11 Thread Jeff Jirsa (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-13655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16083423#comment-16083423
 ] 

Jeff Jirsa commented on CASSANDRA-13655:


[~jay.zhuang] - more eyes are never a bad thing!


> Range deletes in a CAS batch are ignored
> 
>
> Key: CASSANDRA-13655
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13655
> Project: Cassandra
>  Issue Type: Bug
>  Components: CQL
>Reporter: Jeff Jirsa
>Assignee: Jeff Jirsa
>Priority: Critical
> Fix For: 3.0.x, 3.11.x, 4.x
>
>
> Range deletes in a CAS batch are ignored 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-13655) Range deletes in a CAS batch are ignored

2017-07-11 Thread Jay Zhuang (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-13655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16083350#comment-16083350
 ] 

Jay Zhuang commented on CASSANDRA-13655:


[~jjirsa] It looks like a serious bug. Can I review? (and someone else could 
double review it)

> Range deletes in a CAS batch are ignored
> 
>
> Key: CASSANDRA-13655
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13655
> Project: Cassandra
>  Issue Type: Bug
>  Components: CQL
>Reporter: Jeff Jirsa
>Assignee: Jeff Jirsa
>Priority: Critical
> Fix For: 3.0.x, 3.11.x, 4.x
>
>
> Range deletes in a CAS batch are ignored 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-13655) Range deletes in a CAS batch are ignored

2017-07-06 Thread Sylvain Lebresne (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-13655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16076663#comment-16076663
 ] 

Sylvain Lebresne commented on CASSANDRA-13655:
--

I can indeed have a look, but it won't be before next week, so if there is any 
other taker in the meantime, I won't get mad.

> Range deletes in a CAS batch are ignored
> 
>
> Key: CASSANDRA-13655
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13655
> Project: Cassandra
>  Issue Type: Bug
>  Components: CQL
>Reporter: Jeff Jirsa
>Assignee: Jeff Jirsa
>Priority: Critical
> Fix For: 3.0.x, 3.11.x, 4.x
>
>
> Range deletes in a CAS batch are ignored 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Commented] (CASSANDRA-13655) Range deletes in a CAS batch are ignored

2017-07-05 Thread Jeff Jirsa (JIRA) 

[ 
https://issues.apache.org/jira/browse/CASSANDRA-13655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16075524#comment-16075524
 ] 

Jeff Jirsa commented on CASSANDRA-13655:


|| Branch || Unit Tests || Dtests ||
| [3.0|https://github.com/jeffjirsa/cassandra/tree/cassandra-3.0-13655] | 
[circle|https://circleci.com/gh/jeffjirsa/cassandra/tree/cassandra-3.0-13655] | 
[asf 
jenkins|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/113/]
 |
| [3.11|https://github.com/jeffjirsa/cassandra/tree/cassandra-3.11-13655] | 
[circle|https://circleci.com/gh/jeffjirsa/cassandra/tree/cassandra-3.11-13655] 
| [asf 
jenkins|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/114/]
 |
| [trunk|https://github.com/jeffjirsa/cassandra/tree/cassandra-13655] | 
[circle|https://circleci.com/gh/jeffjirsa/cassandra/tree/cassandra-13655] | 
[asf 
jenkins|https://builds.apache.org/view/A-D/view/Cassandra/job/Cassandra-devbranch-dtest/115/]
 |

[~slebresne] any chance you're interested in reviewing? 


> Range deletes in a CAS batch are ignored
> 
>
> Key: CASSANDRA-13655
> URL: https://issues.apache.org/jira/browse/CASSANDRA-13655
> Project: Cassandra
>  Issue Type: Bug
>  Components: CQL
>Reporter: Jeff Jirsa
>Assignee: Jeff Jirsa
>Priority: Critical
> Fix For: 3.0.x, 3.11.x, 4.x
>
>
> Range deletes in a CAS batch are ignored 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org