[GitHub] DaanHoogland commented on a change in pull request #3036: Implemented capabilities for snapshots and vm snapshots.
DaanHoogland commented on a change in pull request #3036: Implemented
capabilities for snapshots and vm snapshots.
URL: https://github.com/apache/cloudstack/pull/3036#discussion_r234766361
##
File path:
server/src/main/java/com/cloud/storage/snapshot/SnapshotManagerImpl.java
##
@@ -1272,15 +1273,15 @@ public boolean configure(String name, Map params) throws Configu
String value =
_configDao.getValue(Config.BackupSnapshotWait.toString());
-Type.HOURLY.setMax(SnapshotHourlyMax.value());
-Type.DAILY.setMax(SnapshotDailyMax.value());
-Type.WEEKLY.setMax(SnapshotWeeklyMax.value());
-Type.MONTHLY.setMax(SnapshotMonthlyMax.value());
+Type.HOURLY.setMax(snapshotHourlyMax.value());
+Type.DAILY.setMax(snapshotDailyMax.value());
+Type.WEEKLY.setMax(snapshotWeeklyMax.value());
+Type.MONTHLY.setMax(snapshotMonthlyMax.value());
_totalRetries =
NumbersUtil.parseInt(_configDao.getValue("total.retries"), 4);
_pauseInterval = 2 *
NumbersUtil.parseInt(_configDao.getValue("ping.interval"), 60);
-snapshotBackupRetries = BackupRetryAttempts.value();
-snapshotBackupRetryInterval = BackupRetryInterval.value();
+snapshotBackupRetries = backupRetryAttempts.value();
Review comment:
ok, not your doing, @bwsw. rather ugly misuse of English though: number of
attempts == initial attempt plus number of retries.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] DaanHoogland commented on a change in pull request #3036: Implemented capabilities for snapshots and vm snapshots.
DaanHoogland commented on a change in pull request #3036: Implemented
capabilities for snapshots and vm snapshots.
URL: https://github.com/apache/cloudstack/pull/3036#discussion_r234765904
##
File path:
engine/components-api/src/main/java/com/cloud/vm/snapshot/VMSnapshotManager.java
##
@@ -28,14 +28,35 @@
public interface VMSnapshotManager extends VMSnapshotService, Manager {
-static final ConfigKey VMSnapshotExpireInterval = new
ConfigKey("Advanced", Integer.class, "vmsnapshot.expire.interval",
"-1",
-"VM Snapshot expire interval in hours", true,
ConfigKey.Scope.Account);
+Integer defaultVirtualMachineSnapshotsMax = 10;
+Integer defaultVirtualMachineJobCheckInterval = 3000;
+Integer defaultVirtualMachineSnapshotExpireInterval = -1;
+Integer defaultVirtualMachineSnapshotCreateWait = 1800;
-public static final int VMSNAPSHOTMAX = 10;
+ConfigKey virtualMachineSnapshotExpireInterval = new
ConfigKey("Advanced",
Review comment:
ok, not making a point of it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] DaanHoogland commented on a change in pull request #3036: Implemented capabilities for snapshots and vm snapshots.
DaanHoogland commented on a change in pull request #3036: Implemented
capabilities for snapshots and vm snapshots.
URL: https://github.com/apache/cloudstack/pull/3036#discussion_r234529665
##
File path:
engine/components-api/src/main/java/com/cloud/vm/snapshot/VMSnapshotManager.java
##
@@ -28,14 +28,35 @@
public interface VMSnapshotManager extends VMSnapshotService, Manager {
-static final ConfigKey VMSnapshotExpireInterval = new
ConfigKey("Advanced", Integer.class, "vmsnapshot.expire.interval",
"-1",
-"VM Snapshot expire interval in hours", true,
ConfigKey.Scope.Account);
+Integer defaultVirtualMachineSnapshotsMax = 10;
+Integer defaultVirtualMachineJobCheckInterval = 3000;
+Integer defaultVirtualMachineSnapshotExpireInterval = -1;
+Integer defaultVirtualMachineSnapshotCreateWait = 1800;
-public static final int VMSNAPSHOTMAX = 10;
+ConfigKey virtualMachineSnapshotExpireInterval = new
ConfigKey("Advanced",
Review comment:
isn't convention for config-values capatalised?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] DaanHoogland commented on a change in pull request #3036: Implemented capabilities for snapshots and vm snapshots.
DaanHoogland commented on a change in pull request #3036: Implemented capabilities for snapshots and vm snapshots. URL: https://github.com/apache/cloudstack/pull/3036#discussion_r234529885 ## File path: engine/components-api/src/main/java/com/cloud/vm/snapshot/VMSnapshotManager.java ## @@ -45,7 +66,7 @@ * Sync VM snapshot state when VM snapshot in reverting or snapshoting or expunging state * Used for fullsync after agent connects * - * @param vm, the VM in question + * @param vm,the VM in question Review comment: since you are fixing the java doc; pleae remove the comma. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] DaanHoogland commented on a change in pull request #3036: Implemented capabilities for snapshots and vm snapshots.
DaanHoogland commented on a change in pull request #3036: Implemented
capabilities for snapshots and vm snapshots.
URL: https://github.com/apache/cloudstack/pull/3036#discussion_r234529165
##
File path:
server/src/main/java/com/cloud/storage/snapshot/SnapshotManagerImpl.java
##
@@ -1272,15 +1273,15 @@ public boolean configure(String name, Map params) throws Configu
String value =
_configDao.getValue(Config.BackupSnapshotWait.toString());
-Type.HOURLY.setMax(SnapshotHourlyMax.value());
-Type.DAILY.setMax(SnapshotDailyMax.value());
-Type.WEEKLY.setMax(SnapshotWeeklyMax.value());
-Type.MONTHLY.setMax(SnapshotMonthlyMax.value());
+Type.HOURLY.setMax(snapshotHourlyMax.value());
+Type.DAILY.setMax(snapshotDailyMax.value());
+Type.WEEKLY.setMax(snapshotWeeklyMax.value());
+Type.MONTHLY.setMax(snapshotMonthlyMax.value());
_totalRetries =
NumbersUtil.parseInt(_configDao.getValue("total.retries"), 4);
_pauseInterval = 2 *
NumbersUtil.parseInt(_configDao.getValue("ping.interval"), 60);
-snapshotBackupRetries = BackupRetryAttempts.value();
-snapshotBackupRetryInterval = BackupRetryInterval.value();
+snapshotBackupRetries = backupRetryAttempts.value();
Review comment:
'retries' would be 'attempts' minus 1, would it?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
