DaanHoogland commented on a change in pull request #3036: Implemented 
capabilities for snapshots and vm snapshots.
URL: https://github.com/apache/cloudstack/pull/3036#discussion_r234765904
 
 

 ##########
 File path: 
engine/components-api/src/main/java/com/cloud/vm/snapshot/VMSnapshotManager.java
 ##########
 @@ -28,14 +28,35 @@
 
 public interface VMSnapshotManager extends VMSnapshotService, Manager {
 
-    static final ConfigKey<Integer> VMSnapshotExpireInterval = new 
ConfigKey<Integer>("Advanced", Integer.class, "vmsnapshot.expire.interval", 
"-1",
-            "VM Snapshot expire interval in hours", true, 
ConfigKey.Scope.Account);
+    Integer defaultVirtualMachineSnapshotsMax = 10;
+    Integer defaultVirtualMachineJobCheckInterval = 3000;
+    Integer defaultVirtualMachineSnapshotExpireInterval = -1;
+    Integer defaultVirtualMachineSnapshotCreateWait = 1800;
 
-    public static final int VMSNAPSHOTMAX = 10;
+    ConfigKey<Integer> virtualMachineSnapshotExpireInterval = new 
ConfigKey<Integer>("Advanced",
 
 Review comment:
   ok, not making a point of it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to