[GitHub] yvsubhash commented on a change in pull request #2102: CLOUDSTACK-9889 Dedication of guest vlan range to a domain

[GitBox]

yvsubhash commented on a change in pull request #2102: CLOUDSTACK-9889 
Dedication of guest vlan range to a domain
URL: https://github.com/apache/cloudstack/pull/2102#discussion_r157452394
 
 

 ##
 File path: ui/l10n/ar.js
 ##
 @@ -309,6 +309,7 @@ var dictionary = {
 "label.add.VM.to.tier": "?  ??? ?? ",
 "label.add.VPN.gateway": "??? ? ?? ?? ???",
 "label.add.account": "Add Account",
+"label.add.accoutordomain": "Add Account/Domain",
 
 Review comment:
   @nitin-maharana resource strings are added for all the languages


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] yvsubhash commented on a change in pull request #2102: CLOUDSTACK-9889 Dedication of guest vlan range to a domain

[GitBox]

yvsubhash commented on a change in pull request #2102: CLOUDSTACK-9889 
Dedication of guest vlan range to a domain
URL: https://github.com/apache/cloudstack/pull/2102#discussion_r153992366
 
 

 ##
 File path: server/src/com/cloud/api/dispatch/ParamProcessWorker.java
 ##
 @@ -145,7 +146,7 @@ private void validateField(final Object paramObj, final 
Parameter annotation) th
 
 @SuppressWarnings({"unchecked", "rawtypes"})
 public void processParameters(final BaseCmd cmd, final Map params) {
-final Map entitiesToAccess = new HashMap();
+final Multimap entitiesToAccess = 
ArrayListMultimap.create();
 
 Review comment:
   This is to check both account and domain vnet tables for a given entity id


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] yvsubhash commented on a change in pull request #2102: CLOUDSTACK-9889 Dedication of guest vlan range to a domain

[GitBox]

yvsubhash commented on a change in pull request #2102: CLOUDSTACK-9889 
Dedication of guest vlan range to a domain
URL: https://github.com/apache/cloudstack/pull/2102#discussion_r152783965
 
 

 ##
 File path: engine/schema/src/com/cloud/network/dao/DomainGuestVlanMapDao.java
 ##
 @@ -0,0 +1,33 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package com.cloud.network.dao;
+
+import com.cloud.utils.db.GenericDao;
+import java.util.List;
+
+public interface DomainGuestVlanMapDao extends 
GenericDao {
+
+public List listDomainGuestVlanMapsByDomain(long 
domainId);
 
 Review comment:
   @nitin-maharana  taken care


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] yvsubhash commented on a change in pull request #2102: CLOUDSTACK-9889 Dedication of guest vlan range to a domain

[GitBox]

yvsubhash commented on a change in pull request #2102: CLOUDSTACK-9889 
Dedication of guest vlan range to a domain
URL: https://github.com/apache/cloudstack/pull/2102#discussion_r152783928
 
 

 ##
 File path: api/src/com/cloud/network/GuestVlanDomain.java
 ##
 @@ -0,0 +1,33 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package com.cloud.network;
+
+import org.apache.cloudstack.api.Identity;
+import org.apache.cloudstack.api.InternalIdentity;
+
+public interface GuestVlanDomain extends InternalIdentity, Identity {
+
+@Override
+public long getId();
 
 Review comment:
   @nitin-maharana  taken care


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] yvsubhash commented on a change in pull request #2102: CLOUDSTACK-9889 Dedication of guest vlan range to a domain

[git]

yvsubhash commented on a change in pull request #2102: CLOUDSTACK-9889 
Dedication of guest vlan range to a domain
URL: https://github.com/apache/cloudstack/pull/2102#discussion_r117221695
 
 

 ##
 File path: 
api/src/org/apache/cloudstack/api/command/admin/network/DedicateGuestVlanRangeCmd.java
 ##
 @@ -106,14 +107,27 @@ public long getEntityOwnerId() {
 
 @Override
 public void execute() throws ResourceUnavailableException, 
ResourceAllocationException {
-GuestVlan result = _networkService.dedicateGuestVlanRange(this);
-if (result != null) {
-GuestVlanRangeResponse response = 
_responseGenerator.createDedicatedGuestVlanRangeResponse(result);
-response.setResponseName(getCommandName());
-response.setObjectName("dedicatedguestvlanrange");
-this.setResponseObject(response);
-} else {
-throw new ServerApiException(ApiErrorCode.INTERNAL_ERROR, "Failed 
to dedicate guest vlan range");
+if (projectId == null && (accountName == null || 
accountName.isEmpty()) ) {
 
 Review comment:
   @kishankavala 
   It is taken care inside the method call 
Domain d = _domainDao.findById(domainId);
   if (d == null) {
   throw new InvalidParameterValueException("Please specify a valid 
domain");
   }
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services