Bug#733866: nyancat-server: drop reconf-inetd dependency
Hi Jonathan, > What are my options apart from manually removing reconf-inet's entries > from /etc/inetd.conf and restart inetd using invoke-rc.d? > It's unfortunate that the same link is used for both reconf-inetd and systemd. Can't you ship a new systemd service file that refers to another (newly shipped) link? Failing that, you can always do it manually (it's ugly but you wouldn't be the first, and it's a one-off solution anyhow). Cheers, Serafeim
Bug#733866: nyancat-server: drop reconf-inetd dependency
Hi Serafeim, On 14/04/14 21:36, Serafeim Zanikolas wrote: >> Can you please provide a tested patch to cleanly remove any existing >> entries in /etc/inetd.conf prior to systemd service file installation? > > I recalled that nyancat-server was a symlink just for reconf-inetd, so you can > stop shipping it. If you also stop shipping the reconf-inet fragments, then > reconf-inetd will remove its inetd.conf entries upon upgrading to the new > package (via a dpkg trigger, ie. you don't need to call anything on postinst, > in fact you should drop postinst altogether). > > Here's a tested patch (not including dropping the postinst file, which is a > no-op for upgrading from wheezy onwards): Thanks for the tested patch. Unfortunately, I won't be removing the nyancat-server symlink, as this is still required for the systemd socket/service files. What are my options apart from manually removing reconf-inet's entries from /etc/inetd.conf and restart inetd using invoke-rc.d? Thanks, Jon -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#733866: nyancat-server: drop reconf-inetd dependency
Hi Jon, On Sat, Apr 12, 2014 at 09:37:51PM +0100, Jonathan McCrohan wrote: > Given that you have already orphaned both reconf-inetd and update-inetd, > and nobody else has come forward, I think it would be best for nyancat > not to depend on either of them. I've RFA'd them; I'm still the maintainer. > I have already created systemd service files for nyancat and sent them > upstream. I would like to use systemd on linux, with perhaps manual > instructions on !linux archs. Sounds great. > Can you please provide a tested patch to cleanly remove any existing > entries in /etc/inetd.conf prior to systemd service file installation? I recalled that nyancat-server was a symlink just for reconf-inetd, so you can stop shipping it. If you also stop shipping the reconf-inet fragments, then reconf-inetd will remove its inetd.conf entries upon upgrading to the new package (via a dpkg trigger, ie. you don't need to call anything on postinst, in fact you should drop postinst altogether). Here's a tested patch (not including dropping the postinst file, which is a no-op for upgrading from wheezy onwards): diff -Nurp orig/nyancat-1.2.2/debian/nyancat-server.install patched2/nyancat-1.2.2/debian/nyancat-server.install --- orig/nyancat-1.2.2/debian/nyancat-server.install2013-06-04 22:06:46.0 +0100 +++ patched2/nyancat-1.2.2/debian/nyancat-server.install1970-01-01 01:00:00.0 +0100 @@ -1,2 +0,0 @@ -debian/reconf-inetd/nyancat-server.tcp usr/share/reconf-inetd/ -debian/reconf-inetd/nyancat-server.tcp6 usr/share/reconf-inetd/ diff -Nurp orig/nyancat-1.2.2/debian/nyancat-server.links patched2/nyancat-1.2.2/debian/nyancat-server.links --- orig/nyancat-1.2.2/debian/nyancat-server.links 2013-06-04 22:06:46.0 +0100 +++ patched2/nyancat-1.2.2/debian/nyancat-server.links 2014-04-13 22:07:19.0 +0100 @@ -1,2 +1 @@ -usr/bin/nyancat usr/bin/nyancat-server -/usr/share/man/man1/nyancat.1.gz /usr/share/man/man1/nyancat-server.1.gz cheers, -- Every great idea is worthless without someone to do the work. --Neil Williams -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#733866: nyancat-server: drop reconf-inetd dependency
On 05/04/14 17:43, Serafeim Zanikolas wrote: > I see two alternatives. Either we leave nyancat on reconf-inetd (it does work > and in fact it's the only way to have both ip4 & ipv6 entries, it's just that > it doesn't make much sense to keep reconf-inetd for just one package). > > Alternatively, you can put in postinst "update-inetd --multi --pattern nyancat > --remove telnet" on the condition that the nyancat server package is being > upgraded from 1.2.2-1 (the latest version that uses reconf-inetd) *and* > inetd.conf has telnet entries exactly as they were shipped by that version. > That's more or less the example snippet at > http://dep.debian.net/deps/dep9/#index5h1 but adding the new entries with > update-inetd (instead of reconf-inetd). > > If you're okay with the latter idea, I'll send you a patch. Given that you have already orphaned both reconf-inetd and update-inetd, and nobody else has come forward, I think it would be best for nyancat not to depend on either of them. I have already created systemd service files for nyancat and sent them upstream. I would like to use systemd on linux, with perhaps manual instructions on !linux archs. Can you please provide a tested patch to cleanly remove any existing entries in /etc/inetd.conf prior to systemd service file installation? Thanks, Jon -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#733866: nyancat-server: drop reconf-inetd dependency
Hi Jon, On Tue, Apr 01, 2014 at 11:51:09PM +0100, Jonathan McCrohan wrote: > Hi Serafeim, > > On 02/01/14 23:13, Serafeim Zanikolas wrote: > > Here's a list of instructions instead: > > > > - don't ship anything under /usr/share/reconf-inetd/ > > - replace dependency on reconf-inetd with one on update-inetd > > - revert postinst script to the one you had before, and put > > "reconf-inetd || true" before invoking "update-inetd --add ..." > > (the former will remove any entries added by reconf-inetd, for which > > there's > > no fragment under /usr/share/reconf-inetd) > > > > Let me know if you run into any issues. > > Have you tested this yourself? I have tried above and it doesn't work. I haven't tested it, and in fact my suggestion shouldn't work (sorry). I didn't remember that reconf-inetd won't delete an inetd.conf entry that refers to an existing path (that's a feature; see table in http://dep.debian.net/deps/dep9/#index3h1). > How you do you propose you fix this? I see two alternatives. Either we leave nyancat on reconf-inetd (it does work and in fact it's the only way to have both ip4 & ipv6 entries, it's just that it doesn't make much sense to keep reconf-inetd for just one package). Alternatively, you can put in postinst "update-inetd --multi --pattern nyancat --remove telnet" on the condition that the nyancat server package is being upgraded from 1.2.2-1 (the latest version that uses reconf-inetd) *and* inetd.conf has telnet entries exactly as they were shipped by that version. That's more or less the example snippet at http://dep.debian.net/deps/dep9/#index5h1 but adding the new entries with update-inetd (instead of reconf-inetd). If you're okay with the latter idea, I'll send you a patch. -- Every great idea is worthless without someone to do the work. --Neil Williams -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#733866: nyancat-server: drop reconf-inetd dependency
Hi Serafeim, On 02/01/14 23:13, Serafeim Zanikolas wrote: > Here's a list of instructions instead: > > - don't ship anything under /usr/share/reconf-inetd/ > - replace dependency on reconf-inetd with one on update-inetd > - revert postinst script to the one you had before, and put > "reconf-inetd || true" before invoking "update-inetd --add ..." > (the former will remove any entries added by reconf-inetd, for which there's > no fragment under /usr/share/reconf-inetd) > > Let me know if you run into any issues. Have you tested this yourself? I have tried above and it doesn't work. With a trivial nyancat-server.postinst in my new version: #!/bin/sh set -e ls -lah /usr/share/reconf-inetd/nyancat-server* || true reconf-inetd --verbose || true ls -lah /usr/share/reconf-inetd/nyancat-server* || true I get the following output: jmccrohan@lambda:~/src/debian/nyancat$ sudo dpkg -i /var/cache/pbuilder/sid-amd64/result/nyancat_1.4.1-1_amd64.deb /var/cache/pbuilder/sid-amd64/result/nyancat-server_1.4.1-1_amd64.deb (Reading database ... 466867 files and directories currently installed.) Preparing to unpack .../nyancat_1.4.1-1_amd64.deb ... Unpacking nyancat (1.4.1-1) over (1.2.2-1) ... Preparing to unpack .../nyancat-server_1.4.1-1_amd64.deb ... Unpacking nyancat-server (1.4.1-1) over (1.2.2-1) ... Setting up nyancat (1.4.1-1) ... Setting up nyancat-server (1.4.1-1) ... ls: cannot access /usr/share/reconf-inetd/nyancat-server*: No such file or directory no changes to be made ls: cannot access /usr/share/reconf-inetd/nyancat-server*: No such file or directory Processing triggers for man-db (2.6.6-1) ... Processing triggers for reconf-inetd (1.120603) ... jmccrohan@lambda:~/src/debian/nyancat$ I have removed the files under /usr/share/reconf-inetd in the new version (verified in postinst output), yet reconf-inetd still leaves dangling entries in /etc/inetd.conf: jmccrohan@lambda:~/src/debian/nyancat$ grep nyancat /etc/inetd.conf telnet stream tcp6 nowait nobody /usr/bin/nyancat-server nyancat -t telnet stream tcp nowait nobody /usr/bin/nyancat-server nyancat -t How you do you propose you fix this? Thanks, Jon -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#733866: nyancat-server: drop reconf-inetd dependency
Hi Jon, On Thu, Jan 02, 2014 at 02:33:22AM +, Jonathan McCrohan wrote: > Can you please supply a patch for this. DEP9 provides no guidance on how > correctly to migrate users away from reconf-inetd in the postinst. Here's a list of instructions instead: - don't ship anything under /usr/share/reconf-inetd/ - replace dependency on reconf-inetd with one on update-inetd - revert postinst script to the one you had before, and put "reconf-inetd || true" before invoking "update-inetd --add ..." (the former will remove any entries added by reconf-inetd, for which there's no fragment under /usr/share/reconf-inetd) Let me know if you run into any issues. Cheers, -- Every great idea is worthless without someone to do the work. --Neil Williams -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#733866: nyancat-server: drop reconf-inetd dependency
Hi Serafeim, On 01/01/14 15:58, Serafeim Zanikolas wrote: > Please drop nyncat-server's dependency on reconf-inetd (eg. by switching back > to update-inetd). Can you please supply a patch for this. DEP9 provides no guidance on how correctly to migrate users away from reconf-inetd in the postinst. Thanks, Jon -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#733866: nyancat-server: drop reconf-inetd dependency
Package: nyancat-server Version: 1.2.2-1 Severity: normal Hi, I plan to remove reconf-inetd from the Debian archive, since jessie will most likely be released with a modern init system which makes inetd even more irrelevant (and thus reconf-inetd not a worthwhile project). Please drop nyncat-server's dependency on reconf-inetd (eg. by switching back to update-inetd). Thanks for giving a try to reconf-inetd and apologies for the wasted time in doing so. Thanks, Serafeim -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
