Build failed in Jenkins: build-master-slowbuild #2850

[jenkins]

See 

--
[...truncated 28723 lines...]
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud ---
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:instrument (default-cli) @ 
cloud-quickcloud ---
[WARNING] No files to instrument.
[INFO] NOT adding cobertura ser file to attached artifacts list.
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-quickcloud ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ 
cloud-quickcloud ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud ---
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Apache CloudStack Developer Tools - Checkstyle Configuration  SUCCESS 
[2.992s]
[INFO] Apache CloudStack . SUCCESS [4.382s]
[INFO] Apache CloudStack Maven Conventions Parent  SUCCESS [0.834s]
[INFO] Apache CloudStack Framework - Managed Context . SUCCESS [19.692s]
[INFO] Apache CloudStack Utils ... SUCCESS [1:37.594s]
[INFO] Apache CloudStack Framework ... SUCCESS [0.172s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [53.872s]
[INFO] Apache CloudStack Framework - Configuration ... SUCCESS [27.930s]
[INFO] Apache CloudStack API . SUCCESS [1:51.778s]
[INFO] Apache CloudStack Framework - REST  SUCCESS [17.190s]
[INFO] Apache CloudStack Framework - IPC . SUCCESS [30.325s]
[INFO] Apache CloudStack Cloud Engine  SUCCESS [0.135s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [28.417s]
[INFO] Apache CloudStack Framework - Security  SUCCESS [25.376s]
[INFO] Apache CloudStack Core  SUCCESS [1:23.471s]
[INFO] Apache CloudStack Agents .. SUCCESS [39.412s]
[INFO] Apache CloudStack Framework - Clustering .. SUCCESS [38.113s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [14.122s]
[INFO] Apache CloudStack Cloud Engine Schema Component ... SUCCESS [2:08.442s]
[INFO] Apache CloudStack Framework - Jobs  SUCCESS [40.943s]
[INFO] Apache CloudStack Cloud Engine Internal Components API  SUCCESS [25.672s]
[INFO] Apache CloudStack Server .. SUCCESS [4:17.129s]
[INFO] Apache CloudStack Framework - Quota ... SUCCESS [38.287s]
[INFO] Apache CloudStack Usage Server  SUCCESS [44.315s]
[INFO] Apache CloudStack Cloud Engine Orchestration Component  SUCCESS 
[1:20.936s]
[INFO] Apache CloudStack Cloud Services .. SUCCESS [0.110s]
[INFO] Apache CloudStack Secondary Storage ... SUCCESS [0.603s]
[INFO] Apache CloudStack Secondary Storage Service ... SUCCESS [56.228s]
[INFO] Apache CloudStack Engine Storage Component  SUCCESS [48.456s]
[INFO] Apache CloudStack Engine Storage Volume Component . SUCCESS [30.093s]
[INFO] Apache CloudStack Engine Storage Image Component .. SUCCESS [25.909s]
[INFO] Apache CloudStack Engine Storage Data Motion Component  SUCCESS [26.108s]
[INFO] Apache CloudStack Engine Storage Cache Component .. SUCCESS [20.490s]
[INFO] Apache CloudStack Engine Storage Snapshot Component  SUCCESS [35.591s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [12.744s]
[INFO] Apache CloudStack Cloud Engine Service  SUCCESS [8.395s]
[INFO] Apache CloudStack Plugin POM .. SUCCESS [1.003s]
[INFO] Apache CloudStack Plugin - API Rate Limit . SUCCESS [26.905s]
[INFO] Apache CloudStack Plugin - Storage Volume default provider  SUCCESS 
[23.469s]
[INFO] Apache CloudStack Plugin - Storage Volume SolidFire Provider  SUCCESS 
[35.839s]
[INFO] Apache CloudStack Plugin - API SolidFire .. SUCCESS [17.705s]
[INFO] Apache CloudStack Plugin - API Discovery .. SUCCESS [23.193s]
[INFO] Apache CloudStack Plugin - ACL Static Role Based .. SUCCESS [14.976s]
[INFO] Apache CloudStack Plugin - Host Anti-Affinity Processor  SUCCESS 
[16.841s]
[INFO] Apache 

[GitHub] cloudstack pull request: CLOUDSTACK-9181 Prevent syntax error in c...

[rafaelweingartner]

Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/1296#issuecomment-167672958
  
@remibergsma the code looks ok, would you mind to squash your commits?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: trailing commas in javascripts removed

[borisroman]

Github user borisroman commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1288#discussion_r48466763
  
--- Diff: ui/plugins/plugins.js ---
@@ -16,7 +16,7 @@
 // under the License.
 (function($, cloudStack) {
   cloudStack.plugins = [
-'quota',
-//'testPlugin'
+//'testPlugin',
--- End diff --

Why not remove it? It's already commented out...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: build-master-jdk18 #446

[jenkins]

See 

Changes:

[nicovazquez90] CLOUDSTACK-9074: API Changes: Add l2gatewayserviceuuid to NVP 
devices

[nicovazquez90] CLOUDSTACK-9074: API Changes: Add nsxLogicalSwitch and

[nicovazquez90] CLOUDSTACK-9074: New NiciraNVP classes to support Shared 
Networks

[nicovazquez90] CLOUDSTACK-9074: New NiciraNVP classes for FindLRouterPort and

[nicovazquez90] CLOUDSTACK-9074: Support Shared Networks in NiciraNVP Plugin

[nicovazquez90] CLOUDSTACK-9074: API add Gateway Service Find method

[nicovazquez90] CLOUDSTACK-9074: Drop nicira_nvp_router_map unique index on

[nicovazquez90] CLOUDSTACK-9074: Marvin tests for NSX Shared Networks Support

[nicovazquez90] Only set L2 Gateway in NSX device if defined

[nicovazquez90] Add helper method to migrate router vms

[nicovazquez90] Use helper method to migrate router vm

[nicovazquez90] Fix method call bugs when accessign non defined variables

[nicovazquez90] Use NSX specific config values instead of zone config values

[nicovazquez90] CLOUDSTACK-9074: Add NetworkGuruAdditionalFunctions license

[nicovazquez90] CLOUDSTACK-9074: Move sql to 4.8.0 schema

--
[...truncated 425 lines...]
Tests run: 10, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 0.526 sec - in 
com.cloud.utils.ScriptTest
Running com.cloud.utils.log.CglibThrowableRendererTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.217 sec - in 
com.cloud.utils.log.CglibThrowableRendererTest
Running com.cloud.utils.UuidUtilsTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.047 sec - in 
com.cloud.utils.UuidUtilsTest
Running com.cloud.utils.crypto.RSAHelperTest
2015-12-28 11:09:04,832 INFO  [utils.crypt.RSAHelper] (main:) [ignored]error 
during public key encryption: Unsupported format
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.824 sec - in 
com.cloud.utils.crypto.RSAHelperTest
Running com.cloud.utils.crypto.EncryptionSecretKeyCheckerTest
2015-12-28 11:09:04,965 DEBUG [utils.crypt.EncryptionSecretKeyChecker] (main:) 
Encryption Type: null
2015-12-28 11:09:04,965 DEBUG [utils.crypt.EncryptionSecretKeyChecker] (main:) 
Encryption Type: file
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.032 sec - in 
com.cloud.utils.crypto.EncryptionSecretKeyCheckerTest
Running com.cloud.utils.PropertiesUtilsTest
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.04 sec - in 
com.cloud.utils.PropertiesUtilsTest
Running com.cloud.utils.exception.ExceptionUtilTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 sec - in 
com.cloud.utils.exception.ExceptionUtilTest
Running com.cloud.utils.storage.QCOW2UtilsTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.001 sec - in 
com.cloud.utils.storage.QCOW2UtilsTest
Running com.cloud.utils.encoding.UrlEncoderTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 sec - in 
com.cloud.utils.encoding.UrlEncoderTest
Running com.cloud.utils.UriUtilsTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.074 sec - in 
com.cloud.utils.UriUtilsTest
Running com.cloud.utils.HttpUtilsTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.076 sec - in 
com.cloud.utils.HttpUtilsTest
Running com.cloud.utils.backoff.impl.ConstantTimeBackoffTest
2015-12-28 11:09:05,301 INFO  [backoff.impl.ConstantTimeBackoff] (Thread-1:) 
Thread Thread-1 interrupted while waiting for retry
2015-12-28 11:09:05,404 DEBUG [backoff.impl.ConstantTimeBackoffTest] (main:) 
thread started
2015-12-28 11:09:05,404 DEBUG [backoff.impl.ConstantTimeBackoffTest] 
(Thread-2:) before
2015-12-28 11:09:05,506 DEBUG [backoff.impl.ConstantTimeBackoffTest] (main:) 
testing wakeup
Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.327 sec - in 
com.cloud.utils.backoff.impl.ConstantTimeBackoffTest
Running com.cloud.utils.ProcessUtilTest
2015-12-28 11:09:05,510 INFO  [backoff.impl.ConstantTimeBackoff] (Thread-2:) 
Thread Thread-2 interrupted while waiting for retry
2015-12-28 11:09:05,510 DEBUG [backoff.impl.ConstantTimeBackoffTest] 
(Thread-2:) after
2015-12-28 11:09:05,514 DEBUG [cloud.utils.ProcessUtil] (main:) 
environment.properties could not be opened
2015-12-28 11:09:05,524 DEBUG [cloud.utils.ProcessUtil] (main:) 
environment.properties could not be opened
2015-12-28 11:09:05,524 DEBUG [cloud.utils.ProcessUtil] (main:) Executing: bash 
-c ps -p 123456 
2015-12-28 11:09:05,605 DEBUG [cloud.utils.ProcessUtil] (main:) Exit value is 1
2015-12-28 11:09:05,606 DEBUG [cloud.utils.ProcessUtil] (main:)   PID TTY   
   TIME CMD
2015-12-28 11:09:05,607 DEBUG [cloud.utils.ProcessUtil] (main:) Executing: bash 
-c echo $PPID 
2015-12-28 11:09:05,610 DEBUG [cloud.utils.ProcessUtil] (main:) Execution is 
successful.
2015-12-28 11:09:05,616 DEBUG [cloud.utils.ProcessUtil] (main:) 
environment.properties could not be opened
Tests run: 3, Failures: 0, 

[GitHub] cloudstack pull request: Quota: findbug fixes

[agneya2001]

GitHub user agneya2001 opened a pull request:

https://github.com/apache/cloudstack/pull/1289

Quota: findbug fixes

Findbug fixes for cloud-framework-quota and cloud-plugin-database-quota.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shapeblue/cloudstack master-quotafb

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1289.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1289


commit 625abb80aa590cfc7e6cfefe6f0bf55c95ac679f
Author: Abhinandan Prateek 
Date:   2015-12-23T04:42:11Z

Quota: findbug fixes




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: build-master-slowbuild #2847

[jenkins]

See 

Changes:

[nicovazquez90] CLOUDSTACK-9074: API Changes: Add l2gatewayserviceuuid to NVP 
devices

[nicovazquez90] CLOUDSTACK-9074: API Changes: Add nsxLogicalSwitch and

[nicovazquez90] CLOUDSTACK-9074: New NiciraNVP classes to support Shared 
Networks

[nicovazquez90] CLOUDSTACK-9074: New NiciraNVP classes for FindLRouterPort and

[nicovazquez90] CLOUDSTACK-9074: Support Shared Networks in NiciraNVP Plugin

[nicovazquez90] CLOUDSTACK-9074: API add Gateway Service Find method

[nicovazquez90] CLOUDSTACK-9074: Drop nicira_nvp_router_map unique index on

[nicovazquez90] CLOUDSTACK-9074: Marvin tests for NSX Shared Networks Support

[nicovazquez90] Only set L2 Gateway in NSX device if defined

[nicovazquez90] Add helper method to migrate router vms

[nicovazquez90] Use helper method to migrate router vm

[nicovazquez90] Fix method call bugs when accessign non defined variables

[nicovazquez90] Use NSX specific config values instead of zone config values

[nicovazquez90] CLOUDSTACK-9074: Add NetworkGuruAdditionalFunctions license

[nicovazquez90] CLOUDSTACK-9074: Move sql to 4.8.0 schema

--
[...truncated 28723 lines...]
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud ---
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:instrument (default-cli) @ 
cloud-quickcloud ---
[WARNING] No files to instrument.
[INFO] NOT adding cobertura ser file to attached artifacts list.
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-quickcloud ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ 
cloud-quickcloud ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud ---
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Apache CloudStack Developer Tools - Checkstyle Configuration  SUCCESS 
[2.272s]
[INFO] Apache CloudStack . SUCCESS [2.110s]
[INFO] Apache CloudStack Maven Conventions Parent  SUCCESS [0.765s]
[INFO] Apache CloudStack Framework - Managed Context . SUCCESS [19.634s]
[INFO] Apache CloudStack Utils ... SUCCESS [1:31.603s]
[INFO] Apache CloudStack Framework ... SUCCESS [0.108s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [54.545s]
[INFO] Apache CloudStack Framework - Configuration ... SUCCESS [28.081s]
[INFO] Apache CloudStack API . SUCCESS [1:48.911s]
[INFO] Apache CloudStack Framework - REST  SUCCESS [16.016s]
[INFO] Apache CloudStack Framework - IPC . SUCCESS [30.267s]
[INFO] Apache CloudStack Cloud Engine  SUCCESS [0.092s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [28.859s]
[INFO] Apache CloudStack Framework - Security  SUCCESS [25.997s]
[INFO] Apache CloudStack Core  SUCCESS [1:22.411s]
[INFO] Apache CloudStack Agents .. SUCCESS [36.883s]
[INFO] Apache CloudStack Framework - Clustering .. SUCCESS [36.410s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [14.470s]
[INFO] Apache CloudStack Cloud Engine Schema Component ... SUCCESS [2:06.398s]
[INFO] Apache CloudStack Framework - Jobs  SUCCESS [41.937s]
[INFO] Apache CloudStack Cloud Engine Internal Components API  SUCCESS [26.024s]
[INFO] Apache CloudStack Server .. SUCCESS [4:11.972s]
[INFO] Apache CloudStack Framework - Quota ... SUCCESS [38.407s]
[INFO] Apache CloudStack Usage Server  SUCCESS [43.460s]
[INFO] Apache CloudStack Cloud Engine Orchestration Component  SUCCESS 
[1:23.890s]
[INFO] Apache CloudStack Cloud Services .. SUCCESS [0.066s]
[INFO] Apache CloudStack Secondary Storage ... SUCCESS [0.474s]
[INFO] Apache CloudStack Secondary Storage Service ... SUCCESS [53.796s]
[INFO] Apache CloudStack Engine Storage Component  SUCCESS [48.096s]
[INFO] Apache CloudStack Engine Storage Volume Component . SUCCESS [30.177s]
[INFO] Apache 

Re: VMware vSphere 6

[Kevin Walker]

Hi Rohit

Ok thats great news, I will deploy CloudStack and perform some testing.

Kind regards

Kevin Walker
+968 99371303
+44 7714303479

On Dec 28, 2015, at 06:17, Rohit Yadav  wrote:

Hi Kevin,

vSphere 6 is already supported in the latest 4.7 release. I’ve tested vSphere 6 
and it seems to work for me, though in the community we have n't had a lot of 
testing efforts wrt vSphere6.

>


Rohit Yadav
Software Architect  ,   ShapeBlue
d:   | s: +44 203 603 0540   |  m:  +91 8826230892
e:  rohit.ya...@shapeblue.com | t:   |  w:  www.shapeblue.com
a:  53 Chandos Place, Covent Garden London WC2N 4HS UK

Shape Blue Ltd is a company incorporated in England & Wales. ShapeBlue Services 
India LLP is a company incorporated in India and is operated under license from 
Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in 
Brasil and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd 
is a company registered by The Republic of South Africa and is traded under 
license from Shape Blue Ltd. ShapeBlue is a registered trademark.
This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error.


On 27-Dec-2015, at 5:07 PM, Kevin Walker  wrote:
> 
> Hi Guys
> 
> Is vSphere 6 support on the roadmap?
> 
> 
> Kind regards
> 
> Kevin Walker

Regards.

Find out more about ShapeBlue and our range of CloudStack related services:
IaaS Cloud Design & Build | CSForge – rapid IaaS deployment framework
CloudStack Consulting | CloudStack Software Engineering
CloudStack Infrastructure Support | CloudStack Bootcamp Training Courses

[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1094#issuecomment-167536985
  
@miguelaferreira I see no issues so LGTM (no integration tests done!)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Quota: findbug fixes

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1289#issuecomment-167554252
  
Based on the code LGTM, tests running


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Quota: findbug fixes

[DaanHoogland]

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1289#discussion_r48476072
  
--- Diff: 
framework/quota/src/org/apache/cloudstack/quota/vo/ServiceOfferingVO.java ---
@@ -310,14 +269,12 @@ public String getDeploymentPlanner() {
 }
 
 public String getDetail(String name) {
-assert (details != null) : "Did you forget to load the details?";
-
-return details != null ? details.get(name) : null;
+if (details == null) throw new IllegalStateException("Cannot set 
value as details is null");
+return details.get(name);
 }
 
 public void setDetail(String name, String value) {
-assert (details != null) : "Did you forget to load the details?";
-
+if (details == null) throw new IllegalStateException("Cannot set 
value as details is null");
--- End diff --

good solution :+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Quota: findbug fixes

[DaanHoogland]

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1289#discussion_r48474787
  
--- Diff: 
framework/quota/src/org/apache/cloudstack/quota/vo/ServiceOfferingVO.java ---
@@ -312,7 +271,7 @@ public String getDeploymentPlanner() {
 public String getDetail(String name) {
 assert (details != null) : "Did you forget to load the details?";
--- End diff --

I would have solved this one by removing the assert. Do we even run any 
tests with asserts enabled? (no :-1: intended!)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8895: Verify if storage on sto...

[sanju1010]

Github user sanju1010 commented on the pull request:

https://github.com/apache/cloudstack/pull/869#issuecomment-167551878
  
I did a code walk-through and looks good.
LGTM !! 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8308:Adding automation testcas...

[sanju1010]

Github user sanju1010 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/384#discussion_r48475810
  
--- Diff: test/integration/testpaths/testpath_delta_snapshots.py ---
@@ -0,0 +1,539 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+""" Test cases for Delta Snapshots Test Path
+"""
+
+from nose.plugins.attrib import attr
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.lib.utils import (cleanup_resources,
+  validateList,
+  is_snapshot_on_nfs)
+from marvin.lib.base import (Account,
+ ServiceOffering,
+ Template,
+ VirtualMachine,
+ Volume,
+ Configurations,
+ Snapshot
+ )
+from marvin.lib.common import (get_domain,
+   get_zone,
+   get_template,
+   list_volumes,
+   createChecksum,
+   compareChecksum
+   )
+from marvin.sshClient import SshClient
+from marvin.codes import (PASS, FAIL, BACKED_UP, ROOT, DATA)
+import time
+
+
+def checkIntegrityOfSnapshot(
+self, snapshotsToRestore, checksumToCompare, disk_type=ROOT):
+"""
+Check integrity of snapshot created of ROOT or DATA Disk:
+
+If ROOT Disk: Deploy a Vm from a template created from the snapshot
+  and checking the contents of the ROOT disk.
+If DATA Disk: Users can create a volume from the snapshot.
+  The volume can then be mounted to a VM and files
+  recovered as needed.
+
+Inputs:
+1. snapshotsToRestore: Snapshots whose integrity is
+   to be checked.
+
+2. checksumToCompare:  The contents of ROOT Disk to be compared.
+
+3. disk_type:  The type of disk - ROOT or DATA Disk
+   of which snapshot was created.
+
+"""
+if disk_type == ROOT:
+# Create template from snapshot
+template_from_snapshot = Template.create_from_snapshot(
+self.apiclient,
+snapshotsToRestore,
+self.testdata["template_2"])
+
+self.assertNotEqual(
+template_from_snapshot,
+None,
+"Check if result exists in list item call"
+)
+
+# Deploy VM
+vm_from_temp = VirtualMachine.create(
+self.apiclient,
+self.testdata["small"],
+templateid=template_from_snapshot.id,
+accountid=self.account.name,
+domainid=self.account.domainid,
+serviceofferingid=self.service_offering.id,
+zoneid=self.zone.id,
+mode=self.zone.networktype
+)
+
+self.assertNotEqual(
+vm_from_temp,
+None,
+"Check if result exists in list item call"
+)
+
+# Verify contents of ROOT disk match with snapshot
+
+compareChecksum(
+self.apiclient,
+service=self.testdata,
+original_checksum=checksumToCompare,
+disk_type="rootdiskdevice",
+virt_machine=vm_from_temp
+)
+
+vm_from_temp.delete(self.apiclient)
+template_from_snapshot.delete(self.apiclient)
+else:
+volumeFormSnap = Volume.create_from_snapshot(
+self.apiclient,
+snapshotsToRestore.id,
+self.testdata["volume"],
+account=self.account.name,
+domainid=self.account.domainid,
+zoneid=self.zone.id
+ 

[GitHub] cloudstack pull request: CLOUDSTACK-8895: Verify if storage on sto...

[DaanHoogland]

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/869#discussion_r48475788
  
--- Diff: test/integration/testpaths/testpath_attach_disk_zwps.py ---
@@ -207,3 +208,188 @@ def test_01_attach_datadisk_to_vm_on_zwps(self):
 "Check: Data if Disk is attached to VM")
 
 return
+
+
+class TestAttachDataDiskOnCWPS(cloudstackTestCase):
--- End diff --

is the name of this class a typo? it ends with CWPS (cluster wide primary 
storage?).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9186: Root admin cannot see VP...

[rafaelweingartner]

Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/1258#issuecomment-167539882
  
@nitin-maharana thanks for checking.
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

[rafaelweingartner]

Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/1273#issuecomment-167540899
  
@nitin-maharana I did not notice that the other PR was to 4.6, I thought it 
was to master.
I would just ask you to use a Javadoc block over 
“getVolumeNameFromCommand” instead of a commenting block.

At line 487, it is good your code, but we can improve it. The code you 
wrote is the same as using 
“org.apache.commons.lang.StringUtils.isBlank(str)”; therefore, I believe 
you should use the method from “StringUtils” from Apache commons lang.

I also recommend you to remove the comments of lines: 362, 369, 376 and 
383, those tests names are intuitive, so there is no need to add comment there.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: trailing commas in javascripts removed

[bhaisaab]

Github user bhaisaab commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1288#discussion_r48466808
  
--- Diff: ui/plugins/plugins.js ---
@@ -16,7 +16,7 @@
 // under the License.
 (function($, cloudStack) {
   cloudStack.plugins = [
-'quota',
-//'testPlugin'
+//'testPlugin',
--- End diff --

also, why not remote the testPlugin folder and the test plugin js etc. 
implementation?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...

[miguelaferreira]

Github user miguelaferreira commented on the pull request:

https://github.com/apache/cloudstack/pull/1094#issuecomment-167517043
  
@DaanHoogland @remibergsma (cc @nvazquez) can we merge this PR before 
master drifts away again?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: build-master-slowbuild #2846

[jenkins]

See 

--
[...truncated 28722 lines...]
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud ---
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:instrument (default-cli) @ 
cloud-quickcloud ---
[WARNING] No files to instrument.
[INFO] NOT adding cobertura ser file to attached artifacts list.
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-quickcloud ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ 
cloud-quickcloud ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud ---
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Apache CloudStack Developer Tools - Checkstyle Configuration  SUCCESS 
[1.730s]
[INFO] Apache CloudStack . SUCCESS [2.077s]
[INFO] Apache CloudStack Maven Conventions Parent  SUCCESS [0.781s]
[INFO] Apache CloudStack Framework - Managed Context . SUCCESS [21.011s]
[INFO] Apache CloudStack Utils ... SUCCESS [1:32.078s]
[INFO] Apache CloudStack Framework ... SUCCESS [0.101s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [53.815s]
[INFO] Apache CloudStack Framework - Configuration ... SUCCESS [27.776s]
[INFO] Apache CloudStack API . SUCCESS [2:01.403s]
[INFO] Apache CloudStack Framework - REST  SUCCESS [17.670s]
[INFO] Apache CloudStack Framework - IPC . SUCCESS [30.574s]
[INFO] Apache CloudStack Cloud Engine  SUCCESS [0.084s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [28.941s]
[INFO] Apache CloudStack Framework - Security  SUCCESS [25.348s]
[INFO] Apache CloudStack Core  SUCCESS [1:23.589s]
[INFO] Apache CloudStack Agents .. SUCCESS [36.150s]
[INFO] Apache CloudStack Framework - Clustering .. SUCCESS [36.470s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [13.866s]
[INFO] Apache CloudStack Cloud Engine Schema Component ... SUCCESS [2:07.657s]
[INFO] Apache CloudStack Framework - Jobs  SUCCESS [41.372s]
[INFO] Apache CloudStack Cloud Engine Internal Components API  SUCCESS [25.177s]
[INFO] Apache CloudStack Server .. SUCCESS [4:12.847s]
[INFO] Apache CloudStack Framework - Quota ... SUCCESS [36.687s]
[INFO] Apache CloudStack Usage Server  SUCCESS [44.017s]
[INFO] Apache CloudStack Cloud Engine Orchestration Component  SUCCESS 
[1:21.904s]
[INFO] Apache CloudStack Cloud Services .. SUCCESS [0.089s]
[INFO] Apache CloudStack Secondary Storage ... SUCCESS [0.434s]
[INFO] Apache CloudStack Secondary Storage Service ... SUCCESS [54.773s]
[INFO] Apache CloudStack Engine Storage Component  SUCCESS [49.427s]
[INFO] Apache CloudStack Engine Storage Volume Component . SUCCESS [29.613s]
[INFO] Apache CloudStack Engine Storage Image Component .. SUCCESS [28.097s]
[INFO] Apache CloudStack Engine Storage Data Motion Component  SUCCESS [25.984s]
[INFO] Apache CloudStack Engine Storage Cache Component .. SUCCESS [20.666s]
[INFO] Apache CloudStack Engine Storage Snapshot Component  SUCCESS [35.005s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [12.656s]
[INFO] Apache CloudStack Cloud Engine Service  SUCCESS [7.945s]
[INFO] Apache CloudStack Plugin POM .. SUCCESS [0.989s]
[INFO] Apache CloudStack Plugin - API Rate Limit . SUCCESS [27.263s]
[INFO] Apache CloudStack Plugin - Storage Volume default provider  SUCCESS 
[24.720s]
[INFO] Apache CloudStack Plugin - Storage Volume SolidFire Provider  SUCCESS 
[35.727s]
[INFO] Apache CloudStack Plugin - API SolidFire .. SUCCESS [17.588s]
[INFO] Apache CloudStack Plugin - API Discovery .. SUCCESS [23.385s]
[INFO] Apache CloudStack Plugin - ACL Static Role Based .. SUCCESS [16.634s]
[INFO] Apache CloudStack Plugin - Host Anti-Affinity Processor  SUCCESS 
[18.002s]
[INFO] Apache 

[GitHub] cloudstack pull request: CLOUDSTACK-8308:Adding automation testcas...

[sanju1010]

Github user sanju1010 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/384#discussion_r48475772
  
--- Diff: test/integration/testpaths/testpath_delta_snapshots.py ---
@@ -0,0 +1,539 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+""" Test cases for Delta Snapshots Test Path
+"""
+
+from nose.plugins.attrib import attr
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.lib.utils import (cleanup_resources,
+  validateList,
+  is_snapshot_on_nfs)
+from marvin.lib.base import (Account,
+ ServiceOffering,
+ Template,
+ VirtualMachine,
+ Volume,
+ Configurations,
+ Snapshot
+ )
+from marvin.lib.common import (get_domain,
+   get_zone,
+   get_template,
+   list_volumes,
+   createChecksum,
+   compareChecksum
+   )
+from marvin.sshClient import SshClient
+from marvin.codes import (PASS, FAIL, BACKED_UP, ROOT, DATA)
+import time
+
+
+def checkIntegrityOfSnapshot(
+self, snapshotsToRestore, checksumToCompare, disk_type=ROOT):
+"""
+Check integrity of snapshot created of ROOT or DATA Disk:
+
+If ROOT Disk: Deploy a Vm from a template created from the snapshot
+  and checking the contents of the ROOT disk.
+If DATA Disk: Users can create a volume from the snapshot.
+  The volume can then be mounted to a VM and files
+  recovered as needed.
+
+Inputs:
+1. snapshotsToRestore: Snapshots whose integrity is
+   to be checked.
+
+2. checksumToCompare:  The contents of ROOT Disk to be compared.
+
+3. disk_type:  The type of disk - ROOT or DATA Disk
+   of which snapshot was created.
+
+"""
+if disk_type == ROOT:
+# Create template from snapshot
+template_from_snapshot = Template.create_from_snapshot(
+self.apiclient,
+snapshotsToRestore,
+self.testdata["template_2"])
+
+self.assertNotEqual(
--- End diff --

This can be replaced with assertNotNone


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8308:Adding automation testcas...

[sanju1010]

Github user sanju1010 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/384#discussion_r48475782
  
--- Diff: test/integration/testpaths/testpath_delta_snapshots.py ---
@@ -0,0 +1,539 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+""" Test cases for Delta Snapshots Test Path
+"""
+
+from nose.plugins.attrib import attr
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.lib.utils import (cleanup_resources,
+  validateList,
+  is_snapshot_on_nfs)
+from marvin.lib.base import (Account,
+ ServiceOffering,
+ Template,
+ VirtualMachine,
+ Volume,
+ Configurations,
+ Snapshot
+ )
+from marvin.lib.common import (get_domain,
+   get_zone,
+   get_template,
+   list_volumes,
+   createChecksum,
+   compareChecksum
+   )
+from marvin.sshClient import SshClient
+from marvin.codes import (PASS, FAIL, BACKED_UP, ROOT, DATA)
+import time
+
+
+def checkIntegrityOfSnapshot(
+self, snapshotsToRestore, checksumToCompare, disk_type=ROOT):
+"""
+Check integrity of snapshot created of ROOT or DATA Disk:
+
+If ROOT Disk: Deploy a Vm from a template created from the snapshot
+  and checking the contents of the ROOT disk.
+If DATA Disk: Users can create a volume from the snapshot.
+  The volume can then be mounted to a VM and files
+  recovered as needed.
+
+Inputs:
+1. snapshotsToRestore: Snapshots whose integrity is
+   to be checked.
+
+2. checksumToCompare:  The contents of ROOT Disk to be compared.
+
+3. disk_type:  The type of disk - ROOT or DATA Disk
+   of which snapshot was created.
+
+"""
+if disk_type == ROOT:
+# Create template from snapshot
+template_from_snapshot = Template.create_from_snapshot(
+self.apiclient,
+snapshotsToRestore,
+self.testdata["template_2"])
+
+self.assertNotEqual(
+template_from_snapshot,
+None,
+"Check if result exists in list item call"
+)
+
+# Deploy VM
+vm_from_temp = VirtualMachine.create(
+self.apiclient,
+self.testdata["small"],
+templateid=template_from_snapshot.id,
+accountid=self.account.name,
+domainid=self.account.domainid,
+serviceofferingid=self.service_offering.id,
+zoneid=self.zone.id,
+mode=self.zone.networktype
+)
+
+self.assertNotEqual(
--- End diff --

Replace with assertNotNone


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1094


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Let’s discuss database upgrades

[Rafael Weingärtner]

Hi all devs,
First of all, sorry the long text, but I hope we can start a discussion
here and improve that part of ACS.

A while ago I have faced the code that Apache CloudStack (ACS) uses to
upgrade from a version to newer one and that did not seem to be a good way
to execute our upgrades. Therefore, I decided to use some time to search
for alternatives.

I have read some material about versioning of scripts used to upgrade a
database (DB) of a system and went through some frameworks that could help
us.

In the literature of software engineering, it is firmly stated that we have
to version DB scripts as we do with the source code of the application,
using the baseline approach. Gladly, we were not that bad at this point, we
already versioned our routines for DB upgrade (.sql and .java). Therefore,
it seemed that we just did not have used a practical approach to help us
during DB upgrades.

>From my readings and looking at the ACS source code I raised the following
requirement:
•We should be able to write more than one routine to upgrade to a
version; those routines can be written in Java and SQL. We might have more
than a routine to be executed for each version and we should be able to
define an order of execution. Additionally, to go to an upper version, we
have to run all of the routines from smaller versions first, until we
achieve the desired version.

We could also add another requirement that is the downgrade from a version,
which we currently do not support. With that comes my first question for
discussion:
•Do we want/need a method to downgrade from a version to a previous one?

I found an explanation for not supporting downgrades, and I liked it:
http://flywaydb.org/documentation/faq.html#downgrade

So, what I devised for us:
First the bureaucracy part  - our migrations occur basically in three (3)
steps, first we have a "prepare script", then a cleanup script and finally
the migration per se that is written in Java, at least, that is what we can
expect when reading the interface “com.cloud.upgrade.dao.DbUpgrade”.

Additionally, our scripts have the following naming convention:
schema-to, which in IMHO may cause some
confusion because at first sight we may think that from the same version we
could have different paths to an upper version, which in practice is not
happening. Instead of a to we could simply use
V__., giving that, we have to
execute all of the V_ scripts that are smaller than the version we
want to upgrade.

To clarify what I am saying, I will use an example. Let’s say we have just
installed ACS and ran the cloudstack-setup-database. That command will
create a database schema in version 4.0.0. To upgrade that schema to
version 4.3.0 (it is just an example, it could be any other version), ACS
will use the following mapping:

_upgradeMap.put("4.0.0", new DbUpgrade[] {new Upgrade40to41(), new
Upgrade410to420(), new Upgrade420to421(), new Upgrade421to430())

After loading the mapping, ACS will execute the scripts defined in each one
of the Upgrade path classes and the migration code per se.

Now, let’s say we change the “.sql” scripts name to the pattern I
mentioned, we would have the following scripts; those are the scripts found
that aim to upgrade to versions between the interval 4.0.0 – 4.3.0
(considering 4.3.0, since that is the goal version):


   - schema-40to410, can be named to:  V_410_A.sql
   - schema-40to410-cleanup, can be named to:  V_410_B.sql
   - schema-410to420, can be named to:  V_420_A.sql
   - schema-410to420-cleanup , can be named to:  V_420_b.sql
   - schema-420to421, can be named to:  V_421_A.sql
   - schema-421to430, can be named to:  V_430_A.sql
   - schema-421to430-cleanup, can be named to:  V_430_B.sql


Additionally, all of the java code would have to follow the same
convention. For instance, we have “com.cloud.upgrade.dao.Upgrade40to41”,
which has some java code to migrate from 4.0.0 to 4.1.0. The idea is to
extract that migration code to a Java class named:  V_410_C.java, giving
that it has to execute the SQL scripts before the java code.

In order to go from a smaller version (4.0.0) to an upper one (4.3.0), we
have to run all of the migration routines from intermediate versions. That
is what we are already doing, but we do all of that manually.

Bottom line, I think we could simple use the convention
V__. to name upgrade routines.
That would facilitate us to use a framework to help us with that process.
Additionally, I believe that we should always assume that to go from a
smaller version to a higher one, we should run all of the scripts that
exist between them. What do you guys think of that?

After the bureaucracy, we can discuss tools. If we use that convention to
name migration (upgrade) routines, we can start thinking on tools to
support our migration process. I found two (2) promising ones: Liquibase
and Flywaydb (both seem to be under Apache license, but the first one has
an enterprise version?!). After reading the documentation and some 

[GitHub] cloudstack pull request: CLOUDSTACK-9091: Update testpath for para...

[sanju1010]

Github user sanju1010 commented on the pull request:

https://github.com/apache/cloudstack/pull/1130#issuecomment-167562545
  
This is one line change and looks good. I will get test results for this. 
LGTM!!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9041: Modifying template creat...

[sanju1010]

Github user sanju1010 commented on the pull request:

https://github.com/apache/cloudstack/pull/1041#issuecomment-167562620
  
I will post test results. LGTM !!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

use android keyboard on cloudstack console

[Alireza Eskandari]

HiDo you know any workaround to force android smartphones to popup keyborad 
when we tap on console of a VM?Regards

master marvin install problem

[Daan Hoogland]

People,

I tried to install marvin 4.8.0-SNAPSHOT this afternoon and found
mysql-connector-python missing from pypi. Is this expected? I tried last
week and everything was dandy.

-- 
Daan

Re: Let’s discuss database upgrades

[Wido den Hollander]

On 28-12-15 14:16, Rafael Weingärtner wrote:
> Hi all devs,
> First of all, sorry the long text, but I hope we can start a discussion
> here and improve that part of ACS.
> 
> A while ago I have faced the code that Apache CloudStack (ACS) uses to
> upgrade from a version to newer one and that did not seem to be a good way
> to execute our upgrades. Therefore, I decided to use some time to search
> for alternatives.
> 

I think we all saw that happen once or more :)

> I have read some material about versioning of scripts used to upgrade a
> database (DB) of a system and went through some frameworks that could help
> us.
> 
> In the literature of software engineering, it is firmly stated that we have
> to version DB scripts as we do with the source code of the application,
> using the baseline approach. Gladly, we were not that bad at this point, we
> already versioned our routines for DB upgrade (.sql and .java). Therefore,
> it seemed that we just did not have used a practical approach to help us
> during DB upgrades.
> 
> From my readings and looking at the ACS source code I raised the following
> requirement:
> •We should be able to write more than one routine to upgrade to a
> version; those routines can be written in Java and SQL. We might have more
> than a routine to be executed for each version and we should be able to
> define an order of execution. Additionally, to go to an upper version, we
> have to run all of the routines from smaller versions first, until we
> achieve the desired version.
> 
> We could also add another requirement that is the downgrade from a version,
> which we currently do not support. With that comes my first question for
> discussion:
> •Do we want/need a method to downgrade from a version to a previous one?
> 

I personally do not care. Usually people should create a backup PRIOR to
a upgrade. If that fails they can restore the backup.

> I found an explanation for not supporting downgrades, and I liked it:
> http://flywaydb.org/documentation/faq.html#downgrade
> 
> So, what I devised for us:
> First the bureaucracy part  - our migrations occur basically in three (3)
> steps, first we have a "prepare script", then a cleanup script and finally
> the migration per se that is written in Java, at least, that is what we can
> expect when reading the interface “com.cloud.upgrade.dao.DbUpgrade”.
> 
> Additionally, our scripts have the following naming convention:
> schema-to, which in IMHO may cause some
> confusion because at first sight we may think that from the same version we
> could have different paths to an upper version, which in practice is not
> happening. Instead of a to we could simply use
> V__., giving that, we have to
> execute all of the V_ scripts that are smaller than the version we
> want to upgrade.
> 
> To clarify what I am saying, I will use an example. Let’s say we have just
> installed ACS and ran the cloudstack-setup-database. That command will
> create a database schema in version 4.0.0. To upgrade that schema to
> version 4.3.0 (it is just an example, it could be any other version), ACS
> will use the following mapping:
> 
> _upgradeMap.put("4.0.0", new DbUpgrade[] {new Upgrade40to41(), new
> Upgrade410to420(), new Upgrade420to421(), new Upgrade421to430())
> 
> After loading the mapping, ACS will execute the scripts defined in each one
> of the Upgrade path classes and the migration code per se.
> 
> Now, let’s say we change the “.sql” scripts name to the pattern I
> mentioned, we would have the following scripts; those are the scripts found
> that aim to upgrade to versions between the interval 4.0.0 – 4.3.0
> (considering 4.3.0, since that is the goal version):
> 
> 
>- schema-40to410, can be named to:  V_410_A.sql
>- schema-40to410-cleanup, can be named to:  V_410_B.sql
>- schema-410to420, can be named to:  V_420_A.sql
>- schema-410to420-cleanup , can be named to:  V_420_b.sql
>- schema-420to421, can be named to:  V_421_A.sql
>- schema-421to430, can be named to:  V_430_A.sql
>- schema-421to430-cleanup, can be named to:  V_430_B.sql
> 
> 
> Additionally, all of the java code would have to follow the same
> convention. For instance, we have “com.cloud.upgrade.dao.Upgrade40to41”,
> which has some java code to migrate from 4.0.0 to 4.1.0. The idea is to
> extract that migration code to a Java class named:  V_410_C.java, giving
> that it has to execute the SQL scripts before the java code.
> 
> In order to go from a smaller version (4.0.0) to an upper one (4.3.0), we
> have to run all of the migration routines from intermediate versions. That
> is what we are already doing, but we do all of that manually.
> 
> Bottom line, I think we could simple use the convention
> V__. to name upgrade routines.
> That would facilitate us to use a framework to help us with that process.
> Additionally, I believe that we should always assume that to go from a
> smaller version to a higher one, we should run all of the scripts 

[GitHub] cloudstack pull request: CLOUDSTACK-9202 Bump ssh timeout for VR c...

[remibergsma]

GitHub user remibergsma opened a pull request:

https://github.com/apache/cloudstack/pull/1290

CLOUDSTACK-9202 Bump ssh timeout for VR commands

It seems the VR needs more time for some of its commands. Until we figured 
out the root cause, this allows the VRs to start again.

Error seen:
```
2015-12-28 14:35:18,201 ERROR [c.c.n.r.VirtualNetworkApplianceManagerImpl] 
(Work-Job-Executor-1:ctx-34ff7f80 job-39723/job-39726 ctx-d63de41b) Timed out 
in waiting SSH execution result
2015-12-28 14:35:18,201 WARN [c.c.n.r.VirtualNetworkApplianceManagerImpl] 
(Work-Job-Executor-1:ctx-34ff7f80 job-39723/job-39726 ctx-d63de41b) Command: 
com.cloud.agent.api.Command failed while starting virtua
l router
2015-12-28 14:35:18,201 INFO [c.c.v.VirtualMachineManagerImpl] 
(Work-Job-Executor-1:ctx-34ff7f80 job-39723/job-39726 ctx-d63de41b) The guru 
did not like the answers so stopping VM[DomainRouter|r-1534-VM]

.Answer":{"result":true,"wait":0}},{"com.cloud.agent.api.Answer":{"result":false,"details":"Timed
 out in waiting SSH execution result","wait":0}}] }
```



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/remibergsma/cloudstack bump-ssh-timeout

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1290.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1290


commit 1c5e899a2d727d8512a28da76a5e49c9d762d295
Author: Remi Bergsma 
Date:   2015-12-28T14:54:26Z

CLOUDSTACK-9202 Bump ssh timeout

It seems the VR needs more time for some of its commands. Until we figured
out the root cause, this allows the VRs to start again.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Add Health Check Command to NSX plugin

[miguelaferreira]

GitHub user miguelaferreira opened a pull request:

https://github.com/apache/cloudstack/pull/1292

Add Health Check Command to NSX plugin

The NSX plugin does not support the HeathCheckCommand. Instead it fakes a 
PingCommand as a call tot he control cluster status API.
However, we have seen in production that the management server will 
sometimes find the NSX controller to be behind on ping and that will trigger a 
HealthCheckCommand which will return with an unsupported command answer.
Once this happens the controller is put into Alert state and will not 
recover until the management sever is restarted.

In addition, during the investigation, there will be a null pointer 
exception due tot he fact that the NSX controllers do not live in a pod.

This PR tries to address those two issues.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/miguelaferreira/cloudstack nsx-heath-check

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1292.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1292


commit 1cc610f617bfa99663701e81216f76258eafb54e
Author: Miguel Ferreira 
Date:   2015-12-28T09:37:33Z

Prevent NullPointerException when host does not belong to a pod

NSX controllers are hosts that do not belong in a Pod.
When investigators kick-in an exception is thrown because of the
missing pod foreign key.

commit 13f1ed7f147f67974102525c1cd9bfc6503e78eb
Author: Miguel Ferreira 
Date:   2015-12-28T10:07:10Z

Fix log message that refers to agent, not host

commit 47a23c22c1d3bd6a195b0a752cfc9ad5f2b78f22
Author: Miguel Ferreira 
Date:   2015-12-28T13:27:27Z

Implement CheckHealthCommand for NSX controllers




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: build-master-slowbuild #2848

[jenkins]

See 

--
[...truncated 28723 lines...]
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud ---
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:instrument (default-cli) @ 
cloud-quickcloud ---
[WARNING] No files to instrument.
[INFO] NOT adding cobertura ser file to attached artifacts list.
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-quickcloud ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ 
cloud-quickcloud ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud ---
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Apache CloudStack Developer Tools - Checkstyle Configuration  SUCCESS 
[2.106s]
[INFO] Apache CloudStack . SUCCESS [2.324s]
[INFO] Apache CloudStack Maven Conventions Parent  SUCCESS [0.764s]
[INFO] Apache CloudStack Framework - Managed Context . SUCCESS [18.803s]
[INFO] Apache CloudStack Utils ... SUCCESS [1:29.541s]
[INFO] Apache CloudStack Framework ... SUCCESS [0.226s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [54.778s]
[INFO] Apache CloudStack Framework - Configuration ... SUCCESS [28.322s]
[INFO] Apache CloudStack API . SUCCESS [1:58.441s]
[INFO] Apache CloudStack Framework - REST  SUCCESS [16.793s]
[INFO] Apache CloudStack Framework - IPC . SUCCESS [30.783s]
[INFO] Apache CloudStack Cloud Engine  SUCCESS [0.096s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [29.055s]
[INFO] Apache CloudStack Framework - Security  SUCCESS [25.726s]
[INFO] Apache CloudStack Core  SUCCESS [1:21.286s]
[INFO] Apache CloudStack Agents .. SUCCESS [36.536s]
[INFO] Apache CloudStack Framework - Clustering .. SUCCESS [36.665s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [14.637s]
[INFO] Apache CloudStack Cloud Engine Schema Component ... SUCCESS [2:08.342s]
[INFO] Apache CloudStack Framework - Jobs  SUCCESS [40.900s]
[INFO] Apache CloudStack Cloud Engine Internal Components API  SUCCESS [25.575s]
[INFO] Apache CloudStack Server .. SUCCESS [4:11.946s]
[INFO] Apache CloudStack Framework - Quota ... SUCCESS [37.633s]
[INFO] Apache CloudStack Usage Server  SUCCESS [44.001s]
[INFO] Apache CloudStack Cloud Engine Orchestration Component  SUCCESS 
[1:21.869s]
[INFO] Apache CloudStack Cloud Services .. SUCCESS [0.078s]
[INFO] Apache CloudStack Secondary Storage ... SUCCESS [0.429s]
[INFO] Apache CloudStack Secondary Storage Service ... SUCCESS [54.216s]
[INFO] Apache CloudStack Engine Storage Component  SUCCESS [48.307s]
[INFO] Apache CloudStack Engine Storage Volume Component . SUCCESS [29.553s]
[INFO] Apache CloudStack Engine Storage Image Component .. SUCCESS [26.204s]
[INFO] Apache CloudStack Engine Storage Data Motion Component  SUCCESS [25.842s]
[INFO] Apache CloudStack Engine Storage Cache Component .. SUCCESS [20.830s]
[INFO] Apache CloudStack Engine Storage Snapshot Component  SUCCESS [35.006s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [12.742s]
[INFO] Apache CloudStack Cloud Engine Service  SUCCESS [7.725s]
[INFO] Apache CloudStack Plugin POM .. SUCCESS [0.959s]
[INFO] Apache CloudStack Plugin - API Rate Limit . SUCCESS [26.533s]
[INFO] Apache CloudStack Plugin - Storage Volume default provider  SUCCESS 
[24.125s]
[INFO] Apache CloudStack Plugin - Storage Volume SolidFire Provider  SUCCESS 
[35.932s]
[INFO] Apache CloudStack Plugin - API SolidFire .. SUCCESS [17.849s]
[INFO] Apache CloudStack Plugin - API Discovery .. SUCCESS [23.335s]
[INFO] Apache CloudStack Plugin - ACL Static Role Based .. SUCCESS [15.993s]
[INFO] Apache CloudStack Plugin - Host Anti-Affinity Processor  SUCCESS 
[17.315s]
[INFO] Apache 

[GitHub] cloudstack pull request: Add Health Check Command to NSX plugin

[miguelaferreira]

Github user miguelaferreira commented on the pull request:

https://github.com/apache/cloudstack/pull/1293#issuecomment-167586479
  
I've built the entire project running the existing and additional unit 
tests. I've also deployed this jar into our beta environment to check that it 
wound't break it. I don't really know how to test this further, since I can't 
trigger ACS to consider that the NSX controller is behind on ping (because the 
ping map is held in memory, not in the DB).

I will run this change in our beta environment (which has production like 
load) for a few days and will monitor the logs.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8818: Use MySQL native connect...

[wido]

Github user wido closed the pull request at:

https://github.com/apache/cloudstack/pull/1054


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9202 Bump ssh timeout for VR c...

[remibergsma]

GitHub user remibergsma opened a pull request:

https://github.com/apache/cloudstack/pull/1291

CLOUDSTACK-9202 Bump ssh timeout for VR commands

It seems the VR needs more time for some of its commands. Until we figured 
out the root cause, this allows the VRs to start again.

Error seen:
```
2015-12-28 14:35:18,201 ERROR [c.c.n.r.VirtualNetworkApplianceManagerImpl] 
(Work-Job-Executor-1:ctx-34ff7f80 job-39723/job-39726 ctx-d63de41b) Timed out 
in waiting SSH execution result
2015-12-28 14:35:18,201 WARN [c.c.n.r.VirtualNetworkApplianceManagerImpl] 
(Work-Job-Executor-1:ctx-34ff7f80 job-39723/job-39726 ctx-d63de41b) Command: 
com.cloud.agent.api.Command failed while starting virtua
l router
2015-12-28 14:35:18,201 INFO [c.c.v.VirtualMachineManagerImpl] 
(Work-Job-Executor-1:ctx-34ff7f80 job-39723/job-39726 ctx-d63de41b) The guru 
did not like the answers so stopping VM[DomainRouter|r-1534-VM]

.Answer":{"result":true,"wait":0}},{"com.cloud.agent.api.Answer":{"result":false,"details":"Timed
 out in waiting SSH execution result","wait":0}}] }
```


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/remibergsma/cloudstack bump-ssh-timeout

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1291.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1291


commit 1c5e899a2d727d8512a28da76a5e49c9d762d295
Author: Remi Bergsma 
Date:   2015-12-28T14:54:26Z

CLOUDSTACK-9202 Bump ssh timeout

It seems the VR needs more time for some of its commands. Until we figured
out the root cause, this allows the VRs to start again.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Add Health Check Command to NSX plugin

[miguelaferreira]

Github user miguelaferreira commented on the pull request:

https://github.com/apache/cloudstack/pull/1292#issuecomment-167586010
  
closing since this should not target master


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Add Health Check Command to NSX plugin

[miguelaferreira]

Github user miguelaferreira closed the pull request at:

https://github.com/apache/cloudstack/pull/1292


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9202 Bump ssh timeout for VR c...

[remibergsma]

Github user remibergsma closed the pull request at:

https://github.com/apache/cloudstack/pull/1290


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Add Health Check Command to NSX plugin

[miguelaferreira]

GitHub user miguelaferreira opened a pull request:

https://github.com/apache/cloudstack/pull/1293

Add Health Check Command to NSX plugin

The NSX plugin does not support the HeathCheckCommand. Instead it fakes a 
PingCommand as a call tot he control cluster status API.
However, we have seen in production that the management server will 
sometimes find the NSX controller to be behind on ping and that will trigger a 
HealthCheckCommand which will return with an unsupported command answer.
Once this happens the controller is put into Alert state and will not 
recover until the management sever is restarted.

In addition, during the investigation, there will be a null pointer 
exception due tot he fact that the NSX controllers do not live in a pod.

This PR tries to address those two issues.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/miguelaferreira/cloudstack nsx-heath-check

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1293.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1293


commit 1cc610f617bfa99663701e81216f76258eafb54e
Author: Miguel Ferreira 
Date:   2015-12-28T09:37:33Z

Prevent NullPointerException when host does not belong to a pod

NSX controllers are hosts that do not belong in a Pod.
When investigators kick-in an exception is thrown because of the
missing pod foreign key.

commit 13f1ed7f147f67974102525c1cd9bfc6503e78eb
Author: Miguel Ferreira 
Date:   2015-12-28T10:07:10Z

Fix log message that refers to agent, not host

commit 47a23c22c1d3bd6a195b0a752cfc9ad5f2b78f22
Author: Miguel Ferreira 
Date:   2015-12-28T13:27:27Z

Implement CheckHealthCommand for NSX controllers




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Let’s discuss database upgrades

[Rafael Weingärtner]

Thanks for your contribution Wido,
I have not seen Rohit’s email; I will take a look at it.

About database schema changes happening only in X.Y, I also agree with you
(that is a convention we all could agree on, and such as conding and
release procedures we could have a wiki page for that). However, I think we
still might have scripts in versions X.Y.Z  to add data to a table such as
“guest_os_hypervisor”.

The point to manage such scripts is that, if we are in version such as
4.7.0 and a new script emerges in version 4.5.3, we would have to decide to
run or not to run it. I would rather not run them, since if they add
something to the code base; those changes should also be applied into
master and as a consequence it will be available in a future update.

On Mon, Dec 28, 2015 at 12:50 PM, Wido den Hollander  wrote:

>
>
> On 28-12-15 14:16, Rafael Weingärtner wrote:
> > Hi all devs,
> > First of all, sorry the long text, but I hope we can start a discussion
> > here and improve that part of ACS.
> >
> > A while ago I have faced the code that Apache CloudStack (ACS) uses to
> > upgrade from a version to newer one and that did not seem to be a good
> way
> > to execute our upgrades. Therefore, I decided to use some time to search
> > for alternatives.
> >
>
> I think we all saw that happen once or more :)
>
> > I have read some material about versioning of scripts used to upgrade a
> > database (DB) of a system and went through some frameworks that could
> help
> > us.
> >
> > In the literature of software engineering, it is firmly stated that we
> have
> > to version DB scripts as we do with the source code of the application,
> > using the baseline approach. Gladly, we were not that bad at this point,
> we
> > already versioned our routines for DB upgrade (.sql and .java).
> Therefore,
> > it seemed that we just did not have used a practical approach to help us
> > during DB upgrades.
> >
> > From my readings and looking at the ACS source code I raised the
> following
> > requirement:
> > •We should be able to write more than one routine to upgrade to a
> > version; those routines can be written in Java and SQL. We might have
> more
> > than a routine to be executed for each version and we should be able to
> > define an order of execution. Additionally, to go to an upper version, we
> > have to run all of the routines from smaller versions first, until we
> > achieve the desired version.
> >
> > We could also add another requirement that is the downgrade from a
> version,
> > which we currently do not support. With that comes my first question for
> > discussion:
> > •Do we want/need a method to downgrade from a version to a previous
> one?
> >
>
> I personally do not care. Usually people should create a backup PRIOR to
> a upgrade. If that fails they can restore the backup.
>
> > I found an explanation for not supporting downgrades, and I liked it:
> > http://flywaydb.org/documentation/faq.html#downgrade
> >
> > So, what I devised for us:
> > First the bureaucracy part  - our migrations occur basically in three (3)
> > steps, first we have a "prepare script", then a cleanup script and
> finally
> > the migration per se that is written in Java, at least, that is what we
> can
> > expect when reading the interface “com.cloud.upgrade.dao.DbUpgrade”.
> >
> > Additionally, our scripts have the following naming convention:
> > schema-to, which in IMHO may cause some
> > confusion because at first sight we may think that from the same version
> we
> > could have different paths to an upper version, which in practice is not
> > happening. Instead of a to we could simply use
> > V__., giving that, we have to
> > execute all of the V_ scripts that are smaller than the version
> we
> > want to upgrade.
> >
> > To clarify what I am saying, I will use an example. Let’s say we have
> just
> > installed ACS and ran the cloudstack-setup-database. That command will
> > create a database schema in version 4.0.0. To upgrade that schema to
> > version 4.3.0 (it is just an example, it could be any other version), ACS
> > will use the following mapping:
> >
> > _upgradeMap.put("4.0.0", new DbUpgrade[] {new Upgrade40to41(), new
> > Upgrade410to420(), new Upgrade420to421(), new Upgrade421to430())
> >
> > After loading the mapping, ACS will execute the scripts defined in each
> one
> > of the Upgrade path classes and the migration code per se.
> >
> > Now, let’s say we change the “.sql” scripts name to the pattern I
> > mentioned, we would have the following scripts; those are the scripts
> found
> > that aim to upgrade to versions between the interval 4.0.0 – 4.3.0
> > (considering 4.3.0, since that is the goal version):
> >
> >
> >- schema-40to410, can be named to:  V_410_A.sql
> >- schema-40to410-cleanup, can be named to:  V_410_B.sql
> >- schema-410to420, can be named to:  V_420_A.sql
> >- schema-410to420-cleanup , can be named to:  V_420_b.sql
> >- schema-420to421, can be named 

[GitHub] cloudstack pull request: CLOUDSTACK-8308:Adding automation testcas...

[sanju1010]

Github user sanju1010 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/384#discussion_r48476636
  
--- Diff: test/integration/testpaths/testpath_delta_snapshots.py ---
@@ -0,0 +1,539 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+""" Test cases for Delta Snapshots Test Path
+"""
+
+from nose.plugins.attrib import attr
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.lib.utils import (cleanup_resources,
+  validateList,
+  is_snapshot_on_nfs)
+from marvin.lib.base import (Account,
+ ServiceOffering,
+ Template,
+ VirtualMachine,
+ Volume,
+ Configurations,
+ Snapshot
+ )
+from marvin.lib.common import (get_domain,
+   get_zone,
+   get_template,
+   list_volumes,
+   createChecksum,
+   compareChecksum
+   )
+from marvin.sshClient import SshClient
+from marvin.codes import (PASS, FAIL, BACKED_UP, ROOT, DATA)
+import time
+
+
+def checkIntegrityOfSnapshot(
+self, snapshotsToRestore, checksumToCompare, disk_type=ROOT):
+"""
+Check integrity of snapshot created of ROOT or DATA Disk:
+
+If ROOT Disk: Deploy a Vm from a template created from the snapshot
+  and checking the contents of the ROOT disk.
+If DATA Disk: Users can create a volume from the snapshot.
+  The volume can then be mounted to a VM and files
+  recovered as needed.
+
+Inputs:
+1. snapshotsToRestore: Snapshots whose integrity is
+   to be checked.
+
+2. checksumToCompare:  The contents of ROOT Disk to be compared.
+
+3. disk_type:  The type of disk - ROOT or DATA Disk
+   of which snapshot was created.
+
+"""
+if disk_type == ROOT:
+# Create template from snapshot
+template_from_snapshot = Template.create_from_snapshot(
+self.apiclient,
+snapshotsToRestore,
+self.testdata["template_2"])
+
+self.assertNotEqual(
+template_from_snapshot,
+None,
+"Check if result exists in list item call"
+)
+
+# Deploy VM
+vm_from_temp = VirtualMachine.create(
+self.apiclient,
+self.testdata["small"],
+templateid=template_from_snapshot.id,
+accountid=self.account.name,
+domainid=self.account.domainid,
+serviceofferingid=self.service_offering.id,
+zoneid=self.zone.id,
+mode=self.zone.networktype
+)
+
+self.assertNotEqual(
+vm_from_temp,
+None,
+"Check if result exists in list item call"
+)
+
+# Verify contents of ROOT disk match with snapshot
+
+compareChecksum(
+self.apiclient,
+service=self.testdata,
+original_checksum=checksumToCompare,
+disk_type="rootdiskdevice",
+virt_machine=vm_from_temp
+)
+
+vm_from_temp.delete(self.apiclient)
+template_from_snapshot.delete(self.apiclient)
+else:
+volumeFormSnap = Volume.create_from_snapshot(
+self.apiclient,
+snapshotsToRestore.id,
+self.testdata["volume"],
+account=self.account.name,
+domainid=self.account.domainid,
+zoneid=self.zone.id
+ 

[GitHub] cloudstack pull request: CLOUDSTACK-8308:Adding automation testcas...

[sanju1010]

Github user sanju1010 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/384#discussion_r48476586
  
--- Diff: test/integration/testpaths/testpath_delta_snapshots.py ---
@@ -0,0 +1,539 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+""" Test cases for Delta Snapshots Test Path
+"""
+
+from nose.plugins.attrib import attr
+from marvin.cloudstackTestCase import cloudstackTestCase
+from marvin.lib.utils import (cleanup_resources,
+  validateList,
+  is_snapshot_on_nfs)
+from marvin.lib.base import (Account,
+ ServiceOffering,
+ Template,
+ VirtualMachine,
+ Volume,
+ Configurations,
+ Snapshot
+ )
+from marvin.lib.common import (get_domain,
+   get_zone,
+   get_template,
+   list_volumes,
+   createChecksum,
+   compareChecksum
+   )
+from marvin.sshClient import SshClient
+from marvin.codes import (PASS, FAIL, BACKED_UP, ROOT, DATA)
+import time
+
+
+def checkIntegrityOfSnapshot(
+self, snapshotsToRestore, checksumToCompare, disk_type=ROOT):
+"""
+Check integrity of snapshot created of ROOT or DATA Disk:
+
+If ROOT Disk: Deploy a Vm from a template created from the snapshot
+  and checking the contents of the ROOT disk.
+If DATA Disk: Users can create a volume from the snapshot.
+  The volume can then be mounted to a VM and files
+  recovered as needed.
+
+Inputs:
+1. snapshotsToRestore: Snapshots whose integrity is
+   to be checked.
+
+2. checksumToCompare:  The contents of ROOT Disk to be compared.
+
+3. disk_type:  The type of disk - ROOT or DATA Disk
+   of which snapshot was created.
+
+"""
+if disk_type == ROOT:
+# Create template from snapshot
+template_from_snapshot = Template.create_from_snapshot(
+self.apiclient,
+snapshotsToRestore,
+self.testdata["template_2"])
+
+self.assertNotEqual(
+template_from_snapshot,
+None,
+"Check if result exists in list item call"
+)
+
+# Deploy VM
+vm_from_temp = VirtualMachine.create(
+self.apiclient,
+self.testdata["small"],
+templateid=template_from_snapshot.id,
+accountid=self.account.name,
+domainid=self.account.domainid,
+serviceofferingid=self.service_offering.id,
+zoneid=self.zone.id,
+mode=self.zone.networktype
+)
+
+self.assertNotEqual(
+vm_from_temp,
+None,
+"Check if result exists in list item call"
+)
+
+# Verify contents of ROOT disk match with snapshot
+
+compareChecksum(
+self.apiclient,
+service=self.testdata,
+original_checksum=checksumToCompare,
+disk_type="rootdiskdevice",
+virt_machine=vm_from_temp
+)
+
+vm_from_temp.delete(self.apiclient)
+template_from_snapshot.delete(self.apiclient)
+else:
+volumeFormSnap = Volume.create_from_snapshot(
+self.apiclient,
+snapshotsToRestore.id,
+self.testdata["volume"],
+account=self.account.name,
+domainid=self.account.domainid,
+zoneid=self.zone.id
+ 

[GitHub] cloudstack pull request: CLOUDSTACK-8818: Use MySQL native connect...

[wido]

GitHub user wido reopened a pull request:

https://github.com/apache/cloudstack/pull/1054

CLOUDSTACK-8818: Use MySQL native connector with Python

MySQLdb has been deprecated and is also not supported in Python 3.

mysql.connector is a connector written in Python which talks the
native MySQL protocol without any external code.

https://dev.mysql.com/doc/connector-python/en/

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/wido/cloudstack CLOUDSTACK-8818

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1054.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1054


commit 4a90b2e1124778c624a71e43bd0c3bc74733d096
Author: Wido den Hollander 
Date:   2015-11-10T08:04:48Z

CLOUDSTACK-8818: Use MySQL native connector with Python

MySQLdb has been deprecated and is also not supported in Python 3.

mysql.connector is a connector written in Python which talks the
native MySQL protocol without any external code.

https://dev.mysql.com/doc/connector-python/en/




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Map LDAP group to Cloudstack account

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1285#issuecomment-167585886
  
LGTM, works as expected. 

![screen shot 2015-12-28 at 16 08 
34](https://cloud.githubusercontent.com/assets/1630096/12020487/55205136-ad7d-11e5-9c3d-ffe334270c4e.png)

@koushik-das I see your point and we can discuss. Although we don't break 
any of the functional requirements listed on the link you shared.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9181 Prevent syntax error in c...

[remibergsma]

Github user remibergsma closed the pull request at:

https://github.com/apache/cloudstack/pull/1295


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9181 Prevent syntax error in c...

[remibergsma]

Github user remibergsma closed the pull request at:

https://github.com/apache/cloudstack/pull/1249


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9181 Prevent syntax error in c...

[remibergsma]

Github user remibergsma commented on the pull request:

https://github.com/apache/cloudstack/pull/1249#issuecomment-167595996
  
Created PR against `4.7`, see #1296



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Let’s discuss database upgrades

[Rohit Yadav]

Hi Rafael and Wido,

Thanks for starting a conversation in this regard, I could not pursue the Chimp 
tool due to other $dayjob work though it’s good to see some discussion has 
started again. Hope we’ll solve this in 2016.

In my opinion, we will need to first separate the database init/migration 
tooling away from mgmt server (right now the mgmt server does db migrations 
when it starts and there is a code/db version mismatch) and secondly make sure 
that we’re using the same code/tool to deploy database (right now, users use 
the cloudstack-setup-database python tool while developer use the maven/java 
DatabaseCreator activated by the -Ddeploydb flag).

After we’ve addressed these two issues we can look into how we can support 
minor releases workflow (or decide to do something else, like not support .Z 
releases like Wido mentioned), and see if we can or want to use any existing 
migration tool or write a wrapper tool “chimp” that uses existing tools (some 
of those are mentioned in the Chimp FS like flywaydb etc). For allowing users 
to go back and forth from a db schema/version, we’ll also need some new DB 
migration conventions/versioning/rules/static-checking, and how developer need 
to write such paths (forward and reverse) etc.

The best approach I figured at the time was to decide that we’ll use the 
previous db upgrade path mechanism till a certain CloudStack version (say 
4.8.0) and after that we’ll use the new approach or tooling to 
upgrade/downgrade DB schemas (thereby retiring away from the old DB upgrade 
path mess).

>

[ShapeBlue]
Rohit Yadav
Software Architect  ,   ShapeBlue


d:   | s: +44 203 603 0540  |  
m:  +91 8826230892

e:  rohit.ya...@shapeblue.com | t: 
   |  w:  
www.shapeblue.com

a:  53 Chandos Place, Covent Garden London WC2N 4HS UK


[cid:image0eb4ef.png@ffdf8a7b.4eae37bd]


Shape Blue Ltd is a company incorporated in England & Wales. ShapeBlue Services 
India LLP is a company incorporated in India and is operated under license from 
Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in 
Brasil and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd 
is a company registered by The Republic of South Africa and is traded under 
license from Shape Blue Ltd. ShapeBlue is a registered trademark.
This email and any attachments to it may be confidential and are intended 
solely for the use of the individual to whom it is addressed. Any views or 
opinions expressed are solely those of the author and do not necessarily 
represent those of Shape Blue Ltd or related companies. If you are not the 
intended recipient of this email, you must neither take any action based upon 
its contents, nor copy or show it to anyone. Please contact the sender if you 
believe you have received this email in error.




On 28-Dec-2015, at 9:10 PM, Wido den Hollander  wrote:
>
>
>
> On 28-12-15 16:21, Rafael Weingärtner wrote:
>> Thanks for your contribution Wido,
>> I have not seen Rohit’s email; I will take a look at it.
>>
>
> Ok, he has a FS here:
> https://cwiki.apache.org/confluence/display/CLOUDSTACK/CloudStack+Chimp
>
>> About database schema changes happening only in X.Y, I also agree with you
>> (that is a convention we all could agree on, and such as conding and
>> release procedures we could have a wiki page for that). However, I think we
>> still might have scripts in versions X.Y.Z to add data to a table such as
>> “guest_os_hypervisor”.
>>
>
> Yes, that is true. A bugfix could be a addition into the database, but
> we have to prevent it as much as possible.
>
>> The point to manage such scripts is that, if we are in version such as
>> 4.7.0 and a new script emerges in version 4.5.3, we would have to decide to
>> run or not to run it. I would rather not run them, since if they add
>> something to the code base; those changes should also be applied into
>> master and as a consequence it will be available in a future update.
>>
>
> I understand, but this is where our release cycle becomes the problem.
> It is because we release a X.Y.Z release we run into these kind of problems.
>
> If we as a project simple do not release the .Z releases we would be
> fine as well ;)
>
> You can try to complicate things with technical things, or if we release
> every two / three weeks we don't run into these kind of situations :)
>
> We might even cut the database version loose from the code version.
>
> Database version is simple 100, 101, 102, 103, 104, 105. And a code
> version requires a certain version of the database.
>
> Wido
>
>> On Mon, Dec 28, 2015 at 12:50 PM, Wido den Hollander  wrote:
>>
>>>
>>>
>>> On 28-12-15 14:16, Rafael Weingärtner wrote:
 Hi all devs,
 First of all, sorry the long text, but I hope we can start 

[GitHub] cloudstack pull request: Implement a NSX API request execution cou...

[miguelaferreira]

GitHub user miguelaferreira opened a pull request:

https://github.com/apache/cloudstack/pull/1294

Implement a NSX API request execution counter per thread

The NSX plugin has a execution counter to prevent infinite recursion (and 
as a result a stack overflow exception). However, the thread safeness of this 
counter are not as desired. The counter was implemented with an AtomicInteger 
which make it safe for multiple threads to update and read it. The desired 
property would be to have a counter per thread.

This PR addresses that issue.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/miguelaferreira/cloudstack 
nsx-execution-counter-per-thread

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1294.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1294


commit 40501518b7fbb71fc138a12fdf2d31a56d822619
Author: Miguel Ferreira 
Date:   2015-12-17T15:29:59Z

Add test to check that each thread has it's own execution counter

commit 7f332d760bc824664f41133eeb694fae0f57f5f3
Author: Miguel Ferreira 
Date:   2015-12-17T18:47:08Z

Fix execution counter to support separate counts per thread




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9181 Prevent syntax error in c...

[remibergsma]

GitHub user remibergsma opened a pull request:

https://github.com/apache/cloudstack/pull/1295

CLOUDSTACK-9181 Prevent syntax error in checkrouter.sh

Added quotes to prevent syntax errors in weird situations.

Error seen in mgt server:
```
2015-12-15 14:30:32,371 DEBUG [c.c.a.m.AgentManagerImpl] 
(RedundantRouterStatusMonitor-7:ctx-0dd8ef3e) Details from executing class 
com.cloud.agent.api.CheckRouterCommand: Status: UNKNOWN
/opt/cloud/bin/checkrouter.sh: line 28: [: =: unary operator expected
/opt/cloud/bin/checkrouter.sh: line 31: [: =: unary operator expected
```
Cause:
```
root@r-1191-VM:/opt/cloud/bin# ./checkrouter.sh
./checkrouter.sh: line 28: [: =: unary operator expected
./checkrouter.sh: line 31: [: =: unary operator expected
Status: UNKNOWN
```

Somehow a nic was missing.

After fix the script can handle this:

```
root@r-1191-VM:/opt/cloud/bin# ./checkrouter.sh
Status: UNKNOWN
```

The other states are also reported fine:
```
root@r-1191-VM:/opt/cloud/bin# ./checkrouter.sh
Status: MASTER
```

```
root@r-1192-VM:/opt/cloud/bin# ./checkrouter.sh
Status: BACKUP
```

While at it, I also removed the INTERFACES variable/constant as it was only 
used once and hardcoded the second time. Now both are hardcoded and easier to 
read.

This is the same as PR #1249 except it is against `4.7`.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/remibergsma/cloudstack 
fix-checkrouter-script47

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1295.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1295


commit 525949e027d89a5c8ef0d1b7012446bb652be659
Author: Remi Bergsma 
Date:   2015-12-16T10:27:26Z

CLOUDSTACK-9181 Prevent syntax error in checkrouter.sh

commit 8fb677027dc48d034fa9440b125c6bae084266d4
Author: Remi Bergsma 
Date:   2015-12-16T13:45:57Z

make both check lines consistent

No need to make a variable, use it on one place and hardcode it on another.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9181 Prevent syntax error in c...

[remibergsma]

GitHub user remibergsma opened a pull request:

https://github.com/apache/cloudstack/pull/1296

CLOUDSTACK-9181 Prevent syntax error in checkrouter.sh

Added quotes to prevent syntax errors in weird situations.

Error seen in mgt server:
```
2015-12-15 14:30:32,371 DEBUG [c.c.a.m.AgentManagerImpl] 
(RedundantRouterStatusMonitor-7:ctx-0dd8ef3e) Details from executing class 
com.cloud.agent.api.CheckRouterCommand: Status: UNKNOWN
/opt/cloud/bin/checkrouter.sh: line 28: [: =: unary operator expected
/opt/cloud/bin/checkrouter.sh: line 31: [: =: unary operator expected
```
Cause:
```
root@r-1191-VM:/opt/cloud/bin# ./checkrouter.sh
./checkrouter.sh: line 28: [: =: unary operator expected
./checkrouter.sh: line 31: [: =: unary operator expected
Status: UNKNOWN
```

Somehow a nic was missing.

After fix the script can handle this:

```
root@r-1191-VM:/opt/cloud/bin# ./checkrouter.sh
Status: UNKNOWN
```

The other states are also reported fine:
```
root@r-1191-VM:/opt/cloud/bin# ./checkrouter.sh
Status: MASTER
```

```
root@r-1192-VM:/opt/cloud/bin# ./checkrouter.sh
Status: BACKUP
```

While at it, I also removed the INTERFACES variable/constant as it was only 
used once and hardcoded the second time. Now both are hardcoded and easier to 
read.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/remibergsma/cloudstack 
fix-checkrouter-script47

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1296.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1296


commit 525949e027d89a5c8ef0d1b7012446bb652be659
Author: Remi Bergsma 
Date:   2015-12-16T10:27:26Z

CLOUDSTACK-9181 Prevent syntax error in checkrouter.sh

commit 8fb677027dc48d034fa9440b125c6bae084266d4
Author: Remi Bergsma 
Date:   2015-12-16T13:45:57Z

make both check lines consistent

No need to make a variable, use it on one place and hardcode it on another.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: build-master-slowbuild #2849

[jenkins]

See 

--
[...truncated 28723 lines...]
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud ---
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:instrument (default-cli) @ 
cloud-quickcloud ---
[WARNING] No files to instrument.
[INFO] NOT adding cobertura ser file to attached artifacts list.
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-quickcloud ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ 
cloud-quickcloud ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud ---
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Apache CloudStack Developer Tools - Checkstyle Configuration  SUCCESS 
[1.753s]
[INFO] Apache CloudStack . SUCCESS [2.076s]
[INFO] Apache CloudStack Maven Conventions Parent  SUCCESS [0.780s]
[INFO] Apache CloudStack Framework - Managed Context . SUCCESS [19.235s]
[INFO] Apache CloudStack Utils ... SUCCESS [1:28.662s]
[INFO] Apache CloudStack Framework ... SUCCESS [0.103s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [53.440s]
[INFO] Apache CloudStack Framework - Configuration ... SUCCESS [26.830s]
[INFO] Apache CloudStack API . SUCCESS [1:49.783s]
[INFO] Apache CloudStack Framework - REST  SUCCESS [16.737s]
[INFO] Apache CloudStack Framework - IPC . SUCCESS [29.352s]
[INFO] Apache CloudStack Cloud Engine  SUCCESS [0.084s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [28.652s]
[INFO] Apache CloudStack Framework - Security  SUCCESS [24.567s]
[INFO] Apache CloudStack Core  SUCCESS [1:21.269s]
[INFO] Apache CloudStack Agents .. SUCCESS [36.083s]
[INFO] Apache CloudStack Framework - Clustering .. SUCCESS [36.290s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [14.260s]
[INFO] Apache CloudStack Cloud Engine Schema Component ... SUCCESS [2:07.800s]
[INFO] Apache CloudStack Framework - Jobs  SUCCESS [40.692s]
[INFO] Apache CloudStack Cloud Engine Internal Components API  SUCCESS [25.168s]
[INFO] Apache CloudStack Server .. SUCCESS [4:13.807s]
[INFO] Apache CloudStack Framework - Quota ... SUCCESS [36.906s]
[INFO] Apache CloudStack Usage Server  SUCCESS [44.211s]
[INFO] Apache CloudStack Cloud Engine Orchestration Component  SUCCESS 
[1:22.704s]
[INFO] Apache CloudStack Cloud Services .. SUCCESS [0.079s]
[INFO] Apache CloudStack Secondary Storage ... SUCCESS [0.442s]
[INFO] Apache CloudStack Secondary Storage Service ... SUCCESS [55.316s]
[INFO] Apache CloudStack Engine Storage Component  SUCCESS [47.854s]
[INFO] Apache CloudStack Engine Storage Volume Component . SUCCESS [29.441s]
[INFO] Apache CloudStack Engine Storage Image Component .. SUCCESS [26.567s]
[INFO] Apache CloudStack Engine Storage Data Motion Component  SUCCESS [30.934s]
[INFO] Apache CloudStack Engine Storage Cache Component .. SUCCESS [21.050s]
[INFO] Apache CloudStack Engine Storage Snapshot Component  SUCCESS [35.368s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [12.836s]
[INFO] Apache CloudStack Cloud Engine Service  SUCCESS [7.575s]
[INFO] Apache CloudStack Plugin POM .. SUCCESS [0.974s]
[INFO] Apache CloudStack Plugin - API Rate Limit . SUCCESS [26.699s]
[INFO] Apache CloudStack Plugin - Storage Volume default provider  SUCCESS 
[23.530s]
[INFO] Apache CloudStack Plugin - Storage Volume SolidFire Provider  SUCCESS 
[37.283s]
[INFO] Apache CloudStack Plugin - API SolidFire .. SUCCESS [17.635s]
[INFO] Apache CloudStack Plugin - API Discovery .. SUCCESS [23.413s]
[INFO] Apache CloudStack Plugin - ACL Static Role Based .. SUCCESS [17.090s]
[INFO] Apache CloudStack Plugin - Host Anti-Affinity Processor  SUCCESS 
[16.759s]
[INFO] Apache 

[GitHub] cloudstack pull request: Map LDAP group to Cloudstack account

[borisroman]

Github user borisroman commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1285#discussion_r48488856
  
--- Diff: 
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapAuthenticator.java
 ---
@@ -111,19 +114,27 @@ public LdapAuthenticator(final LdapManager 
ldapManager, final UserAccountDao use
 return new Pair(result, 
action);
 }
 
-private void enableUserInCloudStack(UserAccount user) {
-if(user != null && 
(user.getState().equalsIgnoreCase(Account.State.disabled.toString( {
+private void enableUserInCloudStack(final UserAccount user) {
+if (user != null && 
user.getState().equalsIgnoreCase(Account.State.disabled.toString())) {
 _accountManager.enableUser(user.getId());
 }
 }
 
-private void createCloudStackUserAccount(LdapUser user, long domainId, 
short accountType) {
-String username = user.getUsername();
-_accountManager.createUserAccount(username, "", 
user.getFirstname(), user.getLastname(), user.getEmail(), null, username, 
accountType, domainId, username, null,
-  UUID.randomUUID().toString(), 
UUID.randomUUID().toString(), User.Source.LDAP);
+private void createCloudStackUserAccount(final LdapUser user, final 
long domainId, final short accountType) {
+final String username = user.getUsername();
+final Account account = 
_accountManager.getActiveAccountByName(ldapGroupName, domainId);
+if (account == null) {
+s_logger.info("Account (" + ldapGroupName + ") for LDAP group 
does not exist. Creating account and user (" + username + ").");
+_accountManager.createUserAccount(username, "", 
user.getFirstname(), user.getLastname(), user.getEmail(), null, ldapGroupName, 
accountType, domainId,
+username, null, UUID.randomUUID().toString(), 
UUID.randomUUID().toString(), User.Source.LDAP);
+} else {
+s_logger.debug("Account (" + ldapGroupName + ") for LDAP group 
already exists not exist. Creating user (" + username + ").");
--- End diff --

@miguelaferreira The following seems a bit strange "for LDAP group already 
exists not exist"... Maybe something like this; "for LDAP group already exists, 
but the user doesn't exist"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Let’s discuss database upgrades

[Wido den Hollander]

On 28-12-15 16:21, Rafael Weingärtner wrote:
> Thanks for your contribution Wido,
> I have not seen Rohit’s email; I will take a look at it.
> 

Ok, he has a FS here:
https://cwiki.apache.org/confluence/display/CLOUDSTACK/CloudStack+Chimp

> About database schema changes happening only in X.Y, I also agree with you
> (that is a convention we all could agree on, and such as conding and
> release procedures we could have a wiki page for that). However, I think we
> still might have scripts in versions X.Y.Z  to add data to a table such as
> “guest_os_hypervisor”.
> 

Yes, that is true. A bugfix could be a addition into the database, but
we have to prevent it as much as possible.

> The point to manage such scripts is that, if we are in version such as
> 4.7.0 and a new script emerges in version 4.5.3, we would have to decide to
> run or not to run it. I would rather not run them, since if they add
> something to the code base; those changes should also be applied into
> master and as a consequence it will be available in a future update.
> 

I understand, but this is where our release cycle becomes the problem.
It is because we release a X.Y.Z release we run into these kind of problems.

If we as a project simple do not release the .Z releases we would be
fine as well ;)

You can try to complicate things with technical things, or if we release
every two / three weeks we don't run into these kind of situations :)

We might even cut the database version loose from the code version.

Database version is simple 100, 101, 102, 103, 104, 105. And a code
version requires a certain version of the database.

Wido

> On Mon, Dec 28, 2015 at 12:50 PM, Wido den Hollander  wrote:
> 
>>
>>
>> On 28-12-15 14:16, Rafael Weingärtner wrote:
>>> Hi all devs,
>>> First of all, sorry the long text, but I hope we can start a discussion
>>> here and improve that part of ACS.
>>>
>>> A while ago I have faced the code that Apache CloudStack (ACS) uses to
>>> upgrade from a version to newer one and that did not seem to be a good
>> way
>>> to execute our upgrades. Therefore, I decided to use some time to search
>>> for alternatives.
>>>
>>
>> I think we all saw that happen once or more :)
>>
>>> I have read some material about versioning of scripts used to upgrade a
>>> database (DB) of a system and went through some frameworks that could
>> help
>>> us.
>>>
>>> In the literature of software engineering, it is firmly stated that we
>> have
>>> to version DB scripts as we do with the source code of the application,
>>> using the baseline approach. Gladly, we were not that bad at this point,
>> we
>>> already versioned our routines for DB upgrade (.sql and .java).
>> Therefore,
>>> it seemed that we just did not have used a practical approach to help us
>>> during DB upgrades.
>>>
>>> From my readings and looking at the ACS source code I raised the
>> following
>>> requirement:
>>> •We should be able to write more than one routine to upgrade to a
>>> version; those routines can be written in Java and SQL. We might have
>> more
>>> than a routine to be executed for each version and we should be able to
>>> define an order of execution. Additionally, to go to an upper version, we
>>> have to run all of the routines from smaller versions first, until we
>>> achieve the desired version.
>>>
>>> We could also add another requirement that is the downgrade from a
>> version,
>>> which we currently do not support. With that comes my first question for
>>> discussion:
>>> •Do we want/need a method to downgrade from a version to a previous
>> one?
>>>
>>
>> I personally do not care. Usually people should create a backup PRIOR to
>> a upgrade. If that fails they can restore the backup.
>>
>>> I found an explanation for not supporting downgrades, and I liked it:
>>> http://flywaydb.org/documentation/faq.html#downgrade
>>>
>>> So, what I devised for us:
>>> First the bureaucracy part  - our migrations occur basically in three (3)
>>> steps, first we have a "prepare script", then a cleanup script and
>> finally
>>> the migration per se that is written in Java, at least, that is what we
>> can
>>> expect when reading the interface “com.cloud.upgrade.dao.DbUpgrade”.
>>>
>>> Additionally, our scripts have the following naming convention:
>>> schema-to, which in IMHO may cause some
>>> confusion because at first sight we may think that from the same version
>> we
>>> could have different paths to an upper version, which in practice is not
>>> happening. Instead of a to we could simply use
>>> V__., giving that, we have to
>>> execute all of the V_ scripts that are smaller than the version
>> we
>>> want to upgrade.
>>>
>>> To clarify what I am saying, I will use an example. Let’s say we have
>> just
>>> installed ACS and ran the cloudstack-setup-database. That command will
>>> create a database schema in version 4.0.0. To upgrade that schema to
>>> version 4.3.0 (it is just an example, it could be any other version), ACS
>>> 

Re: Let’s discuss database upgrades

[Rafael Weingärtner]

Hi Wido, Rohit,
I have just read the feature suggestion.

Wido, I am not trying to complicate things, quite the opposite, I just
illustrate a simple thing that can happen and is happening; I just pointed
how it can be easily solved.

About the release of .Z, releases more constant and others, I do not want
to mix topics. Let’s keep this thread strict to discuss database upgrades.

Now, about the FS. I agree with Rohit that we should have only one way of
managing database upgrades and creation. I just do not like the idea of
creating a tool that work as a wrapper on frameworks/tools such as
flywaydb. I think that those frameworks already work pretty good as they
are; and, I would rather maintain configurations than some wrapper code.

I personally like the way ACS works during upgrades (I just do not like the
code itself and how things are structured), as a system administrator I
like to change the version in the “/etc/apt/sources.list.d/cloudstack.list”
and use the "apt-get" "update" and "install" from the command line. I do
not see the need to add another tool that is just a wrapper to the mix. If
I update ACS code to 4.7.0, why would I let the database schema in an older
version? And if we want version DB schemas and application code separately
maintaining somehow compatibility between them, which would bring a whole
other level of complexity to the code; I think we should avoid that.

The flywaydb can be easily integrated with everything we have now; we could
have a maven profile for developers and integrate it in ACS bootstrap using
its API as a Spring bean. Therefore, we could remove the current
“DatabaseUpgradeChecker “, “DbUpgrade” and other classes that aim to do
that. We could even add the creation of the schema into the first time it
boots using flywaydb and retire the “cloudstack-setup-database” script, or
at least make it less complicated, using it just to configure the database
URL and users.

The point is that to use Flywaydb we would have to agree upon a convention
on creating routines (java and SQL) to execute upgrades. Moreover, using a
tool such as Flywaydb we do not need to worry about upgrade paths. As I
wrote in the email I used to start this thread, the upgrade has to be
straightforward, to go to a version we have to run all of the upgrade
routines between the current version until the desired one. Our job is to
create upgrade routines that work and name them properly, the job of the
tool is to check the current version, the desired one, the upgrades that it
needs to run and execute everything properly.

Additionally, I do not see the need to break compatibility as Rohit
suggested in the FS; in my opinion, everything we have up today can be
migrated to the new structure I proposed. If we use a tool such as
Flywaydb, I even volunteered for that. The only thing we have to discuss
and agree upon is the naming conventions for upgrades routines, where to
put them and the configurations for flywaydb.

Thanks for your contribution and time.


On Mon, Dec 28, 2015 at 2:10 PM, Rohit Yadav 
wrote:

> Hi Rafael and Wido,
>
> Thanks for starting a conversation in this regard, I could not pursue the
> Chimp tool due to other $dayjob work though it’s good to see some
> discussion has started again. Hope we’ll solve this in 2016.
>
> In my opinion, we will need to first separate the database init/migration
> tooling away from mgmt server (right now the mgmt server does db migrations
> when it starts and there is a code/db version mismatch) and secondly make
> sure that we’re using the same code/tool to deploy database (right now,
> users use the cloudstack-setup-database python tool while developer use the
> maven/java DatabaseCreator activated by the -Ddeploydb flag).
>
> After we’ve addressed these two issues we can look into how we can support
> minor releases workflow (or decide to do something else, like not support
> .Z releases like Wido mentioned), and see if we can or want to use any
> existing migration tool or write a wrapper tool “chimp” that uses existing
> tools (some of those are mentioned in the Chimp FS like flywaydb etc). For
> allowing users to go back and forth from a db schema/version, we’ll also
> need some new DB migration conventions/versioning/rules/static-checking,
> and how developer need to write such paths (forward and reverse) etc.
>
> The best approach I figured at the time was to decide that we’ll use the
> previous db upgrade path mechanism till a certain CloudStack version (say
> 4.8.0) and after that we’ll use the new approach or tooling to
> upgrade/downgrade DB schemas (thereby retiring away from the old DB upgrade
> path mess).
>
> >
>
> [image: ShapeBlue]  Rohit Yadav Software
> Architect ,  ShapeBlue d:  * | s: +44 203 603 0540*
> <%7C%20s:%20+44%20203%20603%200540>  |  m:  *+91 8826230892*
> <+91%208826230892> e:  *rohit.ya...@shapeblue.com | t: *
>   |  w:  

[GitHub] cloudstack pull request: Quota: findbug fixes

[bhaisaab]

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1289#issuecomment-167625390
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Map LDAP group to Cloudstack account

[miguelaferreira]

Github user miguelaferreira commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1285#discussion_r48496732
  
--- Diff: 
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapAuthenticator.java
 ---
@@ -111,19 +114,27 @@ public LdapAuthenticator(final LdapManager 
ldapManager, final UserAccountDao use
 return new Pair(result, 
action);
 }
 
-private void enableUserInCloudStack(UserAccount user) {
-if(user != null && 
(user.getState().equalsIgnoreCase(Account.State.disabled.toString( {
+private void enableUserInCloudStack(final UserAccount user) {
+if (user != null && 
user.getState().equalsIgnoreCase(Account.State.disabled.toString())) {
 _accountManager.enableUser(user.getId());
 }
 }
 
-private void createCloudStackUserAccount(LdapUser user, long domainId, 
short accountType) {
-String username = user.getUsername();
-_accountManager.createUserAccount(username, "", 
user.getFirstname(), user.getLastname(), user.getEmail(), null, username, 
accountType, domainId, username, null,
-  UUID.randomUUID().toString(), 
UUID.randomUUID().toString(), User.Source.LDAP);
+private void createCloudStackUserAccount(final LdapUser user, final 
long domainId, final short accountType) {
+final String username = user.getUsername();
+final Account account = 
_accountManager.getActiveAccountByName(ldapGroupName, domainId);
+if (account == null) {
+s_logger.info("Account (" + ldapGroupName + ") for LDAP group 
does not exist. Creating account and user (" + username + ").");
+_accountManager.createUserAccount(username, "", 
user.getFirstname(), user.getLastname(), user.getEmail(), null, ldapGroupName, 
accountType, domainId,
+username, null, UUID.randomUUID().toString(), 
UUID.randomUUID().toString(), User.Source.LDAP);
+} else {
+s_logger.debug("Account (" + ldapGroupName + ") for LDAP group 
already exists not exist. Creating user (" + username + ").");
--- End diff --

That's a copy & paste mistake. I'll fix it. Thanks for bringing it up


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Map LDAP group to Cloudstack account

[borisroman]

Github user borisroman commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1285#discussion_r48498393
  
--- Diff: 
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapAuthenticator.java
 ---
@@ -111,19 +114,27 @@ public LdapAuthenticator(final LdapManager 
ldapManager, final UserAccountDao use
 return new Pair(result, 
action);
 }
 
-private void enableUserInCloudStack(UserAccount user) {
-if(user != null && 
(user.getState().equalsIgnoreCase(Account.State.disabled.toString( {
+private void enableUserInCloudStack(final UserAccount user) {
+if (user != null && 
user.getState().equalsIgnoreCase(Account.State.disabled.toString())) {
 _accountManager.enableUser(user.getId());
 }
 }
 
-private void createCloudStackUserAccount(LdapUser user, long domainId, 
short accountType) {
-String username = user.getUsername();
-_accountManager.createUserAccount(username, "", 
user.getFirstname(), user.getLastname(), user.getEmail(), null, username, 
accountType, domainId, username, null,
-  UUID.randomUUID().toString(), 
UUID.randomUUID().toString(), User.Source.LDAP);
+private void createCloudStackUserAccount(final LdapUser user, final 
long domainId, final short accountType) {
+final String username = user.getUsername();
+final Account account = 
_accountManager.getActiveAccountByName(ldapGroupName, domainId);
+if (account == null) {
+s_logger.info("Account (" + ldapGroupName + ") for LDAP group 
does not exist. Creating account and user (" + username + ").");
+_accountManager.createUserAccount(username, "", 
user.getFirstname(), user.getLastname(), user.getEmail(), null, ldapGroupName, 
accountType, domainId,
+username, null, UUID.randomUUID().toString(), 
UUID.randomUUID().toString(), User.Source.LDAP);
+} else {
+s_logger.debug("Account (" + ldapGroupName + ") for LDAP group 
already exists not exist. Creating user (" + username + ").");
--- End diff --

NP


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: build-master-slowbuild #2852

[jenkins]

See 

--
[...truncated 28723 lines...]
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud ---
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:instrument (default-cli) @ 
cloud-quickcloud ---
[WARNING] No files to instrument.
[INFO] NOT adding cobertura ser file to attached artifacts list.
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-quickcloud ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ 
cloud-quickcloud ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud ---
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Apache CloudStack Developer Tools - Checkstyle Configuration  SUCCESS 
[1.761s]
[INFO] Apache CloudStack . SUCCESS [2.083s]
[INFO] Apache CloudStack Maven Conventions Parent  SUCCESS [0.785s]
[INFO] Apache CloudStack Framework - Managed Context . SUCCESS [19.381s]
[INFO] Apache CloudStack Utils ... SUCCESS [1:30.743s]
[INFO] Apache CloudStack Framework ... SUCCESS [0.105s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [54.464s]
[INFO] Apache CloudStack Framework - Configuration ... SUCCESS [27.526s]
[INFO] Apache CloudStack API . SUCCESS [1:48.618s]
[INFO] Apache CloudStack Framework - REST  SUCCESS [16.542s]
[INFO] Apache CloudStack Framework - IPC . SUCCESS [29.733s]
[INFO] Apache CloudStack Cloud Engine  SUCCESS [0.087s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [28.524s]
[INFO] Apache CloudStack Framework - Security  SUCCESS [24.018s]
[INFO] Apache CloudStack Core  SUCCESS [1:21.711s]
[INFO] Apache CloudStack Agents .. SUCCESS [36.866s]
[INFO] Apache CloudStack Framework - Clustering .. SUCCESS [36.560s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [14.145s]
[INFO] Apache CloudStack Cloud Engine Schema Component ... SUCCESS [2:08.644s]
[INFO] Apache CloudStack Framework - Jobs  SUCCESS [40.861s]
[INFO] Apache CloudStack Cloud Engine Internal Components API  SUCCESS [25.578s]
[INFO] Apache CloudStack Server .. SUCCESS [4:10.973s]
[INFO] Apache CloudStack Framework - Quota ... SUCCESS [37.800s]
[INFO] Apache CloudStack Usage Server  SUCCESS [43.682s]
[INFO] Apache CloudStack Cloud Engine Orchestration Component  SUCCESS 
[1:22.391s]
[INFO] Apache CloudStack Cloud Services .. SUCCESS [0.073s]
[INFO] Apache CloudStack Secondary Storage ... SUCCESS [0.447s]
[INFO] Apache CloudStack Secondary Storage Service ... SUCCESS [55.078s]
[INFO] Apache CloudStack Engine Storage Component  SUCCESS [48.266s]
[INFO] Apache CloudStack Engine Storage Volume Component . SUCCESS [30.575s]
[INFO] Apache CloudStack Engine Storage Image Component .. SUCCESS [26.443s]
[INFO] Apache CloudStack Engine Storage Data Motion Component  SUCCESS [26.005s]
[INFO] Apache CloudStack Engine Storage Cache Component .. SUCCESS [20.408s]
[INFO] Apache CloudStack Engine Storage Snapshot Component  SUCCESS [35.267s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [12.478s]
[INFO] Apache CloudStack Cloud Engine Service  SUCCESS [7.250s]
[INFO] Apache CloudStack Plugin POM .. SUCCESS [0.985s]
[INFO] Apache CloudStack Plugin - API Rate Limit . SUCCESS [26.108s]
[INFO] Apache CloudStack Plugin - Storage Volume default provider  SUCCESS 
[23.498s]
[INFO] Apache CloudStack Plugin - Storage Volume SolidFire Provider  SUCCESS 
[36.813s]
[INFO] Apache CloudStack Plugin - API SolidFire .. SUCCESS [16.940s]
[INFO] Apache CloudStack Plugin - API Discovery .. SUCCESS [23.692s]
[INFO] Apache CloudStack Plugin - ACL Static Role Based .. SUCCESS [14.736s]
[INFO] Apache CloudStack Plugin - Host Anti-Affinity Processor  SUCCESS 
[16.540s]
[INFO] Apache 

[GitHub] cloudstack pull request: CLOUDSTACK-9132: API createVolume takes e...

[nitin-maharana]

Github user nitin-maharana commented on the pull request:

https://github.com/apache/cloudstack/pull/1273#issuecomment-167721727
  
@rafaelweingartner : I have updated the branch. Can you please review the 
change. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: master marvin install problem

[Srikanteswararao talluri]

Looks like Prasanna filed a bug for mysql :
https://bugs.mysql.com/bug.php?id=68549

Daan, Problem you are facing is because pypi is being updated manually. It
should go away, try after some time or manually install that package.

Thanks,
~Talluri

On Mon, Dec 28, 2015 at 6:21 PM, Daan Hoogland 
wrote:

> People,
>
> I tried to install marvin 4.8.0-SNAPSHOT this afternoon and found
> mysql-connector-python missing from pypi. Is this expected? I tried last
> week and everything was dandy.
>
> --
> Daan
>

[GitHub] cloudstack pull request: CLOUDSTACK-9202 Bump ssh timeout for VR c...

[jayapalu]

Github user jayapalu commented on the pull request:

https://github.com/apache/cloudstack/pull/1291#issuecomment-167720561
  
@remibergsma  
I am facing the same issue while running the tests for strongswan s2s vpn.
I will apply this patch and run the tests once.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Build failed in Jenkins: build-master-slowbuild #2853

[jenkins]

See 

--
[...truncated 28723 lines...]
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud ---
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:instrument (default-cli) @ 
cloud-quickcloud ---
[WARNING] No files to instrument.
[INFO] NOT adding cobertura ser file to attached artifacts list.
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-quickcloud ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ 
cloud-quickcloud ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud ---
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Apache CloudStack Developer Tools - Checkstyle Configuration  SUCCESS 
[1.800s]
[INFO] Apache CloudStack . SUCCESS [2.561s]
[INFO] Apache CloudStack Maven Conventions Parent  SUCCESS [0.862s]
[INFO] Apache CloudStack Framework - Managed Context . SUCCESS [18.934s]
[INFO] Apache CloudStack Utils ... SUCCESS [1:29.782s]
[INFO] Apache CloudStack Framework ... SUCCESS [0.101s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [52.803s]
[INFO] Apache CloudStack Framework - Configuration ... SUCCESS [27.164s]
[INFO] Apache CloudStack API . SUCCESS [1:52.502s]
[INFO] Apache CloudStack Framework - REST  SUCCESS [16.499s]
[INFO] Apache CloudStack Framework - IPC . SUCCESS [29.898s]
[INFO] Apache CloudStack Cloud Engine  SUCCESS [0.090s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [27.693s]
[INFO] Apache CloudStack Framework - Security  SUCCESS [25.179s]
[INFO] Apache CloudStack Core  SUCCESS [1:21.633s]
[INFO] Apache CloudStack Agents .. SUCCESS [35.343s]
[INFO] Apache CloudStack Framework - Clustering .. SUCCESS [36.468s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [14.174s]
[INFO] Apache CloudStack Cloud Engine Schema Component ... SUCCESS [2:07.351s]
[INFO] Apache CloudStack Framework - Jobs  SUCCESS [40.762s]
[INFO] Apache CloudStack Cloud Engine Internal Components API  SUCCESS [25.345s]
[INFO] Apache CloudStack Server .. SUCCESS [4:11.088s]
[INFO] Apache CloudStack Framework - Quota ... SUCCESS [38.391s]
[INFO] Apache CloudStack Usage Server  SUCCESS [44.145s]
[INFO] Apache CloudStack Cloud Engine Orchestration Component  SUCCESS 
[1:20.924s]
[INFO] Apache CloudStack Cloud Services .. SUCCESS [0.065s]
[INFO] Apache CloudStack Secondary Storage ... SUCCESS [0.447s]
[INFO] Apache CloudStack Secondary Storage Service ... SUCCESS [54.464s]
[INFO] Apache CloudStack Engine Storage Component  SUCCESS [47.714s]
[INFO] Apache CloudStack Engine Storage Volume Component . SUCCESS [29.496s]
[INFO] Apache CloudStack Engine Storage Image Component .. SUCCESS [26.486s]
[INFO] Apache CloudStack Engine Storage Data Motion Component  SUCCESS [25.956s]
[INFO] Apache CloudStack Engine Storage Cache Component .. SUCCESS [21.063s]
[INFO] Apache CloudStack Engine Storage Snapshot Component  SUCCESS [35.188s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [12.009s]
[INFO] Apache CloudStack Cloud Engine Service  SUCCESS [7.561s]
[INFO] Apache CloudStack Plugin POM .. SUCCESS [0.923s]
[INFO] Apache CloudStack Plugin - API Rate Limit . SUCCESS [26.223s]
[INFO] Apache CloudStack Plugin - Storage Volume default provider  SUCCESS 
[23.409s]
[INFO] Apache CloudStack Plugin - Storage Volume SolidFire Provider  SUCCESS 
[36.972s]
[INFO] Apache CloudStack Plugin - API SolidFire .. SUCCESS [17.419s]
[INFO] Apache CloudStack Plugin - API Discovery .. SUCCESS [23.145s]
[INFO] Apache CloudStack Plugin - ACL Static Role Based .. SUCCESS [16.744s]
[INFO] Apache CloudStack Plugin - Host Anti-Affinity Processor  SUCCESS 
[16.575s]
[INFO] Apache 

Build failed in Jenkins: build-master-slowbuild #2851

[jenkins]

See 

--
[...truncated 28733 lines...]
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- findbugs-maven-plugin:3.0.1:check (cloudstack-findbugs) @ 
cloud-quickcloud ---
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:instrument (default-cli) @ 
cloud-quickcloud ---
[WARNING] No files to instrument.
[INFO] NOT adding cobertura ser file to attached artifacts list.
[INFO] 
[INFO] --- maven-resources-plugin:2.5:testResources (default-testResources) @ 
cloud-quickcloud ---
[debug] execute contextualize
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 

[INFO] Copying 3 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.2:testCompile (default-testCompile) @ 
cloud-quickcloud ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ cloud-quickcloud 
---
[INFO] 
[INFO] <<< cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud <<<
[INFO] 
[INFO] --- cobertura-maven-plugin:2.6:cobertura (default-cli) @ 
cloud-quickcloud ---
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Apache CloudStack Developer Tools - Checkstyle Configuration  SUCCESS 
[1.733s]
[INFO] Apache CloudStack . SUCCESS [2.185s]
[INFO] Apache CloudStack Maven Conventions Parent  SUCCESS [0.783s]
[INFO] Apache CloudStack Framework - Managed Context . SUCCESS [19.604s]
[INFO] Apache CloudStack Utils ... SUCCESS [1:31.014s]
[INFO] Apache CloudStack Framework ... SUCCESS [0.100s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [54.260s]
[INFO] Apache CloudStack Framework - Configuration ... SUCCESS [28.147s]
[INFO] Apache CloudStack API . SUCCESS [1:50.475s]
[INFO] Apache CloudStack Framework - REST  SUCCESS [16.369s]
[INFO] Apache CloudStack Framework - IPC . SUCCESS [29.823s]
[INFO] Apache CloudStack Cloud Engine  SUCCESS [0.088s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [28.184s]
[INFO] Apache CloudStack Framework - Security  SUCCESS [25.828s]
[INFO] Apache CloudStack Core  SUCCESS [1:21.441s]
[INFO] Apache CloudStack Agents .. SUCCESS [36.328s]
[INFO] Apache CloudStack Framework - Clustering .. SUCCESS [36.378s]
[INFO] Apache CloudStack Framework - Event Notification .. SUCCESS [14.297s]
[INFO] Apache CloudStack Cloud Engine Schema Component ... SUCCESS [2:07.265s]
[INFO] Apache CloudStack Framework - Jobs  SUCCESS [40.163s]
[INFO] Apache CloudStack Cloud Engine Internal Components API  SUCCESS [25.297s]
[INFO] Apache CloudStack Server .. SUCCESS [4:16.165s]
[INFO] Apache CloudStack Framework - Quota ... SUCCESS [36.706s]
[INFO] Apache CloudStack Usage Server  SUCCESS [44.581s]
[INFO] Apache CloudStack Cloud Engine Orchestration Component  SUCCESS 
[1:21.708s]
[INFO] Apache CloudStack Cloud Services .. SUCCESS [0.067s]
[INFO] Apache CloudStack Secondary Storage ... SUCCESS [0.453s]
[INFO] Apache CloudStack Secondary Storage Service ... SUCCESS [54.141s]
[INFO] Apache CloudStack Engine Storage Component  SUCCESS [47.703s]
[INFO] Apache CloudStack Engine Storage Volume Component . SUCCESS [30.067s]
[INFO] Apache CloudStack Engine Storage Image Component .. SUCCESS [25.986s]
[INFO] Apache CloudStack Engine Storage Data Motion Component  SUCCESS [25.784s]
[INFO] Apache CloudStack Engine Storage Cache Component .. SUCCESS [23.934s]
[INFO] Apache CloudStack Engine Storage Snapshot Component  SUCCESS [35.954s]
[INFO] Apache CloudStack Cloud Engine API  SUCCESS [12.266s]
[INFO] Apache CloudStack Cloud Engine Service  SUCCESS [7.932s]
[INFO] Apache CloudStack Plugin POM .. SUCCESS [0.994s]
[INFO] Apache CloudStack Plugin - API Rate Limit . SUCCESS [27.770s]
[INFO] Apache CloudStack Plugin - Storage Volume default provider  SUCCESS 
[23.508s]
[INFO] Apache CloudStack Plugin - Storage Volume SolidFire Provider  SUCCESS 
[37.672s]
[INFO] Apache CloudStack Plugin - API SolidFire .. SUCCESS [17.081s]
[INFO] Apache CloudStack Plugin - API Discovery .. SUCCESS [23.350s]
[INFO] Apache CloudStack Plugin - ACL Static Role Based .. SUCCESS [16.877s]
[INFO] Apache CloudStack Plugin - Host Anti-Affinity Processor  SUCCESS 
[17.029s]
[INFO] Apache 

Re: master marvin install problem

[Jayapal Reddy Uradi]

I got the mysql-connector-python version issue on updating the marvin.
I removed marvin, installed again and it working without issues.

Thanks,
Jayapl

> On 29-Dec-2015, at 11:24 am, Srikanteswararao talluri  
> wrote:
> 
> Looks like Prasanna filed a bug for mysql :
> https://bugs.mysql.com/bug.php?id=68549
> 
> Daan, Problem you are facing is because pypi is being updated manually. It
> should go away, try after some time or manually install that package.
> 
> Thanks,
> ~Talluri
> 
> On Mon, Dec 28, 2015 at 6:21 PM, Daan Hoogland 
> wrote:
> 
>> People,
>> 
>> I tried to install marvin 4.8.0-SNAPSHOT this afternoon and found
>> mysql-connector-python missing from pypi. Is this expected? I tried last
>> week and everything was dandy.
>> 
>> --
>> Daan
>>