[jira] [Commented] (TINKERPOP-1320) GremlinGroovyScriptEngineFileSandboxTest throws error: URI is not hierarchical
[ https://issues.apache.org/jira/browse/TINKERPOP-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15367700#comment-15367700 ] ASF GitHub Bot commented on TINKERPOP-1320: --- Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/336 > GremlinGroovyScriptEngineFileSandboxTest throws error: URI is not hierarchical > -- > > Key: TINKERPOP-1320 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1320 > Project: TinkerPop > Issue Type: Bug > Components: test-suite >Affects Versions: 3.2.0-incubating, 3.1.2-incubating >Reporter: Jason Plurad >Assignee: Jason Plurad >Priority: Minor > Fix For: 3.1.3, 3.2.1 > > > This is similar to TINKERPOP-1317. The differences here are > * The {{TestHelper.generateTempFileFromResource()}} call to load the resource > is happening from the {{public static void init()}} method before a graph > instance is available. > * A reference to {{GremlinGroovyScriptEngineFileSandboxTest.class}} is still > required to located the {{sandbox.yaml}} found in the {{gremlin-test.jar}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TINKERPOP-1320) GremlinGroovyScriptEngineFileSandboxTest throws error: URI is not hierarchical
[ https://issues.apache.org/jira/browse/TINKERPOP-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15364213#comment-15364213 ] ASF GitHub Bot commented on TINKERPOP-1320: --- Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/336 VOTE: +1 > GremlinGroovyScriptEngineFileSandboxTest throws error: URI is not hierarchical > -- > > Key: TINKERPOP-1320 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1320 > Project: TinkerPop > Issue Type: Bug > Components: test-suite >Affects Versions: 3.2.0-incubating, 3.1.2-incubating >Reporter: Jason Plurad >Assignee: Jason Plurad >Priority: Minor > Fix For: 3.1.3, 3.2.1 > > > This is similar to TINKERPOP-1317. The differences here are > * The {{TestHelper.generateTempFileFromResource()}} call to load the resource > is happening from the {{public static void init()}} method before a graph > instance is available. > * A reference to {{GremlinGroovyScriptEngineFileSandboxTest.class}} is still > required to located the {{sandbox.yaml}} found in the {{gremlin-test.jar}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TINKERPOP-1320) GremlinGroovyScriptEngineFileSandboxTest throws error: URI is not hierarchical
[ https://issues.apache.org/jira/browse/TINKERPOP-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15357466#comment-15357466 ] ASF GitHub Bot commented on TINKERPOP-1320: --- Github user pluradj commented on the issue: https://github.com/apache/tinkerpop/pull/336 @spmallette I'll get this finished up before the weekend > GremlinGroovyScriptEngineFileSandboxTest throws error: URI is not hierarchical > -- > > Key: TINKERPOP-1320 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1320 > Project: TinkerPop > Issue Type: Bug > Components: test-suite >Affects Versions: 3.2.0-incubating, 3.1.2-incubating >Reporter: Jason Plurad >Assignee: Jason Plurad >Priority: Minor > Fix For: 3.1.3, 3.2.1 > > > This is similar to TINKERPOP-1317. The differences here are > * The {{TestHelper.generateTempFileFromResource()}} call to load the resource > is happening from the {{public static void init()}} method before a graph > instance is available. > * A reference to {{GremlinGroovyScriptEngineFileSandboxTest.class}} is still > required to located the {{sandbox.yaml}} found in the {{gremlin-test.jar}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TINKERPOP-1320) GremlinGroovyScriptEngineFileSandboxTest throws error: URI is not hierarchical
[ https://issues.apache.org/jira/browse/TINKERPOP-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15357296#comment-15357296 ] ASF GitHub Bot commented on TINKERPOP-1320: --- Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/336 @pluradj is there anything left to do on this? were my remarks on `TestHelper` clear? are you just waiting for a final vote at this point? > GremlinGroovyScriptEngineFileSandboxTest throws error: URI is not hierarchical > -- > > Key: TINKERPOP-1320 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1320 > Project: TinkerPop > Issue Type: Bug > Components: test-suite >Affects Versions: 3.2.0-incubating, 3.1.2-incubating >Reporter: Jason Plurad >Assignee: Jason Plurad >Priority: Minor > Fix For: 3.1.3, 3.2.1 > > > This is similar to TINKERPOP-1317. The differences here are > * The {{TestHelper.generateTempFileFromResource()}} call to load the resource > is happening from the {{public static void init()}} method before a graph > instance is available. > * A reference to {{GremlinGroovyScriptEngineFileSandboxTest.class}} is still > required to located the {{sandbox.yaml}} found in the {{gremlin-test.jar}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TINKERPOP-1320) GremlinGroovyScriptEngineFileSandboxTest throws error: URI is not hierarchical
[ https://issues.apache.org/jira/browse/TINKERPOP-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15334082#comment-15334082 ] ASF GitHub Bot commented on TINKERPOP-1320: --- Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/336 `gremlin-core` just have tests that need the some of the same exact functions that are in `gremlin-test`, but the dependencies are such that `gremlin-core` can't use the `TestHelper` in `gremlin-test` and `gremlin-test` can't use the `TestHelper` in `gremlin-core` so there are two of them. I suppose we could move `TestHelper` out of `gremlin-core/test` to the main source code as a utility??? then there could be one. Or we publish `gremlin-core/test` as an artifiact which i kinda hate. Or we create a new dependency all together for `gremlin-core` and `gremlin-test` to depend on. All of the answers sorta stink i guess. Up until now, copying one file seemed to smell the best of all of them > GremlinGroovyScriptEngineFileSandboxTest throws error: URI is not hierarchical > -- > > Key: TINKERPOP-1320 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1320 > Project: TinkerPop > Issue Type: Bug > Components: test-suite >Affects Versions: 3.2.0-incubating, 3.1.2-incubating >Reporter: Jason Plurad >Assignee: Jason Plurad >Priority: Minor > Fix For: 3.1.3, 3.2.1 > > > This is similar to TINKERPOP-1317. The differences here are > * The {{TestHelper.generateTempFileFromResource()}} call to load the resource > is happening from the {{public static void init()}} method before a graph > instance is available. > * A reference to {{GremlinGroovyScriptEngineFileSandboxTest.class}} is still > required to located the {{sandbox.yaml}} found in the {{gremlin-test.jar}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TINKERPOP-1320) GremlinGroovyScriptEngineFileSandboxTest throws error: URI is not hierarchical
[ https://issues.apache.org/jira/browse/TINKERPOP-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15333905#comment-15333905 ] ASF GitHub Bot commented on TINKERPOP-1320: --- Github user pluradj commented on the issue: https://github.com/apache/tinkerpop/pull/336 Can you expand on that more, re: the duplication on `TestHelper.java`? I'd bumped into the two classes previously but haven't spent any time trying to figure out the reason why there are two of them. > GremlinGroovyScriptEngineFileSandboxTest throws error: URI is not hierarchical > -- > > Key: TINKERPOP-1320 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1320 > Project: TinkerPop > Issue Type: Bug > Components: test-suite >Affects Versions: 3.2.0-incubating, 3.1.2-incubating >Reporter: Jason Plurad >Assignee: Jason Plurad >Priority: Minor > Fix For: 3.1.3, 3.2.1 > > > This is similar to TINKERPOP-1317. The differences here are > * The {{TestHelper.generateTempFileFromResource()}} call to load the resource > is happening from the {{public static void init()}} method before a graph > instance is available. > * A reference to {{GremlinGroovyScriptEngineFileSandboxTest.class}} is still > required to located the {{sandbox.yaml}} found in the {{gremlin-test.jar}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TINKERPOP-1320) GremlinGroovyScriptEngineFileSandboxTest throws error: URI is not hierarchical
[ https://issues.apache.org/jira/browse/TINKERPOP-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15333826#comment-15333826 ] ASF GitHub Bot commented on TINKERPOP-1320: --- Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/336 I didn't re-test this but both travis builds are good and the code looks right. Just a side note - @pluradj I didn't review this but note that we have a bit of an ugly reality where `TestHelper` has a twin over in `gremlin-core/test`. There are test classes in there that need that kind of functionality and since `gremlin-core` can't depend on `gremlin-test` I just copied the file. :grimacing: Note sure if any of your changes needs to be propagated over there or not, but probably something you should look at before you finalize this one and merge. Pending that little investigation: VOTE +1 > GremlinGroovyScriptEngineFileSandboxTest throws error: URI is not hierarchical > -- > > Key: TINKERPOP-1320 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1320 > Project: TinkerPop > Issue Type: Bug > Components: test-suite >Affects Versions: 3.2.0-incubating, 3.1.2-incubating >Reporter: Jason Plurad >Assignee: Jason Plurad >Priority: Minor > Fix For: 3.1.3, 3.2.1 > > > This is similar to TINKERPOP-1317. The differences here are > * The {{TestHelper.generateTempFileFromResource()}} call to load the resource > is happening from the {{public static void init()}} method before a graph > instance is available. > * A reference to {{GremlinGroovyScriptEngineFileSandboxTest.class}} is still > required to located the {{sandbox.yaml}} found in the {{gremlin-test.jar}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TINKERPOP-1320) GremlinGroovyScriptEngineFileSandboxTest throws error: URI is not hierarchical
[ https://issues.apache.org/jira/browse/TINKERPOP-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15331847#comment-15331847 ] ASF GitHub Bot commented on TINKERPOP-1320: --- Github user spmallette commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/336#discussion_r67174102 --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/gryo/GryoWriter.java --- @@ -131,7 +131,7 @@ public void writeVertexProperty(final OutputStream outputStream, final VertexPro public void writeProperty(final OutputStream outputStream, final Property p) throws IOException { final Output output = new Output(outputStream); writeHeader(output); -kryo.writeObject(output, DetachedFactory.detach(p, true)); --- End diff -- cool - something doesn't make sense in that {{GryoWriter}} - very weird looking. > GremlinGroovyScriptEngineFileSandboxTest throws error: URI is not hierarchical > -- > > Key: TINKERPOP-1320 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1320 > Project: TinkerPop > Issue Type: Bug > Components: test-suite >Affects Versions: 3.2.0-incubating, 3.1.2-incubating >Reporter: Jason Plurad >Assignee: Jason Plurad >Priority: Minor > Fix For: 3.1.3, 3.2.1 > > > This is similar to TINKERPOP-1317. The differences here are > * The {{TestHelper.generateTempFileFromResource()}} call to load the resource > is happening from the {{public static void init()}} method before a graph > instance is available. > * A reference to {{GremlinGroovyScriptEngineFileSandboxTest.class}} is still > required to located the {{sandbox.yaml}} found in the {{gremlin-test.jar}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TINKERPOP-1320) GremlinGroovyScriptEngineFileSandboxTest throws error: URI is not hierarchical
[ https://issues.apache.org/jira/browse/TINKERPOP-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15331714#comment-15331714 ] ASF GitHub Bot commented on TINKERPOP-1320: --- Github user pluradj commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/336#discussion_r67157872 --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/gryo/GryoWriter.java --- @@ -131,7 +131,7 @@ public void writeVertexProperty(final OutputStream outputStream, final VertexPro public void writeProperty(final OutputStream outputStream, final Property p) throws IOException { final Output output = new Output(outputStream); writeHeader(output); -kryo.writeObject(output, DetachedFactory.detach(p, true)); --- End diff -- Let me pull out this one change and open up a separate issue for it. I'll expand more in the issue on this one. > GremlinGroovyScriptEngineFileSandboxTest throws error: URI is not hierarchical > -- > > Key: TINKERPOP-1320 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1320 > Project: TinkerPop > Issue Type: Bug > Components: test-suite >Affects Versions: 3.2.0-incubating, 3.1.2-incubating >Reporter: Jason Plurad >Assignee: Jason Plurad >Priority: Minor > Fix For: 3.1.3, 3.2.1 > > > This is similar to TINKERPOP-1317. The differences here are > * The {{TestHelper.generateTempFileFromResource()}} call to load the resource > is happening from the {{public static void init()}} method before a graph > instance is available. > * A reference to {{GremlinGroovyScriptEngineFileSandboxTest.class}} is still > required to located the {{sandbox.yaml}} found in the {{gremlin-test.jar}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TINKERPOP-1320) GremlinGroovyScriptEngineFileSandboxTest throws error: URI is not hierarchical
[ https://issues.apache.org/jira/browse/TINKERPOP-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15331706#comment-15331706 ] ASF GitHub Bot commented on TINKERPOP-1320: --- Github user spmallette commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/336#discussion_r67157460 --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/gryo/GryoWriter.java --- @@ -131,7 +131,7 @@ public void writeVertexProperty(final OutputStream outputStream, final VertexPro public void writeProperty(final OutputStream outputStream, final Property p) throws IOException { final Output output = new Output(outputStream); writeHeader(output); -kryo.writeObject(output, DetachedFactory.detach(p, true)); --- End diff -- that's weird as a standalone issue - @pluradj what did this change have to do with TINKERPOP-1320 ? > GremlinGroovyScriptEngineFileSandboxTest throws error: URI is not hierarchical > -- > > Key: TINKERPOP-1320 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1320 > Project: TinkerPop > Issue Type: Bug > Components: test-suite >Affects Versions: 3.2.0-incubating, 3.1.2-incubating >Reporter: Jason Plurad >Assignee: Jason Plurad >Priority: Minor > Fix For: 3.1.3, 3.2.1 > > > This is similar to TINKERPOP-1317. The differences here are > * The {{TestHelper.generateTempFileFromResource()}} call to load the resource > is happening from the {{public static void init()}} method before a graph > instance is available. > * A reference to {{GremlinGroovyScriptEngineFileSandboxTest.class}} is still > required to located the {{sandbox.yaml}} found in the {{gremlin-test.jar}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TINKERPOP-1320) GremlinGroovyScriptEngineFileSandboxTest throws error: URI is not hierarchical
[ https://issues.apache.org/jira/browse/TINKERPOP-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15331676#comment-15331676 ] ASF GitHub Bot commented on TINKERPOP-1320: --- Github user okram commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/336#discussion_r67155745 --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/gryo/GryoWriter.java --- @@ -131,7 +131,7 @@ public void writeVertexProperty(final OutputStream outputStream, final VertexPro public void writeProperty(final OutputStream outputStream, final Property p) throws IOException { final Output output = new Output(outputStream); writeHeader(output); -kryo.writeObject(output, DetachedFactory.detach(p, true)); --- End diff -- Is there any way that this may lead to a serialization format that is not backwards compatible? > GremlinGroovyScriptEngineFileSandboxTest throws error: URI is not hierarchical > -- > > Key: TINKERPOP-1320 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1320 > Project: TinkerPop > Issue Type: Bug > Components: test-suite >Affects Versions: 3.2.0-incubating, 3.1.2-incubating >Reporter: Jason Plurad >Assignee: Jason Plurad >Priority: Minor > Fix For: 3.1.3, 3.2.1 > > > This is similar to TINKERPOP-1317. The differences here are > * The {{TestHelper.generateTempFileFromResource()}} call to load the resource > is happening from the {{public static void init()}} method before a graph > instance is available. > * A reference to {{GremlinGroovyScriptEngineFileSandboxTest.class}} is still > required to located the {{sandbox.yaml}} found in the {{gremlin-test.jar}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TINKERPOP-1320) GremlinGroovyScriptEngineFileSandboxTest throws error: URI is not hierarchical
[ https://issues.apache.org/jira/browse/TINKERPOP-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15331673#comment-15331673 ] ASF GitHub Bot commented on TINKERPOP-1320: --- GitHub user pluradj opened a pull request: https://github.com/apache/tinkerpop/pull/336 TINKERPOP-1320 fix GremlinGroovyScriptEngineFileSandboxTest resource loading https://issues.apache.org/jira/browse/TINKERPOP-1320 Passed `mvn clean install -DincludeNeo4j` and integration tests cleanly. May be CTR worthy. Let me know. VOTE: +1 You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/tinkerpop TINKERPOP-1320 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/336.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #336 commit 11491010f151d32ce80d7b9fdb88f17f57181fd8 Author: Jason Plurad Date: 2016-06-15T12:49:17Z fix GremlinGroovyScriptEngineFileSandboxTest resource loading > GremlinGroovyScriptEngineFileSandboxTest throws error: URI is not hierarchical > -- > > Key: TINKERPOP-1320 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1320 > Project: TinkerPop > Issue Type: Bug > Components: test-suite >Affects Versions: 3.2.0-incubating, 3.1.2-incubating >Reporter: Jason Plurad >Assignee: Jason Plurad >Priority: Minor > Fix For: 3.1.3, 3.2.1 > > > This is similar to TINKERPOP-1317. The differences here are > * The {{TestHelper.generateTempFileFromResource()}} call to load the resource > is happening from the {{public static void init()}} method before a graph > instance is available. > * A reference to {{GremlinGroovyScriptEngineFileSandboxTest.class}} is still > required to located the {{sandbox.yaml}} found in the {{gremlin-test.jar}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)