[Bug 192546] Review Request: gnubiff
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnubiff https://bugzilla.redhat.com/show_bug.cgi?id=192546 [EMAIL PROTECTED] changed: What|Removed |Added Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192546] Review Request: gnubiff
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnubiff https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192546 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |CLOSED Resolution||NEXTRELEASE --- Additional Comments From [EMAIL PROTECTED] 2006-05-24 00:11 EST --- - Remove --prefix='pkg-config libpanelapplet-2.0 openssl --variable=prefix OK - Remove ABOUT-NLS & Changelog in %file section OK - Fixing %{_datadir}/info to {_infodir} OK Package imported in Extras -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192546] Review Request: gnubiff
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnubiff https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192546 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|163778 |163779 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-05-23 15:26 EST --- MD5Sums: 8d2ef679f42e7a593dc88b750d0cca4c gnubiff-2.2.1.tar.gz Good: * Source URL is canonical * Upstream source tarball verified * Package name conforms to the Fedora Naming Guidelines * Group Tag is from the official list * Buildroot has all required elements * All paths begin with macros * All directories are owned by this or other packages * All necessary BuildRequires listed. * All desired features are enabled * Package builds in Mock. * Package installs and uninstalls cleanly on FC5. * rpmlint produces no error. Bad: * Don't pass '--prefix=`pkg-config libpanelapplet-2.0 openssl --variable=prefix`' to the %configure macro. It's not needed. Minor: * In the file section, '%{_datadir}/info' should be '%{_infodir}'. Refer to http://fedoraproject.org/wiki/Extras/RPMMacros * Unnecessary documentation: ABOUT-NLS & Changelog. The first is a generic build tools file, and the second is duplicate information that is included in the NEWS file. Once these items are fixed, considered this approved. +1 Approve -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192546] Review Request: gnubiff
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnubiff https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192546 --- Additional Comments From [EMAIL PROTECTED] 2006-05-23 13:11 EST --- - Upgrade to 2.2.1 - Add --prefix='pkg-config libpanelapplet-2.0 openssl --variable=prefix in %con$ - Add gnome-panel-devel, openssl-devel in BuildRequires Changes available: http://glive.tuxfamily.org/fedora/gnubiff/ -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192546] Review Request: gnubiff
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnubiff https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192546 --- Additional Comments From [EMAIL PROTECTED] 2006-05-23 10:06 EST --- (In reply to comment #5) > Everything looks OK, but how about enabling GNOME support ? It looks like it > can > be embedded in the panel this way. It'd be a nice feature to have IMHO. > > By the way, version 2.2.1 is out. > In addition to the GNOME support, it looks like it also has some SSL/crypto support that would be worthwile to enable. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192546] Review Request: gnubiff
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnubiff https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192546 --- Additional Comments From [EMAIL PROTECTED] 2006-05-23 07:53 EST --- Everything looks OK, but how about enabling GNOME support ? It looks like it can be embedded in the panel this way. It'd be a nice feature to have IMHO. By the way, version 2.2.1 is out. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192546] Review Request: gnubiff
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnubiff https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192546 --- Additional Comments From [EMAIL PROTECTED] 2006-05-22 16:31 EST --- Change available at http://glive.tuxfamily.org/fedora/gnubiff/ -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192546] Review Request: gnubiff
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnubiff https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192546 --- Additional Comments From [EMAIL PROTECTED] 2006-05-21 18:19 EST --- Created an attachment (id=129786) --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=129786&action=view) Mock build log failure Your package fails to build in Mock. Also, you can drop the BR on gettext-devel, since the default build environment in Mock installs gettext. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192546] Review Request: gnubiff
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnubiff https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192546 --- Additional Comments From [EMAIL PROTECTED] 2006-05-21 17:31 EST --- Ok, i've made the changes. Source : http://glive.tuxfamily.org/fedora/gnubiff/ -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192546] Review Request: gnubiff
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnubiff https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192546 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2006-05-20 12:48 EST --- Brian, are you reviewing this package ? Anyway here's my take at it (can't harm to have more people for review) Needs work: * BuildRequires: gettext is missing (required by the %find_lang macro) * /usr/share/info/dir is already owned by info, don't own it (put %{_datadir}/info/*.info.gz in %files for example) * Scriptlets: missing "install-info" in %post and %preun (in the wiki: ScriptletSnippets) Minor: * Version and Source1 are not properly lined-up (tabs instead of spaces) * Duplicate BuildRequires: gtk2-devel (by libglade2-devel) * At the end of ./configure, there is "Gnome support: no". Is that what you want ? From http://gnubiff.sourceforge.net, GNOME support could be useful. Perhaps a missing "BuildRequires: gnome-panel-devel" only ? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 192546] Review Request: gnubiff
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnubiff https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192546 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] OtherBugsDependingO|163776 |163778 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review