Re: [Freedos-devel] DOSFSCK 2G FAT32 bugs fixed!
On Wed, 31 Mar 2004 22:07:55 +0100 (BST), Bart Oldeman wrote: Hmm. Sorry I didn't check out how dosfsck is compiled but perhaps you should compile with the GCC -Wall -Wstrict-prototypes options. -Wmissing-declarations may also come in handy -Wnested-externs sometimes too but it depends on your codingstyle. We use these four for DOSEMU and it catches quite a few of these kinds of errors. Indeed, this is the right way to compile any package, not only DOSEMU and DOSFSCK. -Wall gives me many warnings for volume.c but I think that fixing them won't change the code. Sure they should all be fixed and those that the other warning options you suggest give too. The problem is this: 1. DOSFSTOOLS (http://packages.debian.org/unstable/otherosfs/dosfstools) is by Roman Hodek. 2. DOSFSCK (http://users.pandora.be/imre/FreeDOS/) taken from the above and ported by Imre. 3. Eric's patches, my patches, somebody else's patches, etc... 4. A source/binary package available online. When a new version by Roman is released, (2), (3) and (4) must be repeated. Very inefficient! We must find a REAL maintainer of our port of DOSFSCK who does (2) and (3), puts through to Roman, submits our patches to him so they get into the main code, maintains a site for (4) etc. Sorry, but I'm too busy for that. The TU-Varna server doesn't work now, so I can't even do (4). I can't even test how DOSFSCK writes/fixes bad volumes as I don't currently have one handy ;-) Lucho --- This SF.Net email is sponsored by: IBM Linux Tutorials Free Linux tutorial presented by Daniel Robbins, President and CEO of GenToo technologies. Learn everything from fundamentals to system administration.http://ads.osdn.com/?ad_id=1470alloc_id=3638op=click ___ Freedos-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/freedos-devel
Re: [Freedos-devel] DOSFSCK 2G FAT32 bugs fixed!
The TU-Varna server doesn't work now Just began working so I put it at http://linux.tu-varna.acad.bg/~lig/freedos/DOSFSCK.EXE (58 KB) Happy testing! But please take into account that I don't maintain it! Lucho --- This SF.Net email is sponsored by: IBM Linux Tutorials Free Linux tutorial presented by Daniel Robbins, President and CEO of GenToo technologies. Learn everything from fundamentals to system administration.http://ads.osdn.com/?ad_id=1470alloc_id=3638op=click ___ Freedos-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/freedos-devel
Re: [Freedos-devel] DOSFSCK 2G FAT32 bugs fixed!
On Thu, 01 Apr 2004 11:07:34 +0300, you wrote: Hi Lucho, Sorry, but I'm too busy for that. The TU-Varna server doesn't work now, so I can't even do (4). I can't even test how DOSFSCK writes/fixes bad volumes as I don't currently have one handy ;-) If you need web space please tell me, I can host files for you. Rgds, Johnson. --- This SF.Net email is sponsored by: IBM Linux Tutorials Free Linux tutorial presented by Daniel Robbins, President and CEO of GenToo technologies. Learn everything from fundamentals to system administration.http://ads.osdn.com/?ad_id70alloc_id638op=click ___ Freedos-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/freedos-devel
Re: [Freedos-devel] DOSFSCK 2G FAT32 bugs fixed!
Oops! VolumeSeek() should be loff_t(loff_t offset) instead of off_t
VolumeSeek(off_t offset)! But there must be yet another bug, because
when I changed it, the bug was still there, although the code generated
for VolumeSeek() became correct. Will try to catch the other bug
tomorrow.
Caught it! VolumeSeek() wasn't declared anywhere so its return type was
assimed int. See patch. Needless to say that now DOSFSCK works! I can put
the binary online for test. Just let me know.
Lucho
--- io.h- 2002-10-17 08:43:26.0 +0200
+++ io.h2004-03-31 22:19:20.0 +0200
@@ -19,6 +19,10 @@
#endif
#endif
+loff_t VolumeSeek(loff_t offset);
+
+/* Sets the virtual file pointer */
+
void fs_open(char *path,int rw);
/* Opens the file system PATH. If RW is zero, the file system is opened
--- volume.c- 2004-01-27 20:33:50.0 +0200
+++ volume.c2004-03-31 21:49:56.0 +0200
@@ -364,7 +364,7 @@
*** Sets the virtual file pointer
***/
-off_t VolumeSeek(off_t offset)
+loff_t VolumeSeek(loff_t offset)
{
VolumePointer = offset;
return offset;
---
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470alloc_id=3638op=click
___
Freedos-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/freedos-devel
Re: [Freedos-devel] DOSFSCK 2G FAT32 bugs fixed!
On Wed, 31 Mar 2004, Luchezar Georgiev wrote: Oops! VolumeSeek() should be loff_t(loff_t offset) instead of off_t VolumeSeek(off_t offset)! But there must be yet another bug, because when I changed it, the bug was still there, although the code generated for VolumeSeek() became correct. Will try to catch the other bug tomorrow. Caught it! VolumeSeek() wasn't declared anywhere so its return type was assimed int. See patch. Hmm. Sorry I didn't check out how dosfsck is compiled but perhaps you should compile with the GCC -Wall -Wstrict-prototypes options. -Wmissing-declarations may also come in handy -Wnested-externs sometimes too but it depends on your codingstyle. We use these four for DOSEMU and it catches quite a few of these kinds of errors. Bart --- This SF.Net email is sponsored by: IBM Linux Tutorials Free Linux tutorial presented by Daniel Robbins, President and CEO of GenToo technologies. Learn everything from fundamentals to system administration.http://ads.osdn.com/?ad_id=1470alloc_id=3638op=click ___ Freedos-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/freedos-devel
Re: [Freedos-devel] DOSFSCK 2G FAT32 bugs fixed!
! 31--2004 22:22 [EMAIL PROTECTED] (Luchezar Georgiev) wrote to [EMAIL PROTECTED]: LG Caught it! VolumeSeek() wasn't declared anywhere so its return type was LG assimed int. :( This is anohter reason, why I so hate C mode, when prototypes may be omited. :( How much of other bugs prototypeless mode was and is allows! :( --- This SF.Net email is sponsored by: IBM Linux Tutorials Free Linux tutorial presented by Daniel Robbins, President and CEO of GenToo technologies. Learn everything from fundamentals to system administration.http://ads.osdn.com/?ad_id70alloc_id638op=click ___ Freedos-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/freedos-devel
