Re: [Freedreno] [PATCH] MAINTAINERS: update designated reviewer entry for MSM DRM driver
Hi Joe Thanks for the feedback. On 11/19/2021 7:34 PM, Joe Perches wrote: On Fri, 2021-11-19 at 15:18 -0800, Abhinav Kumar wrote: Adding myself as a designated reviewer to assist with the code reviews for the changes coming into MSM DRM. Acked-by: Rob Clark Signed-off-by: Abhinav Kumar [] diff --git a/MAINTAINERS b/MAINTAINERS [] @@ -5938,6 +5938,7 @@ M:Sean Paul L:linux-arm-...@vger.kernel.org L:dri-de...@lists.freedesktop.org L:freedreno@lists.freedesktop.org +R: Abhinav Kumar S:Maintained T:git https://gitlab.freedesktop.org/drm/msm.git F:Documentation/devicetree/bindings/display/msm/ R: goes after M: not L: I have fixed this and pushed it again. Thanks Abhinav
[Freedreno] [PATCH v2] MAINTAINERS: update designated reviewer entry for MSM DRM driver
Adding myself as a designated reviewer to assist with the code reviews for the changes coming into MSM DRM. Acked-by: Rob Clark Signed-off-by: Abhinav Kumar --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 5b33791..c27d8f7 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -5935,6 +5935,7 @@ F:drivers/gpu/drm/tiny/mi0283qt.c DRM DRIVER FOR MSM ADRENO GPU M: Rob Clark M: Sean Paul +R: Abhinav Kumar L: linux-arm-...@vger.kernel.org L: dri-de...@lists.freedesktop.org L: freedreno@lists.freedesktop.org -- 2.7.4
Re: [Freedreno] [PATCH bpf] treewide: add missing includes masked by cgroup -> bpf dependency
Hi Jakub, [...] > drivers/pci/controller/dwc/pci-exynos.c | 1 + > drivers/pci/controller/dwc/pcie-qcom-ep.c | 1 + Happy to give Acked-by: Krzysztof Wilczyński for the the PCI drivers. Thank you! Krzysztof
[Freedreno] [PATCH bpf] treewide: add missing includes masked by cgroup -> bpf dependency
cgroup.h (therefore swap.h, therefore half of the universe) includes bpf.h which in turn includes module.h and slab.h. Since we're about to get rid of that dependency we need to clean things up. Signed-off-by: Jakub Kicinski --- CC: ax...@kernel.dk CC: maarten.lankho...@linux.intel.com CC: mrip...@kernel.org CC: tzimmerm...@suse.de CC: airl...@linux.ie CC: dan...@ffwll.ch CC: jani.nik...@linux.intel.com CC: joonas.lahti...@linux.intel.com CC: rodrigo.v...@intel.com CC: yuq...@gmail.com CC: robdcl...@gmail.com CC: s...@poorly.run CC: christian.koe...@amd.com CC: ray.hu...@amd.com CC: sgout...@marvell.com CC: gak...@marvell.com CC: sbha...@marvell.com CC: hke...@marvell.com CC: jingooh...@gmail.com CC: lorenzo.pieral...@arm.com CC: r...@kernel.org CC: k...@linux.com CC: bhelg...@google.com CC: krzysztof.kozlow...@canonical.com CC: m...@kernel.org CC: paw...@cadence.com CC: peter.c...@kernel.org CC: rog...@kernel.org CC: a-govindr...@ti.com CC: gre...@linuxfoundation.org CC: a...@kernel.org CC: dan...@iogearbox.net CC: and...@kernel.org CC: ka...@fb.com CC: songliubrav...@fb.com CC: y...@fb.com CC: john.fastab...@gmail.com CC: kpsi...@kernel.org CC: s...@kernel.org CC: a...@linux-foundation.org CC: thomas.hellst...@linux.intel.com CC: matthew.a...@intel.com CC: colin.k...@intel.com CC: ge...@linux-m68k.org CC: linux-bl...@vger.kernel.org CC: dri-de...@lists.freedesktop.org CC: intel-...@lists.freedesktop.org CC: l...@lists.freedesktop.org CC: linux-arm-...@vger.kernel.org CC: freedreno@lists.freedesktop.org CC: linux-...@vger.kernel.org CC: linux-arm-ker...@lists.infradead.org CC: linux-samsung-...@vger.kernel.org CC: linux-...@vger.kernel.org CC: b...@vger.kernel.org CC: linux...@kvack.org Well, let's see if this makes it thru email servers... --- block/fops.c | 1 + drivers/gpu/drm/drm_gem_shmem_helper.c| 1 + drivers/gpu/drm/i915/gt/intel_gtt.c | 1 + drivers/gpu/drm/i915/i915_request.c | 1 + drivers/gpu/drm/lima/lima_device.c| 1 + drivers/gpu/drm/msm/msm_gem_shrinker.c| 1 + drivers/gpu/drm/ttm/ttm_tt.c | 1 + drivers/net/ethernet/huawei/hinic/hinic_sriov.c | 1 + drivers/net/ethernet/marvell/octeontx2/nic/otx2_ptp.c | 2 ++ drivers/pci/controller/dwc/pci-exynos.c | 1 + drivers/pci/controller/dwc/pcie-qcom-ep.c | 1 + drivers/usb/cdns3/host.c | 1 + include/linux/device/driver.h | 1 + include/linux/filter.h| 2 +- mm/damon/vaddr.c | 1 + mm/memory_hotplug.c | 1 + mm/swap_slots.c | 1 + 17 files changed, 18 insertions(+), 1 deletion(-) diff --git a/block/fops.c b/block/fops.c index ad732a36f9b3..3cb1e81929bc 100644 --- a/block/fops.c +++ b/block/fops.c @@ -15,6 +15,7 @@ #include #include #include +#include #include "blk.h" static inline struct inode *bdev_file_inode(struct file *file) diff --git a/drivers/gpu/drm/drm_gem_shmem_helper.c b/drivers/gpu/drm/drm_gem_shmem_helper.c index 7b9f69f21f1e..bca0de92802e 100644 --- a/drivers/gpu/drm/drm_gem_shmem_helper.c +++ b/drivers/gpu/drm/drm_gem_shmem_helper.c @@ -9,6 +9,7 @@ #include #include #include +#include #ifdef CONFIG_X86 #include diff --git a/drivers/gpu/drm/i915/gt/intel_gtt.c b/drivers/gpu/drm/i915/gt/intel_gtt.c index 67d14afa6623..b67f620c3d93 100644 --- a/drivers/gpu/drm/i915/gt/intel_gtt.c +++ b/drivers/gpu/drm/i915/gt/intel_gtt.c @@ -6,6 +6,7 @@ #include /* fault-inject.h is not standalone! */ #include +#include #include "gem/i915_gem_lmem.h" #include "i915_trace.h" diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915/i915_request.c index 820a1f38b271..89cccefeea63 100644 --- a/drivers/gpu/drm/i915/i915_request.c +++ b/drivers/gpu/drm/i915/i915_request.c @@ -29,6 +29,7 @@ #include #include #include +#include #include "gem/i915_gem_context.h" #include "gt/intel_breadcrumbs.h" diff --git a/drivers/gpu/drm/lima/lima_device.c b/drivers/gpu/drm/lima/lima_device.c index 65fdca366e41..f74f8048af8f 100644 --- a/drivers/gpu/drm/lima/lima_device.c +++ b/drivers/gpu/drm/lima/lima_device.c @@ -4,6 +4,7 @@ #include #include #include +#include #include #include diff --git a/drivers/gpu/drm/msm/msm_gem_shrinker.c b/drivers/gpu/drm/msm/msm_gem_shrinker.c index 4a1420b05e97..086dacf2f26a 100644 --- a/drivers/gpu/drm/msm/msm_gem_shrinker.c +++ b/drivers/gpu/drm/msm/msm_gem_shrinker.c @@ -5,6 +5,7 @@ */ #include +#include #include "msm_drv.h" #include "msm_gem.h" diff --git a/drivers/gpu/drm/ttm/ttm_tt.c b/drivers/gpu/drm/ttm/ttm_tt.c index 7e83c00a3f48..79c870a3bef8 100644 --- a/drivers/gpu/drm/ttm/ttm_tt.c +++ b/drivers/gpu/drm/ttm/ttm_tt.c @@ -34,6 +34,7 @@ #include #include #include
Re: [Freedreno] [PATCH] MAINTAINERS: update designated reviewer entry for MSM DRM driver
On Fri, 2021-11-19 at 15:18 -0800, Abhinav Kumar wrote: > Adding myself as a designated reviewer to assist with the > code reviews for the changes coming into MSM DRM. > > Acked-by: Rob Clark > Signed-off-by: Abhinav Kumar [] > diff --git a/MAINTAINERS b/MAINTAINERS [] > @@ -5938,6 +5938,7 @@ M: Sean Paul > L: linux-arm-...@vger.kernel.org > L: dri-de...@lists.freedesktop.org > L: freedreno@lists.freedesktop.org > +R: Abhinav Kumar > S: Maintained > T: git https://gitlab.freedesktop.org/drm/msm.git > F: Documentation/devicetree/bindings/display/msm/ R: goes after M: not L:
Re: [Freedreno] [PATCH 2/2] drm/msm/gpu: Respect PM QoS constraints
Hi,
On Fri, Nov 19, 2021 at 2:47 PM Rob Clark wrote:
>
> +void msm_devfreq_boost(struct msm_gpu *gpu, unsigned factor)
> +{
> + struct msm_gpu_devfreq *df = >devfreq;
> + unsigned long freq;
> +
> + freq = get_freq(gpu);
> + freq *= factor;
> + freq /= HZ_PER_KHZ;
Should it do the divide first? I don't know for sure, but it feels
like GPU frequency could conceivably be near-ish the u32 overflow? (~4
GHz). Better to be safe and do the / 1000 first?
> @@ -201,26 +217,14 @@ static void msm_devfreq_idle_work(struct kthread_work
> *work)
> struct msm_gpu_devfreq *df = container_of(work,
> struct msm_gpu_devfreq, idle_work.work);
> struct msm_gpu *gpu = container_of(df, struct msm_gpu, devfreq);
> - unsigned long idle_freq, target_freq = 0;
>
> if (!df->devfreq)
> return;
Why does the msm_devfreq_idle_work() need a check for "!df->devfreq"
but the boost work doesn't? Maybe you don't need it anymore now that
you're not reaching into the mutex? ...or maybe the boost work does
need it?
...and if "df->devfreq" is NULL then doesn't it mean that
msm_hrtimer_work_init() was never called? That seems bad...
-Doug
Re: [Freedreno] [PATCH 1/2] drm/msm/gpu: Fix idle_work time
Hi, On Fri, Nov 19, 2021 at 2:47 PM Rob Clark wrote: > > From: Rob Clark > > This was supposed to be a relative timer, not absolute. > > Signed-off-by: Rob Clark > --- > drivers/gpu/drm/msm/msm_gpu_devfreq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Douglas Anderson
[Freedreno] [PATCH] MAINTAINERS: update designated reviewer entry for MSM DRM driver
Adding myself as a designated reviewer to assist with the code reviews for the changes coming into MSM DRM. Acked-by: Rob Clark Signed-off-by: Abhinav Kumar --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 5b33791..503112d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -5938,6 +5938,7 @@ M:Sean Paul L: linux-arm-...@vger.kernel.org L: dri-de...@lists.freedesktop.org L: freedreno@lists.freedesktop.org +R: Abhinav Kumar S: Maintained T: git https://gitlab.freedesktop.org/drm/msm.git F: Documentation/devicetree/bindings/display/msm/ -- 2.7.4
[Freedreno] mailmap: add and update email addresses
Add and also update the email addresses to prepare for the transition to the new ones. Signed-off-by: Abhinav Kumar --- .mailmap | 8 1 file changed, 8 insertions(+) diff --git a/.mailmap b/.mailmap index 6e84911..92f4cd7 100644 --- a/.mailmap +++ b/.mailmap @@ -10,10 +10,12 @@ # Please keep this list dictionary sorted. # Aaron Durbin +Abhinav Kumar Adam Oldham Adam Radford Adriana Reus Adrian Bunk +Akhil P Oommen Alan Cox Alan Cox Aleksandar Markovic @@ -162,6 +164,7 @@ Jeff Layton Jens Axboe Jens Osterkamp Jernej Skrabec +Jessica Zhang Jiri Slaby Jiri Slaby Jiri Slaby @@ -181,6 +184,7 @@ Juha Yrjola Juha Yrjola Juha Yrjola Julien Thierry +Kalyan Thota Kay Sievers Kees Cook Kees Cook @@ -192,9 +196,11 @@ Kenneth W Chen Konstantin Khlebnikov Konstantin Khlebnikov Koushik +Krishna Manikandan Krzysztof Kozlowski Krzysztof Kozlowski Kuninori Morimoto +Kuogee Hsieh Leonardo Bras Leonid I Ananiev Leon Romanovsky @@ -300,6 +306,7 @@ Qais Yousef Quentin Monnet Quentin Perret Rafael J. Wysocki +Rajeev Nandan Rajesh Shah Ralf Baechle Ralf Wildenhues @@ -314,6 +321,7 @@ Rui Saraiva Sachin P Sant Sakari Ailus Sam Ravnborg +Sankeerth Billakanti Santosh Shilimkar Santosh Shilimkar Sarangdhar Joshi -- 2.7.4
Re: [Freedreno] [PATCH 1/2] drm/msm/gpu: Fix idle_work time
On Fri, Nov 19, 2021 at 2:46 PM Rob Clark wrote:
>
> From: Rob Clark
>
> This was supposed to be a relative timer, not absolute.
>
Fixes: 658f4c829688 ("drm/msm/devfreq: Add 1ms delay before clamping freq")
> Signed-off-by: Rob Clark
> ---
> drivers/gpu/drm/msm/msm_gpu_devfreq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/msm_gpu_devfreq.c
> b/drivers/gpu/drm/msm/msm_gpu_devfreq.c
> index 43468919df61..7285041c737e 100644
> --- a/drivers/gpu/drm/msm/msm_gpu_devfreq.c
> +++ b/drivers/gpu/drm/msm/msm_gpu_devfreq.c
> @@ -228,5 +228,5 @@ void msm_devfreq_idle(struct msm_gpu *gpu)
> struct msm_gpu_devfreq *df = >devfreq;
>
> msm_hrtimer_queue_work(>idle_work, ms_to_ktime(1),
> - HRTIMER_MODE_ABS);
> + HRTIMER_MODE_REL);
> }
> --
> 2.33.1
>
[Freedreno] [PATCH 1/2] drm/msm/gpu: Fix idle_work time
From: Rob Clark This was supposed to be a relative timer, not absolute. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gpu_devfreq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/msm_gpu_devfreq.c b/drivers/gpu/drm/msm/msm_gpu_devfreq.c index 43468919df61..7285041c737e 100644 --- a/drivers/gpu/drm/msm/msm_gpu_devfreq.c +++ b/drivers/gpu/drm/msm/msm_gpu_devfreq.c @@ -228,5 +228,5 @@ void msm_devfreq_idle(struct msm_gpu *gpu) struct msm_gpu_devfreq *df = >devfreq; msm_hrtimer_queue_work(>idle_work, ms_to_ktime(1), - HRTIMER_MODE_ABS); + HRTIMER_MODE_REL); } -- 2.33.1
Re: [Freedreno] [PATCH v4] drm/msm/dp: do not initialize phy until plugin interrupt received
On 11/18/2021 5:20 PM, Stephen Boyd wrote:
Quoting Kuogee Hsieh (2021-11-09 13:38:13)
From: Kuogee Hsieh
Current DP drivers have regulators, clocks, irq and phy are grouped
together within a function and executed not in a symmetric manner.
This increase difficulty of code maintenance and limited code scalability.
This patch divided the driver life cycle of operation into four states,
resume (including booting up), dongle plugin, dongle unplugged and suspend.
Regulators, core clocks and irq are grouped together and enabled at resume
(or booting up) so that the DP controller is armed and ready to receive HPD
plugin interrupts. HPD plugin interrupt is generated when a dongle plugs
into DUT (device under test). Once HPD plugin interrupt is received, DP
controller will initialize phy so that dpcd read/write will function and
following link training can be proceeded successfully. DP phy will be
disabled after main link is teared down at end of unplugged HPD interrupt
handle triggered by dongle unplugged out of DUT. Finally regulators, code
clocks and irq are disabled at corresponding suspension.
Changes in V2:
-- removed unnecessary dp_ctrl NULL check
-- removed unnecessary phy init_count and power_count DRM_DEBUG_DP logs
-- remove flip parameter out of dp_ctrl_irq_enable()
-- add fixes tag
Changes in V3:
-- call dp_display_host_phy_init() instead of dp_ctrl_phy_init() at
dp_display_host_init() for eDP
Changes in V4:
-- rewording commit text to match this commit changes
Fixes: e91e3065a806 ("drm/msm/dp: Add DP compliance tests on Snapdragon
Chipsets")
Signed-off-by: Kuogee Hsieh
---
What commit is this patch based on?
It base on Bjorn's patch,
https://patchwork.freedesktop.org/series/92992/
