Jenkins build is back to normal : master-osmo-iuh » a1=default,a2=default,a3=default,osmocom-master-debian9 #1528

[jenkins]

See 

Change in osmocom-bb[master]: Move from libc random() to osmo_get_rand_id

[Vadim Yanitskiy]

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/9914 )

Change subject: Move from libc random() to osmo_get_rand_id
..


Patch Set 2: Code-Review+1


--
To view, visit https://gerrit.osmocom.org/9914
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0cc64663cd4b90c027b79545dc5d3ac9d87b9dd
Gerrit-Change-Number: 9914
Gerrit-PatchSet: 2
Gerrit-Owner: Holger Freyther 
Gerrit-Reviewer: Holger Freyther 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Sun, 08 Jul 2018 00:51:26 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Build failed in Jenkins: master-osmo-iuh » a1=default,a2=default,a3=default,osmocom-master-debian9 #1527

[jenkins]

See 


--
[...truncated 678.53 KB...]
  CC   RANAP_CauseMisc.lo
  CC   RANAP_CauseNAS.lo
  CC   RANAP_CauseProtocol.lo
In file included from 
:8:0,
 from ../../include/osmocom/ranap/RANAP_AuthorisedPLMNs.h:14,
 from RANAP_AuthorisedPLMNs.c:7:
../../include/osmocom/ranap/RANAP_AuthorisedPLMNs.h:27:23: warning: ‘struct 
MemberC’ declared inside parameter list will not be visible outside of this 
definition or declaration
  A_SEQUENCE_OF(struct MemberC {
   ^
:17:16:
 note: in definition of macro ‘A_SET_OF’
   void (*free)(type *);   \
^~~~
../../include/osmocom/ranap/RANAP_AuthorisedPLMNs.h:27:2: note: in expansion of 
macro ‘A_SEQUENCE_OF’
  A_SEQUENCE_OF(struct MemberC {
  ^
  CC   RANAP_CauseRadioNetwork.lo
  CC   RANAP_CauseRadioNetworkExtension.lo
  CC   RANAP_CauseNon-Standard.lo
  CC   RANAP_CauseTransmissionNetwork.lo
  CC   RANAP_Cell-Access-Mode.lo
  CC   RANAP_CellBased.lo
  CC   RANAP_CellIdList.lo
  CC   RANAP_Cell-Id.lo
  CC   RANAP_Cell-Capacity-Class-Value.lo
  CC   RANAP_CellLoadInformation.lo
  CC   RANAP_CellLoadInformationGroup.lo
  CC   RANAP_CellType.lo
  CC   RANAP_ClientType.lo
  CC   RANAP_CriticalityDiagnostics.lo
  CC   RANAP_CriticalityDiagnostics-IE-List.lo
  CC   RANAP_MessageStructure.lo
  CC   RANAP_CGI.lo
  CC   RANAP_ChosenEncryptionAlgorithm.lo
  CC   RANAP_ChosenIntegrityProtectionAlgorithm.lo
In file included from 
:8:0,
 from 
../../include/osmocom/ranap/RANAP_CriticalityDiagnostics-IE-List.h:14,
 from 
../../include/osmocom/ranap/RANAP_CriticalityDiagnostics.h:17,
 from RANAP_CriticalityDiagnostics.c:7:
../../include/osmocom/ranap/RANAP_CriticalityDiagnostics-IE-List.h:28:23: 
warning: ‘struct MemberG’ declared inside parameter list will not be visible 
outside of this definition or declaration
  A_SEQUENCE_OF(struct MemberG {
   ^
:17:16:
 note: in definition of macro ‘A_SET_OF’
   void (*free)(type *);   \
^~~~
../../include/osmocom/ranap/RANAP_CriticalityDiagnostics-IE-List.h:28:2: note: 
in expansion of macro ‘A_SEQUENCE_OF’
  A_SEQUENCE_OF(struct MemberG {
  ^
  CC   RANAP_CI.lo
In file included from 
:8:0,
 from 
../../include/osmocom/ranap/RANAP_CriticalityDiagnostics-IE-List.h:14,
 from RANAP_CriticalityDiagnostics-IE-List.c:7:
../../include/osmocom/ranap/RANAP_CriticalityDiagnostics-IE-List.h:28:23: 
warning: ‘struct MemberG’ declared inside parameter list will not be visible 
outside of this definition or declaration
  A_SEQUENCE_OF(struct MemberG {
   ^
:17:16:
 note: in definition of macro ‘A_SET_OF’
   void (*free)(type *);   \
^~~~
../../include/osmocom/ranap/RANAP_CriticalityDiagnostics-IE-List.h:28:2: note: 
in expansion of macro ‘A_SEQUENCE_OF’
  A_SEQUENCE_OF(struct MemberG {
  ^
  CC   RANAP_ClassmarkInformation2.lo
In file included from 
:8:0,
 from ../../include/osmocom/ranap/RANAP_MessageStructure.h:14,
 from RANAP_MessageStructure.c:7:
../../include/osmocom/ranap/RANAP_MessageStructure.h:27:23: warning: ‘struct 
MemberL’ declared inside parameter list will not be visible outside of this 
definition or declaration
  A_SEQUENCE_OF(struct MemberL {
   ^

Jenkins build is back to normal : master-osmo-mgw » --enable-mgcp-transcoding,a2=default,a3=default,osmocom-master-debian9 #1090

[jenkins]

See 

Change in osmocom-bb[master]: Move from libc random() to osmo_get_rand_id

[Holger Freyther]

Hello Vadim Yanitskiy, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/9914

to look at the new patch set (#2).

Change subject: Move from libc random() to osmo_get_rand_id
..

Move from libc random() to osmo_get_rand_id

When starting multiple mobile in the same second, the libc random number
generator will be seeded to exactly the same value.

The random bits inside the RACH request(s) will be exactly the same
across multiple mobile and when the channel fails they all pick the same
randomized back-off timing.

Use stronger random numbers and replace all calls to random(2) with
osmo_get_rand_id. Add a fallback to try random().

Change-Id: Ie0cc64663cd4b90c027b79545dc5d3ac9d87b9dd
---
M src/host/layer23/src/mobile/gsm322.c
M src/host/layer23/src/mobile/gsm48_mm.c
M src/host/layer23/src/mobile/gsm48_rr.c
M src/host/layer23/src/mobile/settings.c
4 files changed, 18 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/14/9914/2
--
To view, visit https://gerrit.osmocom.org/9914
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie0cc64663cd4b90c027b79545dc5d3ac9d87b9dd
Gerrit-Change-Number: 9914
Gerrit-PatchSet: 2
Gerrit-Owner: Holger Freyther 
Gerrit-Reviewer: Holger Freyther 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 

Change in osmocom-bb[master]: Move from libc random() to osmo_get_rand_id

[Holger Freyther]

Holger Freyther has posted comments on this change. ( 
https://gerrit.osmocom.org/9914 )

Change subject: Move from libc random() to osmo_get_rand_id
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/9914/1/src/host/layer23/src/mobile/gsm322.c
File src/host/layer23/src/mobile/gsm322.c:

https://gerrit.osmocom.org/#/c/9914/1/src/host/layer23/src/mobile/gsm322.c@964
PS1, Line 964:  move = move % entries;
> cosmetic: this line may go under the 'else' part of condition.
it should have read: "move = random()"; because we will execute % random 
anyway. I will update it.



--
To view, visit https://gerrit.osmocom.org/9914
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0cc64663cd4b90c027b79545dc5d3ac9d87b9dd
Gerrit-Change-Number: 9914
Gerrit-PatchSet: 1
Gerrit-Owner: Holger Freyther 
Gerrit-Reviewer: Holger Freyther 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Sat, 07 Jul 2018 23:54:04 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in osmocom-bb[master]: Move from libc random() to osmo_get_rand_id

[Vadim Yanitskiy]

Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/9914 )

Change subject: Move from libc random() to osmo_get_rand_id
..


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/#/c/9914/1/src/host/layer23/src/mobile/gsm322.c
File src/host/layer23/src/mobile/gsm322.c:

https://gerrit.osmocom.org/#/c/9914/1/src/host/layer23/src/mobile/gsm322.c@964
PS1, Line 964:  move = move % entries;
cosmetic: this line may go under the 'else' part of condition.



--
To view, visit https://gerrit.osmocom.org/9914
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0cc64663cd4b90c027b79545dc5d3ac9d87b9dd
Gerrit-Change-Number: 9914
Gerrit-PatchSet: 1
Gerrit-Owner: Holger Freyther 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Sat, 07 Jul 2018 22:36:12 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes

Change in osmocom-bb[master]: Move from libc random() to osmo_get_rand_id

[Holger Freyther]

Holger Freyther has uploaded this change for review. ( 
https://gerrit.osmocom.org/9914


Change subject: Move from libc random() to osmo_get_rand_id
..

Move from libc random() to osmo_get_rand_id

When starting multiple mobile in the same second, the libc random number
generator will be seeded to exactly the same value.

The random bits inside the RACH request(s) will be exactly the same
across multiple mobile and when the channel fails they all pick the same
randomized back-off timing.

Use stronger random numbers and replace all calls to random(2) with
osmo_get_rand_id. Add a fallback to try random().

Change-Id: Ie0cc64663cd4b90c027b79545dc5d3ac9d87b9dd
---
M src/host/layer23/src/mobile/gsm322.c
M src/host/layer23/src/mobile/gsm48_mm.c
M src/host/layer23/src/mobile/gsm48_rr.c
M src/host/layer23/src/mobile/settings.c
4 files changed, 18 insertions(+), 5 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/14/9914/1

diff --git a/src/host/layer23/src/mobile/gsm322.c 
b/src/host/layer23/src/mobile/gsm322.c
index c3485b6..fc90c07 100644
--- a/src/host/layer23/src/mobile/gsm322.c
+++ b/src/host/layer23/src/mobile/gsm322.c
@@ -959,7 +959,9 @@
entries++;
}
while(entries) {
-   move = random() % entries;
+   if (osmo_get_rand_id((uint8_t *) , sizeof(move)) != 0)
+   move = random() % entries;
+   move = move % entries;
i = 0;
llist_for_each_entry(temp, _list, entry) {
if (rxlev2dbm(temp->rxlev) > -85) {
diff --git a/src/host/layer23/src/mobile/gsm48_mm.c 
b/src/host/layer23/src/mobile/gsm48_mm.c
index a7af1f5..a36e7e8 100644
--- a/src/host/layer23/src/mobile/gsm48_mm.c
+++ b/src/host/layer23/src/mobile/gsm48_mm.c
@@ -30,6 +30,7 @@
 #include 
 #include 
 #include 
+#include 

 #include 
 #include 
@@ -2099,7 +2100,9 @@
mm->t3212.timeout.tv_sec = current_time.tv_sec
+ (t % s->t3212);
} else {
-   uint32_t rand = random();
+   uint32_t rand;
+   if (osmo_get_rand_id((uint8_t *) , sizeof(rand)) 
!= 0)
+   rand = random();

LOGP(DMM, LOGL_INFO, "New T3212 while timer is not "
"running (value %d)\n", s->t3212);
diff --git a/src/host/layer23/src/mobile/gsm48_rr.c 
b/src/host/layer23/src/mobile/gsm48_rr.c
index dd3fe93..db2cb5e 100644
--- a/src/host/layer23/src/mobile/gsm48_rr.c
+++ b/src/host/layer23/src/mobile/gsm48_rr.c
@@ -71,6 +71,7 @@
 #include 
 #include 
 #include 
+#include 

 #include 
 #include 
@@ -1628,7 +1629,8 @@
}
}

-   chan_req = random();
+   if (osmo_get_rand_id((uint8_t *) _req, sizeof(chan_req)) != 0)
+   chan_req = random();
chan_req &= rr->chan_req_mask;
chan_req |= rr->chan_req_val;

diff --git a/src/host/layer23/src/mobile/settings.c 
b/src/host/layer23/src/mobile/settings.c
index 7370b0a..80b0b48 100644
--- a/src/host/layer23/src/mobile/settings.c
+++ b/src/host/layer23/src/mobile/settings.c
@@ -23,6 +23,7 @@
 #include 
 #include 
 #include 
+#include 

 #include 
 #include 
@@ -178,14 +179,19 @@
 {
int digits = set->imei_random;
char rand[16];
+   long rand_num;

if (digits <= 0)
return 0;
if (digits > 15)
digits = 15;

-   sprintf(rand, "%08ld", random() % 1);
-   sprintf(rand + 8, "%07ld", random() % 1000);
+   if (osmo_get_rand_id((uint8_t *) _num, sizeof(rand_num)) != 0)
+   rand_num = random();
+   sprintf(rand, "%08ld", rand_num % 1);
+   if (osmo_get_rand_id((uint8_t *) _num, sizeof(rand_num)) != 0)
+   rand_num = random();
+   sprintf(rand + 8, "%07ld", rand_num % 1000);

strcpy(set->imei + 15 - digits, rand + 15 - digits);
strncpy(set->imeisv, set->imei, 15);

--
To view, visit https://gerrit.osmocom.org/9914
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie0cc64663cd4b90c027b79545dc5d3ac9d87b9dd
Gerrit-Change-Number: 9914
Gerrit-PatchSet: 1
Gerrit-Owner: Holger Freyther 

Build failure of network:osmocom:nightly/osmo-mgw in Debian_9.0/armv7l

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-mgw/Debian_9.0/armv7l

Package network:osmocom:nightly/osmo-mgw failed to build in Debian_9.0/armv7l

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-mgw

Last lines of build log:
[  151s] -'10, a:PCMU' -> 'a:PCMU'
[  151s] -'10,a: PCMU' -> 'a: PCMU'
[  151s] -'10 ,a: PCMU' -> 'a: PCMU'
[  151s] -', a:PCMU' -> 'a:PCMU'
[  151s] -' a:PCMU' -> 'a:PCMU'
[  151s] -'' -> '(null)'
[  151s] -p10, aPCMU -> (null)
[  151s] -'10,a :PCMU' -> '(null)'
[  151s] -Done
[  151s] +DLCX failed.
[  151s] +backtrace() returned 0 addresses
[  151s] ./testsuite.at:27: exit code was 134, expected 0
[  151s] 4. testsuite.at:24: 4. mgcp (testsuite.at:24): FAILED (testsuite.at:27)
[  151s] debian/rules:30: recipe for target 'override_dh_auto_test' failed
[  151s] make[1]: *** [override_dh_auto_test] Error 1
[  151s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  151s] debian/rules:17: recipe for target 'build' failed
[  151s] make: *** [build] Error 2
[  151s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  151s] 
[  151s] armbuild21 failed "build osmo-mgw_1.3.0.29.cede2.dsc" at Sat Jul  7 
20:28:07 UTC 2018.
[  151s] 
[  151s] ### VM INTERACTION START ###
[  153s] [  139.512576] SysRq : Power Off
[  153s] [  139.513759] reboot: Power down
[  153s] ### VM INTERACTION END ###
[  153s] 
[  153s] armbuild21 failed "build osmo-mgw_1.3.0.29.cede2.dsc" at Sat Jul  7 
20:28:10 UTC 2018.
[  153s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Change in osmocom-bb[master]: calypso: Print warning about unsupported encryption algorithms

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9906 )

Change subject: calypso: Print warning about unsupported encryption algorithms
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/9906
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9b622dd5c9770c5e97fa58deee124a409544d3b
Gerrit-Change-Number: 9906
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 
Gerrit-Comment-Date: Sat, 07 Jul 2018 16:19:40 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmocom-bb[master]: calypso: Print warning about unsupported encryption algorithms

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/9906 )

Change subject: calypso: Print warning about unsupported encryption algorithms
..

calypso: Print warning about unsupported encryption algorithms

Unfortunately current code architecture doesn't support a return path
with an error so tell the caller of L1CTL on the other side that
something's wrong.

Change-Id: Ib9b622dd5c9770c5e97fa58deee124a409544d3b
---
M src/target/firmware/calypso/dsp.c
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/src/target/firmware/calypso/dsp.c 
b/src/target/firmware/calypso/dsp.c
index c37ca82..235d359 100644
--- a/src/target/firmware/calypso/dsp.c
+++ b/src/target/firmware/calypso/dsp.c
@@ -568,6 +568,9 @@
 {
dsp_api.ndb->d_a5mode = mode;

+   if (mode >= 3) /* Only A5/0, A5/1, A5/2 are supported by calypso */
+   printd("Algo A5/%u is not supported!!!\n", mode);
+
if (!mode || !key)
return;


--
To view, visit https://gerrit.osmocom.org/9906
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib9b622dd5c9770c5e97fa58deee124a409544d3b
Gerrit-Change-Number: 9906
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy 

Change in osmo-ttcn3-hacks[master]: BTS_Tests: Ensure mtc.stop is called after setverdict(fail, ...)

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9904 )

Change subject: BTS_Tests: Ensure mtc.stop is called after setverdict(fail, ...)
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/9904
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba59a69127e845cadbe9aaa1dabd87ff5ce8b43b
Gerrit-Change-Number: 9904
Gerrit-PatchSet: 1
Gerrit-Owner: daniel 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Sat, 07 Jul 2018 16:18:55 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ttcn3-hacks[master]: RSL_Emulation: Stop with error verdict if conn table runs out of space

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/9903 )

Change subject: RSL_Emulation: Stop with error verdict if conn table runs out 
of space
..

RSL_Emulation: Stop with error verdict if conn table runs out of space

Change-Id: If1a002da97cf1b66855f2e7a0fe2a54a6428bc81
---
M library/RSL_Emulation.ttcn
1 file changed, 4 insertions(+), 6 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/library/RSL_Emulation.ttcn b/library/RSL_Emulation.ttcn
index 119a9be..325f22e 100644
--- a/library/RSL_Emulation.ttcn
+++ b/library/RSL_Emulation.ttcn
@@ -195,7 +195,7 @@
return;
}
}
-   setverdict(fail, "No free entry in conn table for ", ra, fn);
+   testcase.stop("No free entry in conn table for ", ra, fn);
 }

 /* create an ew client with given RA and FN */
@@ -212,7 +212,7 @@
return;
}
}
-   setverdict(fail, "No free entry in conn table for ", trx_nr, chan_nr, 
comp_ref);
+   testcase.stop("No free entry in conn table for ", trx_nr, chan_nr, 
comp_ref);
 }


@@ -263,8 +263,7 @@
return;
}
}
-   setverdict(fail, "No space left in LastActTable to store chan_act for 
", chan_nr);
-   self.stop;
+   testcase.stop("No space left in LastActTable to store chan_act for ", 
chan_nr);
 }

 private function f_lookup_last_act(uint8_t trx_nr, RslChannelNr chan_nr)
@@ -275,8 +274,7 @@
return LastActTable[i].chan_act;
}
}
-   setverdict(fail, "No LastActTable entry found for TRX ", trx_nr, " ", 
chan_nr);
-   self.stop;
+   testcase.stop("No LastActTable entry found for TRX ", trx_nr, " ", 
chan_nr);
 }

 private function f_last_act_table_init() runs on RSL_Emulation_CT {

--
To view, visit https://gerrit.osmocom.org/9903
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If1a002da97cf1b66855f2e7a0fe2a54a6428bc81
Gerrit-Change-Number: 9903
Gerrit-PatchSet: 1
Gerrit-Owner: daniel 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 

Change in osmo-ttcn3-hacks[master]: RSL_Emulation: Stop with error verdict if conn table runs out of space

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9903 )

Change subject: RSL_Emulation: Stop with error verdict if conn table runs out 
of space
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/9903
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If1a002da97cf1b66855f2e7a0fe2a54a6428bc81
Gerrit-Change-Number: 9903
Gerrit-PatchSet: 1
Gerrit-Owner: daniel 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Sat, 07 Jul 2018 16:18:33 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-ttcn3-hacks[master]: BTS_Tests: Ensure mtc.stop is called after setverdict(fail, ...)

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/9904 )

Change subject: BTS_Tests: Ensure mtc.stop is called after setverdict(fail, ...)
..

BTS_Tests: Ensure mtc.stop is called after setverdict(fail, ...)

This will prevent subsequent failures from overwriting the verdict so we
can easily see the root cause of the test failure.

Change-Id: Iba59a69127e845cadbe9aaa1dabd87ff5ce8b43b
---
M bts/BTS_Tests.ttcn
1 file changed, 74 insertions(+), 40 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index aee081e..4f0f0ef 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -257,7 +257,7 @@
}
[] pt.receive(t_SD_PCUIF(pcu_conn_id, tr_PCUIF_INFO_IND(?, ?, ?))) -> 
value sd {
setverdict(fail, "Invalid PCU Version/BTS Number received");
-   self.stop;
+   mtc.stop;
}
 }

@@ -276,7 +276,7 @@
[] as_pcu_info_ind(pt, pcu_conn_id, pcu_last_info);
[] T.timeout {
setverdict(fail, "Timeout waiting for PCU INFO_IND");
-   self.stop;
+   mtc.stop;
}
}
 }
@@ -316,7 +316,7 @@
[] RSL_CCHAN.receive(ASP_IPA_Event:{up_down := ASP_IPA_EVENT_UP});
[] T.timeout {
setverdict(fail, "Timeout waiting for ASP_IPA_EVENT_UP");
-   self.stop;
+   mtc.stop;
}
}
f_sleep(0.5);   /* workaround for OS#3000 */
@@ -389,7 +389,7 @@
 private altstep as_Tguard() runs on ConnHdlr {
[] g_Tguard.timeout {
setverdict(fail, "Tguard timeout");
-   self.stop;
+   mtc.stop;
}
 }

@@ -404,7 +404,7 @@
"", -1, -1, {udp:={}}, 
{});
if (not ispresent(res.connId)) {
setverdict(fail, "Could not connect to trx-control interface of 
trxcon, check your configuration");
-   self.stop;
+   mtc.stop;
}
g_bb_trxc_conn_id := res.connId;
 }
@@ -455,14 +455,14 @@
}
[] T.timeout {
setverdict(fail, "Timeout expecting " & id);
-   self.stop;
+   mtc.stop;
}
[not ignore_other] as_l1_sacch();
[not ignore_other] as_meas_res();
[not ignore_other] as_l1_dcch();
[not ignore_other] RSL.receive {
setverdict(fail, "Unexpected RSL message received");
-   self.stop;
+   mtc.stop;
}
[ignore_other] RSL.receive { repeat; }
}
@@ -550,6 +550,7 @@
alt {
[] RSL.receive(tr_RSL_CHAN_ACT_ACK(g_chan_nr)) {
setverdict(fail, "Unexpected CHAN ACT ACK on double 
activation");
+   mtc.stop;
}
[] RSL.receive(tr_RSL_CHAN_ACT_NACK(g_chan_nr)) {
setverdict(pass);
@@ -577,6 +578,7 @@
}
[] T.timeout {
setverdict(fail, "Timeout expecting RF_CHAN_REL_ACK");
+   mtc.stop;
}
}
 }
@@ -594,6 +596,7 @@
alt {
[] RSL.receive(tr_RSL_CHAN_ACT_ACK(g_chan_nr)) {
setverdict(fail, "Unexpected CHAN ACT ACK");
+   mtc.stop;
}
[] RSL.receive(tr_RSL_CHAN_ACT_NACK(g_chan_nr)) {
setverdict(pass);
@@ -667,6 +670,7 @@
alt {
[not exp] L1CTL.receive(tr_L1CTL_DATA_IND(g_chan_nr, 
tr_RslLinkID_SACCH(0))) {
setverdict(fail, "Received SACCH when not expecting it");
+   mtc.stop;
}
[not exp] T_sacch.timeout {
setverdict(pass);
@@ -676,6 +680,7 @@
}
[exp] T_sacch.timeout {
setverdict(fail, "Timeout waiting for SACCH on ", g_chan_nr);
+   mtc.stop;
}
[] L1CTL.receive { repeat; }
[] RSL.receive { repeat; }
@@ -740,7 +745,7 @@
[] L1CTL.receive { repeat; }
[] T_sacch.timeout {
setverdict(fail, "Timeout waiting for SACCH ", l3_exp);
-   self.stop;
+   mtc.stop;
}
}
 }
@@ -986,7 +991,7 @@
var GsmFrameNumber fn := f_L1CTL_RACH(L1CTL, oct2int(ra));
if (fn == fn_last) {
setverdict(fail, "Two RACH in same FN?!?");
-   self.stop;
+   mtc.stop;
}
fn_last := fn;

@@ -998,12 +1003,12 @@
}
[] RSL_CCHAN.receive(tr_RSL_UD(tr_RSL_CHAN_RQD(?, ?, ?))) {
setverdict(fail, "Unexpected CHAN RQD");
-   self.stop;
+   mtc.stop;
   

Change in simtrace2[master]: DFU: disable configured console UART before starting main app

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/9909 )

Change subject: DFU: disable configured console UART before starting main app
..

DFU: disable configured console UART before starting main app

The DFU uses the UART peripheral (with IRQ/ISR) for the debug output
console. Before starting the main application we should make sure
this configuration is reset to avoid interference (particularly the
IRQ/ISR).
This is not too important though since the main application
reconfigures the UART for console output.
Other peripheral could also be disabled (e.g. all other PIO used
by DFU), but most of them also get configured by the main application.

Change-Id: I8234d1b85938ad6393094c08183f613ad09ee01b
---
M firmware/libboard/common/include/uart_console.h
M firmware/libboard/common/source/board_cstartup_gnu.c
M firmware/libboard/common/source/uart_console.c
3 files changed, 19 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/firmware/libboard/common/include/uart_console.h 
b/firmware/libboard/common/include/uart_console.h
index c48c2c1..0e49bfd 100644
--- a/firmware/libboard/common/include/uart_console.h
+++ b/firmware/libboard/common/include/uart_console.h
@@ -34,6 +34,7 @@
 #include 
 
 extern void UART_Configure( uint32_t dwBaudrate, uint32_t dwMasterClock ) ;
+extern void UART_Exit(void) ;
 extern void UART_PutChar( uint8_t uc ) ;
 extern uint32_t UART_GetChar( void ) ;
 extern uint32_t UART_IsRxReady( void ) ;
diff --git a/firmware/libboard/common/source/board_cstartup_gnu.c 
b/firmware/libboard/common/source/board_cstartup_gnu.c
index 4b561ec..42231fb 100644
--- a/firmware/libboard/common/source/board_cstartup_gnu.c
+++ b/firmware/libboard/common/source/board_cstartup_gnu.c
@@ -173,6 +173,8 @@
  * the second entry in the vector table is the reset address, 
corresponding to the application start
  */
 if 
(((*((uint32_t*)(IFLASH_ADDR+BOARD_DFU_BOOT_SIZE)))&0x)==0x2000) {
+UART_Exit();
+__disable_irq();
 BootIntoApp();
 /* Infinite loop */
 while ( 1 ) ;
diff --git a/firmware/libboard/common/source/uart_console.c 
b/firmware/libboard/common/source/uart_console.c
index a47ba0c..fe64922 100644
--- a/firmware/libboard/common/source/uart_console.c
+++ b/firmware/libboard/common/source/uart_console.c
@@ -103,6 +103,22 @@
 _ucIsConsoleInitialized=1 ;
 }
 
+/**
+ * \brief Disables the USART peripheral and related IRQ
+ */
+void UART_Exit(void)
+{
+   if (!_ucIsConsoleInitialized) {
+   return;
+   }
+
+   Uart *pUart = CONSOLE_UART;
+   pUart->UART_IDR = UART_IDR_TXRDY;
+   pUart->UART_CR = UART_CR_RSTRX | UART_CR_RSTTX | UART_CR_RXDIS | 
UART_CR_TXDIS | UART_CR_RSTSTA;
+   PMC->PMC_PCDR0 = 1 << CONSOLE_ID;
+   NVIC_DisableIRQ(CONSOLE_IRQ);
+}
+
 /** Interrupt Service routine to transmit queued data */
 void CONSOLE_ISR(void)
 {

--
To view, visit https://gerrit.osmocom.org/9909
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8234d1b85938ad6393094c08183f613ad09ee01b
Gerrit-Change-Number: 9909
Gerrit-PatchSet: 1
Gerrit-Owner: Kévin Redon 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder

Change in simtrace2[master]: UART: remove unused code

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/9911 )

Change subject: UART: remove unused code
..

UART: remove unused code

PutChar already takes care of enabling the IRQ

Change-Id: I63af5eba27c9a6f3e23412060028e817e4d9f233
---
M firmware/libboard/common/source/uart_console.c
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/firmware/libboard/common/source/uart_console.c 
b/firmware/libboard/common/source/uart_console.c
index 9004197..07f41ed 100644
--- a/firmware/libboard/common/source/uart_console.c
+++ b/firmware/libboard/common/source/uart_console.c
@@ -125,7 +125,6 @@
Uart *uart = CONSOLE_UART;
if (uart->UART_SR & UART_SR_TXRDY) {
if (!rbuf_is_empty(_tx_buffer)) {
-   //uart->UART_IER = UART_IER_TXRDY;
uart->UART_THR = rbuf_read(_tx_buffer);
} else {
uart->UART_IDR = UART_IER_TXRDY;

--
To view, visit https://gerrit.osmocom.org/9911
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I63af5eba27c9a6f3e23412060028e817e4d9f233
Gerrit-Change-Number: 9911
Gerrit-PatchSet: 1
Gerrit-Owner: Kévin Redon 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder

Change in simtrace2[master]: DFU: re-enable UART after testing forced bootloader

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/9912 )

Change subject: DFU: re-enable UART after testing forced bootloader
..

DFU: re-enable UART after testing forced bootloader

The qmod does not have a separate force button as simtrace has.
Instead it check is TX and RX of UART are shorted using PIO.
If the pins are not set back to the UART peripheral, the TRACE/debug
console output will not work anymore.

Change-Id: Id434b49909d6395a2f93a00f39d2d770a5725466
---
M firmware/libboard/qmod/source/board_qmod.c
1 file changed, 20 insertions(+), 8 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/firmware/libboard/qmod/source/board_qmod.c 
b/firmware/libboard/qmod/source/board_qmod.c
index dd6e616..0eda1ef 100644
--- a/firmware/libboard/qmod/source/board_qmod.c
+++ b/firmware/libboard/qmod/source/board_qmod.c
@@ -261,20 +261,32 @@
/* Configure UART pins as I/O */
PIO_Configure(uart_loopback_pins, PIO_LISTSIZE(uart_loopback_pins));

+   /* Send pattern over UART TX and check if it is received on RX
+* If the loop doesn't get interrupted, RxD always follows TxD and thus 
a
+* loopback jumper has been placed on RxD/TxD, and we will boot
+* into DFU unconditionally
+*/
+   int has_loopback_jumper = 1;
for (i = 0; i < 10; i++) {
/* Set TxD high; abort if RxD doesn't go high either */
PIO_Set(_loopback_pins[1]);
-   if (!PIO_Get(_loopback_pins[0]))
-   return 0;
+   if (!PIO_Get(_loopback_pins[0])) {
+   has_loopback_jumper = 0;
+   break;
+   }
/* Set TxD low, abort if RxD doesn't go low either */
PIO_Clear(_loopback_pins[1]);
-   if (PIO_Get(_loopback_pins[0]))
-   return 0;
+   if (PIO_Get(_loopback_pins[0])) {
+   has_loopback_jumper = 0;
+   break;
+   }
}
-   /* if we reached here, RxD always follows TxD and thus a
-* loopback jumper has been placed on RxD/TxD, and we will boot
-* into DFU unconditionally */
-   return 1;
+
+   /* Put pins back to UART mode */
+   const Pin uart_pins[] = {PINS_UART};
+   PIO_Configure(uart_pins, PIO_LISTSIZE(uart_pins));
+
+   return has_loopback_jumper;
 }

 int board_override_enter_dfu(void)

--
To view, visit https://gerrit.osmocom.org/9912
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id434b49909d6395a2f93a00f39d2d770a5725466
Gerrit-Change-Number: 9912
Gerrit-PatchSet: 1
Gerrit-Owner: Kévin Redon 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder

Change in simtrace2[master]: DFU: set stack pointer before starting main app

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9908 )

Change subject: DFU: set stack pointer before starting main app
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/9908
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie354d603fe302d3d5bdfa9c31575411de722323b
Gerrit-Change-Number: 9908
Gerrit-PatchSet: 1
Gerrit-Owner: Kévin Redon 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Sat, 07 Jul 2018 16:16:39 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in simtrace2[master]: DFU: set stack pointer before starting main app

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/9908 )

Change subject: DFU: set stack pointer before starting main app
..

DFU: set stack pointer before starting main app

The stack size is fixed. The linker script puts the stack section
after the bss section. The initial stack pointer is not at the
end of the RAM (as often seen).
Thus the initial stack pointer address of the main application
is different than the one from DFU. When starting the main
application the stack pointer needs to be set to the new value.
If this is not done the main application stack may overwrite the
data in bss, even without exceeding the fixed stack size.

Change-Id: Ie354d603fe302d3d5bdfa9c31575411de722323b
---
M firmware/libboard/common/source/board_cstartup_gnu.c
1 file changed, 5 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/firmware/libboard/common/source/board_cstartup_gnu.c 
b/firmware/libboard/common/source/board_cstartup_gnu.c
index 15c70dd..4b561ec 100644
--- a/firmware/libboard/common/source/board_cstartup_gnu.c
+++ b/firmware/libboard/common/source/board_cstartup_gnu.c
@@ -133,7 +133,11 @@
void (*appReset)(void);
 
pSrc = (unsigned int *) ((unsigned char *)IFLASH_ADDR + 
BOARD_DFU_BOOT_SIZE);
-   SCB->VTOR = ((unsigned int)(pSrc)) | (0x0 << 7);
+   /* set vector table to application vector table (store at the beginning 
of the application) */
+   SCB->VTOR = (unsigned int)(pSrc);
+   /* set stack pointer to address provided in the beginning of the 
application (loaded into a register first) */
+   __asm__ volatile ("MSR msp,%0" : :"r"(*pSrc));
+   /* start application (by jumping to the reset function which address is 
stored as second entry of the vector table) */
appReset = (void(*)(void))pSrc[1];
 
g_dfu->state = DFU_STATE_appIDLE;

--
To view, visit https://gerrit.osmocom.org/9908
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie354d603fe302d3d5bdfa9c31575411de722323b
Gerrit-Change-Number: 9908
Gerrit-PatchSet: 1
Gerrit-Owner: Kévin Redon 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder

Change in simtrace2[master]: buffer: increase buffer size to 512 to cope with fast and long TPDUs

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/9877 )

Change subject: buffer: increase buffer size to 512 to cope with fast and long 
TPDUs
..

buffer: increase buffer size to 512 to cope with fast and long TPDUs

Change-Id: I194c90cf09306a982d80c5bf1222397af6e658a9
---
M firmware/libcommon/include/ringbuffer.h
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/firmware/libcommon/include/ringbuffer.h 
b/firmware/libcommon/include/ringbuffer.h
index efc557c..aa200ba 100644
--- a/firmware/libcommon/include/ringbuffer.h
+++ b/firmware/libcommon/include/ringbuffer.h
@@ -5,7 +5,7 @@
 #include 
 #include 

-#define RING_BUFLEN 256
+#define RING_BUFLEN 512

 typedef struct ringbuf {
uint8_t buf[RING_BUFLEN];

--
To view, visit https://gerrit.osmocom.org/9877
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I194c90cf09306a982d80c5bf1222397af6e658a9
Gerrit-Change-Number: 9877
Gerrit-PatchSet: 13
Gerrit-Owner: Kévin Redon 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder

Change in simtrace2[master]: UART: make IRQ/ISR enabling simpler

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/9910 )

Change subject: UART: make IRQ/ISR enabling simpler
..

UART: make IRQ/ISR enabling simpler

Change-Id: Id3742850eb5bac91559e0c2b4144bd7b1ae5b07b
---
M firmware/libboard/common/source/uart_console.c
1 file changed, 4 insertions(+), 8 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/firmware/libboard/common/source/uart_console.c 
b/firmware/libboard/common/source/uart_console.c
index fe64922..9004197 100644
--- a/firmware/libboard/common/source/uart_console.c
+++ b/firmware/libboard/common/source/uart_console.c
@@ -150,16 +150,12 @@
 }
 
 /* Only store input if buffer is not full, else drop it */
-bool trigger_isr = false;
-if (rbuf_is_empty(_tx_buffer)) {
-trigger_isr = true;
-}
 if (!rbuf_is_full(_tx_buffer)) {
 rbuf_write(_tx_buffer, c);
-}
-if (trigger_isr) {
-pUart->UART_IER = UART_IER_TXRDY;
-CONSOLE_ISR();
+if (!(pUart->UART_IMR & UART_IMR_TXRDY)) {
+pUart->UART_IER = UART_IER_TXRDY;
+CONSOLE_ISR();
+}
 }
 }
 

--
To view, visit https://gerrit.osmocom.org/9910
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id3742850eb5bac91559e0c2b4144bd7b1ae5b07b
Gerrit-Change-Number: 9910
Gerrit-PatchSet: 1
Gerrit-Owner: Kévin Redon 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder

Change in simtrace2[master]: buffer: increase buffer size to 512 to cope with fast and long TPDUs

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9877 )

Change subject: buffer: increase buffer size to 512 to cope with fast and long 
TPDUs
..


Patch Set 13: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/9877
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I194c90cf09306a982d80c5bf1222397af6e658a9
Gerrit-Change-Number: 9877
Gerrit-PatchSet: 13
Gerrit-Owner: Kévin Redon 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Sat, 07 Jul 2018 16:16:43 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Build failed in Jenkins: master-osmo-mgw » --enable-mgcp-transcoding,a2=default,a3=default,osmocom-master-debian9 #1089

[jenkins]

See 


--
[...truncated 19.47 KB...]
 /bin/mkdir -p '/build/deps/install/stow/libosmocore/include/osmocom/codec'
 /usr/bin/install -c -m 644  osmocom/codec/ecu.h osmocom/codec/codec.h 
osmocom/codec/gsm610_bits.h 
'/build/deps/install/stow/libosmocore/include/osmocom/codec'
make[4]: Leaving directory '/build/deps/libosmocore/include'
make[3]: Leaving directory '/build/deps/libosmocore/include'
make[2]: Leaving directory '/build/deps/libosmocore/include'
Making install in src
make[2]: Entering directory '/build/deps/libosmocore/src'
  GEN  crc8gen.c
  GEN  crc32gen.c
  GEN  crc64gen.c
  GEN  crc16gen.c
make  install-am
make[3]: Entering directory '/build/deps/libosmocore/src'
  CC   timer.lo
  CC   select.lo
  CC   timer_clockgettime.lo
  CC   timer_gettimeofday.lo
  CC   signal.lo
  CC   msgb.lo
  CC   bits.lo
  CC   bitvec.lo
  CC   bitcomp.lo
  CC   counter.lo
  CC   fsm.lo
  CC   write_queue.lo
  CC   utils.lo
  CC   socket.lo
  CC   logging.lo
  CC   logging_syslog.lo
  CC   logging_gsmtap.lo
  CC   rate_ctr.lo
  CC   gsmtap_util.lo
  CC   crc16.lo
  CC   panic.lo
  CC   backtrace.lo
  CC   conv.lo
  CC   application.lo
  CC   rbtree.lo
  CC   strrb.lo
  CC   loggingrb.lo
  CC   crc8gen.lo
  CC   crc16gen.lo
  CC   crc32gen.lo
  CC   crc64gen.lo
  CC   macaddr.lo
  CC   stat_item.lo
  CC   stats.lo
  CC   stats_statsd.lo
  CC   prim.lo
  CC   conv_acc.lo
  CC   conv_acc_generic.lo
  CC   sercomm.lo
  CC   prbs.lo
  CC   isdnhdlc.lo
  CC   conv_acc_sse.lo
  CC   conv_acc_sse_avx.lo
  CC   plugin.lo
  CC   msgfile.lo
  CC   serial.lo
  CCLD libosmocore.la
make[4]: Entering directory '/build/deps/libosmocore/src'
make[4]: Nothing to be done for 'install-data-am'.
 /bin/mkdir -p '/build/deps/install/stow/libosmocore/lib'
 /bin/bash ../libtool   --mode=install /usr/bin/install -c   libosmocore.la 
'/build/deps/install/stow/libosmocore/lib'
libtool: install: /usr/bin/install -c .libs/libosmocore.so.10.0.0 
/build/deps/install/stow/libosmocore/lib/libosmocore.so.10.0.0
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmocore.so.10.0.0 libosmocore.so.10 || { rm -f libosmocore.so.10 && ln -s 
libosmocore.so.10.0.0 libosmocore.so.10; }; })
libtool: install: (cd /build/deps/install/stow/libosmocore/lib && { ln -s -f 
libosmocore.so.10.0.0 libosmocore.so || { rm -f libosmocore.so && ln -s 
libosmocore.so.10.0.0 libosmocore.so; }; })
libtool: install: /usr/bin/install -c .libs/libosmocore.lai 
/build/deps/install/stow/libosmocore/lib/libosmocore.la
libtool: finish: 
PATH="/usr/local/bin:/usr/bin:/bin:/usr/games:/home/osmocom-build/bin:/build_bin:/sbin"
 ldconfig -n /build/deps/install/stow/libosmocore/lib
--
Libraries have been installed in:
   /build/deps/install/stow/libosmocore/lib

If you ever happen to want to link against installed libraries
in a given directory, LIBDIR, you must either use libtool, and
specify the full pathname of the library, or use the `-LLIBDIR'
flag during linking and do at least one of the following:
   - add LIBDIR to the `LD_LIBRARY_PATH' environment variable
 during execution
   - add LIBDIR to the `LD_RUN_PATH' environment variable
 during linking
   - use the `-Wl,-rpath -Wl,LIBDIR' linker flag
   - have your system administrator add LIBDIR to `/etc/ld.so.conf'

See any operating system documentation about shared libraries for
more information, such as the ld(1) and ld.so(8) manual pages.
--
make[4]: Leaving directory '/build/deps/libosmocore/src'
make[3]: Leaving directory '/build/deps/libosmocore/src'
make[2]: Leaving directory '/build/deps/libosmocore/src'
Making install in src/vty
make[2]: Entering directory '/build/deps/libosmocore/src/vty'
  CC   command.lo
  CC   buffer.lo
  CC   vty.lo
  CC   utils.lo
  CC   vector.lo
  CC   logging_vty.lo
  CC   telnet_interface.lo
  CC   stats_vty.lo
  CC   fsm_vty.lo
  CC   talloc_ctx_vty.lo
  CCLD libosmovty.la
make[3]: Entering directory '/build/deps/libosmocore/src/vty'
make[3]: Nothing to be done for 'install-data-am'.
 /bin/mkdir -p '/build/deps/install/stow/libosmocore/lib'
 /bin/bash ../../libtool   --mode=install /usr/bin/install -c   libosmovty.la 
'/build/deps/install/stow/libosmocore/lib'
libtool: install: warning: relinking `libosmovty.la'
libtool: install: (cd /build/deps/libosmocore/src/vty; /bin/bash 
/build/deps/libosmocore/libtool  --silent --tag CC --mode=relink gcc -Wall -g 
-O2 -DBUILDING_LIBOSMOCORE 

Change in simtrace2[master]: DFU: re-enable UART after testing forced bootloader

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9912 )

Change subject: DFU: re-enable UART after testing forced bootloader
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/9912
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id434b49909d6395a2f93a00f39d2d770a5725466
Gerrit-Change-Number: 9912
Gerrit-PatchSet: 1
Gerrit-Owner: Kévin Redon 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Sat, 07 Jul 2018 15:48:54 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in simtrace2[master]: UART: remove unused code

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9911 )

Change subject: UART: remove unused code
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/9911
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I63af5eba27c9a6f3e23412060028e817e4d9f233
Gerrit-Change-Number: 9911
Gerrit-PatchSet: 1
Gerrit-Owner: Kévin Redon 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Sat, 07 Jul 2018 15:48:10 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in simtrace2[master]: UART: make IRQ/ISR enabling simpler

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9910 )

Change subject: UART: make IRQ/ISR enabling simpler
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/9910
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3742850eb5bac91559e0c2b4144bd7b1ae5b07b
Gerrit-Change-Number: 9910
Gerrit-PatchSet: 1
Gerrit-Owner: Kévin Redon 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Sat, 07 Jul 2018 15:48:02 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in simtrace2[master]: DFU: disable configured console UART before starting main app

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9909 )

Change subject: DFU: disable configured console UART before starting main app
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/9909
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8234d1b85938ad6393094c08183f613ad09ee01b
Gerrit-Change-Number: 9909
Gerrit-PatchSet: 1
Gerrit-Owner: Kévin Redon 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Sat, 07 Jul 2018 15:47:29 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-msc[master]: configure.ac: drop unused dependencies

[Harald Welte]

Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/9751 )

Change subject: configure.ac: drop unused dependencies
..

configure.ac: drop unused dependencies

Change-Id: I82083c33b0448113c74b21ed6c51cda121bc9f79
---
M configure.ac
1 file changed, 0 insertions(+), 12 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/configure.ac b/configure.ac
index c02b74d..be66d51 100644
--- a/configure.ac
+++ b/configure.ac
@@ -34,10 +34,6 @@
AC_MSG_ERROR([Please install autoconf-archive; re-run 'autoreconf -fi' 
for it to take effect.])
])

-dnl checks for libraries
-AC_SEARCH_LIBS([dlopen], [dl dld], [LIBRARY_DL="$LIBS";LIBS=""])
-AC_SUBST(LIBRARY_DL)
-

 PKG_CHECK_MODULES(LIBOSMOCORE, libosmocore >= 0.11.0)
 PKG_CHECK_MODULES(LIBOSMOVTY, libosmovty >= 0.11.0)
@@ -104,14 +100,6 @@
 AC_HEADER_STDC
 AC_CHECK_HEADERS(dbi/dbd.h,,AC_MSG_ERROR(DBI library is not installed))

-found_pcap=yes
-AC_CHECK_HEADERS(pcap/pcap.h,,found_pcap=no)
-AM_CONDITIONAL(HAVE_PCAP, test "$found_pcap" = yes)
-
-found_cdk=yes
-AC_CHECK_HEADERS(cdk/cdk.h,,found_cdk=no)
-AM_CONDITIONAL(HAVE_LIBCDK, test "$found_cdk" = yes)
-
 found_sqlite3=yes
 PKG_CHECK_MODULES(SQLITE3, sqlite3, ,found_sqlite3=no)
 AM_CONDITIONAL(HAVE_SQLITE3, test "$found_sqlite3" = yes)

--
To view, visit https://gerrit.osmocom.org/9751
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I82083c33b0448113c74b21ed6c51cda121bc9f79
Gerrit-Change-Number: 9751
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 

Change in osmo-msc[master]: configure.ac: drop unused dependencies

[Harald Welte]

Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/9751 )

Change subject: configure.ac: drop unused dependencies
..


Patch Set 1: Code-Review+2


--
To view, visit https://gerrit.osmocom.org/9751
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I82083c33b0448113c74b21ed6c51cda121bc9f79
Gerrit-Change-Number: 9751
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-Comment-Date: Sat, 07 Jul 2018 15:46:32 +
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Change in osmo-gsm-tester[master]: ms: Quit early when all tests concluded..

[Holger Freyther]

Hello Pau Espin Pedrol, Harald Welte, Jenkins Builder,

I'd like you to reexamine a change. Please visit

https://gerrit.osmocom.org/9716

to look at the new patch set (#3).

Change subject: ms: Quit early when all tests concluded..
..

ms: Quit early when all tests concluded..

And fix the the detection if everything has completed.

Change-Id: I3575ee7618c35e3b66d25fa31844d267489d9179
---
M src/osmo_ms_driver/location_update_test.py
1 file changed, 11 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/16/9716/3
--
To view, visit https://gerrit.osmocom.org/9716
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3575ee7618c35e3b66d25fa31844d267489d9179
Gerrit-Change-Number: 9716
Gerrit-PatchSet: 3
Gerrit-Owner: Holger Freyther 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Holger Freyther 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol 

Build failed in Jenkins: master-asn1c » a1=default,a2=default,a3=default,osmocom-master-debian9 #177

[jenkins]

See 


--
[...truncated 3.81 KB...]
checking target system type... x86_64-unknown-linux-gnu
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether to enable maintainer-specific portions of Makefiles... no
checking for style of include used by make... GNU
checking for gcc... gcc
checking for C compiler default output file name... a.out
checking whether the C compiler works... yes
checking whether we are cross compiling... no
checking for suffix of executables... 
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking dependency style of gcc... gcc3
checking for a sed that does not truncate output... /bin/sed
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for ld used by gcc... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for /usr/bin/ld option to reload object files... -r
checking for BSD-compatible nm... /usr/bin/nm -B
checking whether ln -s works... yes
checking how to recognise dependent libraries... pass_all
checking how to run the C preprocessor... gcc -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking dlfcn.h usability... yes
checking dlfcn.h presence... yes
checking for dlfcn.h... yes
checking for g++... g++
checking whether we are using the GNU C++ compiler... yes
checking whether g++ accepts -g... yes
checking dependency style of g++... gcc3
checking how to run the C++ preprocessor... g++ -E
checking for g77... no
checking for f77... no
checking for xlf... no
checking for frt... no
checking for pgf77... no
checking for cf77... no
checking for fort77... no
checking for fl32... no
checking for af77... no
checking for f90... no
checking for xlf90... no
checking for pgf90... no
checking for pghpf... no
checking for epcf90... no
checking for gfortran... no
checking for g95... no
checking for f95... no
checking for fort... no
checking for xlf95... no
checking for ifort... no
checking for ifc... no
checking for efc... no
checking for pgf95... no
checking for lf95... no
checking for ftn... no
checking whether we are using the GNU Fortran 77 compiler... no
checking whether  accepts -g... no
checking the maximum length of command line arguments... 32768
checking command to parse /usr/bin/nm -B output from gcc object... ok
checking for objdir... .libs
checking for ar... ar
checking for ranlib... ranlib
checking for strip... strip
checking if gcc supports -fno-rtti -fno-exceptions... no
checking for gcc option to produce PIC... -fPIC
checking if gcc PIC flag -fPIC works... yes
checking if gcc static flag -static works... yes
checking if gcc supports -c -o file.o... yes
checking whether the gcc linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking whether -lc should be explicitly linked in... no
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... yes
configure: creating libtool
appending configuration tag "CXX" to libtool
checking for ld used by g++... /usr/bin/ld -m elf_x86_64
checking if the linker (/usr/bin/ld -m elf_x86_64) is GNU ld... yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking for g++ option to produce PIC... -fPIC
checking if g++ PIC flag -fPIC works... yes
checking if g++ static flag -static works... yes
checking if g++ supports -c -o file.o... yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared 
libraries... yes
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
appending configuration tag "F77" to libtool
checking for autoconf... /usr/bin/autoconf
checking for autoheader... /usr/bin/autoheader
checking for gcc... (cached) gcc
checking whether we are using the GNU C compiler... (cached) yes
checking whether gcc accepts -g... (cached) yes
checking for gcc option to accept ISO C89... (cached) none needed
checking dependency style of gcc... (cached) gcc3
checking how to run the C preprocessor... gcc -E
checking for a BSD-compatible 

Change in openbsc[master]: bsc-nat: forward_sccp_to_msc: Fix memleak on receive from non authent...

[Holger Freyther]

Holger Freyther has posted comments on this change. ( 
https://gerrit.osmocom.org/9509 )

Change subject: bsc-nat: forward_sccp_to_msc: Fix memleak on receive from non 
authenticated bsc
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/9509/1/openbsc/src/osmo-bsc_nat/bsc_nat.c
File openbsc/src/osmo-bsc_nat/bsc_nat.c:

https://gerrit.osmocom.org/#/c/9509/1/openbsc/src/osmo-bsc_nat/bsc_nat.c@a1127
PS1, Line 1127:
Are you sure this leaked? The code relied on the parent/child relationship of a 
talloc context. "parsed" is allocated in the "msg" context. It's still better 
to explicitly free it.



--
To view, visit https://gerrit.osmocom.org/9509
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd0c145ff733fdfb2f6fcb32065de99ee951d106
Gerrit-Change-Number: 9509
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: Holger Freyther 
Gerrit-Comment-Date: Sat, 07 Jul 2018 13:45:21 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in openbsc[master]: bsc-nat: ipaccess_auth_bsc: Close bsc conn immediately on bad format ...

[Holger Freyther]

Holger Freyther has posted comments on this change. ( 
https://gerrit.osmocom.org/9510 )

Change subject: bsc-nat: ipaccess_auth_bsc: Close bsc conn immediately on bad 
format received
..


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/9510/1//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/9510/1//COMMIT_MSG@13
PS1, Line 13: Previously, authentication would still not be accepted but the
: connection would be staying alive for a while until id_timeout 
timer
: triggers. Let's close the connection immediately instead, this 
way BSC
: side can see quickly something is wrong with what it is sending.
That is because our memcmp is not constant time and I didn't want to build an 
oracle. ;)



--
To view, visit https://gerrit.osmocom.org/9510
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I972961b8967076c56c607f98c2360054144951e4
Gerrit-Change-Number: 9510
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: Holger Freyther 
Gerrit-Comment-Date: Sat, 07 Jul 2018 13:41:22 +
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Change in simtrace2[master]: DFU: re-enable UART after testing forced bootloader

[Kévin Redon]

Kévin Redon has uploaded this change for review. ( 
https://gerrit.osmocom.org/9912


Change subject: DFU: re-enable UART after testing forced bootloader
..

DFU: re-enable UART after testing forced bootloader

The qmod does not have a separate force button as simtrace has.
Instead it check is TX and RX of UART are shorted using PIO.
If the pins are not set back to the UART peripheral, the TRACE/debug
console output will not work anymore.

Change-Id: Id434b49909d6395a2f93a00f39d2d770a5725466
---
M firmware/libboard/qmod/source/board_qmod.c
1 file changed, 20 insertions(+), 8 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/12/9912/1

diff --git a/firmware/libboard/qmod/source/board_qmod.c 
b/firmware/libboard/qmod/source/board_qmod.c
index dd6e616..0eda1ef 100644
--- a/firmware/libboard/qmod/source/board_qmod.c
+++ b/firmware/libboard/qmod/source/board_qmod.c
@@ -261,20 +261,32 @@
/* Configure UART pins as I/O */
PIO_Configure(uart_loopback_pins, PIO_LISTSIZE(uart_loopback_pins));
 
+   /* Send pattern over UART TX and check if it is received on RX
+* If the loop doesn't get interrupted, RxD always follows TxD and thus 
a
+* loopback jumper has been placed on RxD/TxD, and we will boot
+* into DFU unconditionally
+*/
+   int has_loopback_jumper = 1;
for (i = 0; i < 10; i++) {
/* Set TxD high; abort if RxD doesn't go high either */
PIO_Set(_loopback_pins[1]);
-   if (!PIO_Get(_loopback_pins[0]))
-   return 0;
+   if (!PIO_Get(_loopback_pins[0])) {
+   has_loopback_jumper = 0;
+   break;
+   }
/* Set TxD low, abort if RxD doesn't go low either */
PIO_Clear(_loopback_pins[1]);
-   if (PIO_Get(_loopback_pins[0]))
-   return 0;
+   if (PIO_Get(_loopback_pins[0])) {
+   has_loopback_jumper = 0;
+   break;
+   }
}
-   /* if we reached here, RxD always follows TxD and thus a
-* loopback jumper has been placed on RxD/TxD, and we will boot
-* into DFU unconditionally */
-   return 1;
+
+   /* Put pins back to UART mode */
+   const Pin uart_pins[] = {PINS_UART};
+   PIO_Configure(uart_pins, PIO_LISTSIZE(uart_pins));
+
+   return has_loopback_jumper;
 }

 int board_override_enter_dfu(void)

--
To view, visit https://gerrit.osmocom.org/9912
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id434b49909d6395a2f93a00f39d2d770a5725466
Gerrit-Change-Number: 9912
Gerrit-PatchSet: 1
Gerrit-Owner: Kévin Redon 

Change in simtrace2[master]: DFU: use central DFU override check

[Kévin Redon]

Kévin Redon has uploaded this change for review. ( 
https://gerrit.osmocom.org/9913


Change subject: DFU: use central DFU override check
..

DFU: use central DFU override check

TRACE_INFO will also provide the DFU start reason, but TRACE_INFO
(TRACE_LEVEL >= 4) should only be used for debugging.
WARNING: With TRACE_LEVEL >= 4 the DFU binary is over the maximum of
16 kiB allocated for the DFU bootloader.
Thus make combined will not boot the main application because its
start if after the expecte 16 kiB address; and flashing using DFU
will overwrite the DFU bootloader itself.

Change-Id: I82323e0f76c03f67df7dc8f2b6783166cc25f3aa
---
M firmware/apps/dfu/main.c
M firmware/libboard/common/source/board_cstartup_gnu.c
2 files changed, 49 insertions(+), 28 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/13/9913/1

diff --git a/firmware/apps/dfu/main.c b/firmware/apps/dfu/main.c
index 26cbb8c..796a13f 100644
--- a/firmware/apps/dfu/main.c
+++ b/firmware/apps/dfu/main.c
@@ -159,22 +159,32 @@
 int USBDFU_OverrideEnterDFU(void)
 {
uint32_t *app_part = (uint32_t *)FLASH_ADDR(0);
+   /* at the first call we are before the text segment has been relocated,
+* so g_dfu is not initialized yet */
+g_dfu = &_g_dfu;
+   static bool dfu_magic = false;
+   if (dfu_magic || (!dfu_magic && USB_DFU_MAGIC == g_dfu->magic)) {
+   dfu_magic = true;
+   return 1;
+   }

/* If the loopback jumper is set, we enter DFU mode */
-   if (board_override_enter_dfu())
-   return 1;
+   if (board_override_enter_dfu()) {
+   return 2;
+   }

/* if the first word of the application partition doesn't look
 * like a stack pointer (i.e. point to RAM), enter DFU mode */
-   if ((app_part[0] < IRAM_ADDR) ||
-   ((uint8_t *)app_part[0] > IRAM_END))
-   return 1;
+   if ((app_part[0] < IRAM_ADDR) || ((uint8_t *)app_part[0] > IRAM_END)) {
+   return 3;
+   }

/* if the second word of the application partition doesn't look
 * like a function from flash (reset vector), enter DFU mode */
if (((uint32_t *)app_part[1] < app_part) ||
-   ((uint8_t *)app_part[1] > IFLASH_END))
-   return 1;
+   ((uint8_t *)app_part[1] > IFLASH_END)) {
+   return 4;
+   }

return 0;
 }
@@ -218,7 +228,7 @@

EEFC_ReadUniqueID(g_unique_id);

-printf("\n\r\n\r"
+   printf("\n\r\n\r"

"=\n\r"
"DFU bootloader %s for board %s (C) 2010-2017 by Harald 
Welte\n\r"

"=\n\r",
@@ -230,6 +240,31 @@
   g_unique_id[2], g_unique_id[3]);
TRACE_INFO("Reset Cause: 0x%x\n\r", reset_cause);
 
+#if (TRACE_LEVEL >= TRACE_LEVEL_INFO)
+   /* Find out why we are in the DFU bootloader, and not the main 
application */
+   TRACE_INFO("DFU bootloader start reason: ");
+   switch (USBDFU_OverrideEnterDFU()) {
+   case 0:
+   TRACE_INFO_WP("none\n\r");
+   break;
+   case 1:
+   TRACE_INFO_WP("DFU switch requested by main application\n\r");
+   break;
+   case 2:
+   TRACE_INFO_WP("bootloader forced (button pressed or jumper 
set)\n\r");
+   break;
+   case 3:
+   TRACE_INFO_WP("stack pointer (first application word) does no 
point in RAM\n\r");
+   break;
+   case 4: // the is no reason
+   TRACE_INFO_WP("reset vector (second application word) does no 
point in flash\n\r");
+   break;
+   default:
+   TRACE_INFO_WP("unknown\n\r");
+   break;
+   }
+#endif
+
/* clear g_dfu on power-up reset */
if (reset_cause == 0)
memset(g_dfu, 0, sizeof(*g_dfu));
diff --git a/firmware/libboard/common/source/board_cstartup_gnu.c 
b/firmware/libboard/common/source/board_cstartup_gnu.c
index 42231fb..bfe59ad 100644
--- a/firmware/libboard/common/source/board_cstartup_gnu.c
+++ b/firmware/libboard/common/source/board_cstartup_gnu.c
@@ -159,26 +159,12 @@
 
 
 #if defined(BOARD_USB_DFU) && defined(APPLICATION_dfu)
-/* we are before the text segment has been relocated, so g_dfu is
- * not initialized yet */
-g_dfu = &_g_dfu;
-if ((g_dfu->magic != USB_DFU_MAGIC) && !USBDFU_OverrideEnterDFU()) {
-/* start application if valid
- * the application starts with the vector table
- * the first entry in the vector table is the initial stack pointer 
(SP) address
- * the stack will be placed in RAM, which begins at 0x2000 
- * there is up to 48 KB of RAM (0xc000)
- * since the stack 

Change in simtrace2[master]: DFU: set stack pointer before starting main app

[Kévin Redon]

Kévin Redon has uploaded this change for review. ( 
https://gerrit.osmocom.org/9908


Change subject: DFU: set stack pointer before starting main app
..

DFU: set stack pointer before starting main app

The stack size is fixed. The linker script puts the stack section
after the bss section. The initial stack pointer is not at the
end of the RAM (as often seen).
Thus the initial stack pointer address of the main application
is different than the one from DFU. When starting the main
application the stack pointer needs to be set to the new value.
If this is not done the main application stack may overwrite the
data in bss, even without exceeding the fixed stack size.

Change-Id: Ie354d603fe302d3d5bdfa9c31575411de722323b
---
M firmware/libboard/common/source/board_cstartup_gnu.c
1 file changed, 5 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/08/9908/1

diff --git a/firmware/libboard/common/source/board_cstartup_gnu.c 
b/firmware/libboard/common/source/board_cstartup_gnu.c
index 15c70dd..4b561ec 100644
--- a/firmware/libboard/common/source/board_cstartup_gnu.c
+++ b/firmware/libboard/common/source/board_cstartup_gnu.c
@@ -133,7 +133,11 @@
void (*appReset)(void);
 
pSrc = (unsigned int *) ((unsigned char *)IFLASH_ADDR + 
BOARD_DFU_BOOT_SIZE);
-   SCB->VTOR = ((unsigned int)(pSrc)) | (0x0 << 7);
+   /* set vector table to application vector table (store at the beginning 
of the application) */
+   SCB->VTOR = (unsigned int)(pSrc);
+   /* set stack pointer to address provided in the beginning of the 
application (loaded into a register first) */
+   __asm__ volatile ("MSR msp,%0" : :"r"(*pSrc));
+   /* start application (by jumping to the reset function which address is 
stored as second entry of the vector table) */
appReset = (void(*)(void))pSrc[1];
 
g_dfu->state = DFU_STATE_appIDLE;

--
To view, visit https://gerrit.osmocom.org/9908
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie354d603fe302d3d5bdfa9c31575411de722323b
Gerrit-Change-Number: 9908
Gerrit-PatchSet: 1
Gerrit-Owner: Kévin Redon 

Change in simtrace2[master]: DFU: disable configured console UART before starting main app

[Kévin Redon]

Kévin Redon has uploaded this change for review. ( 
https://gerrit.osmocom.org/9909


Change subject: DFU: disable configured console UART before starting main app
..

DFU: disable configured console UART before starting main app

The DFU uses the UART peripheral (with IRQ/ISR) for the debug output
console. Before starting the main application we should make sure
this configuration is reset to avoid interference (particularly the
IRQ/ISR).
This is not too important though since the main application
reconfigures the UART for console output.
Other peripheral could also be disabled (e.g. all other PIO used
by DFU), but most of them also get configured by the main application.

Change-Id: I8234d1b85938ad6393094c08183f613ad09ee01b
---
M firmware/libboard/common/include/uart_console.h
M firmware/libboard/common/source/board_cstartup_gnu.c
M firmware/libboard/common/source/uart_console.c
3 files changed, 19 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/09/9909/1

diff --git a/firmware/libboard/common/include/uart_console.h 
b/firmware/libboard/common/include/uart_console.h
index c48c2c1..0e49bfd 100644
--- a/firmware/libboard/common/include/uart_console.h
+++ b/firmware/libboard/common/include/uart_console.h
@@ -34,6 +34,7 @@
 #include 

 extern void UART_Configure( uint32_t dwBaudrate, uint32_t dwMasterClock ) ;
+extern void UART_Exit(void) ;
 extern void UART_PutChar( uint8_t uc ) ;
 extern uint32_t UART_GetChar( void ) ;
 extern uint32_t UART_IsRxReady( void ) ;
diff --git a/firmware/libboard/common/source/board_cstartup_gnu.c 
b/firmware/libboard/common/source/board_cstartup_gnu.c
index 4b561ec..42231fb 100644
--- a/firmware/libboard/common/source/board_cstartup_gnu.c
+++ b/firmware/libboard/common/source/board_cstartup_gnu.c
@@ -173,6 +173,8 @@
  * the second entry in the vector table is the reset address, 
corresponding to the application start
  */
 if 
(((*((uint32_t*)(IFLASH_ADDR+BOARD_DFU_BOOT_SIZE)))&0x)==0x2000) {
+UART_Exit();
+__disable_irq();
 BootIntoApp();
 /* Infinite loop */
 while ( 1 ) ;
diff --git a/firmware/libboard/common/source/uart_console.c 
b/firmware/libboard/common/source/uart_console.c
index a47ba0c..fe64922 100644
--- a/firmware/libboard/common/source/uart_console.c
+++ b/firmware/libboard/common/source/uart_console.c
@@ -103,6 +103,22 @@
 _ucIsConsoleInitialized=1 ;
 }
 
+/**
+ * \brief Disables the USART peripheral and related IRQ
+ */
+void UART_Exit(void)
+{
+   if (!_ucIsConsoleInitialized) {
+   return;
+   }
+
+   Uart *pUart = CONSOLE_UART;
+   pUart->UART_IDR = UART_IDR_TXRDY;
+   pUart->UART_CR = UART_CR_RSTRX | UART_CR_RSTTX | UART_CR_RXDIS | 
UART_CR_TXDIS | UART_CR_RSTSTA;
+   PMC->PMC_PCDR0 = 1 << CONSOLE_ID;
+   NVIC_DisableIRQ(CONSOLE_IRQ);
+}
+
 /** Interrupt Service routine to transmit queued data */
 void CONSOLE_ISR(void)
 {

--
To view, visit https://gerrit.osmocom.org/9909
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8234d1b85938ad6393094c08183f613ad09ee01b
Gerrit-Change-Number: 9909
Gerrit-PatchSet: 1
Gerrit-Owner: Kévin Redon 

Change in simtrace2[master]: UART: remove unused code

[Kévin Redon]

Kévin Redon has uploaded this change for review. ( 
https://gerrit.osmocom.org/9911


Change subject: UART: remove unused code
..

UART: remove unused code

PutChar already takes care of enabling the IRQ

Change-Id: I63af5eba27c9a6f3e23412060028e817e4d9f233
---
M firmware/libboard/common/source/uart_console.c
1 file changed, 0 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/11/9911/1

diff --git a/firmware/libboard/common/source/uart_console.c 
b/firmware/libboard/common/source/uart_console.c
index 9004197..07f41ed 100644
--- a/firmware/libboard/common/source/uart_console.c
+++ b/firmware/libboard/common/source/uart_console.c
@@ -125,7 +125,6 @@
Uart *uart = CONSOLE_UART;
if (uart->UART_SR & UART_SR_TXRDY) {
if (!rbuf_is_empty(_tx_buffer)) {
-   //uart->UART_IER = UART_IER_TXRDY;
uart->UART_THR = rbuf_read(_tx_buffer);
} else {
uart->UART_IDR = UART_IER_TXRDY;

--
To view, visit https://gerrit.osmocom.org/9911
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I63af5eba27c9a6f3e23412060028e817e4d9f233
Gerrit-Change-Number: 9911
Gerrit-PatchSet: 1
Gerrit-Owner: Kévin Redon 

Change in simtrace2[master]: UART: make IRQ/ISR enabling simpler

[Kévin Redon]

Kévin Redon has uploaded this change for review. ( 
https://gerrit.osmocom.org/9910


Change subject: UART: make IRQ/ISR enabling simpler
..

UART: make IRQ/ISR enabling simpler

Change-Id: Id3742850eb5bac91559e0c2b4144bd7b1ae5b07b
---
M firmware/libboard/common/source/uart_console.c
1 file changed, 4 insertions(+), 8 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/10/9910/1

diff --git a/firmware/libboard/common/source/uart_console.c 
b/firmware/libboard/common/source/uart_console.c
index fe64922..9004197 100644
--- a/firmware/libboard/common/source/uart_console.c
+++ b/firmware/libboard/common/source/uart_console.c
@@ -150,16 +150,12 @@
 }
 
 /* Only store input if buffer is not full, else drop it */
-bool trigger_isr = false;
-if (rbuf_is_empty(_tx_buffer)) {
-trigger_isr = true;
-}
 if (!rbuf_is_full(_tx_buffer)) {
 rbuf_write(_tx_buffer, c);
-}
-if (trigger_isr) {
-pUart->UART_IER = UART_IER_TXRDY;
-CONSOLE_ISR();
+if (!(pUart->UART_IMR & UART_IMR_TXRDY)) {
+pUart->UART_IER = UART_IER_TXRDY;
+CONSOLE_ISR();
+}
 }
 }
 

--
To view, visit https://gerrit.osmocom.org/9910
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id3742850eb5bac91559e0c2b4144bd7b1ae5b07b
Gerrit-Change-Number: 9910
Gerrit-PatchSet: 1
Gerrit-Owner: Kévin Redon 

Build failed in Jenkins: master-gapk » a1=default,a2=default,a3=default,osmocom-master-debian9 #13

[jenkins]

See 


--
[...truncated 127.14 KB...]
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... no
checking whether make supports nested variables... (cached) yes
checking if gcc supports -fvisibility=hidden... yes
checking for gcc... (cached) gcc
checking whether we are using the GNU C compiler... (cached) yes
checking whether gcc accepts -g... (cached) yes
checking for gcc option to accept ISO C89... (cached) none needed
checking whether gcc understands -c and -o together... (cached) yes
checking dependency style of gcc... (cached) gcc3
checking for pkg-config... /usr/bin/pkg-config
checking pkg-config is at least version 0.9.0... yes
checking for LIBOSMOCORE... yes
checking for LIBOSMOCODEC... yes
checking for LIBALSA... yes
checking for OPENCORE_AMRNB... yes
checking gsm/gsm.h usability... yes
checking gsm/gsm.h presence... yes
checking for gsm/gsm.h... yes
checking for gsm_create in -lgsm... yes
checking for stdint.h... (cached) yes
checking for stdlib.h... (cached) yes
checking for string.h... (cached) yes
checking for unistd.h... (cached) yes
checking for inline... inline
checking for int16_t... yes
checking for int32_t... yes
checking for uint16_t... yes
checking for uint32_t... yes
checking for uint64_t... yes
checking for uint8_t... yes
checking for stdlib.h... (cached) yes
checking for GNU libc compatible malloc... yes
checking for memset... yes
checking that generated files are newer than configure... done
configure: creating ./config.status
config.status: creating Makefile
config.status: creating src/Makefile
config.status: creating libgsmhr/Makefile
config.status: creating include/Makefile
config.status: creating include/gsmhr/Makefile
config.status: creating libosmogapk.pc
config.status: creating tests/atlocal
config.status: creating tests/Makefile
config.status: creating config.h
config.status: executing depfiles commands
config.status: executing libtool commands
config.status: executing tests/atconfig commands
make[1]: Entering directory 
'
make  all-recursive
make[2]: Entering directory 
'
Making all in include
make[3]: Entering directory 
'
make[4]: Entering directory 
'
make[4]: Nothing to be done for 'all-am'.
make[4]: Leaving directory 
'
make[3]: Leaving directory 
'
Making all in src
make[3]: Entering directory 
'
  CC   procqueue.lo
  CC   pq_format.lo
  CC   pq_codec.lo
  CC   pq_file.lo
  CC   pq_alsa.lo
  CC   pq_rtp.lo
  CC   pq_ecu.lo
  CC   ecu_fr.lo
  CC   formats.lo
  CC   fmt_ti.lo
  CC   fmt_amr.lo
  CC   fmt_gsm.lo
  CC   fmt_hr_ref.lo
  CC   fmt_racal.lo
  CC   fmt_rawpcm.lo
  CC   fmt_rtp_amr.lo
  CC   fmt_rtp_efr.lo
  CC   fmt_rtp_hr_etsi.lo
  CC   fmt_rtp_hr_ietf.lo
  CC   fmt_amr_opencore.lo
  CC   codecs.lo
  CC   codec_pcm.lo
  CC   codec_hr.lo
  CC   codec_fr.lo
  CC   codec_efr.lo
  CC   codec_amr.lo
  CC   benchmark.lo
  CC   common.lo
  CCLD libosmogapk.la
  CC   app_osmo_gapk.o
  CCLD osmo-gapk
make[3]: Leaving directory 
'
Making all in tests
make[3]: Entering directory 
'
make[3]: Nothing to be done for 'all'.
make[3]: Leaving directory 

Change in osmo-ttcn3-hacks[master]: Stop tests after failures

[daniel]

daniel has uploaded this change for review. ( https://gerrit.osmocom.org/9907


Change subject: Stop tests after failures
..

Stop tests after failures

Call mtc.stop after setverdict(fail), add reasons to most failures and
fail with verdict error for internal errors.

Change-Id: I9b618235939fa41160b9be6677b121963d3ec857
---
M mgw/MGCP_Test.ttcn
M mgw/RTP_Endpoint.ttcn
M msc/BSC_ConnectionHandler.ttcn
M msc/MSC_Tests.ttcn
M pcu/GPRS_TBF.ttcn
M pcu/PCU_Tests.ttcn
M selftest/Selftest.ttcn
M sgsn/SGSN_Tests.ttcn
M sip/SIP_Tests.ttcn
M sysinfo/Test.ttcn
10 files changed, 155 insertions(+), 71 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/07/9907/1

diff --git a/mgw/MGCP_Test.ttcn b/mgw/MGCP_Test.ttcn
index d816a71..feed34f 100644
--- a/mgw/MGCP_Test.ttcn
+++ b/mgw/MGCP_Test.ttcn
@@ -70,7 +70,7 @@
res := MGCP_CodecPort_CtrlFunct.f_IPL4_connect(MGCP, 
mp_remote_ip, mp_remote_udp_port, mp_local_ip, mp_local_udp_port, 0, { udp := 
{} });
if (not ispresent(res.connId)) {
setverdict(fail, "Could not connect MGCP, check 
your configuration");
-   self.stop;
+   mtc.stop;
}
g_mgcp_conn_id := res.connId;

@@ -179,9 +179,15 @@
T.start;
alt {
[] MGCP.receive(mrt) -> value mrf { }
-   [] MGCP.receive(tr_MGCP_RecvFrom_R(?)) { 
setverdict(fail); }
+   [] MGCP.receive(tr_MGCP_RecvFrom_R(?)) {
+   setverdict(fail, "Response didn't match 
template");
+   mtc.stop;
+   }
[] MGCP.receive { repeat; }
-   [] T.timeout { setverdict(fail); }
+   [] T.timeout {
+   setverdict(fail, "Timeout waiting for response 
to ", cmd);
+   mtc.stop;
+   }
}
T.stop;

@@ -201,7 +207,8 @@
return str2hex(par.val);
}
}
-   setverdict(fail);
+   setverdict(fail, "Could not find conn id for MgcpReponse");
+   mtc.stop;
return ''H;
}

@@ -370,12 +377,14 @@
   payload type should be visible in the SDP of the response. */
if (resp.sdp.media_list[0].media_field.fmts[0] != "0") {
setverdict(fail, "SDP contains unexpected codec");
+   mtc.stop;
}

/* See also OS#2658: We also expect the MGW to assign a port
   number to us. */
if 
(isbound(resp.sdp.media_list[0].media_field.ports.port_number) == false) {
setverdict(fail, "SDP does not contain a port number");
+   mtc.stop;
}
}

@@ -559,6 +568,7 @@
}
if (f_mgcp_find_param(resp_msg, "Z", ep_assigned) == false) {
setverdict(fail, "No SpecificEndpointName in MGCP 
response", resp);
+   mtc.stop;
}

/* clean-up */
@@ -591,6 +601,7 @@
}
if (f_mgcp_find_param(resp_msg, "Z", ep_assigned[i]) == 
false) {
setverdict(fail, "No SpecificEndpointName in 
MGCP response", resp);
+   mtc.stop;
}
}

@@ -900,6 +911,7 @@
stats[1] := f_rtpem_stats_get(RTPEM[1]);
if (not f_rtpem_stats_compare(stats[0], stats[1])) {
setverdict(fail, "RTP endpoint statistics don't match");
+   mtc.stop;
}
setverdict(pass);
}
@@ -1027,6 +1039,7 @@
stats[1] := f_rtpem_stats_get(RTPEM[1]);
if (not f_rtpem_stats_compare(stats[0], stats[1], tolerance)) {
setverdict(fail, "RTP endpoint statistics don't match");
+   mtc.stop;
}

setverdict(pass);
@@ -1072,10 +1085,12 @@
stats[0] := f_rtpem_stats_get(RTPEM[0]);
if (stats[0].num_pkts_rx_err_disabled != 0) {
setverdict(fail, "received packets from MGW on recvonly 
connection");
+   mtc.stop;
}
stats[1] := f_rtpem_stats_get(RTPEM[1]);
if (stats[1].num_pkts_rx_err_disabled != 0) {
setverdict(fail, "received packets from MGW on recvonly 
connection");
+   mtc.stop;
}