[jira] [Comment Edited] (HDFS-14035) NN status discovery does not leverage delegation token
[ https://issues.apache.org/jira/browse/HDFS-14035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16684621#comment-16684621 ] Chen Liang edited comment on HDFS-14035 at 11/13/18 2:06 AM: - I ran the tests locally, none of TestEditLogTailer, TestNamenodeCapacityReport or TestBPOfferService failed. The failed CTEST are unrelated. was (Author: vagarychen): I ran the tests locally, none of TestEditLogTailer, TestNamenodeCapacityReport or TestBPOfferService failed. The failed CTEST are irrelevant. > NN status discovery does not leverage delegation token > -- > > Key: HDFS-14035 > URL: https://issues.apache.org/jira/browse/HDFS-14035 > Project: Hadoop HDFS > Issue Type: Sub-task >Reporter: Chen Liang >Assignee: Chen Liang >Priority: Major > Attachments: HDFS-14035-HDFS-12943.001.patch, > HDFS-14035-HDFS-12943.002.patch, HDFS-14035-HDFS-12943.003.patch, > HDFS-14035-HDFS-12943.004.patch, HDFS-14035-HDFS-12943.005.patch, > HDFS-14035-HDFS-12943.006.patch, HDFS-14035-HDFS-12943.007.patch, > HDFS-14035-HDFS-12943.008.patch, HDFS-14035-HDFS-12943.009.patch, > HDFS-14035-HDFS-12943.010.patch, HDFS-14035-HDFS-12943.011.patch, > HDFS-14035-HDFS-12943.012.patch, HDFS-14035-HDFS-12943.013.patch > > > Currently ObserverReadProxyProvider uses > {{HAServiceProtocol#getServiceStatus}} to get the status of each NN. However > {{HAServiceProtocol}} does not leverage delegation token. So when running an > application on YARN and when YARN node manager makes this call > getServiceStatus, token authentication will fail, causing the application to > fail. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (HDFS-14035) NN status discovery does not leverage delegation token
[ https://issues.apache.org/jira/browse/HDFS-14035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677412#comment-16677412 ] Chen Liang edited comment on HDFS-14035 at 11/6/18 11:32 PM: - Didn't see [~xkrogen]'s comment before posting v008 patch...post v009 patch to address Erik's comments. was (Author: vagarychen): Did see [~xkrogen]'s comment before posting v008 patch...post v009 patch to address Erik's comments. > NN status discovery does not leverage delegation token > -- > > Key: HDFS-14035 > URL: https://issues.apache.org/jira/browse/HDFS-14035 > Project: Hadoop HDFS > Issue Type: Sub-task >Reporter: Chen Liang >Assignee: Chen Liang >Priority: Major > Attachments: HDFS-14035-HDFS-12943.001.patch, > HDFS-14035-HDFS-12943.002.patch, HDFS-14035-HDFS-12943.003.patch, > HDFS-14035-HDFS-12943.004.patch, HDFS-14035-HDFS-12943.005.patch, > HDFS-14035-HDFS-12943.006.patch, HDFS-14035-HDFS-12943.007.patch, > HDFS-14035-HDFS-12943.008.patch, HDFS-14035-HDFS-12943.009.patch > > > Currently ObserverReadProxyProvider uses > {{HAServiceProtocol#getServiceStatus}} to get the status of each NN. However > {{HAServiceProtocol}} does not leverage delegation token. So when running an > application on YARN and when YARN node manager makes this call > getServiceStatus, token authentication will fail, causing the application to > fail. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Comment Edited] (HDFS-14035) NN status discovery does not leverage delegation token
[ https://issues.apache.org/jira/browse/HDFS-14035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677380#comment-16677380 ] Erik Krogen edited comment on HDFS-14035 at 11/6/18 10:50 PM: -- This approach LGTM, thanks [~vagarychen]! A few comments: * -Within NNProxyInfo, we changed serviceProxy from a HAServiceProtocol to a {{ClientProtocol}}, should we also change the field name?- I think [~shv]'s point #1 is actually more valid and supersedes this * Should {{ClientProtocol#getHAServiceState()}} be annotated {{@ReadOnly(isCoordinated = false)}} ? * You changed {{HAServiceProtocol.HAServiceState}} to include a {{static}} modifier, but it is redundant as {{HAServiceProtocol}} is an interface so all inner classes are static (also all inner enums are static regardless of whether their container is an interface). was (Author: xkrogen): This approach LGTM, thanks [~vagarychen]! A few comments: * Within {{NNProxyInfo}}, we changed {{serviceProxy}} from a {{HAServiceProtocol}} to a {{ClientProtocol}}, should we also change the field name? * Should {{ClientProtocol#getHAServiceState()}} be annotated {{@ReadOnly(isCoordinated = false)}} ? * You changed {{HAServiceProtocol.HAServiceState}} to include a {{static}} modifier, but it is redundant as {{HAServiceProtocol}} is an interface so all inner classes are static (also all inner enums are static regardless of whether their container is an interface). > NN status discovery does not leverage delegation token > -- > > Key: HDFS-14035 > URL: https://issues.apache.org/jira/browse/HDFS-14035 > Project: Hadoop HDFS > Issue Type: Sub-task >Reporter: Chen Liang >Assignee: Chen Liang >Priority: Major > Attachments: HDFS-14035-HDFS-12943.001.patch, > HDFS-14035-HDFS-12943.002.patch, HDFS-14035-HDFS-12943.003.patch, > HDFS-14035-HDFS-12943.004.patch, HDFS-14035-HDFS-12943.005.patch, > HDFS-14035-HDFS-12943.006.patch, HDFS-14035-HDFS-12943.007.patch > > > Currently ObserverReadProxyProvider uses > {{HAServiceProtocol#getServiceStatus}} to get the status of each NN. However > {{HAServiceProtocol}} does not leverage delegation token. So when running an > application on YARN and when YARN node manager makes this call > getServiceStatus, token authentication will fail, causing the application to > fail. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org