[jira] [Commented] (HBASE-21634) Print error message when user uses unacceptable values for LIMIT while setting quotas.
[ https://issues.apache.org/jira/browse/HBASE-21634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16757447#comment-16757447 ] Hudson commented on HBASE-21634: Results for branch branch-2.1 [build #818 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/818/]: (x) *{color:red}-1 overall{color}* details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/818//General_Nightly_Build_Report/] (/) {color:green}+1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/818//JDK8_Nightly_Build_Report_(Hadoop2)/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/818//JDK8_Nightly_Build_Report_(Hadoop3)/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > Print error message when user uses unacceptable values for LIMIT while > setting quotas. > -- > > Key: HBASE-21634 > URL: https://issues.apache.org/jira/browse/HBASE-21634 > Project: HBase > Issue Type: Improvement >Reporter: Sakthi >Assignee: Sakthi >Priority: Minor > Fix For: 3.0.0, 2.2.0, 2.1.3, 2.0.5, 2.3.0 > > Attachments: hbase-21634.branch-2.0.001.patch, > hbase-21634.branch-2.0.002.patch, hbase-21634.master.001.patch, > hbase-21634.master.002.patch, hbase-21634.master.003.patch, > hbase-21634.master.004.patch > > > When unacceptable value(like 2.3G or 70H) to LIMIT are passed while setting > quotas, we currently do not print any error message (informing the user about > the erroneous input). Like below: > {noformat} > hbase(main):002:0> set_quota TYPE => SPACE, TABLE => 't2', LIMIT => '2.3G', > POLICY => NO_WRITES > Took 0.0792 seconds > hbase(main):003:0> list_quotas > OWNERQUOTAS > TABLE => t2 TYPE => SPACE, > TABLE => t2, LIMIT => 2B, VIOLATION_POLICY => NO_WRITES > 1 row(s) > Took 0.0512 seconds > hbase(main):006:0> set_quota TYPE => SPACE, TABLE => 't2', LIMIT => '70H', > POLICY => NO_WRITES > Took 0.0088 seconds > hbase(main):007:0> list_quotas > OWNERQUOTAS > TABLE => t2 TYPE => SPACE, > TABLE => t2, LIMIT => 70B, VIOLATION_POLICY => NO_WRITES > 1 row(s) > Took 0.0448 seconds > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21634) Print error message when user uses unacceptable values for LIMIT while setting quotas.
[ https://issues.apache.org/jira/browse/HBASE-21634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16757371#comment-16757371 ] Hudson commented on HBASE-21634: Results for branch branch-2.0 [build #1302 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1302/]: (x) *{color:red}-1 overall{color}* details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1302//General_Nightly_Build_Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1302//JDK8_Nightly_Build_Report_(Hadoop2)/] (/) {color:green}+1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1302//JDK8_Nightly_Build_Report_(Hadoop3)/] (/) {color:green}+1 source release artifact{color} -- See build output for details. > Print error message when user uses unacceptable values for LIMIT while > setting quotas. > -- > > Key: HBASE-21634 > URL: https://issues.apache.org/jira/browse/HBASE-21634 > Project: HBase > Issue Type: Improvement >Reporter: Sakthi >Assignee: Sakthi >Priority: Minor > Fix For: 3.0.0, 2.2.0, 2.1.3, 2.0.5, 2.3.0 > > Attachments: hbase-21634.branch-2.0.001.patch, > hbase-21634.branch-2.0.002.patch, hbase-21634.master.001.patch, > hbase-21634.master.002.patch, hbase-21634.master.003.patch, > hbase-21634.master.004.patch > > > When unacceptable value(like 2.3G or 70H) to LIMIT are passed while setting > quotas, we currently do not print any error message (informing the user about > the erroneous input). Like below: > {noformat} > hbase(main):002:0> set_quota TYPE => SPACE, TABLE => 't2', LIMIT => '2.3G', > POLICY => NO_WRITES > Took 0.0792 seconds > hbase(main):003:0> list_quotas > OWNERQUOTAS > TABLE => t2 TYPE => SPACE, > TABLE => t2, LIMIT => 2B, VIOLATION_POLICY => NO_WRITES > 1 row(s) > Took 0.0512 seconds > hbase(main):006:0> set_quota TYPE => SPACE, TABLE => 't2', LIMIT => '70H', > POLICY => NO_WRITES > Took 0.0088 seconds > hbase(main):007:0> list_quotas > OWNERQUOTAS > TABLE => t2 TYPE => SPACE, > TABLE => t2, LIMIT => 70B, VIOLATION_POLICY => NO_WRITES > 1 row(s) > Took 0.0448 seconds > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21634) Print error message when user uses unacceptable values for LIMIT while setting quotas.
[ https://issues.apache.org/jira/browse/HBASE-21634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16756787#comment-16756787 ] Wellington Chevreuil commented on HBASE-21634: -- lgtm, +1. > Print error message when user uses unacceptable values for LIMIT while > setting quotas. > -- > > Key: HBASE-21634 > URL: https://issues.apache.org/jira/browse/HBASE-21634 > Project: HBase > Issue Type: Improvement >Reporter: Sakthi >Assignee: Sakthi >Priority: Minor > Fix For: 3.0.0, 2.2.0 > > Attachments: hbase-21634.branch-2.0.001.patch, > hbase-21634.branch-2.0.002.patch, hbase-21634.master.001.patch, > hbase-21634.master.002.patch, hbase-21634.master.003.patch, > hbase-21634.master.004.patch > > > When unacceptable value(like 2.3G or 70H) to LIMIT are passed while setting > quotas, we currently do not print any error message (informing the user about > the erroneous input). Like below: > {noformat} > hbase(main):002:0> set_quota TYPE => SPACE, TABLE => 't2', LIMIT => '2.3G', > POLICY => NO_WRITES > Took 0.0792 seconds > hbase(main):003:0> list_quotas > OWNERQUOTAS > TABLE => t2 TYPE => SPACE, > TABLE => t2, LIMIT => 2B, VIOLATION_POLICY => NO_WRITES > 1 row(s) > Took 0.0512 seconds > hbase(main):006:0> set_quota TYPE => SPACE, TABLE => 't2', LIMIT => '70H', > POLICY => NO_WRITES > Took 0.0088 seconds > hbase(main):007:0> list_quotas > OWNERQUOTAS > TABLE => t2 TYPE => SPACE, > TABLE => t2, LIMIT => 70B, VIOLATION_POLICY => NO_WRITES > 1 row(s) > Took 0.0448 seconds > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21634) Print error message when user uses unacceptable values for LIMIT while setting quotas.
[ https://issues.apache.org/jira/browse/HBASE-21634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16756675#comment-16756675 ] Hadoop QA commented on HBASE-21634: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 12s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} branch-2.0 Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m 51s{color} | {color:green} branch-2.0 passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 21s{color} | {color:green} branch-2.0 passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 52s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} rubocop {color} | {color:green} 0m 9s{color} | {color:green} The patch generated 0 new + 111 unchanged - 11 fixed = 111 total (was 122) {color} | | {color:orange}-0{color} | {color:orange} ruby-lint {color} | {color:orange} 0m 6s{color} | {color:orange} The patch generated 82 new + 220 unchanged - 7 fixed = 302 total (was 227) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 10s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 6m 49s{color} | {color:green} hbase-shell in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 15s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 17m 4s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:6f01af0 | | JIRA Issue | HBASE-21634 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12956969/hbase-21634.branch-2.0.002.patch | | Optional Tests | dupname asflicense javac javadoc unit rubocop ruby_lint | | uname | Linux a90d543580e3 4.4.0-139-generic #165~14.04.1-Ubuntu SMP Wed Oct 31 10:55:11 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | branch-2.0 / d94a719e8f | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Default Java | 1.8.0_181 | | rubocop | v0.60.0 | | ruby-lint | v2.3.1 | | ruby-lint | https://builds.apache.org/job/PreCommit-HBASE-Build/15797/artifact/patchprocess/diff-patch-ruby-lint.txt | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/15797/testReport/ | | Max. process+thread count | 2105 (vs. ulimit of 1) | | modules | C: hbase-shell U: hbase-shell | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/15797/console | | Powered by | Apache Yetus 0.8.0 http://yetus.apache.org | This message was automatically generated. > Print error message when user uses unacceptable values for LIMIT while > setting quotas. > -- > > Key: HBASE-21634 > URL: https://issues.apache.org/jira/browse/HBASE-21634 > Project: HBase > Issue Type: Improvement >Reporter: Sakthi >Assignee: Sakthi >Priority: Minor > Fix For: 3.0.0, 2.2.0 > > Attachments: hbase-21634.branch-2.0.001.patch, > hbase-21634.branch-2.0.002.patch, hbase-21634.master.001.patch, > hbase-21634.master.002.patch, hbase-21634.master.003.patch, > hbase-21634.master.004.patch > > > When unacceptable value(like 2.3G or 70H) to LIMIT are passed while setting > quotas, we currently do not print any error message (informing the user about > the erroneous input). Like below: > {noformat} > hbase(main):002:0> set_quota TYPE => SPACE, TABLE => 't2', LIMIT => '2.3G', > POLICY => NO_WRITES > Took 0.0792 seconds > hbase(main):003:0> list_quotas > OWNER
[jira] [Commented] (HBASE-21634) Print error message when user uses unacceptable values for LIMIT while setting quotas.
[ https://issues.apache.org/jira/browse/HBASE-21634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16755493#comment-16755493 ] Hadoop QA commented on HBASE-21634: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 36s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} branch-2.0 Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m 44s{color} | {color:green} branch-2.0 passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 19s{color} | {color:green} branch-2.0 passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 49s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} rubocop {color} | {color:red} 0m 7s{color} | {color:red} The patch generated 1 new + 113 unchanged - 9 fixed = 114 total (was 122) {color} | | {color:orange}-0{color} | {color:orange} ruby-lint {color} | {color:orange} 0m 6s{color} | {color:orange} The patch generated 82 new + 221 unchanged - 6 fixed = 303 total (was 227) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 9s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red} 13m 30s{color} | {color:red} hbase-shell in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 13s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 24m 50s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.hbase.client.TestAdminShell | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:6f01af0 | | JIRA Issue | HBASE-21634 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12956805/hbase-21634.branch-2.0.001.patch | | Optional Tests | dupname asflicense javac javadoc unit rubocop ruby_lint | | uname | Linux 8d0ba67ca5b8 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh | | git revision | branch-2.0 / 1f2241d714 | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Default Java | 1.8.0_181 | | rubocop | v0.63.1 | | rubocop | https://builds.apache.org/job/PreCommit-HBASE-Build/15775/artifact/patchprocess/diff-patch-rubocop.txt | | ruby-lint | v2.3.1 | | ruby-lint | https://builds.apache.org/job/PreCommit-HBASE-Build/15775/artifact/patchprocess/diff-patch-ruby-lint.txt | | unit | https://builds.apache.org/job/PreCommit-HBASE-Build/15775/artifact/patchprocess/patch-unit-hbase-shell.txt | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/15775/testReport/ | | Max. process+thread count | 2518 (vs. ulimit of 1) | | modules | C: hbase-shell U: hbase-shell | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/15775/console | | Powered by | Apache Yetus 0.8.0 http://yetus.apache.org | This message was automatically generated. > Print error message when user uses unacceptable values for LIMIT while > setting quotas. > -- > > Key: HBASE-21634 > URL: https://issues.apache.org/jira/browse/HBASE-21634 > Project: HBase > Issue Type: Improvement >Reporter: Sakthi >Assignee: Sakthi >Priority: Minor > Fix For: 3.0.0, 2.2.0 > > Attachments: hbase-21634.branch-2.0.001.patch, > hbase-21634.master.001.patch, hbase-21634.master.002.patch, > hbase-21634.master.003.patch, hbase-21634.master.004.patch > > > When unacceptable value(like 2.3G or 70H) to LIMIT are passed while setting > quotas, we currently do not print any error message (informing the user about
[jira] [Commented] (HBASE-21634) Print error message when user uses unacceptable values for LIMIT while setting quotas.
[ https://issues.apache.org/jira/browse/HBASE-21634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16755477#comment-16755477 ] Sakthi commented on HBASE-21634: Have uploaded a patch for branch-2.0 > Print error message when user uses unacceptable values for LIMIT while > setting quotas. > -- > > Key: HBASE-21634 > URL: https://issues.apache.org/jira/browse/HBASE-21634 > Project: HBase > Issue Type: Improvement >Reporter: Sakthi >Assignee: Sakthi >Priority: Minor > Fix For: 3.0.0, 2.2.0 > > Attachments: hbase-21634.branch-2.0.001.patch, > hbase-21634.master.001.patch, hbase-21634.master.002.patch, > hbase-21634.master.003.patch, hbase-21634.master.004.patch > > > When unacceptable value(like 2.3G or 70H) to LIMIT are passed while setting > quotas, we currently do not print any error message (informing the user about > the erroneous input). Like below: > {noformat} > hbase(main):002:0> set_quota TYPE => SPACE, TABLE => 't2', LIMIT => '2.3G', > POLICY => NO_WRITES > Took 0.0792 seconds > hbase(main):003:0> list_quotas > OWNERQUOTAS > TABLE => t2 TYPE => SPACE, > TABLE => t2, LIMIT => 2B, VIOLATION_POLICY => NO_WRITES > 1 row(s) > Took 0.0512 seconds > hbase(main):006:0> set_quota TYPE => SPACE, TABLE => 't2', LIMIT => '70H', > POLICY => NO_WRITES > Took 0.0088 seconds > hbase(main):007:0> list_quotas > OWNERQUOTAS > TABLE => t2 TYPE => SPACE, > TABLE => t2, LIMIT => 70B, VIOLATION_POLICY => NO_WRITES > 1 row(s) > Took 0.0448 seconds > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21634) Print error message when user uses unacceptable values for LIMIT while setting quotas.
[ https://issues.apache.org/jira/browse/HBASE-21634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16743378#comment-16743378 ] Sakthi commented on HBASE-21634: Thanks for pushing [~zghaobac]. I'll work on patches for branch-2.1 & branch-2.0 > Print error message when user uses unacceptable values for LIMIT while > setting quotas. > -- > > Key: HBASE-21634 > URL: https://issues.apache.org/jira/browse/HBASE-21634 > Project: HBase > Issue Type: Improvement >Reporter: Sakthi >Assignee: Sakthi >Priority: Minor > Fix For: 3.0.0, 2.2.0 > > Attachments: hbase-21634.master.001.patch, > hbase-21634.master.002.patch, hbase-21634.master.003.patch, > hbase-21634.master.004.patch > > > When unacceptable value(like 2.3G or 70H) to LIMIT are passed while setting > quotas, we currently do not print any error message (informing the user about > the erroneous input). Like below: > {noformat} > hbase(main):002:0> set_quota TYPE => SPACE, TABLE => 't2', LIMIT => '2.3G', > POLICY => NO_WRITES > Took 0.0792 seconds > hbase(main):003:0> list_quotas > OWNERQUOTAS > TABLE => t2 TYPE => SPACE, > TABLE => t2, LIMIT => 2B, VIOLATION_POLICY => NO_WRITES > 1 row(s) > Took 0.0512 seconds > hbase(main):006:0> set_quota TYPE => SPACE, TABLE => 't2', LIMIT => '70H', > POLICY => NO_WRITES > Took 0.0088 seconds > hbase(main):007:0> list_quotas > OWNERQUOTAS > TABLE => t2 TYPE => SPACE, > TABLE => t2, LIMIT => 70B, VIOLATION_POLICY => NO_WRITES > 1 row(s) > Took 0.0448 seconds > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21634) Print error message when user uses unacceptable values for LIMIT while setting quotas.
[ https://issues.apache.org/jira/browse/HBASE-21634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16742834#comment-16742834 ] Hudson commented on HBASE-21634: Results for branch branch-2 [build #1611 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1611/]: (x) *{color:red}-1 overall{color}* details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1611//General_Nightly_Build_Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1611//JDK8_Nightly_Build_Report_(Hadoop2)/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1611//JDK8_Nightly_Build_Report_(Hadoop3)/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > Print error message when user uses unacceptable values for LIMIT while > setting quotas. > -- > > Key: HBASE-21634 > URL: https://issues.apache.org/jira/browse/HBASE-21634 > Project: HBase > Issue Type: Improvement >Reporter: Sakthi >Assignee: Sakthi >Priority: Minor > Fix For: 3.0.0, 2.2.0 > > Attachments: hbase-21634.master.001.patch, > hbase-21634.master.002.patch, hbase-21634.master.003.patch, > hbase-21634.master.004.patch > > > When unacceptable value(like 2.3G or 70H) to LIMIT are passed while setting > quotas, we currently do not print any error message (informing the user about > the erroneous input). Like below: > {noformat} > hbase(main):002:0> set_quota TYPE => SPACE, TABLE => 't2', LIMIT => '2.3G', > POLICY => NO_WRITES > Took 0.0792 seconds > hbase(main):003:0> list_quotas > OWNERQUOTAS > TABLE => t2 TYPE => SPACE, > TABLE => t2, LIMIT => 2B, VIOLATION_POLICY => NO_WRITES > 1 row(s) > Took 0.0512 seconds > hbase(main):006:0> set_quota TYPE => SPACE, TABLE => 't2', LIMIT => '70H', > POLICY => NO_WRITES > Took 0.0088 seconds > hbase(main):007:0> list_quotas > OWNERQUOTAS > TABLE => t2 TYPE => SPACE, > TABLE => t2, LIMIT => 70B, VIOLATION_POLICY => NO_WRITES > 1 row(s) > Took 0.0448 seconds > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21634) Print error message when user uses unacceptable values for LIMIT while setting quotas.
[ https://issues.apache.org/jira/browse/HBASE-21634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16742813#comment-16742813 ] Hudson commented on HBASE-21634: Results for branch master [build #720 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/720/]: (x) *{color:red}-1 overall{color}* details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/master/720//General_Nightly_Build_Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/master/720//JDK8_Nightly_Build_Report_(Hadoop2)/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/master/720//JDK8_Nightly_Build_Report_(Hadoop3)/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > Print error message when user uses unacceptable values for LIMIT while > setting quotas. > -- > > Key: HBASE-21634 > URL: https://issues.apache.org/jira/browse/HBASE-21634 > Project: HBase > Issue Type: Improvement >Reporter: Sakthi >Assignee: Sakthi >Priority: Minor > Fix For: 3.0.0, 2.2.0 > > Attachments: hbase-21634.master.001.patch, > hbase-21634.master.002.patch, hbase-21634.master.003.patch, > hbase-21634.master.004.patch > > > When unacceptable value(like 2.3G or 70H) to LIMIT are passed while setting > quotas, we currently do not print any error message (informing the user about > the erroneous input). Like below: > {noformat} > hbase(main):002:0> set_quota TYPE => SPACE, TABLE => 't2', LIMIT => '2.3G', > POLICY => NO_WRITES > Took 0.0792 seconds > hbase(main):003:0> list_quotas > OWNERQUOTAS > TABLE => t2 TYPE => SPACE, > TABLE => t2, LIMIT => 2B, VIOLATION_POLICY => NO_WRITES > 1 row(s) > Took 0.0512 seconds > hbase(main):006:0> set_quota TYPE => SPACE, TABLE => 't2', LIMIT => '70H', > POLICY => NO_WRITES > Took 0.0088 seconds > hbase(main):007:0> list_quotas > OWNERQUOTAS > TABLE => t2 TYPE => SPACE, > TABLE => t2, LIMIT => 70B, VIOLATION_POLICY => NO_WRITES > 1 row(s) > Took 0.0448 seconds > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21634) Print error message when user uses unacceptable values for LIMIT while setting quotas.
[ https://issues.apache.org/jira/browse/HBASE-21634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16742668#comment-16742668 ] Guanghao Zhang commented on HBASE-21634: Pushed to master and branch-2. This can't apply to branch-2.1 and branch-2.0? > Print error message when user uses unacceptable values for LIMIT while > setting quotas. > -- > > Key: HBASE-21634 > URL: https://issues.apache.org/jira/browse/HBASE-21634 > Project: HBase > Issue Type: Improvement >Reporter: Sakthi >Assignee: Sakthi >Priority: Minor > Attachments: hbase-21634.master.001.patch, > hbase-21634.master.002.patch, hbase-21634.master.003.patch, > hbase-21634.master.004.patch > > > When unacceptable value(like 2.3G or 70H) to LIMIT are passed while setting > quotas, we currently do not print any error message (informing the user about > the erroneous input). Like below: > {noformat} > hbase(main):002:0> set_quota TYPE => SPACE, TABLE => 't2', LIMIT => '2.3G', > POLICY => NO_WRITES > Took 0.0792 seconds > hbase(main):003:0> list_quotas > OWNERQUOTAS > TABLE => t2 TYPE => SPACE, > TABLE => t2, LIMIT => 2B, VIOLATION_POLICY => NO_WRITES > 1 row(s) > Took 0.0512 seconds > hbase(main):006:0> set_quota TYPE => SPACE, TABLE => 't2', LIMIT => '70H', > POLICY => NO_WRITES > Took 0.0088 seconds > hbase(main):007:0> list_quotas > OWNERQUOTAS > TABLE => t2 TYPE => SPACE, > TABLE => t2, LIMIT => 70B, VIOLATION_POLICY => NO_WRITES > 1 row(s) > Took 0.0448 seconds > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21634) Print error message when user uses unacceptable values for LIMIT while setting quotas.
[ https://issues.apache.org/jira/browse/HBASE-21634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16742657#comment-16742657 ] Guanghao Zhang commented on HBASE-21634: Let me commit it. Thanks [~jatsakthi] for contributing. > Print error message when user uses unacceptable values for LIMIT while > setting quotas. > -- > > Key: HBASE-21634 > URL: https://issues.apache.org/jira/browse/HBASE-21634 > Project: HBase > Issue Type: Improvement >Reporter: Sakthi >Assignee: Sakthi >Priority: Minor > Attachments: hbase-21634.master.001.patch, > hbase-21634.master.002.patch, hbase-21634.master.003.patch, > hbase-21634.master.004.patch > > > When unacceptable value(like 2.3G or 70H) to LIMIT are passed while setting > quotas, we currently do not print any error message (informing the user about > the erroneous input). Like below: > {noformat} > hbase(main):002:0> set_quota TYPE => SPACE, TABLE => 't2', LIMIT => '2.3G', > POLICY => NO_WRITES > Took 0.0792 seconds > hbase(main):003:0> list_quotas > OWNERQUOTAS > TABLE => t2 TYPE => SPACE, > TABLE => t2, LIMIT => 2B, VIOLATION_POLICY => NO_WRITES > 1 row(s) > Took 0.0512 seconds > hbase(main):006:0> set_quota TYPE => SPACE, TABLE => 't2', LIMIT => '70H', > POLICY => NO_WRITES > Took 0.0088 seconds > hbase(main):007:0> list_quotas > OWNERQUOTAS > TABLE => t2 TYPE => SPACE, > TABLE => t2, LIMIT => 70B, VIOLATION_POLICY => NO_WRITES > 1 row(s) > Took 0.0448 seconds > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21634) Print error message when user uses unacceptable values for LIMIT while setting quotas.
[ https://issues.apache.org/jira/browse/HBASE-21634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16742646#comment-16742646 ] Sakthi commented on HBASE-21634: [~zghaobac], please let me know if anything else is required before pushing in :) > Print error message when user uses unacceptable values for LIMIT while > setting quotas. > -- > > Key: HBASE-21634 > URL: https://issues.apache.org/jira/browse/HBASE-21634 > Project: HBase > Issue Type: Improvement >Reporter: Sakthi >Assignee: Sakthi >Priority: Minor > Attachments: hbase-21634.master.001.patch, > hbase-21634.master.002.patch, hbase-21634.master.003.patch, > hbase-21634.master.004.patch > > > When unacceptable value(like 2.3G or 70H) to LIMIT are passed while setting > quotas, we currently do not print any error message (informing the user about > the erroneous input). Like below: > {noformat} > hbase(main):002:0> set_quota TYPE => SPACE, TABLE => 't2', LIMIT => '2.3G', > POLICY => NO_WRITES > Took 0.0792 seconds > hbase(main):003:0> list_quotas > OWNERQUOTAS > TABLE => t2 TYPE => SPACE, > TABLE => t2, LIMIT => 2B, VIOLATION_POLICY => NO_WRITES > 1 row(s) > Took 0.0512 seconds > hbase(main):006:0> set_quota TYPE => SPACE, TABLE => 't2', LIMIT => '70H', > POLICY => NO_WRITES > Took 0.0088 seconds > hbase(main):007:0> list_quotas > OWNERQUOTAS > TABLE => t2 TYPE => SPACE, > TABLE => t2, LIMIT => 70B, VIOLATION_POLICY => NO_WRITES > 1 row(s) > Took 0.0448 seconds > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21634) Print error message when user uses unacceptable values for LIMIT while setting quotas.
[ https://issues.apache.org/jira/browse/HBASE-21634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16741726#comment-16741726 ] Guanghao Zhang commented on HBASE-21634: +1 > Print error message when user uses unacceptable values for LIMIT while > setting quotas. > -- > > Key: HBASE-21634 > URL: https://issues.apache.org/jira/browse/HBASE-21634 > Project: HBase > Issue Type: Improvement >Reporter: Sakthi >Assignee: Sakthi >Priority: Minor > Attachments: hbase-21634.master.001.patch, > hbase-21634.master.002.patch, hbase-21634.master.003.patch, > hbase-21634.master.004.patch > > > When unacceptable value(like 2.3G or 70H) to LIMIT are passed while setting > quotas, we currently do not print any error message (informing the user about > the erroneous input). Like below: > {noformat} > hbase(main):002:0> set_quota TYPE => SPACE, TABLE => 't2', LIMIT => '2.3G', > POLICY => NO_WRITES > Took 0.0792 seconds > hbase(main):003:0> list_quotas > OWNERQUOTAS > TABLE => t2 TYPE => SPACE, > TABLE => t2, LIMIT => 2B, VIOLATION_POLICY => NO_WRITES > 1 row(s) > Took 0.0512 seconds > hbase(main):006:0> set_quota TYPE => SPACE, TABLE => 't2', LIMIT => '70H', > POLICY => NO_WRITES > Took 0.0088 seconds > hbase(main):007:0> list_quotas > OWNERQUOTAS > TABLE => t2 TYPE => SPACE, > TABLE => t2, LIMIT => 70B, VIOLATION_POLICY => NO_WRITES > 1 row(s) > Took 0.0448 seconds > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21634) Print error message when user uses unacceptable values for LIMIT while setting quotas.
[ https://issues.apache.org/jira/browse/HBASE-21634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16740925#comment-16740925 ] Sakthi commented on HBASE-21634: [~zghaobac] / [~elserj] Mind taking a look at the patch? Thanks. > Print error message when user uses unacceptable values for LIMIT while > setting quotas. > -- > > Key: HBASE-21634 > URL: https://issues.apache.org/jira/browse/HBASE-21634 > Project: HBase > Issue Type: Improvement >Reporter: Sakthi >Assignee: Sakthi >Priority: Minor > Attachments: hbase-21634.master.001.patch, > hbase-21634.master.002.patch, hbase-21634.master.003.patch, > hbase-21634.master.004.patch > > > When unacceptable value(like 2.3G or 70H) to LIMIT are passed while setting > quotas, we currently do not print any error message (informing the user about > the erroneous input). Like below: > {noformat} > hbase(main):002:0> set_quota TYPE => SPACE, TABLE => 't2', LIMIT => '2.3G', > POLICY => NO_WRITES > Took 0.0792 seconds > hbase(main):003:0> list_quotas > OWNERQUOTAS > TABLE => t2 TYPE => SPACE, > TABLE => t2, LIMIT => 2B, VIOLATION_POLICY => NO_WRITES > 1 row(s) > Took 0.0512 seconds > hbase(main):006:0> set_quota TYPE => SPACE, TABLE => 't2', LIMIT => '70H', > POLICY => NO_WRITES > Took 0.0088 seconds > hbase(main):007:0> list_quotas > OWNERQUOTAS > TABLE => t2 TYPE => SPACE, > TABLE => t2, LIMIT => 70B, VIOLATION_POLICY => NO_WRITES > 1 row(s) > Took 0.0448 seconds > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21634) Print error message when user uses unacceptable values for LIMIT while setting quotas.
[ https://issues.apache.org/jira/browse/HBASE-21634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16738512#comment-16738512 ] Hadoop QA commented on HBASE-21634: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 12s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m 13s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 11s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m 6s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} rubocop {color} | {color:green} 0m 9s{color} | {color:green} The patch generated 0 new + 116 unchanged - 9 fixed = 116 total (was 125) {color} | | {color:orange}-0{color} | {color:orange} ruby-lint {color} | {color:orange} 0m 7s{color} | {color:orange} The patch generated 82 new + 272 unchanged - 6 fixed = 354 total (was 278) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 11s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 7m 0s{color} | {color:green} hbase-shell in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 10s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 18m 38s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b | | JIRA Issue | HBASE-21634 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12954338/hbase-21634.master.004.patch | | Optional Tests | dupname asflicense javac javadoc unit rubocop ruby_lint | | uname | Linux 179f0d091e29 4.4.0-139-generic #165~14.04.1-Ubuntu SMP Wed Oct 31 10:55:11 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | master / 620d70d618 | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Default Java | 1.8.0_181 | | rubocop | v0.60.0 | | ruby-lint | v2.3.1 | | ruby-lint | https://builds.apache.org/job/PreCommit-HBASE-Build/15525/artifact/patchprocess/diff-patch-ruby-lint.txt | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/15525/testReport/ | | Max. process+thread count | 2672 (vs. ulimit of 1) | | modules | C: hbase-shell U: hbase-shell | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/15525/console | | Powered by | Apache Yetus 0.8.0 http://yetus.apache.org | This message was automatically generated. > Print error message when user uses unacceptable values for LIMIT while > setting quotas. > -- > > Key: HBASE-21634 > URL: https://issues.apache.org/jira/browse/HBASE-21634 > Project: HBase > Issue Type: Improvement >Reporter: Sakthi >Assignee: Sakthi >Priority: Minor > Attachments: hbase-21634.master.001.patch, > hbase-21634.master.002.patch, hbase-21634.master.003.patch, > hbase-21634.master.004.patch > > > When unacceptable value(like 2.3G or 70H) to LIMIT are passed while setting > quotas, we currently do not print any error message (informing the user about > the erroneous input). Like below: > {noformat} > hbase(main):002:0> set_quota TYPE => SPACE, TABLE => 't2', LIMIT => '2.3G', > POLICY => NO_WRITES > Took 0.0792 seconds > hbase(main):003:0> list_quotas > OWNERQUOTAS > TABLE => t2 TYPE => SPACE, > TABLE => t2, LIMIT => 2B, VIOLATION_PO
[jira] [Commented] (HBASE-21634) Print error message when user uses unacceptable values for LIMIT while setting quotas.
[ https://issues.apache.org/jira/browse/HBASE-21634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16738051#comment-16738051 ] Hadoop QA commented on HBASE-21634: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 11s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 38s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 10s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 50s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} rubocop {color} | {color:red} 0m 7s{color} | {color:red} The patch generated 8 new + 116 unchanged - 9 fixed = 124 total (was 125) {color} | | {color:orange}-0{color} | {color:orange} ruby-lint {color} | {color:orange} 0m 7s{color} | {color:orange} The patch generated 82 new + 272 unchanged - 6 fixed = 354 total (was 278) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 10s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 8m 5s{color} | {color:green} hbase-shell in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 10s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 18m 44s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b | | JIRA Issue | HBASE-21634 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12954295/hbase-21634.master.003.patch | | Optional Tests | dupname asflicense javac javadoc unit rubocop ruby_lint | | uname | Linux 51dc3331bc84 4.4.0-138-generic #164~14.04.1-Ubuntu SMP Fri Oct 5 08:56:16 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh | | git revision | master / f053003ce7 | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Default Java | 1.8.0_181 | | rubocop | v0.62.0 | | rubocop | https://builds.apache.org/job/PreCommit-HBASE-Build/15519/artifact/patchprocess/diff-patch-rubocop.txt | | ruby-lint | v2.3.1 | | ruby-lint | https://builds.apache.org/job/PreCommit-HBASE-Build/15519/artifact/patchprocess/diff-patch-ruby-lint.txt | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/15519/testReport/ | | Max. process+thread count | 2209 (vs. ulimit of 1) | | modules | C: hbase-shell U: hbase-shell | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/15519/console | | Powered by | Apache Yetus 0.8.0 http://yetus.apache.org | This message was automatically generated. > Print error message when user uses unacceptable values for LIMIT while > setting quotas. > -- > > Key: HBASE-21634 > URL: https://issues.apache.org/jira/browse/HBASE-21634 > Project: HBase > Issue Type: Improvement >Reporter: Sakthi >Assignee: Sakthi >Priority: Minor > Attachments: hbase-21634.master.001.patch, > hbase-21634.master.002.patch, hbase-21634.master.003.patch > > > When unacceptable value(like 2.3G or 70H) to LIMIT are passed while setting > quotas, we currently do not print any error message (informing the user about > the erroneous input). Like below: > {noformat} > hbase(main):002:0> set_quota TYPE => SPACE, TABLE => 't2', LIMIT => '2.3G', > POLICY => NO_WRITES > Took 0.0792 seconds > hbase(main):003:0> list_quotas > OWNERQUOTAS > TABLE => t2
[jira] [Commented] (HBASE-21634) Print error message when user uses unacceptable values for LIMIT while setting quotas.
[ https://issues.apache.org/jira/browse/HBASE-21634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16738017#comment-16738017 ] Sakthi commented on HBASE-21634: Have uploaded a patch with the rubocop fixes and correct assert_raise blocks. > Print error message when user uses unacceptable values for LIMIT while > setting quotas. > -- > > Key: HBASE-21634 > URL: https://issues.apache.org/jira/browse/HBASE-21634 > Project: HBase > Issue Type: Improvement >Reporter: Sakthi >Assignee: Sakthi >Priority: Minor > Attachments: hbase-21634.master.001.patch, > hbase-21634.master.002.patch, hbase-21634.master.003.patch > > > When unacceptable value(like 2.3G or 70H) to LIMIT are passed while setting > quotas, we currently do not print any error message (informing the user about > the erroneous input). Like below: > {noformat} > hbase(main):002:0> set_quota TYPE => SPACE, TABLE => 't2', LIMIT => '2.3G', > POLICY => NO_WRITES > Took 0.0792 seconds > hbase(main):003:0> list_quotas > OWNERQUOTAS > TABLE => t2 TYPE => SPACE, > TABLE => t2, LIMIT => 2B, VIOLATION_POLICY => NO_WRITES > 1 row(s) > Took 0.0512 seconds > hbase(main):006:0> set_quota TYPE => SPACE, TABLE => 't2', LIMIT => '70H', > POLICY => NO_WRITES > Took 0.0088 seconds > hbase(main):007:0> list_quotas > OWNERQUOTAS > TABLE => t2 TYPE => SPACE, > TABLE => t2, LIMIT => 70B, VIOLATION_POLICY => NO_WRITES > 1 row(s) > Took 0.0448 seconds > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21634) Print error message when user uses unacceptable values for LIMIT while setting quotas.
[ https://issues.apache.org/jira/browse/HBASE-21634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16737986#comment-16737986 ] Hadoop QA commented on HBASE-21634: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 10s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 36s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 9s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 39s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} rubocop {color} | {color:red} 0m 7s{color} | {color:red} The patch generated 1 new + 123 unchanged - 2 fixed = 124 total (was 125) {color} | | {color:orange}-0{color} | {color:orange} ruby-lint {color} | {color:orange} 0m 7s{color} | {color:orange} The patch generated 59 new + 272 unchanged - 6 fixed = 331 total (was 278) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 10s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 7m 59s{color} | {color:green} hbase-shell in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 8s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 18m 22s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b | | JIRA Issue | HBASE-21634 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12954292/hbase-21634.master.002.patch | | Optional Tests | dupname asflicense javac javadoc unit rubocop ruby_lint | | uname | Linux b30fa4397ec9 4.4.0-138-generic #164~14.04.1-Ubuntu SMP Fri Oct 5 08:56:16 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | master / f053003ce7 | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Default Java | 1.8.0_181 | | rubocop | v0.62.0 | | rubocop | https://builds.apache.org/job/PreCommit-HBASE-Build/15517/artifact/patchprocess/diff-patch-rubocop.txt | | ruby-lint | v2.3.1 | | ruby-lint | https://builds.apache.org/job/PreCommit-HBASE-Build/15517/artifact/patchprocess/diff-patch-ruby-lint.txt | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/15517/testReport/ | | Max. process+thread count | 2219 (vs. ulimit of 1) | | modules | C: hbase-shell U: hbase-shell | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/15517/console | | Powered by | Apache Yetus 0.8.0 http://yetus.apache.org | This message was automatically generated. > Print error message when user uses unacceptable values for LIMIT while > setting quotas. > -- > > Key: HBASE-21634 > URL: https://issues.apache.org/jira/browse/HBASE-21634 > Project: HBase > Issue Type: Improvement >Reporter: Sakthi >Assignee: Sakthi >Priority: Minor > Attachments: hbase-21634.master.001.patch, > hbase-21634.master.002.patch > > > When unacceptable value(like 2.3G or 70H) to LIMIT are passed while setting > quotas, we currently do not print any error message (informing the user about > the erroneous input). Like below: > {noformat} > hbase(main):002:0> set_quota TYPE => SPACE, TABLE => 't2', LIMIT => '2.3G', > POLICY => NO_WRITES > Took 0.0792 seconds > hbase(main):003:0> list_quotas > OWNERQUOTAS > TABLE => t2 TYPE => SPA
[jira] [Commented] (HBASE-21634) Print error message when user uses unacceptable values for LIMIT while setting quotas.
[ https://issues.apache.org/jira/browse/HBASE-21634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16737991#comment-16737991 ] Sakthi commented on HBASE-21634: Yes, you are right [~nihaljain.cs], will make the change. Thanks for pointing out. > Print error message when user uses unacceptable values for LIMIT while > setting quotas. > -- > > Key: HBASE-21634 > URL: https://issues.apache.org/jira/browse/HBASE-21634 > Project: HBase > Issue Type: Improvement >Reporter: Sakthi >Assignee: Sakthi >Priority: Minor > Attachments: hbase-21634.master.001.patch, > hbase-21634.master.002.patch > > > When unacceptable value(like 2.3G or 70H) to LIMIT are passed while setting > quotas, we currently do not print any error message (informing the user about > the erroneous input). Like below: > {noformat} > hbase(main):002:0> set_quota TYPE => SPACE, TABLE => 't2', LIMIT => '2.3G', > POLICY => NO_WRITES > Took 0.0792 seconds > hbase(main):003:0> list_quotas > OWNERQUOTAS > TABLE => t2 TYPE => SPACE, > TABLE => t2, LIMIT => 2B, VIOLATION_POLICY => NO_WRITES > 1 row(s) > Took 0.0512 seconds > hbase(main):006:0> set_quota TYPE => SPACE, TABLE => 't2', LIMIT => '70H', > POLICY => NO_WRITES > Took 0.0088 seconds > hbase(main):007:0> list_quotas > OWNERQUOTAS > TABLE => t2 TYPE => SPACE, > TABLE => t2, LIMIT => 70B, VIOLATION_POLICY => NO_WRITES > 1 row(s) > Took 0.0448 seconds > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21634) Print error message when user uses unacceptable values for LIMIT while setting quotas.
[ https://issues.apache.org/jira/browse/HBASE-21634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16737981#comment-16737981 ] Nihal Jain commented on HBASE-21634: [~jatsakthi] Each command should have its own assert_raise block. Right? > Print error message when user uses unacceptable values for LIMIT while > setting quotas. > -- > > Key: HBASE-21634 > URL: https://issues.apache.org/jira/browse/HBASE-21634 > Project: HBase > Issue Type: Improvement >Reporter: Sakthi >Assignee: Sakthi >Priority: Minor > Attachments: hbase-21634.master.001.patch, > hbase-21634.master.002.patch > > > When unacceptable value(like 2.3G or 70H) to LIMIT are passed while setting > quotas, we currently do not print any error message (informing the user about > the erroneous input). Like below: > {noformat} > hbase(main):002:0> set_quota TYPE => SPACE, TABLE => 't2', LIMIT => '2.3G', > POLICY => NO_WRITES > Took 0.0792 seconds > hbase(main):003:0> list_quotas > OWNERQUOTAS > TABLE => t2 TYPE => SPACE, > TABLE => t2, LIMIT => 2B, VIOLATION_POLICY => NO_WRITES > 1 row(s) > Took 0.0512 seconds > hbase(main):006:0> set_quota TYPE => SPACE, TABLE => 't2', LIMIT => '70H', > POLICY => NO_WRITES > Took 0.0088 seconds > hbase(main):007:0> list_quotas > OWNERQUOTAS > TABLE => t2 TYPE => SPACE, > TABLE => t2, LIMIT => 70B, VIOLATION_POLICY => NO_WRITES > 1 row(s) > Took 0.0448 seconds > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21634) Print error message when user uses unacceptable values for LIMIT while setting quotas.
[ https://issues.apache.org/jira/browse/HBASE-21634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16737774#comment-16737774 ] Hadoop QA commented on HBASE-21634: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 10s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m 12s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 10s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m 34s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} rubocop {color} | {color:red} 0m 9s{color} | {color:red} The patch generated 9 new + 124 unchanged - 1 fixed = 133 total (was 125) {color} | | {color:orange}-0{color} | {color:orange} ruby-lint {color} | {color:orange} 0m 8s{color} | {color:orange} The patch generated 48 new + 278 unchanged - 0 fixed = 326 total (was 278) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 12s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 8m 20s{color} | {color:green} hbase-shell in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 10s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 20m 22s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b | | JIRA Issue | HBASE-21634 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12954255/hbase-21634.master.001.patch | | Optional Tests | dupname asflicense javac javadoc unit rubocop ruby_lint | | uname | Linux 23ab8747e8e2 4.4.0-138-generic #164~14.04.1-Ubuntu SMP Fri Oct 5 08:56:16 UTC 2018 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | master / ebe3d1d1d9 | | maven | version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) | | Default Java | 1.8.0_181 | | rubocop | v0.62.0 | | rubocop | https://builds.apache.org/job/PreCommit-HBASE-Build/15509/artifact/patchprocess/diff-patch-rubocop.txt | | ruby-lint | v2.3.1 | | ruby-lint | https://builds.apache.org/job/PreCommit-HBASE-Build/15509/artifact/patchprocess/diff-patch-ruby-lint.txt | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/15509/testReport/ | | Max. process+thread count | 2226 (vs. ulimit of 1) | | modules | C: hbase-shell U: hbase-shell | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/15509/console | | Powered by | Apache Yetus 0.8.0 http://yetus.apache.org | This message was automatically generated. > Print error message when user uses unacceptable values for LIMIT while > setting quotas. > -- > > Key: HBASE-21634 > URL: https://issues.apache.org/jira/browse/HBASE-21634 > Project: HBase > Issue Type: Improvement >Reporter: Sakthi >Assignee: Sakthi >Priority: Minor > Attachments: hbase-21634.master.001.patch > > > When unacceptable value(like 2.3G or 70H) to LIMIT are passed while setting > quotas, we currently do not print any error message (informing the user about > the erroneous input). Like below: > {noformat} > hbase(main):002:0> set_quota TYPE => SPACE, TABLE => 't2', LIMIT => '2.3G', > POLICY => NO_WRITES > Took 0.0792 seconds > hbase(main):003:0> list_quotas > OWNERQUOTAS > TABLE => t2 TYPE => SPACE, > TABLE => t2, LIMIT => 2B,
[jira] [Commented] (HBASE-21634) Print error message when user uses unacceptable values for LIMIT while setting quotas.
[ https://issues.apache.org/jira/browse/HBASE-21634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16727793#comment-16727793 ] Sakthi commented on HBASE-21634: We can either * just throw exception saying "Invalid value xyz for LIMIT. Not updating quotas." * Or we can accept them as bytes (like we are already doing) and print out a warning message saying: "Invalid value xyz for LIMIT. Setting LIMIT to abc bytes.' I prefer the second one, where just warning the user would be okay, as the user can always re-run the set-quota command with the updated LIMIT value. > Print error message when user uses unacceptable values for LIMIT while > setting quotas. > -- > > Key: HBASE-21634 > URL: https://issues.apache.org/jira/browse/HBASE-21634 > Project: HBase > Issue Type: Improvement >Reporter: Sakthi >Assignee: Sakthi >Priority: Minor > > When unacceptable value(like 2.3G or 70H) to LIMIT are passed while setting > quotas, we currently do not print any error message (informing the user about > the erroneous input). Like below: > {noformat} > hbase(main):002:0> set_quota TYPE => SPACE, TABLE => 't2', LIMIT => '2.3G', > POLICY => NO_WRITES > Took 0.0792 seconds > hbase(main):003:0> list_quotas > OWNERQUOTAS > TABLE => t2 TYPE => SPACE, > TABLE => t2, LIMIT => 2B, VIOLATION_POLICY => NO_WRITES > 1 row(s) > Took 0.0512 seconds > hbase(main):006:0> set_quota TYPE => SPACE, TABLE => 't2', LIMIT => '70H', > POLICY => NO_WRITES > Took 0.0088 seconds > hbase(main):007:0> list_quotas > OWNERQUOTAS > TABLE => t2 TYPE => SPACE, > TABLE => t2, LIMIT => 70B, VIOLATION_POLICY => NO_WRITES > 1 row(s) > Took 0.0448 seconds > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)