[jira] [Commented] (SCB-991) Optimize args parsing
[ https://issues.apache.org/jira/browse/SCB-991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1878#comment-1878 ] ASF GitHub Bot commented on SCB-991: little-cui commented on issue #471: SCB-991 Optimize args parsing URL: https://github.com/apache/incubator-servicecomb-service-center/pull/471#issuecomment-433835904 > > @xcaspar flag.Parse() is a good idea. > > And import 'grace' to initialize automatically, it is difficult to control the initialization time sequence. > > Here only need to satisfy the grace.go than the core.go first to execute the init function. grace package is a common lib here. if grace init first, then the '-v' flag will be ignored This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Optimize args parsing > - > > Key: SCB-991 > URL: https://issues.apache.org/jira/browse/SCB-991 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-991) Optimize args parsing
[ https://issues.apache.org/jira/browse/SCB-991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1898#comment-1898 ] ASF GitHub Bot commented on SCB-991: xcaspar commented on issue #471: SCB-991 Optimize args parsing URL: https://github.com/apache/incubator-servicecomb-service-center/pull/471#issuecomment-433839578 > > > @xcaspar flag.Parse() is a good idea. > > > And import 'grace' to initialize automatically, it is difficult to control the initialization time sequence. > > > > > > Here only need to satisfy the grace.go than the core.go first to execute the init function. > > grace package is a common lib here. if grace init first, then the '-v' flag will be ignored `import _ "github.com/apache/incubator-servicecomb-service-center/pkg/grace"` will not affect the `-v` flag, because the init function initialization order starts with the imported package. Even if you use `grace.ParseCommandLine()`, the init function in grace.go is executed first, the effect is the same as using `_ "github.com/apache/incubator-servicecomb-service-center/pkg/grace"`. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Optimize args parsing > - > > Key: SCB-991 > URL: https://issues.apache.org/jira/browse/SCB-991 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-991) Optimize args parsing
[
https://issues.apache.org/jira/browse/SCB-991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1992#comment-1992
]
ASF GitHub Bot commented on SCB-991:
little-cui closed pull request #471: SCB-991 Optimize args parsing
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/471
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/server/core/core.go b/server/core/core.go
index 545ceb74..fd313218 100644
--- a/server/core/core.go
+++ b/server/core/core.go
@@ -19,7 +19,8 @@ package core
import (
"flag"
- "github.com/apache/incubator-servicecomb-service-center/pkg/grace"
+ // import the grace package and parse grace cmd line
+ _ "github.com/apache/incubator-servicecomb-service-center/pkg/grace"
"github.com/apache/incubator-servicecomb-service-center/pkg/log"
"github.com/apache/incubator-servicecomb-service-center/version"
"os"
@@ -41,16 +42,12 @@ func Initialize() {
func ParseCommandLine() {
var printVer bool
flag.BoolVar(, "v", false, "Print the version and exit.")
- flag.CommandLine.Init(os.Args[0], flag.ContinueOnError)
- flag.CommandLine.Parse(os.Args[1:])
+ flag.Parse()
if printVer {
version.Ver().Print()
os.Exit(0)
}
-
- // import the grace package and parse grace cmd line
- grace.ParseCommandLine()
}
func handleSignals() {
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Optimize args parsing
> -
>
> Key: SCB-991
> URL: https://issues.apache.org/jira/browse/SCB-991
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Service-Center
>Reporter: little-cui
>Assignee: little-cui
>Priority: Major
> Fix For: service-center-1.1.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-991) Optimize args parsing
[ https://issues.apache.org/jira/browse/SCB-991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1903#comment-1903 ] ASF GitHub Bot commented on SCB-991: little-cui commented on issue #471: SCB-991 Optimize args parsing URL: https://github.com/apache/incubator-servicecomb-service-center/pull/471#issuecomment-433840932 > > > > @xcaspar flag.Parse() is a good idea. > > > > And import 'grace' to initialize automatically, it is difficult to control the initialization time sequence. > > > > > > > > > Here only need to satisfy the grace.go than the core.go first to execute the init function. > > > > > > grace package is a common lib here. if grace init first, then the '-v' flag will be ignored > > `import _ "github.com/apache/incubator-servicecomb-service-center/pkg/grace"` will not affect the `-v` flag, because the init function initialization order starts with the imported package. Even if you use `grace.ParseCommandLine()`, the init function in grace.go is executed first, the effect is the same as using `_ "github.com/apache/incubator-servicecomb-service-center/pkg/grace"`. oooh, i have misunderstood your word. yes! sure we can replace it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Optimize args parsing > - > > Key: SCB-991 > URL: https://issues.apache.org/jira/browse/SCB-991 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-991) Optimize args parsing
[ https://issues.apache.org/jira/browse/SCB-991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1928#comment-1928 ] ASF GitHub Bot commented on SCB-991: codecov-io edited a comment on issue #471: SCB-991 Optimize args parsing URL: https://github.com/apache/incubator-servicecomb-service-center/pull/471#issuecomment-433813466 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/471?src=pr=h1) Report > Merging [#471](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/471?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/ed9a459d51e2e40a9b07bacf3e9d74ffca514f41?src=pr=desc) will **increase** coverage by `0.04%`. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/471?src=pr=tree) ```diff @@Coverage Diff @@ ## master #471 +/- ## == + Coverage 60.34% 60.39% +0.04% == Files 156 156 Lines 1338113379 -2 == + Hits 8075 8080 +5 + Misses 4727 4722 -5 + Partials 579 577 -2 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/471?src=pr=tree) | Coverage Δ | | |---|---|---| | [server/core/core.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/471/diff?src=pr=tree#diff-c2VydmVyL2NvcmUvY29yZS5nbw==) | `0% <0%> (ø)` | :arrow_up: | | [server/plugin/pkg/registry/etcd/tracing.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/471/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvcmVnaXN0cnkvZXRjZC90cmFjaW5nLmdv) | `72.72% <0%> (-9.1%)` | :arrow_down: | | [pkg/log/logrotate.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/471/diff?src=pr=tree#diff-cGtnL2xvZy9sb2dyb3RhdGUuZ28=) | `33.71% <0%> (-0.58%)` | :arrow_down: | | [server/govern/service.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/471/diff?src=pr=tree#diff-c2VydmVyL2dvdmVybi9zZXJ2aWNlLmdv) | `73.33% <0%> (-0.34%)` | :arrow_down: | | [server/broker/util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/471/diff?src=pr=tree#diff-c2VydmVyL2Jyb2tlci91dGlsLmdv) | `53.2% <0%> (-0.27%)` | :arrow_down: | | [server/broker/service.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/471/diff?src=pr=tree#diff-c2VydmVyL2Jyb2tlci9zZXJ2aWNlLmdv) | `57.94% <0%> (+0.15%)` | :arrow_up: | | [pkg/tlsutil/tlsutil.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/471/diff?src=pr=tree#diff-cGtnL3Rsc3V0aWwvdGxzdXRpbC5nbw==) | `74.52% <0%> (+0.94%)` | :arrow_up: | | [...erver/plugin/pkg/tracing/buildin/file\_collector.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/471/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvdHJhY2luZy9idWlsZGluL2ZpbGVfY29sbGVjdG9yLmdv) | `64.07% <0%> (+0.97%)` | :arrow_up: | | [pkg/etcdsync/mutex.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/471/diff?src=pr=tree#diff-cGtnL2V0Y2RzeW5jL211dGV4Lmdv) | `66.66% <0%> (+5.37%)` | :arrow_up: | | [server/service/util/heartbeat\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/471/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9oZWFydGJlYXRfdXRpbC5nbw==) | `80% <0%> (+6.66%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/471?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/471?src=pr=footer). Last update [ed9a459...f366a84](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/471?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Optimize args parsing > - > > Key: SCB-991 > URL:
[jira] [Commented] (SCB-991) Optimize args parsing
[ https://issues.apache.org/jira/browse/SCB-991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1929#comment-1929 ] ASF GitHub Bot commented on SCB-991: coveralls edited a comment on issue #471: SCB-991 Optimize args parsing URL: https://github.com/apache/incubator-servicecomb-service-center/pull/471#issuecomment-433813460 [](https://coveralls.io/builds/19775639) Coverage increased (+0.02%) to 62.878% when pulling **f366a84ab0501ef9bb93325365f632f8191db0ef on little-cui:flag** into **ed9a459d51e2e40a9b07bacf3e9d74ffca514f41 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Optimize args parsing > - > > Key: SCB-991 > URL: https://issues.apache.org/jira/browse/SCB-991 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SCB-992) Synchronous open source code from Vert.x 3.3.5 version
jeho0815 created SCB-992: Summary: Synchronous open source code from Vert.x 3.3.5 version Key: SCB-992 URL: https://issues.apache.org/jira/browse/SCB-992 Project: Apache ServiceComb Issue Type: Task Components: Java-Chassis Reporter: jeho0815 Assignee: jeho0815 Fix For: java-chassis-1.1.0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-992) Synchronous open source code from Vert.x 3.5.3 version
[ https://issues.apache.org/jira/browse/SCB-992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16667017#comment-16667017 ] ASF GitHub Bot commented on SCB-992: jeho0815 opened a new pull request #973: [SCB-992] Synchronous open source code from Vert.x 3.5.3 version URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/973 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Synchronous open source code from Vert.x 3.5.3 version > -- > > Key: SCB-992 > URL: https://issues.apache.org/jira/browse/SCB-992 > Project: Apache ServiceComb > Issue Type: Task > Components: Java-Chassis >Reporter: jeho0815 >Assignee: jeho0815 >Priority: Major > Fix For: java-chassis-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SCB-991) Optimize args parsing
[ https://issues.apache.org/jira/browse/SCB-991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] little-cui resolved SCB-991. Resolution: Fixed > Optimize args parsing > - > > Key: SCB-991 > URL: https://issues.apache.org/jira/browse/SCB-991 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-991) Optimize args parsing
[ https://issues.apache.org/jira/browse/SCB-991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1869#comment-1869 ] ASF GitHub Bot commented on SCB-991: little-cui commented on issue #471: SCB-991 Optimize args parsing URL: https://github.com/apache/incubator-servicecomb-service-center/pull/471#issuecomment-433832056 @xcaspar flag.Parse() is a good idea. And import 'grace' to initialize automatically, it is difficult to control the initialization time sequence. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Optimize args parsing > - > > Key: SCB-991 > URL: https://issues.apache.org/jira/browse/SCB-991 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-991) Optimize args parsing
[ https://issues.apache.org/jira/browse/SCB-991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1884#comment-1884 ] ASF GitHub Bot commented on SCB-991: codecov-io edited a comment on issue #471: SCB-991 Optimize args parsing URL: https://github.com/apache/incubator-servicecomb-service-center/pull/471#issuecomment-433813466 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/471?src=pr=h1) Report > Merging [#471](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/471?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/ed9a459d51e2e40a9b07bacf3e9d74ffca514f41?src=pr=desc) will **increase** coverage by `0.03%`. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/471?src=pr=tree) ```diff @@Coverage Diff @@ ## master #471 +/- ## == + Coverage 60.34% 60.38% +0.03% == Files 156 156 Lines 1338113380 -1 == + Hits 8075 8079 +4 + Misses 4727 4723 -4 + Partials 579 578 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/471?src=pr=tree) | Coverage Δ | | |---|---|---| | [server/core/core.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/471/diff?src=pr=tree#diff-c2VydmVyL2NvcmUvY29yZS5nbw==) | `0% <0%> (ø)` | :arrow_up: | | [server/plugin/pkg/registry/etcd/tracing.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/471/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvcmVnaXN0cnkvZXRjZC90cmFjaW5nLmdv) | `72.72% <0%> (-9.1%)` | :arrow_down: | | [pkg/util/util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/471/diff?src=pr=tree#diff-cGtnL3V0aWwvdXRpbC5nbw==) | `66.21% <0%> (-1.36%)` | :arrow_down: | | [pkg/log/logrotate.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/471/diff?src=pr=tree#diff-cGtnL2xvZy9sb2dyb3RhdGUuZ28=) | `33.71% <0%> (-0.58%)` | :arrow_down: | | [server/broker/util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/471/diff?src=pr=tree#diff-c2VydmVyL2Jyb2tlci91dGlsLmdv) | `53.2% <0%> (-0.27%)` | :arrow_down: | | [server/service/tag.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/471/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdGFnLmdv) | `68.86% <0%> (+0.59%)` | :arrow_up: | | [pkg/tlsutil/tlsutil.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/471/diff?src=pr=tree#diff-cGtnL3Rsc3V0aWwvdGxzdXRpbC5nbw==) | `74.52% <0%> (+0.94%)` | :arrow_up: | | [server/service/util/tag\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/471/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC90YWdfdXRpbC5nbw==) | `65.38% <0%> (+3.84%)` | :arrow_up: | | [pkg/etcdsync/mutex.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/471/diff?src=pr=tree#diff-cGtnL2V0Y2RzeW5jL211dGV4Lmdv) | `66.66% <0%> (+5.37%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/471?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/471?src=pr=footer). Last update [ed9a459...ff23c34](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/471?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Optimize args parsing > - > > Key: SCB-991 > URL: https://issues.apache.org/jira/browse/SCB-991 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This
[jira] [Commented] (SCB-991) Optimize args parsing
[ https://issues.apache.org/jira/browse/SCB-991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1886#comment-1886 ] ASF GitHub Bot commented on SCB-991: coveralls edited a comment on issue #471: SCB-991 Optimize args parsing URL: https://github.com/apache/incubator-servicecomb-service-center/pull/471#issuecomment-433813460 [](https://coveralls.io/builds/19775156) Coverage decreased (-0.04%) to 62.816% when pulling **ff23c34bbed2c6bb019c4dab2fb81735d244afa4 on little-cui:flag** into **ed9a459d51e2e40a9b07bacf3e9d74ffca514f41 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Optimize args parsing > - > > Key: SCB-991 > URL: https://issues.apache.org/jira/browse/SCB-991 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-990) Support to lookup the Omega instance if the original instance is not exit
[ https://issues.apache.org/jira/browse/SCB-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1858#comment-1858 ] Willem Jiang commented on SCB-990: -- We need to find a solution for the Alpha can not find the right Omega instance[1], do we need to store the message to try again or just discard the message. [1]https://github.com/apache/incubator-servicecomb-saga/issues/323 > Support to lookup the Omega instance if the original instance is not exit > - > > Key: SCB-990 > URL: https://issues.apache.org/jira/browse/SCB-990 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Saga >Reporter: Willem Jiang >Priority: Major > Labels: easyfix > Fix For: saga-0.3.0 > > > Current we just look up the instance of Service which is start the > transaction, if the service is stateless , we could support to invoke the > other service instance in case of the original instance is out of service. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-991) Optimize args parsing
[ https://issues.apache.org/jira/browse/SCB-991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1871#comment-1871 ] ASF GitHub Bot commented on SCB-991: xcaspar commented on issue #471: SCB-991 Optimize args parsing URL: https://github.com/apache/incubator-servicecomb-service-center/pull/471#issuecomment-433833114 > @xcaspar flag.Parse() is a good idea. > And import 'grace' to initialize automatically, it is difficult to control the initialization time sequence. Here only need to satisfy the grace.go than the core.go first to execute the init function. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Optimize args parsing > - > > Key: SCB-991 > URL: https://issues.apache.org/jira/browse/SCB-991 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SCB-992) Synchronous open source code from Vert.x 3.5.3 version
[ https://issues.apache.org/jira/browse/SCB-992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jeho0815 updated SCB-992: - Summary: Synchronous open source code from Vert.x 3.5.3 version (was: Synchronous open source code from Vert.x 3.3.5 version) > Synchronous open source code from Vert.x 3.5.3 version > -- > > Key: SCB-992 > URL: https://issues.apache.org/jira/browse/SCB-992 > Project: Apache ServiceComb > Issue Type: Task > Components: Java-Chassis >Reporter: jeho0815 >Assignee: jeho0815 >Priority: Major > Fix For: java-chassis-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-991) Optimize args parsing
[ https://issues.apache.org/jira/browse/SCB-991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1812#comment-1812 ] ASF GitHub Bot commented on SCB-991: little-cui opened a new pull request #471: SCB-991 Optimize args parsing URL: https://github.com/apache/incubator-servicecomb-service-center/pull/471 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Optimize args parsing > - > > Key: SCB-991 > URL: https://issues.apache.org/jira/browse/SCB-991 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SCB-991) Optimize args parsing
little-cui created SCB-991: -- Summary: Optimize args parsing Key: SCB-991 URL: https://issues.apache.org/jira/browse/SCB-991 Project: Apache ServiceComb Issue Type: Bug Components: Service-Center Reporter: little-cui Assignee: little-cui Fix For: service-center-1.1.0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-991) Optimize args parsing
[ https://issues.apache.org/jira/browse/SCB-991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1828#comment-1828 ] ASF GitHub Bot commented on SCB-991: codecov-io commented on issue #471: SCB-991 Optimize args parsing URL: https://github.com/apache/incubator-servicecomb-service-center/pull/471#issuecomment-433813466 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/471?src=pr=h1) Report > Merging [#471](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/471?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/ed9a459d51e2e40a9b07bacf3e9d74ffca514f41?src=pr=desc) will **increase** coverage by `0.03%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/471?src=pr=tree) ```diff @@Coverage Diff @@ ## master #471 +/- ## == + Coverage 60.34% 60.38% +0.03% == Files 156 156 Lines 1338113380 -1 == + Hits 8075 8079 +4 + Misses 4727 4723 -4 + Partials 579 578 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/471?src=pr=tree) | Coverage Δ | | |---|---|---| | [server/core/core.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/471/diff?src=pr=tree#diff-c2VydmVyL2NvcmUvY29yZS5nbw==) | `0% <ø> (ø)` | :arrow_up: | | [pkg/util/util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/471/diff?src=pr=tree#diff-cGtnL3V0aWwvdXRpbC5nbw==) | `66.21% <0%> (-1.36%)` | :arrow_down: | | [pkg/log/logrotate.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/471/diff?src=pr=tree#diff-cGtnL2xvZy9sb2dyb3RhdGUuZ28=) | `33.71% <0%> (-0.58%)` | :arrow_down: | | [server/govern/service.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/471/diff?src=pr=tree#diff-c2VydmVyL2dvdmVybi9zZXJ2aWNlLmdv) | `73.33% <0%> (-0.34%)` | :arrow_down: | | [server/broker/util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/471/diff?src=pr=tree#diff-c2VydmVyL2Jyb2tlci91dGlsLmdv) | `53.2% <0%> (-0.27%)` | :arrow_down: | | [server/broker/service.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/471/diff?src=pr=tree#diff-c2VydmVyL2Jyb2tlci9zZXJ2aWNlLmdv) | `57.94% <0%> (+0.15%)` | :arrow_up: | | [server/service/tag.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/471/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdGFnLmdv) | `68.86% <0%> (+0.59%)` | :arrow_up: | | [server/service/notification/websocket.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/471/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL3dlYnNvY2tldC5nbw==) | `84.51% <0%> (+0.64%)` | :arrow_up: | | [pkg/etcdsync/mutex.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/471/diff?src=pr=tree#diff-cGtnL2V0Y2RzeW5jL211dGV4Lmdv) | `66.66% <0%> (+5.37%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/471?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/471?src=pr=footer). Last update [ed9a459...16c6694](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/471?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Optimize args parsing > - > > Key: SCB-991 > URL: https://issues.apache.org/jira/browse/SCB-991 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian
[jira] [Commented] (SCB-991) Optimize args parsing
[ https://issues.apache.org/jira/browse/SCB-991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1827#comment-1827 ] ASF GitHub Bot commented on SCB-991: coveralls commented on issue #471: SCB-991 Optimize args parsing URL: https://github.com/apache/incubator-servicecomb-service-center/pull/471#issuecomment-433813460 [](https://coveralls.io/builds/19773910) Coverage increased (+0.01%) to 62.868% when pulling **16c66949fc6b8e3781336b3b9d7cf2dec4da246a on little-cui:flag** into **ed9a459d51e2e40a9b07bacf3e9d74ffca514f41 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Optimize args parsing > - > > Key: SCB-991 > URL: https://issues.apache.org/jira/browse/SCB-991 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-991) Optimize args parsing
[ https://issues.apache.org/jira/browse/SCB-991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1836#comment-1836 ] ASF GitHub Bot commented on SCB-991: xcaspar commented on issue #471: SCB-991 Optimize args parsing URL: https://github.com/apache/incubator-servicecomb-service-center/pull/471#issuecomment-433819477 I think you can also replace the `flag.CommandLine.Parse(os.Args[1:])` line with `flag.Parse()`，and replace `grace.ParseCommandLine()` with `_ "github.com/apache/incubator-servicecomb-service-center/pkg/grace"` in `import` code block to increase code readability. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Optimize args parsing > - > > Key: SCB-991 > URL: https://issues.apache.org/jira/browse/SCB-991 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16667983#comment-16667983 ] ASF GitHub Bot commented on SCB-993: coveralls commented on issue #474: SCB-993 span_test.go:151: Fatalf call has arguments but no formatting directives URL: https://github.com/apache/incubator-servicecomb-service-center/pull/474#issuecomment-434138966 [](https://coveralls.io/builds/19794791) Coverage increased (+0.09%) to 62.927% when pulling **88e2bf7ffc384188519576775cb0aeec938fd1b7 on little-cui:bug** into **5a68edee4c4095367145fbe9484b369d30064c9e on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SCB-993) Bug fixes
little-cui created SCB-993: -- Summary: Bug fixes Key: SCB-993 URL: https://issues.apache.org/jira/browse/SCB-993 Project: Apache ServiceComb Issue Type: Bug Components: Service-Center Reporter: little-cui Assignee: little-cui Fix For: service-center-1.1.0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16667962#comment-16667962 ] ASF GitHub Bot commented on SCB-993: little-cui opened a new pull request #474: SCB-993 span_test.go:151: Fatalf call has arguments but no formatting directives URL: https://github.com/apache/incubator-servicecomb-service-center/pull/474 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16667963#comment-16667963 ] ASF GitHub Bot commented on SCB-993: little-cui commented on issue #474: SCB-993 span_test.go:151: Fatalf call has arguments but no formatting directives URL: https://github.com/apache/incubator-servicecomb-service-center/pull/474#issuecomment-434135332 #472 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16667982#comment-16667982 ] ASF GitHub Bot commented on SCB-993: codecov-io commented on issue #474: SCB-993 span_test.go:151: Fatalf call has arguments but no formatting directives URL: https://github.com/apache/incubator-servicecomb-service-center/pull/474#issuecomment-434138922 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/474?src=pr=h1) Report > Merging [#474](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/474?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/5a68edee4c4095367145fbe9484b369d30064c9e?src=pr=desc) will **increase** coverage by `0.02%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/474?src=pr=tree) ```diff @@Coverage Diff@@ ## master#474 +/- ## = + Coverage 60.38% 60.4% +0.02% = Files 156 156 Lines 13379 13379 = + Hits 80798082 +3 Misses 47224722 + Partials 578 575 -3 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/474?src=pr=tree) | Coverage Δ | | |---|---|---| | [server/broker/util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/474/diff?src=pr=tree#diff-c2VydmVyL2Jyb2tlci91dGlsLmdv) | `53.2% <0%> (-0.27%)` | :arrow_down: | | [server/service/instance.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/474/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvaW5zdGFuY2UuZ28=) | `68.09% <0%> (-0.2%)` | :arrow_down: | | [server/plugin/pkg/registry/etcd/etcd.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/474/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvcmVnaXN0cnkvZXRjZC9ldGNkLmdv) | `86.3% <0%> (-0.19%)` | :arrow_down: | | [server/broker/service.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/474/diff?src=pr=tree#diff-c2VydmVyL2Jyb2tlci9zZXJ2aWNlLmdv) | `57.94% <0%> (+0.15%)` | :arrow_up: | | [server/govern/service.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/474/diff?src=pr=tree#diff-c2VydmVyL2dvdmVybi9zZXJ2aWNlLmdv) | `73.66% <0%> (+0.33%)` | :arrow_up: | | [pkg/tlsutil/tlsutil.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/474/diff?src=pr=tree#diff-cGtnL3Rsc3V0aWwvdGxzdXRpbC5nbw==) | `74.52% <0%> (+0.94%)` | :arrow_up: | | [pkg/util/tree.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/474/diff?src=pr=tree#diff-cGtnL3V0aWwvdHJlZS5nbw==) | `84.37% <0%> (+3.12%)` | :arrow_up: | | [server/service/util/tag\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/474/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC90YWdfdXRpbC5nbw==) | `65.38% <0%> (+3.84%)` | :arrow_up: | | [server/plugin/pkg/registry/etcd/tracing.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/474/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvcmVnaXN0cnkvZXRjZC90cmFjaW5nLmdv) | `81.81% <0%> (+9.09%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/474?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/474?src=pr=footer). Last update [5a68ede...88e2bf7](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/474?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16668005#comment-16668005 ] ASF GitHub Bot commented on SCB-993: little-cui closed pull request #475: SCB-993 Add sc binary to .gitignore URL: https://github.com/apache/incubator-servicecomb-service-center/pull/475 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/.gitignore b/.gitignore index c4d8a42d..01b32abb 100644 --- a/.gitignore +++ b/.gitignore @@ -27,3 +27,4 @@ tmp/ glide.lock incubator-servicecomb-service-center go.sum +service-center This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16668004#comment-16668004 ] ASF GitHub Bot commented on SCB-993: codecov-io commented on issue #475: SCB-993 Add sc binary to .gitignore URL: https://github.com/apache/incubator-servicecomb-service-center/pull/475#issuecomment-434145979 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/475?src=pr=h1) Report > Merging [#475](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/475?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/5a68edee4c4095367145fbe9484b369d30064c9e?src=pr=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/475?src=pr=tree) ```diff @@Coverage Diff @@ ## master #475 +/- ## == - Coverage 60.38% 60.37% -0.01% == Files 156 156 Lines 1337913379 == - Hits 8079 8078 -1 Misses 4722 4722 - Partials 578 579 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/475?src=pr=tree) | Coverage Δ | | |---|---|---| | [server/service/notification/websocket.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/475/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL3dlYnNvY2tldC5nbw==) | `83.87% <0%> (-0.65%)` | :arrow_down: | | [server/service/instance.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/475/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvaW5zdGFuY2UuZ28=) | `68.09% <0%> (-0.2%)` | :arrow_down: | | [server/plugin/pkg/registry/etcd/etcd.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/475/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvcmVnaXN0cnkvZXRjZC9ldGNkLmdv) | `86.3% <0%> (-0.19%)` | :arrow_down: | | [server/govern/service.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/475/diff?src=pr=tree#diff-c2VydmVyL2dvdmVybi9zZXJ2aWNlLmdv) | `73.66% <0%> (+0.33%)` | :arrow_up: | | [server/plugin/pkg/registry/etcd/tracing.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/475/diff?src=pr=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvcmVnaXN0cnkvZXRjZC90cmFjaW5nLmdv) | `81.81% <0%> (+9.09%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/475?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/475?src=pr=footer). Last update [5a68ede...a85e300](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/475?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[ https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16668003#comment-16668003 ] ASF GitHub Bot commented on SCB-993: coveralls commented on issue #475: SCB-993 Add sc binary to .gitignore URL: https://github.com/apache/incubator-servicecomb-service-center/pull/475#issuecomment-434145954 [](https://coveralls.io/builds/19795120) Coverage decreased (-0.01%) to 62.829% when pulling **a85e300d1823cbcfdf52593261ce05127d2089d7 on xcaspar:master** into **5a68edee4c4095367145fbe9484b369d30064c9e on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Bug fixes > - > > Key: SCB-993 > URL: https://issues.apache.org/jira/browse/SCB-993 > Project: Apache ServiceComb > Issue Type: Bug > Components: Service-Center >Reporter: little-cui >Assignee: little-cui >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-992) Synchronous open source code from Vert.x 3.5.3 version
[ https://issues.apache.org/jira/browse/SCB-992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16668102#comment-16668102 ] ASF GitHub Bot commented on SCB-992: coveralls commented on issue #973: [SCB-992] Synchronous open source code from Vert.x 3.5.3 version URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/973#issuecomment-434165878 [](https://coveralls.io/builds/19796161) Coverage decreased (-0.05%) to 86.334% when pulling **a1439fe42fd421f22295d11d1667a60c9f021f80 on jeho0815:Branch_master_SCB-992** into **0daff2ebb2444c1ef6b0deaca545c0821207f0cc on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Synchronous open source code from Vert.x 3.5.3 version > -- > > Key: SCB-992 > URL: https://issues.apache.org/jira/browse/SCB-992 > Project: Apache ServiceComb > Issue Type: Task > Components: Java-Chassis >Reporter: jeho0815 >Assignee: jeho0815 >Priority: Major > Fix For: java-chassis-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-993) Bug fixes
[
https://issues.apache.org/jira/browse/SCB-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16668006#comment-16668006
]
ASF GitHub Bot commented on SCB-993:
little-cui closed pull request #474: SCB-993 span_test.go:151: Fatalf call has
arguments but no formatting directives
URL: https://github.com/apache/incubator-servicecomb-service-center/pull/474
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/server/plugin/pkg/tracing/buildin/span_test.go
b/server/plugin/pkg/tracing/buildin/span_test.go
index c44ba2a2..fcf86679 100644
--- a/server/plugin/pkg/tracing/buildin/span_test.go
+++ b/server/plugin/pkg/tracing/buildin/span_test.go
@@ -148,19 +148,19 @@ func TestFromZipkinSpan(t *testing.T) {
span := {}
err := json.Unmarshal(sample, )
if err != nil {
- t.Fatalf("TestFromZipkinSpan Unmarshal", err)
+ t.Fatalf("TestFromZipkinSpan Unmarshal, %v", err)
}
s := FromZipkinSpan(span)
b, err := json.Marshal(s)
if err != nil {
- t.Fatalf("TestFromZipkinSpan Marshal", err)
+ t.Fatalf("TestFromZipkinSpan Marshal, %v", err)
}
fmt.Println(string(b))
s = FromZipkinSpan({})
b, err = json.Marshal(s)
if err != nil {
- t.Fatalf("TestFromZipkinSpan Marshal", err)
+ t.Fatalf("TestFromZipkinSpan Marshal, %v", err)
}
fmt.Println(string(b))
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Bug fixes
> -
>
> Key: SCB-993
> URL: https://issues.apache.org/jira/browse/SCB-993
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Service-Center
>Reporter: little-cui
>Assignee: little-cui
>Priority: Major
> Fix For: service-center-1.1.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-989) scan RestController to to make springmvc controller publish as ServiceComb Rest easier
[
https://issues.apache.org/jira/browse/SCB-989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16667152#comment-16667152
]
ASF GitHub Bot commented on SCB-989:
liubao68 closed pull request #972: [SCB-989]scan RestController to to make
springmvc controller publish as ServiceComb Rest easier
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/972
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/RestConst.java
b/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/RestConst.java
index 57b4029ae..afdc96bff 100644
---
a/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/RestConst.java
+++
b/common/common-rest/src/main/java/org/apache/servicecomb/common/rest/RestConst.java
@@ -70,4 +70,6 @@ private RestConst() {
// the size threshold after which files will be written to disk
// only available for servlet rest transport
public static final String UPLOAD_FILE_SIZE_THRESHOLD =
"servicecomb.uploads.fileSizeThreshold";
+
+ public static final String PROVIDER_SCAN_REST_CONTROLLER =
"servicecomb.provider.rest.scanRestController";
}
diff --git
a/integration-tests/it-consumer/src/main/java/org/apache/servicecomb/it/ConsumerMain.java
b/integration-tests/it-consumer/src/main/java/org/apache/servicecomb/it/ConsumerMain.java
index b534c5948..61db4463f 100644
---
a/integration-tests/it-consumer/src/main/java/org/apache/servicecomb/it/ConsumerMain.java
+++
b/integration-tests/it-consumer/src/main/java/org/apache/servicecomb/it/ConsumerMain.java
@@ -32,6 +32,7 @@
import org.apache.servicecomb.it.testcase.TestParamCodec;
import org.apache.servicecomb.it.testcase.TestParamCodecEdge;
import org.apache.servicecomb.it.testcase.TestRequestBodySpringMvcSchema;
+import org.apache.servicecomb.it.testcase.TestRestController;
import org.apache.servicecomb.it.testcase.TestRestServerConfig;
import org.apache.servicecomb.it.testcase.TestRestServerConfigEdge;
import org.apache.servicecomb.it.testcase.TestTrace;
@@ -132,6 +133,7 @@ private static void runShareTestCases() throws Throwable {
ITJUnitUtils.run(TestRequestBodySpringMvcSchema.class);
ITJUnitUtils.run(TestDefaultJsonValueJaxrsSchema.class);
+ITJUnitUtils.run(TestRestController.class);
}
private static void testStandalone() throws Throwable {
diff --git
a/integration-tests/it-consumer/src/main/java/org/apache/servicecomb/it/extend/engine/ITSCBRestTemplate.java
b/integration-tests/it-consumer/src/main/java/org/apache/servicecomb/it/extend/engine/ITSCBRestTemplate.java
index 8446b9324..b1ed1f95e 100644
---
a/integration-tests/it-consumer/src/main/java/org/apache/servicecomb/it/extend/engine/ITSCBRestTemplate.java
+++
b/integration-tests/it-consumer/src/main/java/org/apache/servicecomb/it/extend/engine/ITSCBRestTemplate.java
@@ -29,6 +29,8 @@
private String schemaId;
+ private String basePath;
+
public ITSCBRestTemplate(String schemaId) {
this.schemaId = schemaId;
}
@@ -40,7 +42,8 @@ public ITSCBRestTemplate init() {
DefinitionConst.VERSION_RULE_ALL);
MicroserviceVersionMeta microserviceVersionMeta =
microserviceVersionRule.getLatestMicroserviceVersion();
SchemaMeta schemaMeta =
microserviceVersionMeta.getMicroserviceMeta().ensureFindSchemaMeta(schemaId);
-urlPrefix = String.format("cse://%s/%s", producerName,
schemaMeta.getSwagger().getBasePath());
+basePath = schemaMeta.getSwagger().getBasePath();
+urlPrefix = String.format("cse://%s%s", producerName, basePath);
setUriTemplateHandler(new ITUriTemplateHandler(urlPrefix));
setRequestFactory(new ITClientHttpRequestFactory());
@@ -48,6 +51,10 @@ public ITSCBRestTemplate init() {
return this;
}
+ public String getBasePath() {
+return basePath;
+ }
+
public String getUrlPrefix() {
return urlPrefix;
}
diff --git
a/integration-tests/it-consumer/src/main/java/org/apache/servicecomb/it/testcase/TestRestController.java
b/integration-tests/it-consumer/src/main/java/org/apache/servicecomb/it/testcase/TestRestController.java
new file mode 100644
index 0..722a43913
--- /dev/null
+++
b/integration-tests/it-consumer/src/main/java/org/apache/servicecomb/it/testcase/TestRestController.java
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance
