KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.9 - Build # 177 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.9/177/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Tue, 06 Nov 2018 06:24:17 +
 Build duration:
36 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 14 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.plasma-iconitemtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(9/18)45%
(57/126)45%
(57/126)39%
(5177/13179)29%
(2735/9444)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(13/14)93%
(13/14)96%
(1067/1117)51%
(551/1084)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/463)0%
(0/231)src.declarativeimports.core44%
(7/16)44%
(7/16)33%
(749/2240)27%
(388/1442)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/497)0%
(0/187)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)48%
(1698/3504)39%
(1030/2633)src.plasma.packagestructure57%
(4/7)57%
(4/7)37%
(51/138)42%
(5/12)src.plasma.private63%
(12/19)63%
(12/19)61%
(945/1558)42%
(424/1003)src.plasma.scripting67%
(2/3)67%
(2/3)20%
(34/166)10%
(13/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick27%
(3/11)27%
(3/11)30%
(589/1977)19%
(319/1702)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/107)36%
(5/14)src.scriptengines.qml.plasmoid17%
(1/6)17%
(1/6)1%
(13/1098)0%
(0/906)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
(0/2)0%
(0/2)0%
(0/61)0%
(0/16)tests.testengine0%
  

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.9 - Build # 75 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.9/75/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Tue, 06 Nov 2018 06:23:02 +
 Build duration:
24 min and counting
   JUnit Tests
  Name: (root) Failed: 4 test(s), Passed: 42 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: TestSuite.kwayland-testDataDeviceFailed: TestSuite.kwayland-testPlasmaVirtualDesktopFailed: TestSuite.kwayland-testPlasmaWindowModelFailed: TestSuite.kwayland-testRemoteAccess
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)91%
(234/257)91%
(234/257)85%
(24796/29129)52%
(9840/18779)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client98%
(41/42)98%
(41/42)97%
(11669/12057)49%
(6194/12589)autotests.server100%
(5/5)100%
(5/5)99%
(353/356)49%
(169/344)src.client97%
(71/73)97%
(71/73)83%
(5743/6936)64%
(1509/2370)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server99%
(115/116)99%
(115/116)85%
(6950/8190)64%
(1968/3061)src.tools0%
(0/2)0%
(0/2)0%
(0/693)0%
(0/272)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/69)0%
(0/10)tests0%
(0/14)0%
(0/14)0%
(0/747)0%
(0/133)

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.9 - Build # 39 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.9/39/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Tue, 06 Nov 2018 06:23:17 +
 Build duration:
22 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.kwindowsystem-kwindowinfox11testFailed: TestSuite.kwindowsystem-netrootinfotestwm
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(43/54)80%
(43/54)75%
(7100/9494)55%
(3474/6353)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)96%
(3005/3137)51%
(1262/2454)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src92%
(12/13)92%
(12/13)56%
(774/1377)45%
(293/658)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)71%
(3314/4657)60%
(1916/3209)tests0%
(0/5)0%
(0/5)0%
(0/243)0%
(0/26)

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 101 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/101/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 06 Nov 2018 06:23:02 +
 Build duration:
23 min and counting
   JUnit Tests
  Name: (root) Failed: 4 test(s), Passed: 42 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: TestSuite.kwayland-testPlasmaVirtualDesktopFailed: TestSuite.kwayland-testPlasmaWindowModelFailed: TestSuite.kwayland-testRemoteAccessFailed: TestSuite.kwayland-testWaylandSeat
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)91%
(234/257)91%
(234/257)85%
(24644/29125)52%
(9734/18779)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client98%
(41/42)98%
(41/42)96%
(11548/12056)48%
(6105/12589)autotests.server100%
(5/5)100%
(5/5)99%
(353/356)49%
(169/344)src.client97%
(71/73)97%
(71/73)83%
(5735/6935)64%
(1508/2370)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server99%
(115/116)99%
(115/116)85%
(6927/8188)64%
(1952/3061)src.tools0%
(0/2)0%
(0/2)0%
(0/693)0%
(0/272)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/69)0%
(0/10)tests0%
(0/14)0%
(0/14)0%
(0/747)0%
(0/133)

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 251 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/251/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 06 Nov 2018 06:24:17 +
 Build duration:
9 min 25 sec and counting
   JUnit Tests
  Name: (root) Failed: 6 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(44/126)35%
(44/126)27%
(3599/13119)19%
(1821/9446)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(607/1113)29%
(313/1084)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/463)0%
(0/231)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2221)7%
(96/1444)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/497)0%
(0/187)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)41%
(1418/3490)30%
(794/2633)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/135)0%
(0/12)src.plasma.private47%
(9/19)47%
(9/19)43%
(665/1544)30%
(301/1003)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick27%
(3/11)27%
(3/11)29%
(579/1978)18%
(312/1702)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/107)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1096)0%
(0/906)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
(0/2)0%
  

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.10 - Build # 51 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.10/51/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 06 Nov 2018 06:23:17 +
 Build duration:
7 min 28 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.kwindowsystem-kwindowinfox11testFailed: TestSuite.kwindowsystem-netrootinfotestwm
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(43/54)80%
(43/54)75%
(7100/9494)55%
(3475/6353)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)96%
(3006/3137)51%
(1262/2454)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src92%
(12/13)92%
(12/13)56%
(773/1377)45%
(294/658)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)71%
(3314/4657)60%
(1916/3209)tests0%
(0/5)0%
(0/5)0%
(0/243)0%
(0/26)

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.9 - Build # 48 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.9/48/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Tue, 06 Nov 2018 06:17:32 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 40 test(s)Failed: TestSuite.ktabwidget_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report29%
(4/14)43%
(124/291)43%
(124/291)47%
(21750/45961)38%
(13184/34249)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault0%
(0/1)0%
(0/1)0%
(0/87)0%
(0/56)autotests98%
(44/45)98%
(44/45)98%
(11469/11759)50%
(7254/14375)src0%
(0/1)0%
(0/1)0%
(0/4)0%
(0/2)src.kdebugdialog0%
(0/7)0%
(0/7)0%
(0/256)0%
(0/73)src.kdecore76%
(65/86)76%
(65/86)53%
(9506/17866)49%
(5599/11459)src.kdeui19%
(13/68)19%
(13/68)8%
(765/9694)6%
(330/5364)src.kio7%
(2/27)7%
(2/27)0%
(10/2258)0%
(1/1238)src.kioslave.metainfo0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/4)src.kparts0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/12)src.kssl0%
(0/8)0%
(0/8)0%
(0/1807)0%
(0/853)src.kssl.kcm0%
(0/3)0%
(0/3)0%
(0/264)0%
(0/145)src.solid0%
(0/3)0%
(0/3)0%
(0/188)0%
(0/87)src.solid-networkstatus.kded0%
(0/6)0%
(0/6)0%
(0/185)0%
(0/94)tests0%
(0/34)0%
(0/34)0%
(0/1537)0%
(0/487)

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.10 - Build # 74 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.10/74/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 06 Nov 2018 06:17:32 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 40 test(s)Failed: TestSuite.ktabwidget_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report29%
(4/14)43%
(124/291)43%
(124/291)47%
(21615/45959)38%
(13051/34249)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault0%
(0/1)0%
(0/1)0%
(0/87)0%
(0/56)autotests98%
(44/45)98%
(44/45)97%
(11364/11759)50%
(7174/14375)src0%
(0/1)0%
(0/1)0%
(0/4)0%
(0/2)src.kdebugdialog0%
(0/7)0%
(0/7)0%
(0/256)0%
(0/73)src.kdecore76%
(65/86)76%
(65/86)53%
(9476/17864)48%
(5546/11459)src.kdeui19%
(13/68)19%
(13/68)8%
(765/9694)6%
(330/5364)src.kio7%
(2/27)7%
(2/27)0%
(10/2258)0%
(1/1238)src.kioslave.metainfo0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/4)src.kparts0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/12)src.kssl0%
(0/8)0%
(0/8)0%
(0/1807)0%
(0/853)src.kssl.kcm0%
(0/3)0%
(0/3)0%
(0/264)0%
(0/145)src.solid0%
(0/3)0%
(0/3)0%
(0/188)0%
(0/87)src.solid-networkstatus.kded0%
(0/6)0%
(0/6)0%
(0/185)0%
(0/94)tests0%
(0/34)0%
(0/34)0%
(0/1537)0%
(0/487)

KDE CI: Frameworks » kdoctools » kf5-qt5 SUSEQt5.10 - Build # 63 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdoctools/job/kf5-qt5%20SUSEQt5.10/63/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 06 Nov 2018 06:02:52 +
 Build duration:
1 min 7 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.kdoctools_install
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(1/1)67%
(4/6)67%
(4/6)68%
(335/490)48%
(138/287)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalssrc67%
(4/6)67%
(4/6)68%
(335/490)48%
(138/287)

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.10 - Build # 85 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.10/85/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 06 Nov 2018 05:51:32 +
 Build duration:
1 min 12 sec and counting
   JUnit Tests
  Name: (root) Failed: 4 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.plasma-plasmoidpackagetestFailed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackage-nodisplay-appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)84%
(16/19)84%
(16/19)54%
(1154/2122)40%
(850/2120)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests83%
(5/6)83%
(5/6)57%
(308/536)35%
(167/472)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)66%
(497/755)51%
(478/935)src.kpackage.private83%
(5/6)83%
(5/6)54%
(190/351)34%
(67/195)src.kpackagetool100%
(2/2)100%
(2/2)31%
(145/462)26%
(131/506)

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.9 - Build # 63 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.9/63/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Tue, 06 Nov 2018 05:51:32 +
 Build duration:
1 min 32 sec and counting
   JUnit Tests
  Name: (root) Failed: 4 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.plasma-plasmoidpackagetestFailed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackage-nodisplay-appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)84%
(16/19)84%
(16/19)54%
(1154/2122)40%
(850/2120)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests83%
(5/6)83%
(5/6)57%
(308/536)35%
(167/472)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)66%
(497/755)51%
(478/935)src.kpackage.private83%
(5/6)83%
(5/6)54%
(190/351)34%
(67/195)src.kpackagetool100%
(2/2)100%
(2/2)31%
(145/462)26%
(131/506)

D16692: A QApplication object needs to be instantiated for kio-kdeconnect to work on KDE Neon

[Simon Redman]

sredman added a comment.


  This is going to be our cleanest patch ever once we've had everybody and 
their grandmother look at it. I guess this is what happens when you fix a hot 
bug! 
  
  In D16692#354783 , @jriddell wrote:
  
  > I can recreate the problem with 1.3 branch build of kdeconnect-kde in a 
virtualmachine install of KDE neon user edition
  >  The problem remains when building and installing it with the D16692 
 patch
  >
  > Building 1.3 branch on KDE neon developer edition I can not recreate the 
problem.  So the problem may be in some other area such as kio framework.
  
  
  On my KDE Neon user edition VM, this patch solves the issue 

INLINE COMMENTS

> CMakeLists.txt:23
> +install(TARGETS kio_kdeconnect DESTINATION ${KDE_INSTALL_PLUGINDIR}/kf5/kio)
> +#install(FILES kdeconnect.protocol DESTINATION ${SERVICES_INSTALL_DIR})

Is there some reason to keep this line as a comment?

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D16692

To: eduisters, #kde_connect, #frameworks, albertvaka
Cc: sredman, apol, jriddell, nicolasfella, albertvaka, kdeconnect, 
shivanshukantprasad, skymoore, wistak, dvalencia, rmenezes, julioc, Leptopoda, 
timothyc, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, 
daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, tctara

D16409: [Bookmarks Runner] Open database connection in the query thread

[Stefan Brüns]

bruns edited the summary of this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16409

To: bruns, #frameworks
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 72 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.11/72/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Tue, 06 Nov 2018 01:08:51 +
 Build duration:
3 min 44 sec and counting
   CONSOLE OUTPUT
  [...truncated 553.11 KB...]ksambashare.cppC:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\core\ksambashare.cpp(438): warning C4273: 'KSambaShare::KSambaShare': inconsistent dll linkagec:\ci\workspace\frameworks\kio\kf5-qt5 windowsmsvcqt5.11\src\core\ksambashare.h(128): note: see previous definition of '{ctor}'C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\core\ksambashare.cpp(450): warning C4273: 'KSambaShare::~KSambaShare': inconsistent dll linkagec:\ci\workspace\frameworks\kio\kf5-qt5 windowsmsvcqt5.11\src\core\ksambashare.h(107): note: see previous definition of '{dtor}'C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\core\ksambashare.cpp(460): warning C4273: 'KSambaShare::smbConfPath': inconsistent dll linkagec:\ci\workspace\frameworks\kio\kf5-qt5 windowsmsvcqt5.11\src\core\ksambashare.h(118): note: see previous definition of 'smbConfPath'C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\core\ksambashare.cpp(467): warning C4273: 'KSambaShare::isDirectoryShared': inconsistent dll linkagec:\ci\workspace\frameworks\kio\kf5-qt5 windowsmsvcqt5.11\src\core\ksambashare.h(52): note: see previous definition of 'isDirectoryShared'C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\core\ksambashare.cpp(473): warning C4273: 'KSambaShare::isShareNameAvailable': inconsistent dll linkagec:\ci\workspace\frameworks\kio\kf5-qt5 windowsmsvcqt5.11\src\core\ksambashare.h(71): note: see previous definition of 'isShareNameAvailable'C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\core\ksambashare.cpp(479): warning C4273: 'KSambaShare::shareNames': inconsistent dll linkagec:\ci\workspace\frameworks\kio\kf5-qt5 windowsmsvcqt5.11\src\core\ksambashare.h(81): note: see previous definition of 'shareNames'C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\core\ksambashare.cpp(485): warning C4273: 'KSambaShare::sharedDirectories': inconsistent dll linkagec:\ci\workspace\frameworks\kio\kf5-qt5 windowsmsvcqt5.11\src\core\ksambashare.h(60): note: see previous definition of 'sharedDirectories'C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\core\ksambashare.cpp(491): warning C4273: 'KSambaShare::getShareByName': inconsistent dll linkagec:\ci\workspace\frameworks\kio\kf5-qt5 windowsmsvcqt5.11\src\core\ksambashare.h(93): note: see previous definition of 'getShareByName'C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\core\ksambashare.cpp(497): warning C4273: 'KSambaShare::getSharesByPath': inconsistent dll linkagec:\ci\workspace\frameworks\kio\kf5-qt5 windowsmsvcqt5.11\src\core\ksambashare.h(105): note: see previous definition of 'getSharesByPath'C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\src\core\ksambashare.cpp(511): warning C4273: 'KSambaShare::instance': inconsistent dll linkagec:\ci\workspace\frameworks\kio\kf5-qt5 windowsmsvcqt5.11\src\core\ksambashare.h(43): note: see previous definition of 'instance'C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\build\autotests\ksambashareprivatetest_autogen\include\moc_ksambashare.cpp(73): warning C4273: 'KSambaShare::qt_static_metacall': inconsistent dll linkagec:\ci\workspace\frameworks\kio\kf5-qt5 windowsmsvcqt5.11\src\core\ksambashare.h(37): note: see previous definition of 'qt_static_metacall'C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\build\autotests\ksambashareprivatetest_autogen\include\moc_ksambashare.cpp(94): warning C4273: 'staticMetaObject': inconsistent dll linkagec:\ci\workspace\frameworks\kio\kf5-qt5 windowsmsvcqt5.11\src\core\ksambashare.h(37): note: see previous definition of 'public: static QMetaObject const KSambaShare::staticMetaObject'C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\build\autotests\ksambashareprivatetest_autogen\include\moc_ksambashare.cpp(94): error C2491: 'KSambaShare::staticMetaObject': definition of dllimport static data member not allowedC:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\build\autotests\ksambashareprivatetest_autogen\include\moc_ksambashare.cpp(101): warning C4273: 'KSambaShare::metaObject': inconsistent dll linkagec:\ci\workspace\frameworks\kio\kf5-qt5 windowsmsvcqt5.11\src\core\ksambashare.h(37): note: see previous definition of 'metaObject'C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\build\autotests\ksambashareprivatetest_autogen\include\moc_ksambashare.cpp(106): warning C4273: 'KSambaShare::qt_metacast': inconsistent dll linkagec:\ci\workspace\frameworks\kio\kf5-qt5 windowsmsvcqt5.11\src\core\ksambashare.h(37): note: see previous definition of 'qt_metacast'C:\CI\workspace\Frameworks\kio\kf5-qt5 

D16692: A QApplication object needs to be instantiated for kio-kdeconnect to work on KDE Neon

[Aleix Pol Gonzalez]

apol added a comment.


  In D16692#354767 , @albertvaka 
wrote:
  
  > In my opinion this is a regression in KIO and it would be nice to check if 
it can somehow be fixed there: Upgrading KIO should not break existing apps.
  >
  > Even if we make a release with this fix, it doesn't guarantee all distros 
will pick it up.
  
  
  Yet it's the preferred way to list plugins, I'd say we should do it. If KIO 
regressed that's something for whoever broke it to figure out.
  
  The fastInsert change is indeed unrelated and it would at least need a 
separate patch (or just not have it if Albert is opposing it).

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D16692

To: eduisters, #kde_connect, #frameworks, albertvaka
Cc: apol, jriddell, nicolasfella, albertvaka, kdeconnect, shivanshukantprasad, 
skymoore, wistak, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, 
yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, 
seebauer, bugzy, MayeulC, menasshock, tctara

D16684: Updated with petroleum industry units

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Looks great and works great! Nice first patch. Just one more thing is 
required before I can land it: add the following to the Summary section of the 
patch:
  
BUG: 388074
FIXED-IN: 5.53
  
  Thanks!

REPOSITORY
  R292 KUnitConversion

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16684

To: joaonetto, ngraham, broulik, #frameworks
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D16524: [Extractor] Use QDataStream serialization in place of cooked one

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:a3943b1fd575: [Extractor] Use QDataStream serialization 
in place of cooked one (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16524?vs=44477=44943

REVISION DETAIL
  https://phabricator.kde.org/D16524

AFFECTED FILES
  src/file/extractor/app.cpp
  src/file/extractorprocess.cpp

To: bruns, #baloo, #frameworks, ngraham, poboiko, lbeltrame
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D16395: Update the "About KDE" text

[Nathaniel Graham]

ngraham edited the test plan for this revision.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D16395

To: ngraham, #vdg, #plasma, #frameworks, #kde_applications, #kde_promo
Cc: valorie, davidc, xyquadrat, rizzitello, ltoscano, aspotashev, abetts, 
kde-frameworks-devel, michaelh, ngraham, bruns

D16395: Update the "About KDE" text

[Nathaniel Graham]

ngraham updated this revision to Diff 44942.
ngraham added a comment.


  Add a link to the "Get Involved" page

REPOSITORY
  R263 KXmlGui

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16395?vs=44605=44942

BRANCH
  arcpatch-D16395

REVISION DETAIL
  https://phabricator.kde.org/D16395

AFFECTED FILES
  src/kaboutkdedialog_p.cpp

To: ngraham, #vdg, #plasma, #frameworks, #kde_applications, #kde_promo
Cc: valorie, davidc, xyquadrat, rizzitello, ltoscano, aspotashev, abetts, 
kde-frameworks-devel, michaelh, ngraham, bruns

D16692: A QApplication object needs to be instantiated for kio-kdeconnect to work on KDE Neon

[Jonathan Riddell]

jriddell added a comment.


  I can recreate the problem with 1.3 branch build of kdeconnect-kde in a 
virtualmachine install of KDE neon user edition
  The problem remains when building and installing it with the D16692 
 patch
  
  Building 1.3 branch on KDE neon developer edition I can not recreate the 
problem.  So the problem may be in some other area such as kio framework.

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D16692

To: eduisters, #kde_connect, #frameworks, albertvaka
Cc: jriddell, nicolasfella, albertvaka, kdeconnect, shivanshukantprasad, 
skymoore, wistak, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, 
yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, 
seebauer, bugzy, MayeulC, menasshock, tctara, apol

D16678: Fix root disk icon change so that it doesn't erroneously change other icons

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R245:6d0f74132fcd: Fix root disk icon change so that it 
doesnt erroneously change other icons (authored by ngraham).

REPOSITORY
  R245 Solid

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16678?vs=44884=44941

REVISION DETAIL
  https://phabricator.kde.org/D16678

AFFECTED FILES
  src/solid/devices/backends/udisks2/udisksdevice.cpp
  src/solid/devices/backends/udisks2/udisksdevice.h

To: ngraham, bruns, broulik, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16692: A QApplication object needs to be instantiated for kio-kdeconnect to work on KDE Neon

[Nicolas Fella]

nicolasfella added a comment.


  Probably related: D16189 

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D16692

To: eduisters, #kde_connect, #frameworks, albertvaka
Cc: nicolasfella, albertvaka, kdeconnect, shivanshukantprasad, skymoore, 
wistak, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, yannux, 
Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, 
bugzy, MayeulC, menasshock, tctara, apol

D16189: kio_help: Fix crash in QCoreApplication when accessing help://

[Albert Vaca Cintora]

albertvaka added a comment.


  As I commented in this similar patch (https://phabricator.kde.org/D16692 ) I 
think this is a regression that should be fixed in KIO.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16189

To: mpyne, #frameworks, sitter, dfaure, broulik
Cc: albertvaka, broulik, dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D16692: A QApplication object needs to be instantiated for kio-kdeconnect to work on KDE Neon

[Albert Vaca Cintora]

albertvaka requested changes to this revision.
albertvaka added a comment.
This revision now requires changes to proceed.


  In my opinion this is a regression in KIO and it would be nice to check if it 
can somehow be fixed there: Upgrading KIO should not break existing apps.
  
  Even if we make a release with this fix, it doesn't guarantee all distros 
will pick it up.

INLINE COMMENTS

> kiokdeconnect.cpp:155
>  KIO::UDSEntry entry;
> -entry.insert(KIO::UDSEntry::UDS_NAME, QStringLiteral("files"));
> -entry.insert(KIO::UDSEntry::UDS_DISPLAY_NAME, name);

Also don't change insert to fastInsert, as it requires KIO 5.48 and we want to 
support older than that.

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D16692

To: eduisters, #kde_connect, #frameworks, albertvaka
Cc: albertvaka, kdeconnect, shivanshukantprasad, skymoore, wistak, dvalencia, 
rmenezes, julioc, Leptopoda, timothyc, jdvr, yannux, Danial0_0, johnq, Pitel, 
adeen-s, SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, 
menasshock, tctara, apol

D16523: [Extractor] Replace homegrown IO handler with QDataStream, catch HUP

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:52107a8af3ee: [Extractor] Replace homegrown IO handler 
with QDataStream, catch HUP (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16523?vs=44476=44939

REVISION DETAIL
  https://phabricator.kde.org/D16523

AFFECTED FILES
  src/file/extractor/CMakeLists.txt
  src/file/extractor/app.cpp
  src/file/extractor/app.h
  src/file/extractor/autotests/CMakeLists.txt
  src/file/extractor/autotests/iohandlertest.cpp
  src/file/extractor/iohandler.cpp
  src/file/extractor/iohandler.h

To: bruns, #baloo, #frameworks, ngraham, poboiko, lbeltrame
Cc: lbeltrame, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D16523: [Extractor] Replace homegrown IO handler with QDataStream, catch HUP

[Luca Beltrame]

lbeltrame accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  extractor

REVISION DETAIL
  https://phabricator.kde.org/D16523

To: bruns, #baloo, #frameworks, ngraham, poboiko, lbeltrame
Cc: lbeltrame, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D16523: [Extractor] Replace homegrown IO handler with QDataStream, catch HUP

[Stefan Brüns]

bruns added a comment.


  good to go?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D16523

To: bruns, #baloo, #frameworks, ngraham, poboiko
Cc: lbeltrame, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

[Emirald Mateli]

emateli updated this revision to Diff 44938.
emateli added a comment.


  - Initialize pointers to nullptr
  - Code style fix
  
  ---
  
  Thoughts on proceeding with the proposed changes to batchrenamejob? Also, the 
filenameutils namespace feels like duplicated work. Any existing solution 
available to use? It uses QMimeDatabase to look up the extension and if its not 
found, then it uses the suffix from QFileInfo

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14631?vs=44737=44938

BRANCH
  batchrename2

REVISION DETAIL
  https://phabricator.kde.org/D14631

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/batchrenametypestest.cpp
  autotests/batchrenametypestest.h
  src/widgets/CMakeLists.txt
  src/widgets/rename/batchrenamedialog.cpp
  src/widgets/rename/batchrenamedialog.h
  src/widgets/rename/batchrenamedialogmodel_p.cpp
  src/widgets/rename/batchrenamedialogmodel_p.h
  src/widgets/rename/batchrenametypes_p.cpp
  src/widgets/rename/batchrenametypes_p.h
  src/widgets/rename/batchrenamevar_p.cpp
  src/widgets/rename/batchrenamevar_p.h
  src/widgets/rename/filenameutils_p.cpp
  src/widgets/rename/filenameutils_p.h
  tests/CMakeLists.txt
  tests/batchrenamedialogtest_gui.cpp

To: emateli, #frameworks, dfaure, mlaurent
Cc: mlaurent, asensi, rkflx, dfaure, aacid, ngraham, kde-frameworks-devel, 
michaelh, bruns

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.9 - Build # 96 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.9/96/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 05 Nov 2018 22:05:10 +
 Build duration:
8 min 4 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 16 test(s), Skipped: 0 test(s), Total: 16 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)87%
(46/53)87%
(46/53)81%
(2875/3568)48%
(4299/9024)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(15/15)100%
(15/15)98%
(781/799)49%
(1699/3456)src75%
(18/24)75%
(18/24)79%
(1004/1269)44%
(464/1045)src.extractors100%
(12/12)100%
(12/12)73%
(1050/1432)47%
(2065/4362)src.writers100%
(1/1)100%
(1/1)98%
(40/41)48%
(71/149)tests0%
(0/1)0%
(0/1)0%
(0/27)0%
(0/12)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 117 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/117/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 05 Nov 2018 22:05:10 +
 Build duration:
2 min 46 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 16 test(s), Skipped: 0 test(s), Total: 16 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)87%
(46/53)87%
(46/53)81%
(2874/3568)48%
(4314/9060)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(15/15)100%
(15/15)98%
(781/799)49%
(1699/3456)src75%
(18/24)75%
(18/24)79%
(1003/1269)44%
(463/1045)src.extractors100%
(12/12)100%
(12/12)73%
(1050/1432)47%
(2081/4398)src.writers100%
(1/1)100%
(1/1)98%
(40/41)48%
(71/149)tests0%
(0/1)0%
(0/1)0%
(0/27)0%
(0/12)

Re: Python bindings using cppyy (was: An update on Python bindings)

[Dominik Haumann]

... wasn't there also some python related work by Stefan? Or is that
unrelated?

Greetings
Dominik


Am Mo., 5. Nov. 2018, 16:20 hat Shaheed Haque 
geschrieben:

> I'm afraid that there has been no progress as I am buried in "startup"
> mode. I'm not sure when that might change.
>
> On Mon, 5 Nov 2018, 14:02 Philipp A. 
>> Hi Shaheed!
>>
>> The year is nearing its end, and I wonder if there has been any progress
>> and/or if you people need help with the bindings!
>>
>> I’d really like to revive my IPython console in Kate :D
>>
>> Best, Philipp
>>
>> Shaheed Haque  schrieb am Sa., 13. Jan. 2018 um
>> 19:06 Uhr:
>>
>>> Thanks to some upstream fixes, I have the cppyy-based bindings for KF5
>>> and also Qt5 (see below) showing signs of life. Notes:
>>>
>>>
>>>1. The packaging has advanced to the point where I think ECM-based
>>>framework-by-framework bindings are a real possibility, with both Py2 and
>>>Py3. AFAICS, this addresses the main feedback received to date.
>>>2. With reference to the remark about tracking dependencies between
>>>frameworks, apologies for the delayed response as I somehow missed
>>>the email. I note that the dependencies currently in CMake often
>>>seem incomplete. I'll bring that to the community separately.
>>>3. There is one issue still open upstream (
>>>
>>> https://bitbucket.org/wlav/cppyy/issues/16/pragma-link-defined_in-seems-to-select).
>>>However, I don't consider this to be a showstopper...we might even be 
>>> able
>>>to live with it as is.
>>>4. For me, the jury is still out on PyQt versus a new set of
>>>cppyy-based Qt bindings. Clearly PyQt is solid and mature, but the
>>>limitations really concern me (if anybody wants to know more, I'm happy 
>>> to
>>>discuss, but let's do that in another thread please). Now, given that 
>>> there
>>>are examples in the wild of interoperating cppyy/cling/ROOT with PyQt, 
>>> I'm
>>>going to sidestep this question but am playing with a cppyy-based 
>>> approach.
>>>At this point, all of Qt has basic cppyy-based bindings, and the next 
>>> step
>>>is to tackle things like finding a way to express the object
>>>ownership/destruction rules in a more-or-less systematic way.
>>>5. On the P2/P3 question, I'm presently still committed to both P2
>>>and P3. I *have* had a couple of minor occasions where P3-only might have
>>>been nice *for my code*, but if I do find an issue that tips the balance,
>>>or I find some serious benefit *for the bindings*, I'll drop P2. One
>>>possible such benefit would be if I can see a sane way to address PEP484
>>>type hints.
>>>
>>> To get here, I had to build a subset of the tooling I previously had
>>> developed for the SIP-based approach. The big difference is the absence of
>>> any need to support customisation of the generated bindings. I am hopeful
>>> that in the worst case, there might be some minimal customisation (known as
>>> Pythonisations in cppyy parlance) such as for #4 above, but nothing like
>>> the scale needed for SIP.
>>>
>>> The core tooling is not specific to KF5 or KDE or Qt5, and is developed
>>> in upstream cppyy over on bitbucket.org. The core tooling is built
>>> around CMake, notably for the generation phase and the C++ library build.
>>>
>>> The PoC extends the core tooling with Pythonic packaging and
>>> installation using pip/wheels, also from CMake. As before I would look for
>>> help to get an ECM equivalent, possibly based on the same approach but
>>> perhaps including CI and distribution via PyPi.
>>>
>>> Finally, now would be a good time for anybody else who wants to get
>>> involved to step up, especially as a new job limits my free time.
>>>
>>> Thanks, Shaheed
>>>
>>> P.S. Not to stoke the the P2/P3 wars unnecessarily, but while I know
>>> that upstream Clang just added P3 support in the clang 5.0 release, current
>>> Ubuntu only packages it for 2.7.14. So I won't be moving yet...
>>>
>>> On 5 November 2017 at 13:23, Boudewijn Rempt  wrote:
>>>
 On Sat, 4 Nov 2017, Chris Burel wrote:

 > I think this is a remarkably short sighted statement. It assumes that
 people that would use these bindings have no existing Python codebase at
 all, and can afford to start a brand new project. The reality is much
 different.
 >
 > Let's take a specific example. I have 6 years experience writing
 Python for the visual effects industry. We have a 10 year old Python 2
 codebase. We also use an application from Autodesk called Maya. It has been
 a Qt 4 application with Python 2 embedded since 2012. In 2016 they jumped
 to qt 5 and pyside2. Now Autodesk knows that companies have built large
 codebase around their product that requires Python 2. What would've
 happened if pyside2 did not support Python 2.7? They'd be stuck either
 forcing all their customers to move to Python 3 and risk people not wanting
 the new version of 

D16674: MTP: fix runtime warning when showing a warning to the user.

[Andreas Krutzler]

akrutzler accepted this revision.

REPOSITORY
  R320 KIO Extras

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16674

To: dfaure, akrutzler, elvisangelaccio, apol
Cc: kde-frameworks-devel, kfm-devel, alexde, sourabhboss, feverfew, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.9 - Build # 95 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.9/95/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 05 Nov 2018 20:52:05 +
 Build duration:
2 min 18 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: TestSuite.extractorcollectiontest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)87%
(46/53)87%
(46/53)80%
(2871/3568)48%
(4288/9024)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(15/15)100%
(15/15)97%
(779/799)49%
(1691/3456)src75%
(18/24)75%
(18/24)79%
(1002/1269)44%
(461/1045)src.extractors100%
(12/12)100%
(12/12)73%
(1050/1432)47%
(2065/4362)src.writers100%
(1/1)100%
(1/1)98%
(40/41)48%
(71/149)tests0%
(0/1)0%
(0/1)0%
(0/27)0%
(0/12)

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 116 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/116/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 05 Nov 2018 20:52:05 +
 Build duration:
2 min 32 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 16 test(s)Failed: TestSuite.extractorcollectiontest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)87%
(46/53)87%
(46/53)80%
(2870/3568)47%
(4303/9060)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(15/15)100%
(15/15)97%
(779/799)49%
(1691/3456)src75%
(18/24)75%
(18/24)79%
(1001/1269)44%
(460/1045)src.extractors100%
(12/12)100%
(12/12)73%
(1050/1432)47%
(2081/4398)src.writers100%
(1/1)100%
(1/1)98%
(40/41)48%
(71/149)tests0%
(0/1)0%
(0/1)0%
(0/27)0%
(0/12)

D16672: Add support for speex files to taglibextractor

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:ac63b25577f3: Add support for speex files to 
taglibextractor (authored by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16672?vs=44869=44937

REVISION DETAIL
  https://phabricator.kde.org/D16672

AFFECTED FILES
  autotests/samplefiles/test.spx
  autotests/taglibextractortest.cpp
  src/extractors/taglibextractor.cpp

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16694: Improve visibility for Konsole icon when using Breeze Dark

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.


  Thanks for making those changes. Now we can see the icon, and also an issue 
that needs to be corrected. :) Notice how the corners look really 
bright--especially the bottom corners? That's a problem. I suspect what's 
happening is that the lines you drew to make the border are semi-transparent, 
but overlap one another at the corners, so the corners are mor opaque and 
therefore lighter. Either way, that "dots in the corner" effect must be fixed 
before this can land.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16694

To: anishgiri, ngraham, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D16694: Improve visibility for Konsole icon when using Breeze Dark

[Anish Giri]

anishgiri retitled this revision from "Patch For Bug 367696" to "Improve 
visibility for Konsole icon when using Breeze Dark".
anishgiri edited the summary of this revision.
anishgiri edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16694

To: anishgiri, ngraham, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D16674: MTP: fix runtime warning when showing a warning to the user.

[Elvis Angelaccio]

elvisangelaccio accepted this revision.

REPOSITORY
  R320 KIO Extras

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16674

To: dfaure, akrutzler, elvisangelaccio, apol
Cc: kde-frameworks-devel, kfm-devel, alexde, sourabhboss, feverfew, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D16694: Patch For Bug 367696

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a reviewer: VDG.
ngraham added a comment.
This revision now requires changes to proceed.


  Thanks for the patch! And thanks for using `arc`, too. That makes life a bit 
easier for us. :)
  
  Couple of things:
  
  1. The title becomes the commit message, so please change it to something 
more descriptive, such as, "Improve visibility for Konsole icon when using 
Breeze Dark"
  2. Please add `BUG: 367696` to its own line in the summary section and add 
some explanation there regarding why this patch is necessary.
  3. The Test Plan section is empty; we need some evidence of testing. Can you 
provide some screenshots that show the icon when using Breeze Dark?
  4. In the future, please tag #VDG  for 
anything that involve an icon or visual change.
  
  See also 
https://community.kde.org/Infrastructure/Phabricator#Formatting_your_patch

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16694

To: anishgiri, ngraham, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D16694: Patch For Bug 367696

[Anish Giri]

anishgiri created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
anishgiri requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  utilities-terminal (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16694

AFFECTED FILES
  icons-dark/apps/48/utilities-terminal.svg
  icons-dark/apps/64/utilities-terminal.svg

To: anishgiri
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16692: A QApplication object needs to be instantiated for kio-kdeconnect to work on KDE Neon

[Nicolas Fella]

nicolasfella added a reviewer: Frameworks.

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D16692

To: eduisters, #kde_connect, #frameworks
Cc: kdeconnect, shivanshukantprasad, skymoore, wistak, dvalencia, rmenezes, 
julioc, Leptopoda, timothyc, jdvr, yannux, Danial0_0, johnq, Pitel, adeen-s, 
SemperPeritus, daniel.z.tg, jeanv, seebauer, bugzy, MayeulC, menasshock, 
tctara, apol

D16471: [RFC] Listen for added DBus interfaces instead of registered services

[Fabian Vogt]

fvogt added a comment.


  In D16471#354635 , @jgrulich wrote:
  
  > Is this supposed to fix also the issue where when you log into a Plasma 
session, you first get a notification that it failed to activate a connection 
and then it gets activated successfuly?
  
  
  I only saw that once and was unable to reproduce it, but someone else 
reported it downstream and posted an NM trace log: 
https://bugzilla.suse.com/attachment.cgi?id=777407
  
  A more or less educated guess:
  
  - User logs in
  - NM tries autologin, but no secrets available
  - NM tries WPS as fallback
  - Agent registers
  - WPS returns without success -> notification shown
  - As the agent registered, it queued another autoactivate event
  
  If that's true though it's a bug in NM and this won't fix it.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D16471

To: fvogt, #frameworks, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16471: [RFC] Listen for added DBus interfaces instead of registered services

[Jan Grulich]

jgrulich added a comment.


  Is this supposed to fix also the issue where when you log into a Plasma 
session, you first get a notification that it failed to activate a connection 
and then it gets activated successfuly?

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D16471

To: fvogt, #frameworks, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16593: [ExtractorCollection] Use only best matching extractor plugin

[Ben Cooksley]

bcooksley added a comment.


  You can rely on shared-mime-info being present on all platforms (Linux, 
FreeBSD, Windows, Android) yes.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16593

To: bruns, #frameworks, astippich
Cc: bcooksley, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D16593: [ExtractorCollection] Use only best matching extractor plugin

[Stefan Brüns]

bruns added a comment.


  In D16593#354311 , @bcooksley 
wrote:
  
  > As noted in the build log on the CI system, kfilemetadata doesn't depend on 
kcoreaddons so you therefore cannot rely on the kde5.xml file being available:
  >
  >   [kf5-qt5 SUSEQt5.9] Running shell script
  >+ python3 -u ci-tooling/helpers/prepare-dependencies.py --product 
Frameworks --project kfilemetadata --branchGroup kf5-qt5 --environment 
production --platform SUSEQt5.9 --installTo /home/jenkins//install-prefix/
  >Retrieving: Frameworks-extra-cmake-modules-kf5-qt5
  >Retrieving: Frameworks-ki18n-kf5-qt5
  >Retrieving: Frameworks-karchive-kf5-qt5
  >
  > The CI system is working correctly in this case and as designed, only 
allowing actual dependencies of a project to be used during it's build and 
testing.
  
  
  Obviously the tests require a sufficient dataset for a working QMimeDatabase. 
This hasn't changed, only the extent of required mime types has. Up until now, 
the implicitly installed definitions (shared-mime-info?) did the job.
  
  So, which mime-types are guaranteed by the CI system to be available? Can one 
rely on shared-mime-info? What about Windows/macOS?
  
  There are dozens of mime types in shared-mime-info which are sub-class-of 
application/xml, see:
  `grep -E 'mime-type |sub-class-of.*application/xml'  
/usr/share/mime/packages/freedesktop.org.xml | grep -B1 sub-class-of | head `

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16593

To: bruns, #frameworks, astippich
Cc: bcooksley, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D16684: Updated with petroleum industry units

[Kai Uwe Broulik]

broulik added a comment.


  Looking good now, +1

REPOSITORY
  R292 KUnitConversion

REVISION DETAIL
  https://phabricator.kde.org/D16684

To: joaonetto, ngraham, broulik, #frameworks
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D16676: [server] Put text-input (de-)activate, en-/disable callbacks in child classes

[Roman Gilg]

romangg retitled this revision from "[server] Put (de-)activate, en-/disable 
callbacks in child classes" to "[server] Put text-input (de-)activate, 
en-/disable callbacks in child classes".

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D16676

To: romangg, #kwin, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16684: Updated with petroleum industry units

[Joao Oliveira]

joaonetto updated this revision to Diff 44918.

REPOSITORY
  R292 KUnitConversion

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16684?vs=44917=44918

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16684

AFFECTED FILES
  README.md
  src/CMakeLists.txt
  src/converter.cpp
  src/permeability.cpp
  src/permeability_p.h
  src/unit.h
  src/volume.cpp

To: joaonetto, ngraham, broulik, #frameworks
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D16684: Updated with petroleum industry units

[Joao Oliveira]

joaonetto updated this revision to Diff 44917.
joaonetto marked 3 inline comments as done.
joaonetto added a comment.


  permeability.h renamed to permeability_p.h and change Darcy to start at 33000

REPOSITORY
  R292 KUnitConversion

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16684?vs=44914=44917

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16684

AFFECTED FILES
  README.md
  src/CMakeLists.txt
  src/converter.cpp
  src/permeability.cpp
  src/permeability_p.h
  src/unit.h
  src/volume.cpp

To: joaonetto, ngraham, broulik, #frameworks
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D16684: Updated with petroleum industry units

[Kai Uwe Broulik]

broulik added a comment.


  The header file for `class Permeability` should probably be named 
`permeability_p.h` to match the other category classes since it's a not 
exported implementation detail

INLINE COMMENTS

> unit.h:335
> +/** @since 5.53 */
> +Darcy,
> +/** @since 5.53 */

Given this is a new category, assign `Darcy = 33000` so that one can still add 
new values after `Yoctoohm` to electrical resistance category without breaking 
compatibility

REPOSITORY
  R292 KUnitConversion

REVISION DETAIL
  https://phabricator.kde.org/D16684

To: joaonetto, ngraham, broulik, #frameworks
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D16594: Add context to kcmodule connection to lambdas

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R295:2da8aed41663: Add context to kcmodule connection to 
lambdas (authored by davidedmundson).

REPOSITORY
  R295 KCMUtils

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16594?vs=44659=44915

REVISION DETAIL
  https://phabricator.kde.org/D16594

AFFECTED FILES
  src/kcmoduleqml.cpp

To: davidedmundson, #plasma, broulik, bruns
Cc: bruns, kde-frameworks-devel, michaelh, ngraham

D16684: Updated with petroleum industry units

[Joao Oliveira]

joaonetto updated this revision to Diff 44914.
joaonetto marked an inline comment as done.
joaonetto added a comment.


  Reviewed with comments made on this diff.

REPOSITORY
  R292 KUnitConversion

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16684?vs=44906=44914

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16684

AFFECTED FILES
  README.md
  src/CMakeLists.txt
  src/converter.cpp
  src/permeability.cpp
  src/permeability.h
  src/unit.h
  src/volume.cpp

To: joaonetto, ngraham, broulik, #frameworks
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D16684: Updated with petroleum industry units

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> unit.h:65
> +ElectricalResistanceCategory,
> +PermeabilityCategory
>  };

Please add `/** @since 5.53 */` here, following the pattern.

REPOSITORY
  R292 KUnitConversion

REVISION DETAIL
  https://phabricator.kde.org/D16684

To: joaonetto, ngraham, broulik, #frameworks
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D16685: Fix issue where there's only one element on the menu

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R858:8fa114df0ad1: Fix issue where theres only one 
element on the menu (authored by apol).

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16685?vs=44908=44913

REVISION DETAIL
  https://phabricator.kde.org/D16685

AFFECTED FILES
  org.kde.desktop/Menu.qml

To: apol, #frameworks, mart, ngraham
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16681: Updated with petroleum industry units

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> unit.h:65
> +ElectricalResistanceCategory,
> +PermeabilityCategory
>  };

`/** @since 5.53 */` is needed here too.

REPOSITORY
  R292 KUnitConversion

REVISION DETAIL
  https://phabricator.kde.org/D16681

To: joaonetto, ngraham, broulik, #frameworks
Cc: apol, ngraham, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.9 - Build # 74 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.9/74/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 05 Nov 2018 15:06:09 +
 Build duration:
22 min and counting
   JUnit Tests
  Name: (root) Failed: 5 test(s), Passed: 41 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: TestSuite.kwayland-testPlasmaVirtualDesktopFailed: TestSuite.kwayland-testPlasmaWindowModelFailed: TestSuite.kwayland-testRemoteAccessFailed: TestSuite.kwayland-testWaylandSurfaceFailed: TestSuite.kwayland-testWindowmanagement
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)91%
(233/257)91%
(233/257)82%
(23830/29106)50%
(9367/18779)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client95%
(40/42)95%
(40/42)90%
(10892/12054)46%
(5781/12589)autotests.server100%
(5/5)100%
(5/5)99%
(353/356)49%
(169/344)src.client97%
(71/73)97%
(71/73)82%
(5657/6925)63%
(1490/2370)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server99%
(115/116)99%
(115/116)84%
(6847/8181)63%
(1927/3061)src.tools0%
(0/2)0%
(0/2)0%
(0/693)0%
(0/272)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/69)0%
(0/10)tests0%
(0/14)0%
(0/14)0%
(0/747)0%
(0/133)

Re: Downtime announcement: www.kde.org

[Bhushan Shah]

[sending again from right address since my gmail address is not
subscribed to somee lists]

Hello,

On Mon, Nov 05, 2018 at 11:02:43PM +1300, Ben Cooksley wrote:
> > In order to allow for hardware maintenance, one of our physical
> > hardware hosts will need to be shutdown for a few hours on Monday.
> > This downtime will commence around 9:30am UTC and may take several
> > hours.

The maintenance is now completed, and as far as we are aware, all
services are now back up. If you have trouble accessing any of services,
please let us know over email or sysadmin ticket.

Thanks!

> >
> > During this time a number of sites will be inaccessible, including:
> > - www.kde.org
> > - autoconfig.kde.org
> > - docs.kde.org
> > - ev.kde.org
> > - freebsd.kde.org
> > - hig.kde.org
> > - kdesrc-build.kde.org
> > - neon.kde.org
> > - releases.neon.kde.org
> > - networkcheck.kde.org
> > - planet.kde.org
> >
> > Other websites within KDE.org that are dependent on resources hosted
> > on those sites may also experience delayed loading times in browsers
> > during this window.
> >
> > As some of these sites are relied upon by applications to function
> > properly, those applications may experience degraded functionality
> > during this time.
> >
> > Affected applications include:
> > - Discover
> > - Kaffeine
> > - Kopete
> > - Plasma Network Manager (when behind a captive portal)
> > - Any application using GHNS
> >
> > In addition, any other site which is hosted by the server known as
> > "olios.kde.org" will also be unavailable during this time.
> >
> > Apologies for any inconvenience caused.
> 
> The maintenance window has now commenced.
> The above sites will be inaccessible until the maintenance is completed.
> 
> >
> > Regards,
> > Ben Cooksley
> > KDE Sysadmin
> 
> Regards,
> Ben

-- 
Bhushan Shah
http://blog.bshah.in
IRC Nick : bshah on Freenode
GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D


signature.asc
Description: PGP signature

Re: Python bindings using cppyy (was: An update on Python bindings)

[Philipp A.]

Hi Shaheed!

The year is nearing its end, and I wonder if there has been any progress
and/or if you people need help with the bindings!

I’d really like to revive my IPython console in Kate :D

Best, Philipp

Shaheed Haque  schrieb am Sa., 13. Jan. 2018 um
19:06 Uhr:

> Thanks to some upstream fixes, I have the cppyy-based bindings for KF5 and
> also Qt5 (see below) showing signs of life. Notes:
>
>
>1. The packaging has advanced to the point where I think ECM-based
>framework-by-framework bindings are a real possibility, with both Py2 and
>Py3. AFAICS, this addresses the main feedback received to date.
>2. With reference to the remark about tracking dependencies between
>frameworks, apologies for the delayed response as I somehow missed the
>email. I note that the dependencies currently in CMake often seem
>incomplete. I'll bring that to the community separately.
>3. There is one issue still open upstream (
>
> https://bitbucket.org/wlav/cppyy/issues/16/pragma-link-defined_in-seems-to-select).
>However, I don't consider this to be a showstopper...we might even be able
>to live with it as is.
>4. For me, the jury is still out on PyQt versus a new set of
>cppyy-based Qt bindings. Clearly PyQt is solid and mature, but the
>limitations really concern me (if anybody wants to know more, I'm happy to
>discuss, but let's do that in another thread please). Now, given that there
>are examples in the wild of interoperating cppyy/cling/ROOT with PyQt, I'm
>going to sidestep this question but am playing with a cppyy-based approach.
>At this point, all of Qt has basic cppyy-based bindings, and the next step
>is to tackle things like finding a way to express the object
>ownership/destruction rules in a more-or-less systematic way.
>5. On the P2/P3 question, I'm presently still committed to both P2 and
>P3. I *have* had a couple of minor occasions where P3-only might have been
>nice *for my code*, but if I do find an issue that tips the balance, or I
>find some serious benefit *for the bindings*, I'll drop P2. One possible
>such benefit would be if I can see a sane way to address PEP484 type hints.
>
> To get here, I had to build a subset of the tooling I previously had
> developed for the SIP-based approach. The big difference is the absence of
> any need to support customisation of the generated bindings. I am hopeful
> that in the worst case, there might be some minimal customisation (known as
> Pythonisations in cppyy parlance) such as for #4 above, but nothing like
> the scale needed for SIP.
>
> The core tooling is not specific to KF5 or KDE or Qt5, and is developed in
> upstream cppyy over on bitbucket.org. The core tooling is built around
> CMake, notably for the generation phase and the C++ library build.
>
> The PoC extends the core tooling with Pythonic packaging and installation
> using pip/wheels, also from CMake. As before I would look for help to get
> an ECM equivalent, possibly based on the same approach but perhaps
> including CI and distribution via PyPi.
>
> Finally, now would be a good time for anybody else who wants to get
> involved to step up, especially as a new job limits my free time.
>
> Thanks, Shaheed
>
> P.S. Not to stoke the the P2/P3 wars unnecessarily, but while I know that
> upstream Clang just added P3 support in the clang 5.0 release, current
> Ubuntu only packages it for 2.7.14. So I won't be moving yet...
>
> On 5 November 2017 at 13:23, Boudewijn Rempt  wrote:
>
>> On Sat, 4 Nov 2017, Chris Burel wrote:
>>
>> > I think this is a remarkably short sighted statement. It assumes that
>> people that would use these bindings have no existing Python codebase at
>> all, and can afford to start a brand new project. The reality is much
>> different.
>> >
>> > Let's take a specific example. I have 6 years experience writing Python
>> for the visual effects industry. We have a 10 year old Python 2 codebase.
>> We also use an application from Autodesk called Maya. It has been a Qt 4
>> application with Python 2 embedded since 2012. In 2016 they jumped to qt 5
>> and pyside2. Now Autodesk knows that companies have built large codebase
>> around their product that requires Python 2. What would've happened if
>> pyside2 did not support Python 2.7? They'd be stuck either forcing all
>> their customers to move to Python 3 and risk people not wanting the new
>> version of the software, or they'd be prevented from moving to Qt 5.
>> >
>>
>> You will have to switch to Python 3 by 2019, since that's what the VFX
>> Reference Platform says. If you haven't started on the migration yet,
>> you're very late. And the VFX Refernece Platform is basically Autodesk
>> telling the rest of the industry what to use, including their weird
>> patchset for Qt...
>>
>> > So no, Python 2 is not dead. Not by a long shot.
>>
>> For VFX, it will be dead in 2019. See http://www.vfxplatform.com/
>>
>>
>> --
>> Boudewijn Rempt 

Re: Python bindings using cppyy (was: An update on Python bindings)

[Shaheed Haque]

I'm afraid that there has been no progress as I am buried in "startup"
mode. I'm not sure when that might change.

On Mon, 5 Nov 2018, 14:02 Philipp A.  Hi Shaheed!
>
> The year is nearing its end, and I wonder if there has been any progress
> and/or if you people need help with the bindings!
>
> I’d really like to revive my IPython console in Kate :D
>
> Best, Philipp
>
> Shaheed Haque  schrieb am Sa., 13. Jan. 2018 um
> 19:06 Uhr:
>
>> Thanks to some upstream fixes, I have the cppyy-based bindings for KF5
>> and also Qt5 (see below) showing signs of life. Notes:
>>
>>
>>1. The packaging has advanced to the point where I think ECM-based
>>framework-by-framework bindings are a real possibility, with both Py2 and
>>Py3. AFAICS, this addresses the main feedback received to date.
>>2. With reference to the remark about tracking dependencies between
>>frameworks, apologies for the delayed response as I somehow missed
>>the email. I note that the dependencies currently in CMake often seem
>>incomplete. I'll bring that to the community separately.
>>3. There is one issue still open upstream (
>>
>> https://bitbucket.org/wlav/cppyy/issues/16/pragma-link-defined_in-seems-to-select).
>>However, I don't consider this to be a showstopper...we might even be able
>>to live with it as is.
>>4. For me, the jury is still out on PyQt versus a new set of
>>cppyy-based Qt bindings. Clearly PyQt is solid and mature, but the
>>limitations really concern me (if anybody wants to know more, I'm happy to
>>discuss, but let's do that in another thread please). Now, given that 
>> there
>>are examples in the wild of interoperating cppyy/cling/ROOT with PyQt, I'm
>>going to sidestep this question but am playing with a cppyy-based 
>> approach.
>>At this point, all of Qt has basic cppyy-based bindings, and the next step
>>is to tackle things like finding a way to express the object
>>ownership/destruction rules in a more-or-less systematic way.
>>5. On the P2/P3 question, I'm presently still committed to both P2
>>and P3. I *have* had a couple of minor occasions where P3-only might have
>>been nice *for my code*, but if I do find an issue that tips the balance,
>>or I find some serious benefit *for the bindings*, I'll drop P2. One
>>possible such benefit would be if I can see a sane way to address PEP484
>>type hints.
>>
>> To get here, I had to build a subset of the tooling I previously had
>> developed for the SIP-based approach. The big difference is the absence of
>> any need to support customisation of the generated bindings. I am hopeful
>> that in the worst case, there might be some minimal customisation (known as
>> Pythonisations in cppyy parlance) such as for #4 above, but nothing like
>> the scale needed for SIP.
>>
>> The core tooling is not specific to KF5 or KDE or Qt5, and is developed
>> in upstream cppyy over on bitbucket.org. The core tooling is built
>> around CMake, notably for the generation phase and the C++ library build.
>>
>> The PoC extends the core tooling with Pythonic packaging and installation
>> using pip/wheels, also from CMake. As before I would look for help to get
>> an ECM equivalent, possibly based on the same approach but perhaps
>> including CI and distribution via PyPi.
>>
>> Finally, now would be a good time for anybody else who wants to get
>> involved to step up, especially as a new job limits my free time.
>>
>> Thanks, Shaheed
>>
>> P.S. Not to stoke the the P2/P3 wars unnecessarily, but while I know that
>> upstream Clang just added P3 support in the clang 5.0 release, current
>> Ubuntu only packages it for 2.7.14. So I won't be moving yet...
>>
>> On 5 November 2017 at 13:23, Boudewijn Rempt  wrote:
>>
>>> On Sat, 4 Nov 2017, Chris Burel wrote:
>>>
>>> > I think this is a remarkably short sighted statement. It assumes that
>>> people that would use these bindings have no existing Python codebase at
>>> all, and can afford to start a brand new project. The reality is much
>>> different.
>>> >
>>> > Let's take a specific example. I have 6 years experience writing
>>> Python for the visual effects industry. We have a 10 year old Python 2
>>> codebase. We also use an application from Autodesk called Maya. It has been
>>> a Qt 4 application with Python 2 embedded since 2012. In 2016 they jumped
>>> to qt 5 and pyside2. Now Autodesk knows that companies have built large
>>> codebase around their product that requires Python 2. What would've
>>> happened if pyside2 did not support Python 2.7? They'd be stuck either
>>> forcing all their customers to move to Python 3 and risk people not wanting
>>> the new version of the software, or they'd be prevented from moving to Qt 5.
>>> >
>>>
>>> You will have to switch to Python 3 by 2019, since that's what the VFX
>>> Reference Platform says. If you haven't started on the migration yet,
>>> you're very late. And the VFX Refernece Platform is 

D16686: Cleanup Virtual Desktop Manager list entry in PlasmaVirtualDesktop destructor

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Current code contains a path to cleanup
  PlasmaVirtualDesktopManagementInterface's list of destops if the
  PlasmaVirtualDesktop object is destroyed.
  
  However at the time that this is run, the entry in the list is already
  dangling and therefore shouldn't be used.
  
  This patch moves the cleanup logic into the destructor of
  PlasmaVirtualDesktop, however this means we need to make sure
  PlasmaVirtualDesktopManagementInterface outlives the
  PlasmaVirtualDesktop by performing an explicit early cleanup instead of
  relying on QObject.

TEST PLAN
  Relevant unit test still passes.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16686

AFFECTED FILES
  src/server/plasmavirtualdesktop_interface.cpp

To: davidedmundson, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 100 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/100/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 05 Nov 2018 15:06:09 +
 Build duration:
4 min 37 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 44 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: TestSuite.kwayland-testPlasmaVirtualDesktopFailed: TestSuite.kwayland-testPlasmaWindowModel
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)91%
(234/257)91%
(234/257)85%
(24820/29127)53%
(9859/18779)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client98%
(41/42)98%
(41/42)97%
(11702/12057)49%
(6216/12589)autotests.server100%
(5/5)100%
(5/5)99%
(353/356)49%
(169/344)src.client97%
(71/73)97%
(71/73)83%
(5733/6934)64%
(1506/2370)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server99%
(115/116)99%
(115/116)85%
(6951/8190)64%
(1968/3061)src.tools0%
(0/2)0%
(0/2)0%
(0/693)0%
(0/272)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/69)0%
(0/10)tests0%
(0/14)0%
(0/14)0%
(0/747)0%
(0/133)

D16685: Fix issue where there's only one element on the menu

[Marco Martin]

mart accepted this revision.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16685

To: apol, #frameworks, mart, ngraham
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16684: Updated with petroleum industry units

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> permeability.cpp:3
> + *   Copyright (C) 2007-2009 Petri Damstén 
> + *   Copyright (C) 2014 John Layt 
> + *

Since you created this file, this should be your own copyright.

> permeability.h:3
> + *   Copyright (C) 2007-2009 Petri Damstén 
> + *   Copyright (C) 2014 John Layt 
> + *

Since you created this file, this should be your own copyright.

REPOSITORY
  R292 KUnitConversion

REVISION DETAIL
  https://phabricator.kde.org/D16684

To: joaonetto, ngraham, broulik, #frameworks
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D16685: Fix issue where there's only one element on the menu

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Seems like this is only a problem if you have a single-item menu, and if you 
have that, you've done something wrong. :) Regardless, this seems to fix the 
issue, so +1.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16685

To: apol, #frameworks, mart, ngraham
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16685: Fix issue where there's only one element on the menu

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Frameworks, mart.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  This (random) height shows an odd padding on the menu when there's just the 
one
  element.
  
  CCBUG: 400517

TEST PLAN
  I don't get it anymore on Discover

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16685

AFFECTED FILES
  org.kde.desktop/Menu.qml

To: apol, #frameworks, mart
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16684: Updated with petroleum industry units

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added reviewers: broulik, Frameworks.
ngraham added a comment.
This revision now requires changes to proceed.


  Great, thanks! This work well; I just have a few comments, listed below.
  
  To update this diff without accidentally creating a new one, make sure you're 
on the `permeability` branch in your `kunitconversion` repo, then make your 
change and run `arc diff`. It shouldn't try to create a new one.

INLINE COMMENTS

> unit.h:333
> +MiliDarcy,
> +PermeabilitySquareMicrometer
>  };

Can you add `/** @since 5.53 */` above each new one, following the pattern?

> volume.cpp:452
>  
> +addCommonUnit(CustomUnit(VolumeCategory, OilBarrel, 0.158987294,
> + i18nc("volume unit symbol", "bbl"),

I'm not sure this should be marked as a common unit. Because it is, I now get 
oil barrels listed first when I have KRunner convert something like "2 cups" or 
"8 liters".

REPOSITORY
  R292 KUnitConversion

REVISION DETAIL
  https://phabricator.kde.org/D16684

To: joaonetto, ngraham, broulik, #frameworks
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D16681: Updated with petroleum industry units

[Joao Oliveira]

joaonetto abandoned this revision.

REPOSITORY
  R292 KUnitConversion

REVISION DETAIL
  https://phabricator.kde.org/D16681

To: joaonetto, ngraham, broulik, #frameworks
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D16684: Updated with petroleum industry units

[Joao Oliveira]

joaonetto updated this revision to Diff 44906.
joaonetto added a comment.


  Couldn't update D16681 , creating new 
revision

REPOSITORY
  R292 KUnitConversion

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16684?vs=44905=44906

BRANCH
  permeability (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16684

AFFECTED FILES
  README.md
  src/CMakeLists.txt
  src/converter.cpp
  src/permeability.cpp
  src/permeability.h
  src/unit.h
  src/volume.cpp

To: joaonetto
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D16684: Updated with petroleum industry units

[Joao Oliveira]

joaonetto abandoned this revision.

REPOSITORY
  R292 KUnitConversion

REVISION DETAIL
  https://phabricator.kde.org/D16684

To: joaonetto
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D16684: Updated with petroleum industry units

[Joao Oliveira]

joaonetto updated this revision to Diff 44905.
joaonetto added a comment.


  Updated with permeability source code

REPOSITORY
  R292 KUnitConversion

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16684?vs=44904=44905

BRANCH
  permeability (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16684

AFFECTED FILES
  README.md
  src/CMakeLists.txt
  src/converter.cpp
  src/permeability.cpp
  src/permeability.h
  src/unit.h
  src/volume.cpp

To: joaonetto
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D16684: Updated with petroleum industry units

[Nathaniel Graham]

ngraham added a comment.


  Oops, you want to be sure you're on the `permeability` branch when you run 
`arc diff`.

REPOSITORY
  R292 KUnitConversion

REVISION DETAIL
  https://phabricator.kde.org/D16684

To: joaonetto
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D16684: Updated with petroleum industry units

[Joao Oliveira]

joaonetto abandoned this revision.

REPOSITORY
  R292 KUnitConversion

REVISION DETAIL
  https://phabricator.kde.org/D16684

To: joaonetto
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16684: Updated with petroleum industry units

[Joao Oliveira]

joaonetto updated this revision to Diff 44904.
joaonetto added a comment.


  - Updated source code with permeability class

REPOSITORY
  R292 KUnitConversion

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16684?vs=44903=44904

BRANCH
  permeability (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16684

AFFECTED FILES
  README.md
  src/CMakeLists.txt
  src/converter.cpp
  src/permeability.cpp
  src/permeability.h
  src/unit.h
  src/volume.cpp

To: joaonetto
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16681: Updated with petroleum industry units

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added reviewers: broulik, Frameworks.
ngraham added a comment.
This revision now requires changes to proceed.


  Great job, and nice first patch!
  
  Unfortunately, this doesn't compile:
  
-- Configuring done
CMake Error at src/CMakeLists.txt:32 (add_library):
  Cannot find source file:

permeability.cpp

  Tried extensions .c .C .c++ .cc .cpp .cxx .m .M .mm .h .hh .h++ .hm .hpp
  .hxx .in .txx
  
  Looks like the new permeability files  weren't added to the patch. You can 
use `git add  ` to do so, 
then `arc diff` to update the diff.

INLINE COMMENTS

> unit.h:333
> +MiliDarcy,
> +PermeabilitySquareMicrometer
>  };

Can you add `/** @since 5.53 */` for each of these new entries, following the 
pattern?

REPOSITORY
  R292 KUnitConversion

REVISION DETAIL
  https://phabricator.kde.org/D16681

To: joaonetto, ngraham, broulik, #frameworks
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D16684: Updated with petroleum industry units

[Joao Oliveira]

joaonetto created this revision.
joaonetto added a project: Frameworks.
joaonetto requested review of this revision.

REVISION SUMMARY
  Added a new volume unity Oil Barrels and a new permeability class that 
handles Darcy and MiliDarcys.

REPOSITORY
  R292 KUnitConversion

BRANCH
  permeability (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16684

AFFECTED FILES
  README.md
  src/CMakeLists.txt
  src/converter.cpp
  src/unit.h
  src/volume.cpp

To: joaonetto
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16684: Updated with petroleum industry units

[Joao Oliveira]

joaonetto abandoned this revision.

REPOSITORY
  R292 KUnitConversion

REVISION DETAIL
  https://phabricator.kde.org/D16684

To: joaonetto
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16681: Updated with petroleum industry units

[Joao Oliveira]

joaonetto edited the summary of this revision.

REPOSITORY
  R292 KUnitConversion

REVISION DETAIL
  https://phabricator.kde.org/D16681

To: joaonetto
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16681: Updated with petroleum industry units

[Joao Oliveira]

joaonetto updated this revision to Diff 44901.
joaonetto added a comment.


  Updating D16681 : Updated with petroleum 
industry units

REPOSITORY
  R292 KUnitConversion

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16681?vs=44899=44901

BRANCH
  permeability (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16681

AFFECTED FILES
  README.md
  src/CMakeLists.txt
  src/converter.cpp
  src/unit.h
  src/volume.cpp

To: joaonetto
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16681: Updated with petroleum industry units

[Joao Oliveira]

joaonetto created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
joaonetto requested review of this revision.

REVISION SUMMARY
  Added a new volume unity Oil Barrels and a new permeability class that 
handles Darcy and MiliDarcys.

REPOSITORY
  R292 KUnitConversion

BRANCH
  permeability (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16681

AFFECTED FILES
  README.md
  src/CMakeLists.txt
  src/converter.cpp
  src/length.cpp
  src/unit.h
  src/volume.cpp

To: joaonetto
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15999: Add icons with added background to system.svgz

[Phil Stefan]

pstefan updated this revision to Diff 44890.
pstefan added a comment.


  - Fixed z order

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15999?vs=44889=44890

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15999

AFFECTED FILES
  src/desktoptheme/breeze/icons/go.svgz
  src/desktoptheme/breeze/icons/system.svgz

To: pstefan, ngraham, #vdg
Cc: broulik, filipf, kde-frameworks-devel, michaelh, ngraham, bruns

D15999: Add icons with added background to system.svgz

[Phil Stefan]

pstefan updated this revision to Diff 44889.
pstefan added a comment.


  - Added missing class attributes

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15999?vs=44862=44889

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15999

AFFECTED FILES
  src/desktoptheme/breeze/icons/go.svgz
  src/desktoptheme/breeze/icons/system.svgz

To: pstefan, ngraham, #vdg
Cc: broulik, filipf, kde-frameworks-devel, michaelh, ngraham, bruns

Re: Downtime announcement: www.kde.org

[Ben Cooksley]

On Sat, Nov 3, 2018 at 7:50 AM Ben Cooksley  wrote:
>
> Hi all,

Hi all,

>
> In order to allow for hardware maintenance, one of our physical
> hardware hosts will need to be shutdown for a few hours on Monday.
> This downtime will commence around 9:30am UTC and may take several
> hours.
>
> During this time a number of sites will be inaccessible, including:
> - www.kde.org
> - autoconfig.kde.org
> - docs.kde.org
> - ev.kde.org
> - freebsd.kde.org
> - hig.kde.org
> - kdesrc-build.kde.org
> - neon.kde.org
> - releases.neon.kde.org
> - networkcheck.kde.org
> - planet.kde.org
>
> Other websites within KDE.org that are dependent on resources hosted
> on those sites may also experience delayed loading times in browsers
> during this window.
>
> As some of these sites are relied upon by applications to function
> properly, those applications may experience degraded functionality
> during this time.
>
> Affected applications include:
> - Discover
> - Kaffeine
> - Kopete
> - Plasma Network Manager (when behind a captive portal)
> - Any application using GHNS
>
> In addition, any other site which is hosted by the server known as
> "olios.kde.org" will also be unavailable during this time.
>
> Apologies for any inconvenience caused.

The maintenance window has now commenced.
The above sites will be inaccessible until the maintenance is completed.

>
> Regards,
> Ben Cooksley
> KDE Sysadmin

Regards,
Ben

D16677: Add BrightScript syntax

[Daniel Levin]

dlevin added a comment.


  There are various reasons I was using 1-element keyword lists instead of 
StringDetect:
  
  1. keyword properly recognizes value surrounded by non-word characters, 
StringDetect does not.
  2. BrightScript language is case insensitive, adding insensitive="true" to 
every single StringDetect is too verbose in my case.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D16677

To: dlevin, #framework_syntax_highlighting, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, 
demsking, sars, dhaumann

D16299: RFC fallback to dnssd service discovery if smb listDir failed on root

[Harald Sitter]

sitter added a comment.


  It's on my todo, unfortunately I am at a sprint this week so probably nothing 
much happening on this until next week.
  
  Meanwhile I'd still like some comments on the presented diff (:

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D16299

To: sitter, #frameworks, #dolphin
Cc: alexde, bcooksley, ngraham, kde-frameworks-devel, kfm-devel, sourabhboss, 
feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, bruns, 
emmanuelp, mikesomov

D16677: Add BrightScript syntax

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Ok, beside that I am not sure why you use 1-element keyword list instead of 
StringDetect at some places, I see no issues with that.
  If you like, you can change that, otherwise I am fine with that as is.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D16677

To: dlevin, #framework_syntax_highlighting, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, 
demsking, sars, dhaumann