date:20181001

D15070: Bindings: Support using sys paths for python install directory

2018-10-01 Thread Christophe Giboudeaux

cgiboudeaux added inline comments.

INLINE COMMENTS

> FindPythonModuleGeneration.cmake:39
>  #
>  
>  
> #=

KDE_INSTALL_USE_PYTHON${version}_SYS_PATHS shall be added to the doc

> FindPythonModuleGeneration.cmake:206-207
> +  if(KDE_INSTALL_PYTHON${pyversion}DIR)
> + # Use dir from command line
> +
> +  elseif(KDE_INSTALL_USE_PYTHON${pyversion}_SYS_PATHS)

This "if" is not needed if nothing happens.

> FindPythonModuleGeneration.cmake:208
> +
> +  elseif(KDE_INSTALL_USE_PYTHON${pyversion}_SYS_PATHS)
> +if (NOT GPB_PYTHON${pyversion}_SITEARCH)

if(KDE_INSTALL_USE_PYTHON${pyversion}_SYS_PATHS)

if the option is set, KDE_INSTALL_PYTHON${pyversion}DIR can be safely ignored

> FindPythonModuleGeneration.cmake:209
> +  elseif(KDE_INSTALL_USE_PYTHON${pyversion}_SYS_PATHS)
> +if (NOT GPB_PYTHON${pyversion}_SITEARCH)
> +  execute_process (

This variable is not defined anywhere, this if can be removed.

> FindPythonModuleGeneration.cmake:216
> +
> +  else()
> +set(KDE_INSTALL_PYTHON${pyversion}DIR 
> lib/python${pyversion${pyversion}_maj_min}/site-packages)

elseif(NOT DEFINED KDE_INSTALL_PYTHON${pyversion}DIR)

> FindPythonModuleGeneration.cmake:217
> +  else()
> +set(KDE_INSTALL_PYTHON${pyversion}DIR 
> lib/python${pyversion${pyversion}_maj_min}/site-packages)
> +  endif()

"lib" is hardcoded. it shouldn't.
the commit log also mentions the patch uses dist-packages on Debian and its 
forks. This is not the case here.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D15070

To: bruns, #frameworks
Cc: cgiboudeaux, bcooksley, kde-frameworks-devel, kde-buildsystem, michaelh, 
ngraham, bruns

D15853: Change drive-harddisk to more adaptable style

2018-10-01 Thread Kai Uwe Broulik

broulik added a comment.


  In D15853#334609 , @mart wrote:
  
  > What's that white blob on top of the hard disk? it looks really weird
  
  
  Hard drives typically have this swivel elevated section that this tries to 
simulate.
  For a lack of a better picture: 
https://de.wikipedia.org/wiki/Datei:Damaged_Hard_disk_drive_for_data_protection_.JPG
 see the elevated sections on the top case?

REPOSITORY
  R266 Breeze Icons

BRANCH
  new-harddisk-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15853

To: ndavis, #vdg, ngraham, pstefan
Cc: broulik, mart, pstefan, ngraham, bruns, kde-frameworks-devel, michaelh

D15873: Improve debugging output by displaying whether the SMBSlave::del() function attempts to delete a file or a directory.

2018-10-01 Thread Michal Malý

madcatx created this revision.
madcatx added a reviewer: elvisangelaccio.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
madcatx requested review of this revision.

REVISION SUMMARY
  This has proven to be useful while I was tracking down what seems like a 
glitch in libsmbclient.
  
  Relevant Samba bug report: https://bugzilla.samba.org/show_bug.cgi?id=13637

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D15873

AFFECTED FILES
  smb/kio_smb_dir.cpp

To: madcatx, elvisangelaccio
Cc: kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp

D15871: Add a specific error string for ENOTEMPTY return code in SMB slave.

2018-10-01 Thread Kai Uwe Broulik

broulik added a reviewer: sitter.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D15871

To: madcatx, elvisangelaccio, sitter
Cc: kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp

D15818: [Exe Thumbnailer] Ignore depth > 32

2018-10-01 Thread Kai Uwe Broulik

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:5943efcfed8d: [Exe Thumbnailer] Ignore depth  32 
(authored by broulik).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15818?vs=42492=42638

REVISION DETAIL
  https://phabricator.kde.org/D15818

AFFECTED FILES
  thumbnail/icoutils_common.cpp

To: broulik, anthonyfieroni
Cc: kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp

D15819: [Exe Thumbnailer] Workaround Qt bug in ico detection heuristic

2018-10-01 Thread Kai Uwe Broulik

This revision was automatically updated to reflect the committed changes.
Closed by commit R320:f7be890d3acd: [Exe Thumbnailer] Workaround Qt bug in ico 
detection heuristic (authored by broulik).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15819?vs=42493=42639

REVISION DETAIL
  https://phabricator.kde.org/D15819

AFFECTED FILES
  thumbnail/icoutils_common.cpp

To: broulik, ngraham, anthonyfieroni, cfeck
Cc: cfeck, kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp

KDE CI: Frameworks » purpose » kf5-qt5 WindowsMSVCQt5.11 - Build # 12 - Still unstable!

2018-10-01 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20WindowsMSVCQt5.11/12/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Mon, 01 Oct 2018 08:32:08 +
 Build duration:
2 min 39 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.alternativesmodeltestFailed: TestSuite.menutest

D15851: Fix signals not being emitted when merging two persons

2018-10-01 Thread Daniel Vrátil

dvratil accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R307 KPeople

BRANCH
  forgotten-signal (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15851

To: poboiko, #frameworks, dvratil
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15866: Reduce emblem size for very small icons to prevent obscuring too much of the icon

2018-10-01 Thread Kai Uwe Broulik

broulik added a comment.


  Did you test this with other icon sets, such as Oxygen? It may work with SVG 
ones but not pixel-based iconsets. Oxygen only has 8x8 emblems.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D15866

To: ngraham, #frameworks, #dolphin, #vdg
Cc: broulik, ndavis, kde-frameworks-devel, michaelh, ngraham, bruns

D15853: Change drive-harddisk to more adaptable style

2018-10-01 Thread Marco Martin

mart added a comment.


  What's that white blob on top of the hard disk? it looks really weird

REPOSITORY
  R266 Breeze Icons

BRANCH
  new-harddisk-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15853

To: ndavis, #vdg, ngraham, pstefan
Cc: mart, pstefan, ngraham, bruns, kde-frameworks-devel, michaelh

D15871: Add a specific error string for ENOTEMPTY return code in SMB slave.

2018-10-01 Thread Michal Malý

madcatx created this revision.
madcatx added a reviewer: elvisangelaccio.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
madcatx requested review of this revision.

REVISION SUMMARY
  ENOEMPTY return code may be a valid return code from i.e. smbc_rmdir(). The 
current error reporting code lets such an error code fall through to the 
default report case, leading to confusing information reported back to the 
user. This patch adds such a case branch.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D15871

AFFECTED FILES
  smb/kio_smb_browse.cpp

To: madcatx, elvisangelaccio
Cc: kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp

D15872: Fix Oxygen background gradient for QML modules

2018-10-01 Thread Loïc Yhuel

hwti created this revision.
hwti added reviewers: mart, VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
hwti requested review of this revision.

REVISION SUMMARY
  We need to make the QQuickWidget transparent, so we see the window 
background, which can be a gradient with Oxygen, instead of a solid color which 
doesn't match the top and bottom of the window.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D15872

AFFECTED FILES
  src/kcmoduleqml.cpp

To: hwti, mart, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15866: Reduce emblem size for very small icons to prevent obscuring too much of the icon

2018-10-01 Thread Noah Davis

ndavis added a comment.


  In D15866#334846 , @ngraham wrote:
  
  > You mean like this?
  >
  >   [Icon] [emblem] Label
  >
  
  
  Yes, like that.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D15866

To: ngraham, #frameworks, #dolphin, #vdg
Cc: broulik, ndavis, kde-frameworks-devel, michaelh, ngraham, bruns

D15353: Use _NET_WM_WINDOW_TYPE_COMBO instead of _NET_WM_WINDOW_TYPE_COMBOBOX

2018-10-01 Thread Vlad Zagorodniy

zzag added a comment.


  Ping.

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D15353

To: zzag, #kwin
Cc: romangg, aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D15891: Fix monochrome icons missing stylesheets

2018-10-01 Thread Noah Davis

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  Some icons were lacking compatibility with system color schemes and that was 
fixed. Nothing about the appearance of these icons was changed.

REPOSITORY
  R266 Breeze Icons

BRANCH
  add-stylesheets (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15891

AFFECTED FILES
  icons-dark/actions/22/application-exit.svg
  icons-dark/actions/22/call-stop.svg
  icons-dark/actions/22/document-close.svg
  icons-dark/actions/22/edit-delete.svg
  icons-dark/actions/22/im-ban-kick-user.svg
  icons-dark/actions/22/im-kick-user.svg
  icons-dark/actions/22/irc-remove-operator.svg
  icons-dark/actions/22/irc-unvoice.svg
  icons-dark/actions/22/news-unsubscribe.svg
  icons-dark/actions/22/process-stop.svg
  icons-dark/actions/22/window-close.svg
  icons-dark/actions/24/application-exit.svg
  icons-dark/actions/24/call-stop.svg
  icons-dark/actions/24/document-close.svg
  icons-dark/actions/24/edit-delete.svg
  icons-dark/actions/32/application-exit.svg
  icons-dark/actions/32/call-stop.svg
  icons-dark/actions/32/document-close.svg
  icons-dark/actions/32/edit-delete.svg
  icons-dark/actions/32/window-close.svg
  icons-dark/apps/16/firewall-applet-error.svg
  icons-dark/apps/16/firewall-applet-panic.svg
  icons-dark/apps/16/firewall-applet-shields_up.svg
  icons-dark/apps/16/firewall-applet.svg
  icons-dark/apps/16/hotspot.svg
  icons-dark/apps/16/plasmavault.svg
  icons-dark/apps/22/firewall-applet-error.svg
  icons-dark/apps/22/firewall-applet-panic.svg
  icons-dark/apps/22/firewall-applet-shields_up.svg
  icons-dark/apps/22/firewall-applet.svg
  icons-dark/apps/22/hotspot.svg
  icons-dark/apps/22/plasmavault.svg
  icons/actions/22/application-exit.svg
  icons/actions/22/call-stop.svg
  icons/actions/22/document-close.svg
  icons/actions/22/edit-delete.svg
  icons/actions/22/im-ban-kick-user.svg
  icons/actions/22/im-kick-user.svg
  icons/actions/22/irc-remove-operator.svg
  icons/actions/22/irc-unvoice.svg
  icons/actions/22/news-unsubscribe.svg
  icons/actions/22/process-stop.svg
  icons/actions/22/window-close.svg
  icons/actions/24/application-exit.svg
  icons/actions/24/call-stop.svg
  icons/actions/24/document-close.svg
  icons/actions/24/edit-delete.svg
  icons/actions/32/application-exit.svg
  icons/actions/32/call-stop.svg
  icons/actions/32/document-close.svg
  icons/actions/32/edit-delete.svg
  icons/actions/32/window-close.svg
  icons/apps/16/firewall-applet-error.svg
  icons/apps/16/firewall-applet-panic.svg
  icons/apps/16/firewall-applet-shields_up.svg
  icons/apps/16/firewall-applet.svg
  icons/apps/16/hotspot.svg
  icons/apps/16/plasmavault.svg
  icons/apps/22/firewall-applet-error.svg
  icons/apps/22/firewall-applet-panic.svg
  icons/apps/22/firewall-applet-shields_up.svg
  icons/apps/22/firewall-applet.svg
  icons/apps/22/hotspot.svg
  icons/apps/22/plasmavault.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15890: kimg_rgb: optimize away QRegExp and QString::fromLocal8Bit.

2018-10-01 Thread Christoph Feck

cfeck accepted this revision.
cfeck added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> rgb.cpp:702
>  
> -const QRegExp regexp(QLatin1String("^\x01\xda\x01[\x01\x02]"));
> -QString data(QString::fromLocal8Bit(head));
> -
> -return data.contains(regexp);
> +return head.size() >= 4 && head.startsWith("\x01\xda\x01") && (head[3] 
> == 1 || head[3] == 2);
>  }

head[i] → head.at(i)

REPOSITORY
  R287 KImageFormats

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15890

To: dfaure, cfeck
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15890: kimg_rgb: optimize away QRegExp and QString::fromLocal8Bit.

2018-10-01 Thread David Faure

dfaure created this revision.
dfaure added a reviewer: cfeck.
Herald added a project: Frameworks.
Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks.
dfaure requested review of this revision.

REVISION SUMMARY
  The code is even simpler this way.
  
  Found by using heaptrack.

TEST PLAN
  the unittest for rgb still passes.

REPOSITORY
  R287 KImageFormats

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15890

AFFECTED FILES
  src/imageformats/rgb.cpp

To: dfaure, cfeck
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15070: Bindings: Support using sys paths for python install directory

2018-10-01 Thread Stefan Brüns

bruns marked 2 inline comments as done.
bruns added inline comments.

INLINE COMMENTS

> cgiboudeaux wrote in FindPythonModuleGeneration.cmake:39
> KDE_INSTALL_USE_PYTHON${version}_SYS_PATHS shall be added to the doc

Yes, will do.

> cgiboudeaux wrote in FindPythonModuleGeneration.cmake:206-207
> This "if" is not needed if nothing happens.

Structural comment - if KDE_INSTALL_PYTHON${pyversion}DIR is set you can skip 
reading the whole block

> cgiboudeaux wrote in FindPythonModuleGeneration.cmake:209
> This variable is not defined anywhere, this if can be removed.

Yes, leftover ...

> cgiboudeaux wrote in FindPythonModuleGeneration.cmake:216
> elseif(NOT DEFINED KDE_INSTALL_PYTHON${pyversion}DIR)

Depends on which variable you want to win if both (K_I_PYTHONx_DIR and 
K_I_USE_PYTHONx_SYS_PATH) are defined

> cgiboudeaux wrote in FindPythonModuleGeneration.cmake:217
> "lib" is hardcoded. it shouldn't.
> the commit log also mentions the patch uses dist-packages on Debian and its 
> forks. This is not the case here.

Keeping broken behaviour for backwards compatibility, see line 445, 455 in the 
original version.
If not installing below the python prefix, its an arbitrary path anyway.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D15070

To: bruns, #frameworks
Cc: cgiboudeaux, bcooksley, kde-frameworks-devel, kde-buildsystem, michaelh, 
ngraham, bruns

D15851: Fix signals not being emitted when merging two persons

2018-10-01 Thread Igor Poboiko

poboiko closed this revision.

REPOSITORY
  R307 KPeople

REVISION DETAIL
  https://phabricator.kde.org/D15851

To: poboiko, #frameworks, dvratil
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D6513: Add support for Attica tags support

2018-10-01 Thread Dan Leinir Turthra Jensen

This revision was automatically updated to reflect the committed changes.
Closed by commit R304:158ba4e2420b: Add support for Attica tags support 
(authored by leinir).

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6513?vs=42360=42657

REVISION DETAIL
  https://phabricator.kde.org/D6513

AFFECTED FILES
  autotests/knewstuffentrytest.cpp
  src/attica/atticaprovider.cpp
  src/core/CMakeLists.txt
  src/core/engine.cpp
  src/core/engine.h
  src/core/entryinternal.cpp
  src/core/entryinternal.h
  src/core/provider.cpp
  src/core/provider.h
  src/core/tagsfilterchecker.cpp
  src/core/tagsfilterchecker.h
  src/staticxml/staticxmlprovider.cpp
  tests/CMakeLists.txt
  tests/khotnewstuff_test-ui/main.qml
  tests/khotnewstuff_test-ui/main.qmlc
  tests/khotnewstuff_test.knsrc.in
  tests/knewstuff2_test.cpp
  tests/knewstuff2_test.h
  tests/knewstuff2_test.knsrc
  tests/testdata/entry.xml
  tests/testdata/provider.xml

To: leinir, #knewstuff, apol, #kde_store, whiting, ahiemstra, mlaurent, dfaure, 
cfeck
Cc: rikmills, dfaure, cfeck, mlaurent, ngraham, ahiemstra, 
kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, bruns

D15873: Improve debugging output by displaying whether the SMBSlave::del() function attempts to delete a file or a directory.

2018-10-01 Thread Kai Uwe Broulik

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D15873

To: madcatx, elvisangelaccio, broulik
Cc: kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp

KDE CI: Frameworks » knewstuff » kf5-qt5 SUSEQt5.10 - Build # 114 - Still Unstable!

2018-10-01 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20SUSEQt5.10/114/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 01 Oct 2018 11:49:52 +
 Build duration:
1 min 29 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: TestSuite.kmoretoolstest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report38%
(5/13)17%
(11/63)17%
(11/63)15%
(901/5957)12%
(435/3512)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)100%
(81/81)53%
(38/72)autotests.kmoretools50%
(1/2)50%
(1/2)73%
(198/273)37%
(63/172)src22%
(2/9)22%
(2/9)2%
(22/960)0%
(0/368)src.attica0%
(0/2)0%
(0/2)0%
(0/298)0%
(0/229)src.core17%
(3/18)17%
(3/18)10%
(190/1819)11%
(146/1317)src.core.jobs0%
(0/6)0%
(0/6)0%
(0/185)0%
(0/83)src.kmoretools60%
(3/5)60%
(3/5)52%
(410/796)36%
(188/528)src.qtquick0%
(0/5)0%
(0/5)0%
(0/276)0%
(0/104)src.staticxml0%
(0/1)0%
(0/1)0%
(0/169)0%
(0/148)src.ui0%
(0/8)0%
(0/8)0%
(0/745)0%
(0/317)src.upload0%
(0/1)0%
(0/1)0%
(0/121)0%
(0/80)tests0%
(0/3)0%
(0/3)0%
(0/133)0%
(0/72)tests.kmoretools0%
(0/1)0%
(0/1)0%
(0/101)0%
(0/22)

KDE CI: Frameworks » knewstuff » kf5-qt5 SUSEQt5.9 - Build # 73 - Still Unstable!

2018-10-01 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20SUSEQt5.9/73/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 01 Oct 2018 11:49:52 +
 Build duration:
1 min 28 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: TestSuite.kmoretoolstest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report38%
(5/13)17%
(11/63)17%
(11/63)15%
(901/5957)12%
(435/3512)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)100%
(81/81)53%
(38/72)autotests.kmoretools50%
(1/2)50%
(1/2)73%
(198/273)37%
(63/172)src22%
(2/9)22%
(2/9)2%
(22/960)0%
(0/368)src.attica0%
(0/2)0%
(0/2)0%
(0/298)0%
(0/229)src.core17%
(3/18)17%
(3/18)10%
(190/1819)11%
(146/1317)src.core.jobs0%
(0/6)0%
(0/6)0%
(0/185)0%
(0/83)src.kmoretools60%
(3/5)60%
(3/5)52%
(410/796)36%
(188/528)src.qtquick0%
(0/5)0%
(0/5)0%
(0/276)0%
(0/104)src.staticxml0%
(0/1)0%
(0/1)0%
(0/169)0%
(0/148)src.ui0%
(0/8)0%
(0/8)0%
(0/745)0%
(0/317)src.upload0%
(0/1)0%
(0/1)0%
(0/121)0%
(0/80)tests0%
(0/3)0%
(0/3)0%
(0/133)0%
(0/72)tests.kmoretools0%
(0/1)0%
(0/1)0%
(0/101)0%
(0/22)

D15353: Use _NET_WM_WINDOW_TYPE_COMBO instead of _NET_WM_WINDOW_TYPE_COMBOBOX

2018-10-01 Thread Roman Gilg

romangg accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R278 KWindowSystem

BRANCH
  use-combo-instead-of-combobox

REVISION DETAIL
  https://phabricator.kde.org/D15353

To: zzag, #kwin, romangg
Cc: romangg, aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D15843: Allow FileIndexerConfig to check device mounted status by path.

2018-10-01 Thread Stefan Brüns

bruns added a comment.


  In D15843#335011 , @smithjd wrote:
  
  > In D15843#334518 , @ngraham 
wrote:
  >
  > >
  >
  >
  > This patch (or the other) is a requirement to augment the **current 
implementation** indexing of multiple devices with **safe** cleanup of the dead 
entries of multiple devices. It does not care about potential problems with the 
generated document id used by the database.
  
  
  No, it is not safe. Did some experiments with 2 Vaults a few days ago (Vault 
does not matter, could be any other mounted storage). After unmounting both and 
mounting one again, it had the device ID of the other one.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15843

To: smithjd, #baloo, bruns
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, bruns, abrahams

KDE CI: Frameworks » knewstuff » kf5-qt5 SUSEQt5.9 - Build # 74 - Still Unstable!

2018-10-01 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20SUSEQt5.9/74/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 01 Oct 2018 20:07:38 +
 Build duration:
2 min 56 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: TestSuite.kmoretoolstest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report38%
(5/13)17%
(11/63)17%
(11/63)15%
(901/5957)12%
(439/3554)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)100%
(81/81)53%
(38/72)autotests.kmoretools50%
(1/2)50%
(1/2)73%
(198/273)37%
(63/172)src22%
(2/9)22%
(2/9)2%
(22/960)0%
(0/376)src.attica0%
(0/2)0%
(0/2)0%
(0/298)0%
(0/231)src.core17%
(3/18)17%
(3/18)10%
(190/1819)11%
(146/1345)src.core.jobs0%
(0/6)0%
(0/6)0%
(0/185)0%
(0/83)src.kmoretools60%
(3/5)60%
(3/5)52%
(410/796)36%
(192/532)src.qtquick0%
(0/5)0%
(0/5)0%
(0/276)0%
(0/104)src.staticxml0%
(0/1)0%
(0/1)0%
(0/169)0%
(0/148)src.ui0%
(0/8)0%
(0/8)0%
(0/745)0%
(0/317)src.upload0%
(0/1)0%
(0/1)0%
(0/121)0%
(0/80)tests0%
(0/3)0%
(0/3)0%
(0/133)0%
(0/72)tests.kmoretools0%
(0/1)0%
(0/1)0%
(0/101)0%
(0/22)

D15890: kimg_rgb: optimize away QRegExp and QString::fromLocal8Bit.

2018-10-01 Thread David Faure

dfaure added inline comments.

INLINE COMMENTS

> cfeck wrote in rgb.cpp:702
> head[i] → head.at(i)

This would make no difference, given that I made `head` const...

REPOSITORY
  R287 KImageFormats

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15890

To: dfaure, cfeck
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15892: [Devicenotifications Engine] Keep at most one notification per UDI

2018-10-01 Thread Stefan Brüns

bruns created this revision.
bruns added a reviewer: Frameworks.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Each notification was created as new datasource, and was newer removed
  as long as the engine exists. This is especially bad for long living
  applets like the device notifier. As there can only be one notification
  per device (the last error state, or none), use the UDI as source name
  and update the contents.
  
  Also cancel (remove source) an old notifications in case of a successful
  setup, otherwise old error messages are shown in the device notifier.

TEST PLAN
  in Dolphin, select "Release" (context menu) for a mounted CD
  -> Notification in device notifier appears "Device can be safely removed"
  remount without ejecting
  -> Notification message is removed, device shows "mounted" emblem.
  
  Without the change, the message stayed and the device kept the notification
  emblem "(!)".

REPOSITORY
  R120 Plasma Workspace

BRANCH
  device_notifier_qml_fix2

REVISION DETAIL
  https://phabricator.kde.org/D15892

AFFECTED FILES
  dataengines/devicenotifications/devicenotificationsengine.cpp
  dataengines/devicenotifications/devicenotificationsengine.h
  dataengines/devicenotifications/ksolidnotify.cpp
  dataengines/devicenotifications/ksolidnotify.h

To: bruns, #frameworks
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15853: Change drive-harddisk to more adaptable style

2018-10-01 Thread Stefan Brüns

bruns added a comment.


  In D15853#334680 , @broulik wrote:
  
  > In D15853#334609 , @mart wrote:
  >
  > > What's that white blob on top of the hard disk? it looks really weird
  >
  >
  > Hard drives typically have this swivel elevated section that this tries to 
simulate.
  >  For a lack of a better picture: 
https://de.wikipedia.org/wiki/Datei:Damaged_Hard_disk_drive_for_data_protection_.JPG
 see the elevated sections on the top case?
  
  
  Two examples, a good matching one and a slighly different:
  https://gzhls.at/i/75/63/757563-n0.jpg
  https://gzhls.at/i/82/31/1508231-n1.jpg

REPOSITORY
  R266 Breeze Icons

BRANCH
  new-harddisk-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15853

To: ndavis, #vdg, ngraham, pstefan
Cc: broulik, mart, pstefan, ngraham, bruns, kde-frameworks-devel, michaelh

D15866: Reduce emblem size for very small icons to prevent obscuring too much of the icon

2018-10-01 Thread Nathaniel Graham

ngraham added a comment.


  In D15866#334519 , @ndavis wrote:
  
  > The emblem for the 16px version is too small to read.
  
  
  
  
  In D15866#334607 , @broulik wrote:
  
  > Did you test this with other icon sets, such as Oxygen? It may work with 
SVG ones but not pixel-based iconsets. Oxygen only has 8x8 emblems.
  
  
  It seems we have a problem, then:
  
  - 8x8 emblems take up 25% of a 16x16 icon's space, rendering the icon 
difficult to distinguish
  - 6x6 emblems are unreadable and/or look bad (for raster icons that get 
scaled)
  
  Suggestions?
  
  In D15866#334519 , @ndavis wrote:
  
  >
  
  
  What if instead of the emblem being on top of the icon, it was off to the 
side? Then it wouldn't matter what size the emblem is as long as it looks good 
where it is.
  
  You mean like this?
  
[Icon] [emblem] Label

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D15866

To: ngraham, #frameworks, #dolphin, #vdg
Cc: broulik, ndavis, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 56 - Still Unstable!

2018-10-01 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/56/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 01 Oct 2018 14:25:02 +
 Build duration:
1 min 18 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)83%
(5/6)83%
(5/6)34%
(102/299)20%
(36/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)74%
(42/57)56%
(10/18)autotests80%
(4/5)80%
(4/5)25%
(60/242)16%
(26/164)

D15853: Change drive-harddisk to more adaptable style

2018-10-01 Thread Nathaniel Graham

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:3f7ca1b59557: Change drive-harddisk to more adaptable 
style (authored by ndavis, committed by ngraham).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15853?vs=42621=42667

REVISION DETAIL
  https://phabricator.kde.org/D15853

AFFECTED FILES
  icons-dark/devices/16/drive-harddisk.svg
  icons-dark/devices/22/drive-harddisk.svg
  icons-dark/devices/64/drive-harddisk.svg
  icons/devices/16/drive-harddisk.svg
  icons/devices/22/drive-harddisk.svg
  icons/devices/64/drive-harddisk.svg

To: ndavis, #vdg, ngraham, pstefan
Cc: broulik, mart, pstefan, ngraham, bruns, kde-frameworks-devel, michaelh

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.10 - Build # 112 - Still Unstable!

2018-10-01 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.10/112/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 01 Oct 2018 14:25:02 +
 Build duration:
3 min 59 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)83%
(5/6)83%
(5/6)34%
(102/299)20%
(36/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)74%
(42/57)56%
(10/18)autotests80%
(4/5)80%
(4/5)25%
(60/242)16%
(26/164)

D15277: [RFC] kio_mtp: Move MTP device handling from kioslave to kiod-module

2018-10-01 Thread Andreas Krutzler

akrutzler updated this revision to Diff 42685.
akrutzler marked 5 inline comments as done.
akrutzler added a comment.


  - Use QString() directly instead of QStringLiteral("")
  - Use explicit specifier
  - Call either finished or error in slave methods

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15277?vs=42450=42685

BRANCH
  mtp_next

REVISION DETAIL
  https://phabricator.kde.org/D15277

AFFECTED FILES
  mtp/CMakeLists.txt
  mtp/devicecache.cpp
  mtp/devicecache.h
  mtp/filecache.cpp
  mtp/filecache.h
  mtp/kio_mtp.cpp
  mtp/kio_mtp.h
  mtp/kio_mtp_helpers.cpp
  mtp/kio_mtp_helpers.h
  mtp/kiod_module/CMakeLists.txt
  mtp/kiod_module/kmtpd.cpp
  mtp/kiod_module/kmtpd.h
  mtp/kiod_module/kmtpd.json
  mtp/kiod_module/mtpdevice.cpp
  mtp/kiod_module/mtpdevice.h
  mtp/kiod_module/mtpstorage.cpp
  mtp/kiod_module/mtpstorage.h
  mtp/shared/CMakeLists.txt
  mtp/shared/kmtpdeviceinterface.cpp
  mtp/shared/kmtpdeviceinterface.h
  mtp/shared/kmtpdinterface.cpp
  mtp/shared/kmtpdinterface.h
  mtp/shared/kmtpfile.cpp
  mtp/shared/kmtpfile.h
  mtp/shared/kmtpstorageinterface.cpp
  mtp/shared/kmtpstorageinterface.h
  mtp/shared/org.kde.kmtp.daemon.xml
  mtp/shared/org.kde.kmtp.device.xml
  mtp/shared/org.kde.kmtp.storage.xml

To: akrutzler, elvisangelaccio, ltoscano, hetzenecker, dfaure, mlaurent
Cc: mlaurent, kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp

D15277: [RFC] kio_mtp: Move MTP device handling from kioslave to kiod-module

2018-10-01 Thread Andreas Krutzler

akrutzler added inline comments.

INLINE COMMENTS

> mlaurent wrote in mtpstorage.cpp:176
> QString() directly no ?

Of course, thanks! :)

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D15277

To: akrutzler, elvisangelaccio, ltoscano, hetzenecker, dfaure, mlaurent
Cc: mlaurent, kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp

KDE CI: Frameworks » knewstuff » kf5-qt5 SUSEQt5.10 - Build # 115 - Still Unstable!

2018-10-01 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20SUSEQt5.10/115/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 01 Oct 2018 20:07:38 +
 Build duration:
6 min 19 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: TestSuite.kmoretoolstest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report38%
(5/13)17%
(11/63)17%
(11/63)15%
(901/5957)12%
(439/3554)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)100%
(81/81)53%
(38/72)autotests.kmoretools50%
(1/2)50%
(1/2)73%
(198/273)37%
(63/172)src22%
(2/9)22%
(2/9)2%
(22/960)0%
(0/376)src.attica0%
(0/2)0%
(0/2)0%
(0/298)0%
(0/231)src.core17%
(3/18)17%
(3/18)10%
(190/1819)11%
(146/1345)src.core.jobs0%
(0/6)0%
(0/6)0%
(0/185)0%
(0/83)src.kmoretools60%
(3/5)60%
(3/5)52%
(410/796)36%
(192/532)src.qtquick0%
(0/5)0%
(0/5)0%
(0/276)0%
(0/104)src.staticxml0%
(0/1)0%
(0/1)0%
(0/169)0%
(0/148)src.ui0%
(0/8)0%
(0/8)0%
(0/745)0%
(0/317)src.upload0%
(0/1)0%
(0/1)0%
(0/121)0%
(0/80)tests0%
(0/3)0%
(0/3)0%
(0/133)0%
(0/72)tests.kmoretools0%
(0/1)0%
(0/1)0%
(0/101)0%
(0/22)

D15739: [Places panel] Don't show Root by default

2018-10-01 Thread Nathaniel Graham

ngraham added a subscriber: ndavis.
ngraham added a comment.


  In D15739#334513 , @romangg wrote:
  
  > Imo this patch can go in as it is, but before that I would like to see a 
patch to have the disk with the root file system getting specially marked 
(icon, color or text) for the case that several block devices are mounted at 
the same time.
  
  
  Yes, that's one of the action items for T8349: Improve Places panel usability 
and presentation . Before we can do it, we 
first needed a better disk icon, which we now have thanks to @ndavis (see 
D15853: Change drive-harddisk to more adaptable style 
)! If we want to signify root disk status 
via the icon, we still need to figure out what to do about emblems, which 
currently obscure most of the icon for the default 16x16 size. I submitted a 
patch for that, but it's run into controversy: D15866: Reduce emblem size for 
very small icons to prevent obscuring too much of the icon 
.
  
  Baby steps...

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15739

To: ngraham, #dolphin, #vdg, davidedmundson
Cc: ndavis, romangg, bruns, davidedmundson, abetts, svenmauch, broulik, 
acrouthamel, kde-frameworks-devel, michaelh, ngraham

D15866: Reduce emblem size for very small icons to prevent obscuring too much of the icon

2018-10-01 Thread Christoph Feck

cfeck added a comment.


  The emblem convers important information; it should be clearly visible. 
Scaling to size 6 or 12 would only make sense if our icon sets ship those sizes 
for emblem icons.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D15866

To: ngraham, #frameworks, #dolphin, #vdg
Cc: cfeck, broulik, ndavis, kde-frameworks-devel, michaelh, ngraham, bruns

D15866: Reduce emblem size for very small icons to prevent obscuring too much of the icon

2018-10-01 Thread Nathaniel Graham

ngraham added a comment.


  In D15866#335042 , @cfeck wrote:
  
  > The emblem conveys important information; it should be clearly visible. 
Scaling to size 6 or 12 would only make sense if our icon sets ship those sizes 
for emblem icons.
  
  
  I would argue that at 8x8, it's really hard to understand what some of the 
emblems are or mean. This is especially true of the mounted and unmounted 
emblems that we're talking about for the purpose of the Places Panel (see T9740 
).
  
  The icon also conveys important information and should be clearly visible. 
The problem here is that currently, the emblem can take up 25% of the icon's 
area when the icon is 16x16 or 32x32, which can render the icon itself 
difficult to distinguish. For icons that don't use the full space, the emblem 
can take up even more space.
  
  For example here's an 8x8 size emblem on top of a 16x16 size icon that 
doesn't use all of its available space: F6297884: image.png 

  
  That's just visual gibberish.
  
  It's a hard problem to solve unless we put on our thinking caps and come up 
with some genius idea. :)

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D15866

To: ngraham, #frameworks, #dolphin, #vdg
Cc: cfeck, broulik, ndavis, kde-frameworks-devel, michaelh, ngraham, bruns

D15873: Improve debugging output by displaying whether the SMBSlave::del() function attempts to delete a file or a directory.

2018-10-01 Thread Elvis Angelaccio

elvisangelaccio accepted this revision.
elvisangelaccio added a comment.


  @madcatx Time to request commit access? :D

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D15873

To: madcatx, elvisangelaccio, broulik
Cc: kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp

D15866: Reduce emblem size for very small icons to prevent obscuring too much of the icon

2018-10-01 Thread Andrew Crouthamel

acrouthamel added a comment.


  What are the different possible emblems that can be applied automatically by 
the mount process?
  
  What if for small sizes, we just use simple shapes and colors. Like a green 
circle for mounted, and a yellow triangle for something else, and a red square 
for another state?
  
  I mention combining shapes and colors, for those who are color-blind.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D15866

To: ngraham, #frameworks, #dolphin, #vdg
Cc: acrouthamel, cfeck, broulik, ndavis, kde-frameworks-devel, michaelh, 
ngraham, bruns

D15739: [Places panel] Don't show Root by default

2018-10-01 Thread David Edmundson

davidedmundson resigned from this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15739

To: ngraham, #dolphin, #vdg
Cc: ndavis, romangg, bruns, davidedmundson, abetts, svenmauch, broulik, 
acrouthamel, kde-frameworks-devel, michaelh, ngraham

D15866: Reduce emblem size for very small icons to prevent obscuring too much of the icon

2018-10-01 Thread Nathaniel Graham

ngraham added a comment.


  Hmm, that would only make sense for small icons. If we implement it for small 
icons but keep the overlay style for larger icons, then there will be an odd 
change if and when the size is increased, and the label will jump horizontally. 
Also, since this patch is for `KIconLoader`, it would affect more than just 
Dolphin's Places panel; such a change would also affect list views in Dolphin 
and the file dialogs when using small icons. Not sure that would be a good idea.
  
  I wonder if maybe we should redesign the emblems that currently have a white 
symbol inside a colored background shape so that their 8x8 versions are just a 
colored symbol with no background shape. The idea would be to remove both some 
of the visual complexity that can get lost at small sizes and also the large 
background that obscures so much of the icon.
  
  If we do that, for the smallest icons it might be feasible to keep the emblem 
sized at 8x8 because they would be more visually clear and obscure less of the 
icon.
  
  Thoughts?

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D15866

To: ngraham, #frameworks, #dolphin, #vdg
Cc: broulik, ndavis, kde-frameworks-devel, michaelh, ngraham, bruns

D15843: Allow FileIndexerConfig to check device mounted status by path.

2018-10-01 Thread James Smith

smithjd added a comment.


  In D15843#334518 , @ngraham wrote:
  
  > Perhaps we should discuss the implementation of multi-device indexing in a 
Phab ticket instead of across the comments of multiple patches. Then we can 
settle on an agreed-upon approach and go implement it instead of going in 
circles with different approaches.
  
  
  This patch (or the other) is a requirement to augment the **current 
implementation** indexing of multiple devices with **safe** cleanup of the dead 
entries of multiple devices. It does not care about potential problems with the 
generated document id used by the database.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D15843

To: smithjd, #baloo, bruns
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, bruns, abrahams

D15866: Reduce emblem size for very small icons to prevent obscuring too much of the icon

2018-10-01 Thread Nathaniel Graham

ngraham added a comment.


  It's possible to have tiny symbolic emblems that still convey information. 
Here's a screenshot from my Dropbox folder in Dolphin, with 16x16 icons plus 
the tiny little emblems that Dropbox adds:
  
  F6297941: 8 emblem on 16 icon.png 
  
  Those emblems are technically 8x8, but the outermost pixels nearly 
transparent, so they're essentially 6x6. Since they're round rather than 
square, even more of the base icon is visible. Yet they're still perfectly 
distinguishable.
  
  Perhaps all that's needed here is to make the emblems a bit smaller within 
their 8x8 box, and to round the corners of the square ones more.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D15866

To: ngraham, #frameworks, #dolphin, #vdg
Cc: acrouthamel, cfeck, broulik, ndavis, kde-frameworks-devel, michaelh, 
ngraham, bruns

D15866: Reduce emblem size for very small icons to prevent obscuring too much of the icon

2018-10-01 Thread Christoph Feck

cfeck added a comment.


  I would prefer that.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D15866

To: ngraham, #frameworks, #dolphin, #vdg
Cc: acrouthamel, cfeck, broulik, ndavis, kde-frameworks-devel, michaelh, 
ngraham, bruns

D15070: Bindings: Support using sys paths for python install directory

2018-10-01 Thread Stefan Brüns

bruns marked 9 inline comments as done.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D15070

To: bruns, #frameworks
Cc: cgiboudeaux, bcooksley, kde-frameworks-devel, kde-buildsystem, michaelh, 
ngraham, bruns

D15070: Bindings: Support using sys paths for python install directory

2018-10-01 Thread Stefan Brüns

bruns updated this revision to Diff 42697.
bruns marked 2 inline comments as done.
bruns added a comment.


  Add documentation, remove leftover GPB_PYTHON${pyversion}_SITEARCH

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15070?vs=42631=42697

BRANCH
  python3_support

REVISION DETAIL
  https://phabricator.kde.org/D15070

AFFECTED FILES
  find-modules/FindPythonModuleGeneration.cmake

To: bruns, #frameworks
Cc: cgiboudeaux, bcooksley, kde-frameworks-devel, kde-buildsystem, michaelh, 
ngraham, bruns

48 matches

Mail list logo