date:20170721

Re: [Kicad-developers] Cursor behavior

2017-07-21 Thread Marcos Chaparro

Good points, I'm especially excited about 1), our pcb edges are usually
footprints, so I'm always working inside a footprint, which is continuously
getting selected.

Cheers


On Jul 21, 2017 18:34, "Piotr Esden-Tempski"  wrote:

> Hi,
>
> > On Jul 20, 2017, at 4:44 AM, jp charras  wrote:
> >
> [SNIP]
> >
> > AFAIK, when moving a single footprint, the anchor point is either one of
> its
> > pads or the footprint origin, the nearest candidate point from mouse
> cursor.
> >
> > Perhaps the algorithm should be slightly modified to use the pad if the
> mouse cursor is inside a
> > pad, and the footprint origin if the mouse cursor is inside the
> footprint (obviously), but not
> > inside a pad.
> >
> > It could be a more intuitive behavior.
>
>
> Very good idea, usually if I click on a component I do not want to move it
> by the pad unless I explicitly want to do that. Your solution is definitely
> better than the current behavior.
>
> On the component and general item selection topic.
>
> 1) If a component is very large in the current zoom level it should be
> ignored. It makes it very difficult to select small components that end up
> on the opposite side of a large component. It is also very unlikely the
> user will want to move the thing that is not even visible at the moment
> because it is 10x the size of the viewport. :)
> 2) Add the option to use a button to flip through potential selections.
> Having to use the mouse to select the component I meant from a list of
> candidates is really annoying. Other software packages have a nicer
> behavior for this: select a component and allow swapping through candidates
> using the right mouse button (this could be a keyboard shortcut too) and
> then confirm with another left click. (a good example is how the package
> with a bird does that, this is one of the few things I miss from using that
> software on daily basis. :) )
>
> I hope this is useful in some way.
>
> Just a few of my own 2c regarding the component selection behavior. :D
>
> Cheers,
> Piotr
> ___
> Mailing list: https://launchpad.net/~kicad-developers
> Post to : kicad-developers@lists.launchpad.net
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] [PATCH 1/2] Update FindGLEW.cmake

2017-07-21 Thread Simon Richter

---
 CMakeModules/FindGLEW.cmake | 155 
 1 file changed, 56 insertions(+), 99 deletions(-)

diff --git a/CMakeModules/FindGLEW.cmake b/CMakeModules/FindGLEW.cmake
index 621fe3b3f..ac2eb9ee8 100644
--- a/CMakeModules/FindGLEW.cmake
+++ b/CMakeModules/FindGLEW.cmake
@@ -1,112 +1,69 @@
-# Copyright (c) 2009 Boudewijn Rempt 
+# Distributed under the OSI-approved BSD 3-Clause License.  See accompanying
+# file Copyright.txt or https://cmake.org/licensing for details.
+
+#.rst:
+# FindGLEW
+# 
 #
-# Redistribution and use is allowed according to the terms of the BSD license.
-# For details see the accompanying COPYING-CMAKE-SCRIPTS file.
+# Find the OpenGL Extension Wrangler Library (GLEW)
 #
-# - try to find glew library and include files
-#  GLEW_INCLUDE_DIR, where to find GL/glew.h, etc.
-#  GLEW_LIBRARIES, the libraries to link against
-#  GLEW_FOUND, If false, do not try to use GLEW.
-# Also defined, but not for general use are:
-#  GLEW_GLEW_LIBRARY = the full path to the glew library.
-
-IF (WIN32)
-
-  IF(CYGWIN)
-
-FIND_PATH( GLEW_INCLUDE_DIR GL/glew.h)
-
-FIND_LIBRARY( GLEW_GLEW_LIBRARY glew32
-  ${OPENGL_LIBRARY_DIR}
-  /usr/lib/w32api
-  /usr/X11R6/lib
-)
-
-
-  ELSE(CYGWIN)
-
-FIND_PATH( GLEW_INCLUDE_DIR GL/glew.h
-  $ENV{GLEW_ROOT_PATH}/include
-)
-
-FIND_LIBRARY( GLEW_GLEW_LIBRARY
-  NAMES glew glew32 glew32s
-  PATHS
-  $ENV{GLEW_ROOT_PATH}/lib
-  $ENV{GLEW_ROOT_PATH}/lib/Release/Win32
-  ${OPENGL_LIBRARY_DIR}
-)
-
-  ENDIF(CYGWIN)
-
-ELSE (WIN32)
-
-  IF (APPLE)
-# These values for Apple could probably do with improvement.
-FIND_PATH( GLEW_INCLUDE_DIR GL/glew.h
-  /System/Library/Frameworks/GLEW.framework/Versions/A/Headers
-  /opt/local/include
-  ${OPENGL_LIBRARY_DIR}
-)
+# IMPORTED Targets
+# 
+#
+# This module defines the :prop_tgt:`IMPORTED` target ``GLEW::GLEW``,
+# if GLEW has been found.
+#
+# Result Variables
+# 
+#
+# This module defines the following variables:
+#
+# ::
+#
+#   GLEW_INCLUDE_DIRS - include directories for GLEW
+#   GLEW_LIBRARIES - libraries to link against GLEW
+#   GLEW_FOUND - true if GLEW has been found and can be used
 
-FIND_LIBRARY( GLEW_GLEW_LIBRARY GLEW
-  /opt/local/lib
-)
+find_path(GLEW_INCLUDE_DIR GL/glew.h)
 
-  ELSE (APPLE)
+if(NOT GLEW_LIBRARY)
+  find_library(GLEW_LIBRARY_RELEASE NAMES GLEW glew32 glew glew32s PATH_SUFFIXES lib64)
+  find_library(GLEW_LIBRARY_DEBUG NAMES GLEWd glew32d glewd PATH_SUFFIXES lib64)
 
-FIND_PATH( GLEW_INCLUDE_DIR GL/glew.h
-  /usr/include/GL
-  /usr/openwin/share/include
-  /usr/openwin/include
-  /usr/X11R6/include
-  /usr/include/X11
-  /opt/graphics/OpenGL/include
-  /opt/graphics/OpenGL/contrib/libglew
-)
+  include(SelectLibraryConfigurations)
+  select_library_configurations(GLEW)
+endif ()
 
-FIND_LIBRARY( GLEW_GLEW_LIBRARY GLEW
-  /usr/openwin/lib
-  /usr/X11R6/lib
-  /usr/lib
-  /usr/lib/x86_64-linux-gnu
-)
+include(FindPackageHandleStandardArgs)
+find_package_handle_standard_args(GLEW
+  REQUIRED_VARS GLEW_INCLUDE_DIR GLEW_LIBRARY)
 
-  ENDIF (APPLE)
+if(GLEW_FOUND)
+  set(GLEW_INCLUDE_DIRS ${GLEW_INCLUDE_DIR})
 
-ENDIF (WIN32)
+  if(NOT GLEW_LIBRARIES)
+set(GLEW_LIBRARIES ${GLEW_LIBRARY})
+  endif()
 
-SET( GLEW_FOUND "NO" )
-IF(GLEW_INCLUDE_DIR)
-  IF(GLEW_GLEW_LIBRARY)
-# Is -lXi and -lXmu required on all platforms that have it?
-# If not, we need some way to figure out what platform we are on.
-SET( GLEW_LIBRARIES
-  ${GLEW_GLEW_LIBRARY}
-  ${GLEW_cocoa_LIBRARY}
-)
-SET( GLEW_FOUND "YES" )
+  if (NOT TARGET GLEW::GLEW)
+add_library(GLEW::GLEW UNKNOWN IMPORTED)
+set_target_properties(GLEW::GLEW PROPERTIES
+  INTERFACE_INCLUDE_DIRECTORIES "${GLEW_INCLUDE_DIRS}")
 
-#The following deprecated settings are for backwards compatibility with CMake1.4
-SET (GLEW_LIBRARY ${GLEW_LIBRARIES})
-SET (GLEW_INCLUDE_PATH ${GLEW_INCLUDE_DIR})
+if(GLEW_LIBRARY_RELEASE)
+  set_property(TARGET GLEW::GLEW APPEND PROPERTY IMPORTED_CONFIGURATIONS RELEASE)
+  set_target_properties(GLEW::GLEW PROPERTIES IMPORTED_LOCATION_RELEASE "${GLEW_LIBRARY_RELEASE}")
+endif()
 
-  ENDIF(GLEW_GLEW_LIBRARY)
-ENDIF(GLEW_INCLUDE_DIR)
+if(GLEW_LIBRARY_DEBUG)
+  set_property(TARGET GLEW::GLEW APPEND PROPERTY IMPORTED_CONFIGURATIONS DEBUG)
+  set_target_properties(GLEW::GLEW PROPERTIES IMPORTED_LOCATION_DEBUG "${GLEW_LIBRARY_DEBUG}")
+endif()
 
-IF(GLEW_FOUND)
-  IF(NOT GLEW_FIND_QUIETLY)
-MESSAGE(STATUS "Found Glew: ${GLEW_LIBRARIES}")
-  ENDIF(NOT GLEW_FIND_QUIETLY)
-ELSE(GLEW_FOUND)
-  IF(GLEW_FIND_REQUIRED)
-MESSAGE(FATAL_ERROR "Could not find Glew")
-  ENDIF(GLEW_FIND_REQUIRED)
-ENDIF(GLEW_FOUND)
+if(NOT GLEW_LIBRARY_RELEASE AND NOT GLEW_LIBRARY_DEBUG)
+

[Kicad-developers] [PATCH 2/2] Legacy handling for Via tool

2017-07-21 Thread Simon Richter


This tool isn't available in the Legacy canvas, but we still need to handle
the selection event and show an appropriate error message if the tool is
used.
---
 pcbnew/edit.cpp| 1 +
 pcbnew/onleftclick.cpp | 1 +
 2 files changed, 2 insertions(+)

diff --git a/pcbnew/edit.cpp b/pcbnew/edit.cpp
index 694bdd519..e454d7f4d 100644
--- a/pcbnew/edit.cpp
+++ b/pcbnew/edit.cpp
@@ -1526,6 +1526,7 @@ void PCB_EDIT_FRAME::OnSelectTool( wxCommandEvent& aEvent )
 break;
 
 // collect GAL-only tools here
+case ID_PCB_DRAW_VIA_BUTT:
 case ID_PCB_MEASUREMENT_TOOL:
 SetToolID( id, wxCURSOR_DEFAULT, _( "Unsupported tool in this canvas" ) );
 break;
diff --git a/pcbnew/onleftclick.cpp b/pcbnew/onleftclick.cpp
index 0da628708..02b90fd82 100644
--- a/pcbnew/onleftclick.cpp
+++ b/pcbnew/onleftclick.cpp
@@ -439,6 +439,7 @@ void PCB_EDIT_FRAME::OnLeftClick( wxDC* aDC, const wxPoint& aPosition )
 m_canvas->DrawGridAxis( aDC, GR_COPY, GetBoard()->GetGridOrigin() );
 break;
 
+case ID_PCB_DRAW_VIA_BUTT:
 case ID_PCB_MEASUREMENT_TOOL:
 DisplayError( this, _( "This tool is not available in the legacy canvas" ) );
 SetNoToolSelected();
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Cursor behavior

2017-07-21 Thread Jörg Hermann

1) If a component is very large in the current zoom level it should be ignored. 
It makes it very difficult to select small components that end up on the 
opposite side of a large component. It is also very unlikely the user will want 
to move the thing that is not even visible at the moment because it is 10x the 
size of the viewport. :)
2) Add the option to use a button to flip through potential selections. Having 
to use the mouse to select the component I meant from a list of candidates is 
really annoying. Other software packages have a nicer behavior for this: select 
a component and allow swapping through candidates using the right mouse button 
(this could be a keyboard shortcut too) and then confirm with another left 
click. (a good example is how the package with a bird does that, this is one of 
the few things I miss from using that software on daily basis. :) )

I second both points. Related to the selection behavior:

In 4.0.6 I can select components even if their anchors are switched off. But 
components on a layer with switched off anchors should not be selectable at all 
- why else did I switch off their anchors?
This lies inline with Pjotrs selection issues and eases working with pcb that 
have both sides populated A LOT!

Best regards,
 
Jörg Hermann

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Cursor behavior

2017-07-21 Thread Piotr Esden-Tempski

Hi,

> On Jul 20, 2017, at 4:44 AM, jp charras  wrote:
> 
[SNIP]
> 
> AFAIK, when moving a single footprint, the anchor point is either one of its
> pads or the footprint origin, the nearest candidate point from mouse cursor.
> 
> Perhaps the algorithm should be slightly modified to use the pad if the mouse 
> cursor is inside a
> pad, and the footprint origin if the mouse cursor is inside the footprint 
> (obviously), but not
> inside a pad.
> 
> It could be a more intuitive behavior.

Very good idea, usually if I click on a component I do not want to move it by 
the pad unless I explicitly want to do that. Your solution is definitely better 
than the current behavior.

On the component and general item selection topic.

1) If a component is very large in the current zoom level it should be ignored. 
It makes it very difficult to select small components that end up on the 
opposite side of a large component. It is also very unlikely the user will want 
to move the thing that is not even visible at the moment because it is 10x the 
size of the viewport. :)
2) Add the option to use a button to flip through potential selections. Having 
to use the mouse to select the component I meant from a list of candidates is 
really annoying. Other software packages have a nicer behavior for this: select 
a component and allow swapping through candidates using the right mouse button 
(this could be a keyboard shortcut too) and then confirm with another left 
click. (a good example is how the package with a bird does that, this is one of 
the few things I miss from using that software on daily basis. :) )

I hope this is useful in some way.

Just a few of my own 2c regarding the component selection behavior. :D

Cheers,
Piotr
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] [PATCH] correct text inside two importantplot windows

2017-07-21 Thread Wayne Stambaugh

This is correct.  I just remember if the string in a group box
(wxStaticBoxSizer) than it doesn't get a colon.  If the string is static
text (wxStaticText) that describes a text control, then it should end in
a colon.

On 7/21/2017 2:31 PM, Chris Pavlina wrote:
> Generally single entry controls will contain a colon in the label but
> entire sections will not - thus "Output directory" and "Default line
> thickness (mm)" should have colons, but "Messages" and "Page Size"
> should not. This is because the single entry controls read as a single
> line of text, where it's correct to separate a label with a colon,
> whereas the section headings read as standalone labels that sit apart
> from the thing they label.
> 
> On Fri, Jul 21, 2017 at 05:41:59PM +0200, Fabrizio Tappero wrote:
>> Hi Wayne,
>>
>> this is an exmaple of the current plot schematic window.
>>
>> [image: Inline image 1]
>>
>>
>> I think it is expected that "Output directory:" and "Default line thickness
>> (mm):" and "Messages:" have a colon.
>>
>> Am I correct?
>>
>> cheers
>> Fabrizio
>>
>>
>>
>> On Fri, Jul 21, 2017 at 4:23 PM, Wayne Stambaugh 
>> wrote:
>>
>>> Fabrizio,
>>>
>>> I pushed your patch to the master branch.  Thank you for your
>>> contribution to KiCad.
>>>
>>> This is not aimed at your patch but one thing I notice is that there is
>>> and inconsistency in some of our wxStaticBoxSizer() strings.  There are
>>> a few cases where the string ends with a colon (:) but it's rare.  For
>>> the sake of consistency, if you find any cases in the future where this
>>> is true, please remove the trailing colon.
>>>
>>> Cheers,
>>>
>>> Wayne
>>>
>>>
>>> On 7/20/2017 5:59 AM, Fabrizio Tappero wrote:
 Hi Wayne,
 you are right. Sorry about that. I have reviewed and changed all
>>> instances.

 In attachment the new patch.

 cheers
 Fabrizio


 On Wed, Jul 19, 2017 at 3:59 PM, Wayne Stambaugh > wrote:

 Fabrizio,

 You are still using header instead of sentence capitalization of text
 box labels.  For example, in pcbnew/dialogs/dialog_plot_base.cpp you
 changed:

 "Plot format:"

 to

 "Plot Format:"

 The original capitalization is correct.  I see a lot of this in this
 patch.

 Please correct the text box label capitalization and resubmit your
 patch.  Also, please give your patches a unique name so I don't have
>>> to.
  Even easier, just use the name generated by `git format-patch`.

 Wayne

 On 7/19/2017 6:55 AM, Fabrizio Tappero wrote:
 > Hi Wayne,
 > really tedious work to spot these kind of mistakes... I hope I
>>> fixed all
 > mistakes.
 >
 > In attachment the new patch.
 >
 > cheers
 > Fabrizio
 >
 >
 > On Wed, Jul 19, 2017 at 12:19 PM, Fabrizio Tappero
 > 
 >> wrote:
 >
 > Hi Wayne,
 > apologies for that. I sometimes think that a unique patch is
>>> more
 > friendly than several ones.
 >
 > Will fix and resubmit.
 >
 > cheers
 > Fabrizio
 >
 >
 > On Tue, Jul 18, 2017 at 3:35 PM, Wayne Stambaugh
 > 
 >> wrote:
 >
 > Fabrizio,
 >
 > This patch has far more changes than the plot dialogs
 mentioned
 > in your
 > commit message.  In the future, please either make your
>>> commit
 > message
 > describe all of the changes related to the patch.  I would
 > prefer that
 > you only make one wxFormbuilder dialog change per patch.
 > wxFormbuilder
 > changes tend to be noisy so it takes longer to review them.
 >
 > You are using the incorrect capitalization in text box
>>> labels.
 > Text box
 > labels use sentence capitalization not header
 capitalization per
 > the UI
 > guidelines[1].
 >
 > Please fix your patch accordingly so I can commit it.
 >
 > Cheers,
 >
 > Wayne
 >
 >
  [1]:http://docs.kicad-pcb.org/doxygen/md_Documentation_
>>> development_ui-policy.html
 >> development_ui-policy.html>
 >

Re: [Kicad-developers] [PATCH] correct text inside two importantplot windows

2017-07-21 Thread Chris Pavlina

Generally single entry controls will contain a colon in the label but
entire sections will not - thus "Output directory" and "Default line
thickness (mm)" should have colons, but "Messages" and "Page Size"
should not. This is because the single entry controls read as a single
line of text, where it's correct to separate a label with a colon,
whereas the section headings read as standalone labels that sit apart
from the thing they label.

On Fri, Jul 21, 2017 at 05:41:59PM +0200, Fabrizio Tappero wrote:
> Hi Wayne,
> 
> this is an exmaple of the current plot schematic window.
> 
> [image: Inline image 1]
> 
> 
> I think it is expected that "Output directory:" and "Default line thickness
> (mm):" and "Messages:" have a colon.
> 
> Am I correct?
> 
> cheers
> Fabrizio
> 
> 
> 
> On Fri, Jul 21, 2017 at 4:23 PM, Wayne Stambaugh 
> wrote:
> 
> > Fabrizio,
> >
> > I pushed your patch to the master branch.  Thank you for your
> > contribution to KiCad.
> >
> > This is not aimed at your patch but one thing I notice is that there is
> > and inconsistency in some of our wxStaticBoxSizer() strings.  There are
> > a few cases where the string ends with a colon (:) but it's rare.  For
> > the sake of consistency, if you find any cases in the future where this
> > is true, please remove the trailing colon.
> >
> > Cheers,
> >
> > Wayne
> >
> >
> > On 7/20/2017 5:59 AM, Fabrizio Tappero wrote:
> > > Hi Wayne,
> > > you are right. Sorry about that. I have reviewed and changed all
> > instances.
> > >
> > > In attachment the new patch.
> > >
> > > cheers
> > > Fabrizio
> > >
> > >
> > > On Wed, Jul 19, 2017 at 3:59 PM, Wayne Stambaugh  > > > wrote:
> > >
> > > Fabrizio,
> > >
> > > You are still using header instead of sentence capitalization of text
> > > box labels.  For example, in pcbnew/dialogs/dialog_plot_base.cpp you
> > > changed:
> > >
> > > "Plot format:"
> > >
> > > to
> > >
> > > "Plot Format:"
> > >
> > > The original capitalization is correct.  I see a lot of this in this
> > > patch.
> > >
> > > Please correct the text box label capitalization and resubmit your
> > > patch.  Also, please give your patches a unique name so I don't have
> > to.
> > >  Even easier, just use the name generated by `git format-patch`.
> > >
> > > Wayne
> > >
> > > On 7/19/2017 6:55 AM, Fabrizio Tappero wrote:
> > > > Hi Wayne,
> > > > really tedious work to spot these kind of mistakes... I hope I
> > fixed all
> > > > mistakes.
> > > >
> > > > In attachment the new patch.
> > > >
> > > > cheers
> > > > Fabrizio
> > > >
> > > >
> > > > On Wed, Jul 19, 2017 at 12:19 PM, Fabrizio Tappero
> > > > 
> > >  > > >> wrote:
> > > >
> > > > Hi Wayne,
> > > > apologies for that. I sometimes think that a unique patch is
> > more
> > > > friendly than several ones.
> > > >
> > > > Will fix and resubmit.
> > > >
> > > > cheers
> > > > Fabrizio
> > > >
> > > >
> > > > On Tue, Jul 18, 2017 at 3:35 PM, Wayne Stambaugh
> > > > 
> > > >> wrote:
> > > >
> > > > Fabrizio,
> > > >
> > > > This patch has far more changes than the plot dialogs
> > > mentioned
> > > > in your
> > > > commit message.  In the future, please either make your
> > commit
> > > > message
> > > > describe all of the changes related to the patch.  I would
> > > > prefer that
> > > > you only make one wxFormbuilder dialog change per patch.
> > > > wxFormbuilder
> > > > changes tend to be noisy so it takes longer to review them.
> > > >
> > > > You are using the incorrect capitalization in text box
> > labels.
> > > > Text box
> > > > labels use sentence capitalization not header
> > > capitalization per
> > > > the UI
> > > > guidelines[1].
> > > >
> > > > Please fix your patch accordingly so I can commit it.
> > > >
> > > > Cheers,
> > > >
> > > > Wayne
> > > >
> > > >
> > >  [1]:http://docs.kicad-pcb.org/doxygen/md_Documentation_
> > development_ui-policy.html
> > >  > development_ui-policy.html>
> > > >
> > >   > development_ui-policy.html
> > >  > development_ui-policy.html>>
> > > >
> > > > On 7/3/2017 4:45 AM, Fabrizio

Re: [Kicad-developers] More layer selection options.

2017-07-21 Thread Kristoffer Ödmark

Yeah, you are right, modified the patch to show edge cuts, it felt 
better actually.




On 07/21/2017 07:04 PM, Eldar Khayrullin wrote:

Hello.
Maybe it will be good to show Edge Cut always.

В Пятница, 21 июл. 2017 в 6:57 , Kristoffer Ödmark 
 написал:
Added a few more layer selections to the layer sidebar. Also included 
two modified versions of the show all layers icon, for front and back, 
but I couldnt find out how to make them into the cpp files. link: 
https://www.youtube.com/watch?v=148ZMCNWqTw=youtu.be
___ Mailing list: 
https://launchpad.net/~kicad-developers Post to : 
kicad-developers@lists.launchpad.net 
 Unsubscribe : 
https://launchpad.net/~kicad-developers More help : 
https://help.launchpad.net/ListHelp 
>From 0455e103aa757487d84a8bbb7e8743423f8ab4e5 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Kristoffer=20=C3=96dmark?= 
Date: Wed, 19 Jul 2017 23:37:10 +0200
Subject: [PATCH] added more layer selector features

---
 bitmaps_png/sources/show_all_back_layers.svg  | 302 ++
 bitmaps_png/sources/show_all_front_layers.svg | 302 ++
 pcbnew/class_pcb_layer_widget.cpp | 206 +-
 pcbnew/class_pcb_layer_widget.h   |  20 +-
 4 files changed, 769 insertions(+), 61 deletions(-)
 create mode 100644 bitmaps_png/sources/show_all_back_layers.svg
 create mode 100644 bitmaps_png/sources/show_all_front_layers.svg

diff --git a/bitmaps_png/sources/show_all_back_layers.svg b/bitmaps_png/sources/show_all_back_layers.svg
new file mode 100644
index 0..efcc3892c
--- /dev/null
+++ b/bitmaps_png/sources/show_all_back_layers.svg
@@ -0,0 +1,302 @@
+
+http://purl.org/dc/elements/1.1/;
+   xmlns:cc="http://creativecommons.org/ns#;
+   xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#;
+   xmlns:svg="http://www.w3.org/2000/svg;
+   xmlns="http://www.w3.org/2000/svg;
+   xmlns:xlink="http://www.w3.org/1999/xlink;
+   xmlns:sodipodi="http://sodipodi.sourceforge.net/DTD/sodipodi-0.dtd;
+   xmlns:inkscape="http://www.inkscape.org/namespaces/inkscape;
+   height="26"
+   width="26"
+   version="1.1"
+   id="svg2"
+   inkscape:version="0.92.1 r"
+   sodipodi:docname="show_all_back.svg">
+  
+
+  
+image/svg+xml
+http://purl.org/dc/dcmitype/StillImage; />
+
+  
+
+  
+  
+
+  
+  
+
+  
+  
+
+
+  
+  
+
+
+  
+
+
+  
+
+
+  
+  
+  
+  
+  
+  
+
+
+  
+  
+
+
+
+  
+  
+
+
+
+  
+  
+
+
+
+
+
+  
+  
+  
+  
+  
+
+  
+  
+  
+
+  
+  
+  
+  
+
diff --git a/bitmaps_png/sources/show_all_front_layers.svg b/bitmaps_png/sources/show_all_front_layers.svg
new file mode 100644
index 0..9eee8e325
--- /dev/null
+++ b/bitmaps_png/sources/show_all_front_layers.svg
@@ -0,0 +1,302 @@
+
+http://purl.org/dc/elements/1.1/;
+   xmlns:cc="http://creativecommons.org/ns#;
+   xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#;
+   xmlns:svg="http://www.w3.org/2000/svg;
+   xmlns="http://www.w3.org/2000/svg;
+   xmlns:xlink="http://www.w3.org/1999/xlink;
+   xmlns:sodipodi="http://sodipodi.sourceforge.net/DTD/sodipodi-0.dtd;
+   xmlns:inkscape="http://www.inkscape.org/namespaces/inkscape;
+   height="26"
+   width="26"
+   version="1.1"
+   id="svg2"
+   inkscape:version="0.92.1 r"
+   sodipodi:docname="show_all_front.svg">
+  
+
+  
+image/svg+xml
+http://purl.org/dc/dcmitype/StillImage; />
+
+  
+
+  
+  
+
+  
+  
+
+  
+  
+
+
+  
+  
+
+
+  
+
+
+  
+
+
+  
+  
+  
+  
+  
+  
+
+
+  
+  
+
+
+
+  
+  
+
+
+
+  
+  
+
+
+
+
+
+  
+  
+  
+  
+  
+
+  
+  
+  
+
+  
+  
+  
+  
+
diff --git a/pcbnew/class_pcb_layer_widget.cpp b/pcbnew/class_pcb_layer_widget.cpp
index 48979829e..97e870e22 100644
--- a/pcbnew/class_pcb_layer_widget.cpp
+++ b/pcbnew/class_pcb_layer_widget.cpp
@@ -107,7 +107,7 @@ PCB_LAYER_WIDGET::PCB_LAYER_WIDGET( PCB_BASE_FRAME* aParent, wxWindow* aFocusOwn
 // since Popupmenu() calls this->ProcessEvent() we must call this->Connect()
 // and not m_LayerScrolledWindow->Connect()
 
-Connect( ID_SHOW_ALL_COPPER_LAYERS, ID_SHOW_ALL_LAYERS,
+Connect( ID_SHOW_ALL_COPPER_LAYERS, ID_LAST_VALUE - 1,
 wxEVT_COMMAND_MENU_SELECTED,
 wxCommandEventHandler( PCB_LAYER_WIDGET::onPopupSelection ), NULL, this );
 // install the right click handler into each control at end of ReFill()
@@ -179,11 +179,28 @@ void PCB_LAYER_WIDGET::onRightDownLayers( wxMouseEvent& event )
 
 menu.AppendSeparator();

Re: [Kicad-developers] More layer selection options.

2017-07-21 Thread Eldar Khayrullin


Hello.
Maybe it will be good to show Edge Cut always.

В Пятница, 21 июл. 2017 в 6:57 , Kristoffer Ödmark 
 написал:

Added a few more layer selections to the layer sidebar.

Also included two modified versions of the show all layers icon, for 
front and back, but I couldnt find out how to make them into the cpp 
files.


link: https://www.youtube.com/watch?v=148ZMCNWqTw=youtu.be
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

[Kicad-developers] More layer selection options.

2017-07-21 Thread Kristoffer Ödmark


Added a few more layer selections to the layer sidebar.

Also included two modified versions of the show all layers icon, for 
front and back, but I couldnt find out how to make them into the cpp files.


link: https://www.youtube.com/watch?v=148ZMCNWqTw=youtu.be
>From c0a54d61cc873bed5eb1e221bafb483144bdb705 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Kristoffer=20=C3=96dmark?= 
Date: Wed, 19 Jul 2017 23:37:10 +0200
Subject: [PATCH] added more layer selector features

---
 bitmaps_png/sources/show_all_back_layers.svg  | 302 ++
 bitmaps_png/sources/show_all_front_layers.svg | 302 ++
 pcbnew/class_pcb_layer_widget.cpp | 206 +-
 pcbnew/class_pcb_layer_widget.h   |  20 +-
 4 files changed, 769 insertions(+), 61 deletions(-)
 create mode 100644 bitmaps_png/sources/show_all_back_layers.svg
 create mode 100644 bitmaps_png/sources/show_all_front_layers.svg

diff --git a/bitmaps_png/sources/show_all_back_layers.svg b/bitmaps_png/sources/show_all_back_layers.svg
new file mode 100644
index 0..efcc3892c
--- /dev/null
+++ b/bitmaps_png/sources/show_all_back_layers.svg
@@ -0,0 +1,302 @@
+
+http://purl.org/dc/elements/1.1/;
+   xmlns:cc="http://creativecommons.org/ns#;
+   xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#;
+   xmlns:svg="http://www.w3.org/2000/svg;
+   xmlns="http://www.w3.org/2000/svg;
+   xmlns:xlink="http://www.w3.org/1999/xlink;
+   xmlns:sodipodi="http://sodipodi.sourceforge.net/DTD/sodipodi-0.dtd;
+   xmlns:inkscape="http://www.inkscape.org/namespaces/inkscape;
+   height="26"
+   width="26"
+   version="1.1"
+   id="svg2"
+   inkscape:version="0.92.1 r"
+   sodipodi:docname="show_all_back.svg">
+  
+
+  
+image/svg+xml
+http://purl.org/dc/dcmitype/StillImage; />
+
+  
+
+  
+  
+
+  
+  
+
+  
+  
+
+
+  
+  
+
+
+  
+
+
+  
+
+
+  
+  
+  
+  
+  
+  
+
+
+  
+  
+
+
+
+  
+  
+
+
+
+  
+  
+
+
+
+
+
+  
+  
+  
+  
+  
+
+  
+  
+  
+
+  
+  
+  
+  
+
diff --git a/bitmaps_png/sources/show_all_front_layers.svg b/bitmaps_png/sources/show_all_front_layers.svg
new file mode 100644
index 0..9eee8e325
--- /dev/null
+++ b/bitmaps_png/sources/show_all_front_layers.svg
@@ -0,0 +1,302 @@
+
+http://purl.org/dc/elements/1.1/;
+   xmlns:cc="http://creativecommons.org/ns#;
+   xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#;
+   xmlns:svg="http://www.w3.org/2000/svg;
+   xmlns="http://www.w3.org/2000/svg;
+   xmlns:xlink="http://www.w3.org/1999/xlink;
+   xmlns:sodipodi="http://sodipodi.sourceforge.net/DTD/sodipodi-0.dtd;
+   xmlns:inkscape="http://www.inkscape.org/namespaces/inkscape;
+   height="26"
+   width="26"
+   version="1.1"
+   id="svg2"
+   inkscape:version="0.92.1 r"
+   sodipodi:docname="show_all_front.svg">
+  
+
+  
+image/svg+xml
+http://purl.org/dc/dcmitype/StillImage; />
+
+  
+
+  
+  
+
+  
+  
+
+  
+  
+
+
+  
+  
+
+
+  
+
+
+  
+
+
+  
+  
+  
+  
+  
+  
+
+
+  
+  
+
+
+
+  
+  
+
+
+
+  
+  
+
+
+
+
+
+  
+  
+  
+  
+  
+
+  
+  
+  
+
+  
+  
+  
+  
+
diff --git a/pcbnew/class_pcb_layer_widget.cpp b/pcbnew/class_pcb_layer_widget.cpp
index 48979829e..6fa35a484 100644
--- a/pcbnew/class_pcb_layer_widget.cpp
+++ b/pcbnew/class_pcb_layer_widget.cpp
@@ -107,7 +107,7 @@ PCB_LAYER_WIDGET::PCB_LAYER_WIDGET( PCB_BASE_FRAME* aParent, wxWindow* aFocusOwn
 // since Popupmenu() calls this->ProcessEvent() we must call this->Connect()
 // and not m_LayerScrolledWindow->Connect()
 
-Connect( ID_SHOW_ALL_COPPER_LAYERS, ID_SHOW_ALL_LAYERS,
+Connect( ID_SHOW_ALL_COPPER_LAYERS, ID_LAST_VALUE - 1,
 wxEVT_COMMAND_MENU_SELECTED,
 wxCommandEventHandler( PCB_LAYER_WIDGET::onPopupSelection ), NULL, this );
 // install the right click handler into each control at end of ReFill()
@@ -179,11 +179,28 @@ void PCB_LAYER_WIDGET::onRightDownLayers( wxMouseEvent& event )
 
 menu.AppendSeparator();
 
+AddMenuItem( , ID_SHOW_ALL_NON_COPPER,
+ _( "Show All Non Copper Layers" ),
+ KiBitmap( select_w_layer_xpm ) );
+AddMenuItem( , ID_HIDE_ALL_NON_COPPER,
+ _( "Hide All Non Copper Layers" ),
+ KiBitmap( show_no_copper_layers_xpm ) );
+
+menu.AppendSeparator();
+
 AddMenuItem( , ID_SHOW_NO_LAYERS, _( "Hide All Layers" ),
  KiBitmap( show_no_layers_xpm ) );
 AddMenuItem( , ID_SHOW_ALL_LAYERS, _( "Show All Layers" ),
  KiBitmap( show_all_layers_xpm ) );
 
+

Re: [Kicad-developers] [PATCH] correct text inside two importantplot windows

2017-07-21 Thread Fabrizio Tappero

Hi Wayne,

this is an exmaple of the current plot schematic window.

[image: Inline image 1]


I think it is expected that "Output directory:" and "Default line thickness
(mm):" and "Messages:" have a colon.

Am I correct?

cheers
Fabrizio



On Fri, Jul 21, 2017 at 4:23 PM, Wayne Stambaugh 
wrote:

> Fabrizio,
>
> I pushed your patch to the master branch.  Thank you for your
> contribution to KiCad.
>
> This is not aimed at your patch but one thing I notice is that there is
> and inconsistency in some of our wxStaticBoxSizer() strings.  There are
> a few cases where the string ends with a colon (:) but it's rare.  For
> the sake of consistency, if you find any cases in the future where this
> is true, please remove the trailing colon.
>
> Cheers,
>
> Wayne
>
>
> On 7/20/2017 5:59 AM, Fabrizio Tappero wrote:
> > Hi Wayne,
> > you are right. Sorry about that. I have reviewed and changed all
> instances.
> >
> > In attachment the new patch.
> >
> > cheers
> > Fabrizio
> >
> >
> > On Wed, Jul 19, 2017 at 3:59 PM, Wayne Stambaugh  > > wrote:
> >
> > Fabrizio,
> >
> > You are still using header instead of sentence capitalization of text
> > box labels.  For example, in pcbnew/dialogs/dialog_plot_base.cpp you
> > changed:
> >
> > "Plot format:"
> >
> > to
> >
> > "Plot Format:"
> >
> > The original capitalization is correct.  I see a lot of this in this
> > patch.
> >
> > Please correct the text box label capitalization and resubmit your
> > patch.  Also, please give your patches a unique name so I don't have
> to.
> >  Even easier, just use the name generated by `git format-patch`.
> >
> > Wayne
> >
> > On 7/19/2017 6:55 AM, Fabrizio Tappero wrote:
> > > Hi Wayne,
> > > really tedious work to spot these kind of mistakes... I hope I
> fixed all
> > > mistakes.
> > >
> > > In attachment the new patch.
> > >
> > > cheers
> > > Fabrizio
> > >
> > >
> > > On Wed, Jul 19, 2017 at 12:19 PM, Fabrizio Tappero
> > > 
> >  > >> wrote:
> > >
> > > Hi Wayne,
> > > apologies for that. I sometimes think that a unique patch is
> more
> > > friendly than several ones.
> > >
> > > Will fix and resubmit.
> > >
> > > cheers
> > > Fabrizio
> > >
> > >
> > > On Tue, Jul 18, 2017 at 3:35 PM, Wayne Stambaugh
> > > 
> > >> wrote:
> > >
> > > Fabrizio,
> > >
> > > This patch has far more changes than the plot dialogs
> > mentioned
> > > in your
> > > commit message.  In the future, please either make your
> commit
> > > message
> > > describe all of the changes related to the patch.  I would
> > > prefer that
> > > you only make one wxFormbuilder dialog change per patch.
> > > wxFormbuilder
> > > changes tend to be noisy so it takes longer to review them.
> > >
> > > You are using the incorrect capitalization in text box
> labels.
> > > Text box
> > > labels use sentence capitalization not header
> > capitalization per
> > > the UI
> > > guidelines[1].
> > >
> > > Please fix your patch accordingly so I can commit it.
> > >
> > > Cheers,
> > >
> > > Wayne
> > >
> > >
> >  [1]:http://docs.kicad-pcb.org/doxygen/md_Documentation_
> development_ui-policy.html
> >  development_ui-policy.html>
> > >
> >   development_ui-policy.html
> >  development_ui-policy.html>>
> > >
> > > On 7/3/2017 4:45 AM, Fabrizio Tappero wrote:
> > > > Hi JP,
> > > > thanks for it. I updated my wxformbuilder to the latest
> > (3.6v)
> > > > version. And I fixed the (mm) issue you mentioned.
> > > >
> > > > In attachment the patch.
> > > >
> > > > thank you
> > > > Fabrizio
> > > >
> > > >
> > > > On Sat, Jul 1, 2017 at 8:40 PM, jp charras
> > > 
> > >>
> wrote:
> > > >> Le 30/06/2017 à 15:34, Fabrizio Tappero a écrit :
> > > >>> Hello,
> > > >>> in attachment the patch reviewed after Wayne comments.
> > >

Re: [Kicad-developers] [PATCH] simplied right click menu icons

2017-07-21 Thread Wayne Stambaugh

Fabrizio,

I pushed your patch to the master branch.  Thank you for your
contribution to KiCad.

Cheers,

Wayne

On 7/20/2017 8:45 AM, Fabrizio Tappero wrote:
> Hi Wayne,
> how are you? 
> 
> very cool. I have changed this patch so that everywhere: 
> 
> "Rotate 90 deg CW" -> "Rotate Clockwise"
> "Rotate 90 deg CCW" -> "Rotate Counterclockwise"
> 
> thanks a lot
> Fabrizio
> 
> 
> 
> 
> 
> 
> 
> On Wed, Jul 19, 2017 at 3:35 PM, Wayne Stambaugh  > wrote:
> 
> On 7/19/2017 6:17 AM, Fabrizio Tappero wrote:
> > Hi Wayne,
> > Thanks for the many messages. I did not know that devs were so into
> > translation...
> >
> > My overall effort is to uniformise the Kicad UI and make it consistent
> > and as correct as possible.
> >
> > Currently in Kicad we are using "Rotate 90 deg CW" and "Rotate 90 deg
> > CCW" in many many menus (see below). This expression is also used in
> > Inkscape, a pretty high standard software for vector image manipulation.
> > I personally think that consistency is the most important aspect of my
> > contributions and, despite loving internal conversations about
> > translations, etc I think we need to pick what is considered the best
> > expression and use it coherently in all kicad menus. I have the feeling
> > that if I submit a similar patch in few months, this kind of discussion
> > will come up again. In a way this is typical of open-source software, so
> > maybe it is not a bad thing.
> 
> I'm fine with consistent but consistently incorrect or confusing is no
> better than inconsistent.
> 
> >
> > In my opinion I think it would be good not to reinvent expressions. I
> > think "CW" and "CCW" is a perfectly understandable and usable 
> expression.
> 
> CW and CCW are not expressions.  They are abbreviations which may not be
> understood outside of English.  I would prefer not to use abbreviations
> except for units unless space is at a premium.  In this case, I don't
> think there is a space issue.  Please use terms clockwise and
> counterclockwise.  These are the correct English terms for rotation
> direction.
> 
> >
> > The custom-defined rotation value is a new piece of info, thanks Wayne
> > for that! does it apply to all rotations?
> 
> This only applies when the user changes the default rotation angle from
> 90 to something else.  The rotation angle is fixed to 90 in the
> schematic, symbol library, and footprint library editors and is user
> configurable in the board editor.
> 
> >
> > Please advise how to modify this patch to make it submittable.
> 
> Use clockwise and counter clockwise instead of CW and CCW.  Either
> remove the 90 deg rotation angle or use the user rotation angle in the
> board editor menu string.  I don't have a preference.
> 
> >
> > Cheers
> > Fabrizio
> >
> >
> >
> > Inline image 1
> >
> >
> >
> > On Wed, Jul 19, 2017 at 2:47 AM, Wayne Stambaugh  
> > >> wrote:
> >
> > On 7/18/2017 8:24 PM, Chris Pavlina wrote:
> > >> (remember, this is localization, not literal translation)
> > >
> > > Thank you! en_US should be "counterclockwise" and "clockwise" (or
> > > even CCW/CW would be easily understood), and different phrasings
> > > should be used in different languages. Don't avoid "clockwise" in
> > > English because the French don't use it. It's up to the 
> translators
> > > to decide how things should be phrased in their locale.
> >
> > Yes!  This is how it should be done.
> >
> > >
> > > On Tue, Jul 18, 2017 at 07:19:35PM -0500, José Ignacio wrote:
> > >> Clockwise and counter-clockwise are the most usual term in 
> American
> > >> Engish, other localizations should use the most usual term in 
> their
> > >> respective locales (remember, this is localization, not literal
> > >> translation). For example in Argentinian Spanish it should be
> > >> "Horario" and "Antihorario". Encoding information in the icons 
> only
> > >> is not a good idea, as users can disable them (or the system can
> > >> disable them by default) also screen readers can't read icons
> > >> (though i doubt many blind people would be using kicad to lay out
> > >> circuits).
> > >>
> > >> On Tue, Jul 18, 2017 at 4:00 PM, Clemens Koller  
> > >>
> > >> wrote:
> > >>
> > >>> Hi!
> > >>>
> > >>> If we want to avoid clockwise (CW) and counterclockwise
> (CCW) I
> > >>> suggest to add a sign to

Re: [Kicad-developers] [PATCH] correct text inside two importantplot windows

2017-07-21 Thread Wayne Stambaugh

Fabrizio,

I pushed your patch to the master branch.  Thank you for your
contribution to KiCad.

This is not aimed at your patch but one thing I notice is that there is
and inconsistency in some of our wxStaticBoxSizer() strings.  There are
a few cases where the string ends with a colon (:) but it's rare.  For
the sake of consistency, if you find any cases in the future where this
is true, please remove the trailing colon.

Cheers,

Wayne


On 7/20/2017 5:59 AM, Fabrizio Tappero wrote:
> Hi Wayne,
> you are right. Sorry about that. I have reviewed and changed all instances. 
> 
> In attachment the new patch.
> 
> cheers
> Fabrizio
> 
> 
> On Wed, Jul 19, 2017 at 3:59 PM, Wayne Stambaugh  > wrote:
> 
> Fabrizio,
> 
> You are still using header instead of sentence capitalization of text
> box labels.  For example, in pcbnew/dialogs/dialog_plot_base.cpp you
> changed:
> 
> "Plot format:"
> 
> to
> 
> "Plot Format:"
> 
> The original capitalization is correct.  I see a lot of this in this
> patch.
> 
> Please correct the text box label capitalization and resubmit your
> patch.  Also, please give your patches a unique name so I don't have to.
>  Even easier, just use the name generated by `git format-patch`.
> 
> Wayne
> 
> On 7/19/2017 6:55 AM, Fabrizio Tappero wrote:
> > Hi Wayne,
> > really tedious work to spot these kind of mistakes... I hope I fixed all
> > mistakes.
> >
> > In attachment the new patch.
> >
> > cheers
> > Fabrizio
> >
> >
> > On Wed, Jul 19, 2017 at 12:19 PM, Fabrizio Tappero
> > 
>  >> wrote:
> >
> > Hi Wayne,
> > apologies for that. I sometimes think that a unique patch is more
> > friendly than several ones.
> >
> > Will fix and resubmit.
> >
> > cheers
> > Fabrizio
> >
> >
> > On Tue, Jul 18, 2017 at 3:35 PM, Wayne Stambaugh
> > 
> >> wrote:
> >
> > Fabrizio,
> >
> > This patch has far more changes than the plot dialogs
> mentioned
> > in your
> > commit message.  In the future, please either make your commit
> > message
> > describe all of the changes related to the patch.  I would
> > prefer that
> > you only make one wxFormbuilder dialog change per patch.
> > wxFormbuilder
> > changes tend to be noisy so it takes longer to review them.
> >
> > You are using the incorrect capitalization in text box labels.
> > Text box
> > labels use sentence capitalization not header
> capitalization per
> > the UI
> > guidelines[1].
> >
> > Please fix your patch accordingly so I can commit it.
> >
> > Cheers,
> >
> > Wayne
> >
> >   
>  
> [1]:http://docs.kicad-pcb.org/doxygen/md_Documentation_development_ui-policy.html
> 
> 
> >   
>  
>  
> >
> >
> > On 7/3/2017 4:45 AM, Fabrizio Tappero wrote:
> > > Hi JP,
> > > thanks for it. I updated my wxformbuilder to the latest
> (3.6v)
> > > version. And I fixed the (mm) issue you mentioned.
> > >
> > > In attachment the patch.
> > >
> > > thank you
> > > Fabrizio
> > >
> > >
> > > On Sat, Jul 1, 2017 at 8:40 PM, jp charras
> > 
> >> wrote:
> > >> Le 30/06/2017 à 15:34, Fabrizio Tappero a écrit :
> > >>> Hello,
> > >>> in attachment the patch reviewed after Wayne comments.
> > >>>
> > >>> Best regards
> > >>> Fabrizio
> > >>>
> > >>
> > >> Hi Fabrizio,
> > >>
> > >> I had a look at your last patch, and found a few issues:
> > >> for instance the change:
> > >>
> > >> -   m_defaultLineWidthTitle = new wxStaticText(
> > sbSizerPlotFormat->GetStaticBox(), wxID_ANY,
> > >> _("Default line thickness"), wxDefaultPosition,
> > wxDefaultSize, 0 );
> > >> +

Re: [Kicad-developers] GAL canvas behavior.

2017-07-21 Thread Sergey A. Borshch


On 21.07.2017 11:26, Lorenzo Marcantonio wrote:

It seems to me that most of the features (that I use, at least) from legacy are 
fine on GAL.



I didn't find next features I often use in "route tracks" mode:

1) Delete last segment while placing track ("Backspace" key in Legacy)
2) Move segment node ("M" key in legacy)


--
Regards,
  Sergey A. Borshchmailto: sb...@sourceforge.net
SB ELDI ltd. Riga, Latvia

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] GAL canvas behavior.

2017-07-21 Thread Lorenzo Marcantonio

On Fri, Jul 21, 2017 at 10:01:36AM +0200, Ingo Kletti wrote:
> I've been using the GAL canvas from the start and therefore pressing the ESC
> key twice to deselect an object is 'natural' to me. Even more since
> LibreCAD, the other tool I use regularly, has the same behavior.

Well, I actually *never* select an object I just hover it and press the
key :P However I agree that shift-selection is quite useful to nudge
things around and make space.

I confirm that the cursor handling for measurement etc is now finished
in GAL. Even found the 'always show cursor' option, which I somehome
missed at first.

Also, armed with the knowledge of *how* the anchor point is chosen, when
the cursor is shown it correctly warps to the anchor.

Kudos for the combination color picker too.

It seems to me that most of the features (that I use, at least) from legacy are 
fine on GAL.

Keep on the good work

-- 
Lorenzo Marcantonio

signature.asc
Description: PGP signature
___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] GAL canvas behavior.

2017-07-21 Thread Ingo Kletti

I've been using the GAL canvas from the start and therefore pressing the 
ESC key twice to deselect an object is 'natural' to me. Even more since 
LibreCAD, the other tool I use regularly, has the same behavior.


It never occured to me this behavior might not be intended.

I also second Greg's and Oliver's argument that the component remains 
selected. Especially for multiple selected objects, having to reselect 
them each time the context menu is dismissed would be a tedious task.


Regards,

Ingo

___
Mailing list: https://launchpad.net/~kicad-developers
Post to : kicad-developers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~kicad-developers
More help   : https://help.launchpad.net/ListHelp

Re: [Kicad-developers] Cursor behavior

[Kicad-developers] [PATCH 1/2] Update FindGLEW.cmake

[Kicad-developers] [PATCH 2/2] Legacy handling for Via tool

Re: [Kicad-developers] Cursor behavior

Re: [Kicad-developers] Cursor behavior

Re: [Kicad-developers] [PATCH] correct text inside two importantplot windows

Re: [Kicad-developers] [PATCH] correct text inside two importantplot windows

Re: [Kicad-developers] More layer selection options.

Re: [Kicad-developers] More layer selection options.

[Kicad-developers] More layer selection options.

Re: [Kicad-developers] [PATCH] correct text inside two importantplot windows

Re: [Kicad-developers] [PATCH] simplied right click menu icons

Re: [Kicad-developers] [PATCH] correct text inside two importantplot windows

Re: [Kicad-developers] GAL canvas behavior.

Re: [Kicad-developers] GAL canvas behavior.

Re: [Kicad-developers] GAL canvas behavior.

16 matches

Site Navigation

Mail list logo

Footer information