[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Katrin Fischer changed: What|Removed |Added Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com --- Comment #204 from Tomás Cohen Arazi --- Nice job! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Tomás Cohen Arazi changed: What|Removed |Added Blocks||25466 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25466 [Bug 25466] Review 'problem_reports' column names and types -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com --- Comment #203 from Joy Nelson --- feature not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Martin Renvoize changed: What|Removed |Added Blocks||25215 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25215 [Bug 25215] 'Report a problem' could be enhanced to become a generic 'Inquiry management' process. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Martin Renvoize changed: What|Removed |Added Blocks||25214 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25214 [Bug 25214] It would be beneficial for patrons to be able to see their OPAC problem reports -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Martin Renvoize changed: What|Removed |Added Blocks||25213 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25213 [Bug 25213] It would be beneficial to be able to notify the patron of a resolution -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 David Nind changed: What|Removed |Added Text to go in the||This new features lets release notes||patrons report problems ||using the OPAC. || ||The ||feature is enabled using ||the new OPACReportProblem ||system preference. This: ||- ||adds a link to each page of ||the OPAC to a form so that ||patrons can report ||problems, and ||- adds a ||problem reporting section ||to the staff interface for ||managing problem reports ||(Koha administration > ||Additional parameters > ||OPAC problem reports). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Martin Renvoize changed: What|Removed |Added Version(s)||20.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #202 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #200 from Jonathan Druart --- Created attachment 102385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102385&action=edit Bug 4461: Correctly deal with encoding/escaping chars This patch deals (hopefully) correctly with encoding and escaping chars. It also remove OPACBaseURL from the url stored in DB, and readd is on display, to avoid possible attacks. Test plan: Go to the authority search fill term with something hacky alert('booh!')And Ŝ♥m€ E★tr₳ Search Click the "Report a problem" link Fill the form and make sure the url is displayed correctly submit Check problem_reports.problempage in DB => Should be correctly displayed Go to staff interface, "OPAC problem reports" => Confirm the link is correctly display Click it => Confirm that you are at the OPAC, and the URL is correct Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #201 from Jonathan Druart --- Created attachment 102386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102386&action=edit Bug 4461: Use inbound_email_address to know if we display the dropdown list Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #199 from Jonathan Druart --- Created attachment 102384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102384&action=edit Bug 4461: Extend problem_reports.problempage to TEXT 255 chars is not enough if want want to store any kind of URL, for instance an authorities search can be much longer Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #197 from Jonathan Druart --- Created attachment 102382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102382&action=edit Bug 4461: Hide link if KohaAdminEmailAddress is not set opac-reportproblem.pl returns a 404 in that case Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #198 from Jonathan Druart --- Created attachment 102383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102383&action=edit Bug 4461: dbic schema update Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #194 from Jonathan Druart --- Created attachment 102379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102379&action=edit Bug 4461: Fix status and borrowernumber fields in problem_reports and more status varchar(6) with readable statuses borrowernumber not null default 0 hide form if message successfully sent fixing hide viewed and hide closed filters adding recipient column Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #195 from Jonathan Druart --- Created attachment 102380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102380&action=edit Bug 4461: get_effective_email has been renamed inbound_email_address On commit 027051c938924a33a64014794705526ab68351af Bug 22823: Rename method with ->inbound_email_address Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #196 from Jonathan Druart --- Created attachment 102381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102381&action=edit Bug 4461: Fix OPAC link from staff QA: We have a security issue here, we should not make this link clickable from the staff side. Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #193 from Jonathan Druart --- Created attachment 102378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102378&action=edit Bug 4461: DBIC Schema Files Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #192 from Jonathan Druart --- Created attachment 102377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102377&action=edit Bug 4461: Checks on library email before enqueuing letter Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #190 from Jonathan Druart --- Created attachment 102375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102375&action=edit Bug 4461: (follow-up) Add missing relationship accessor I think this was a simple case of Aliesha missing a file when commiting. So I could proceed with testing I just quickly re-implimented the patron relationship accessor. Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #188 from Jonathan Druart --- Created attachment 102373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102373&action=edit Bug 4461: Add problem reports link to mainpage and admin home Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #191 from Jonathan Druart --- Created attachment 102376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102376&action=edit Bug 4461: Update license statements Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #189 from Jonathan Druart --- Created attachment 102374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102374&action=edit Bug 4461: Manage problem reports on the staff client Test plan: - Update database and upgrade schema files (if you haven't already). Restart memcached - Check your user's permissions and ensure the 'problem_reports' permission is ticked. Confirm the OPACReportProblem syspref is enabled - Log into the OPAC and submit a problem report - Log into the staff client - You should see a box at the bottom of the main page showing your pending problem report - Click the link and confirm it takes you to the new page for managing problem reports - Go to Administration - Confirm you can see a link to 'OPAC problem reports' under the 'Additional parameters' heading - Click 'OPAC problem reports' - Confirm your problem report is showing in the table - Open the OPAC in another tab and submit at least two more problem reports (so you should have at least three in the table after refreshing) - Try the different buttons - selecting multiple problem reports and using the big 'mark viewed', 'mark closed', 'mark new' buttons. Confirm there are no failures and that the number of selected problem reports is correct - select all, clear all, hide viewed, hide closed, hide new, show all - individual 'mark viewed', 'mark closed', 'mark new' buttons for each problem report. Confirm the status shows and the correct button is disabled while others are enabled - Confirm the problem page link works as expected Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #185 from Jonathan Druart --- Created attachment 102370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102370&action=edit Bug 4461: Drop 'from_address' use 'reply_address' This patch adds support for using the reply-to field added in bug 10269 and drops 'from_address' as it will get defined at a later stage in the emailing process anyway. Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #184 from Jonathan Druart --- Created attachment 102369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102369&action=edit Bug 4461: Remove hard requirement on OpacKohaUrl Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #187 from Jonathan Druart --- Created attachment 102372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102372&action=edit Bug 4461: Adding user flags for managing OPAC problem reports Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #186 from Jonathan Druart --- Created attachment 102371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102371&action=edit Bug 4461: Use get_effective_email from bug 22823 Use the get_effective_email from Koha::Library to get an appropriate inbound address for the branch as aposed to using branchemail directly. Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #180 from Jonathan Druart --- Created attachment 102365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102365&action=edit Bug 4461: Use our local_referer instead of HTTP_REFERER Cannot remember why exactly, but it seems that we should not use HTTP_REFERER directly. Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #181 from Jonathan Druart --- Created attachment 102366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102366&action=edit Bug 4461: Redirect to 404 if KohaAdminEmailAddress is not defined Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #183 from Jonathan Druart --- Created attachment 102368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102368&action=edit Bug 4461: Better error handling Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #179 from Jonathan Druart --- Created attachment 102364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102364&action=edit Bug 4461: Use KohaAdminEmailAddress pref as 'from' We usually do not specify the from_address on enqueuing the notice, but when sending it (from _send_message_by_email). That way a) the code is centralized (as we must use $patron->notice_email_address) and b) the email used is the one that is in the DB when the letter is effectively sent. Here I guess you need to give it when the notice is enqueued as you want to default to the koha admin address. I do not think it's a good idea, we should not send an email with "from" if not really sent by the user. We have the borrowernumber anyway to know who filled the form. Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #182 from Jonathan Druart --- Created attachment 102367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102367&action=edit Bug 4461: Simplify recipients code As the feature is now turned off without KohaAdminEmailAddress, we only need to check if the email address of the library if defined. Not that we should not check for $library->branchreplyto or ReplytoDefault, but only $library->branchemail, as we do everywhere else (I think) Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #178 from Jonathan Druart --- Created attachment 102363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102363&action=edit Bug 4461: Rename report date with created_on And make it a timestamp type column Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #177 from Jonathan Druart --- Created attachment 102362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102362&action=edit Bug 4461: (follow-up) Creating sample notice and other fixes - filters - capitalisation - atomic update Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #176 from Jonathan Druart --- Created attachment 102361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102361&action=edit Bug 4461: (follow-up) Redirect to 404 if OPACProblemReport not enabled Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #175 from Jonathan Druart --- Created attachment 102360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102360&action=edit Bug 4461: Submit a problem report To test: 1) Apply patch, update database, rebuild schema file 2) Restart koha-common and memcached 3) Confirm that your user has an email address. 4) Confirm that your library does NOT have an email address. 5) Confirm that syspref KohaAdminEmailAddress and syspref ReplytoDefault are not filled. Enable the OPACReportProblem syspref. 6) Log into OPAC 7) Click the 'Report a problem' link at the bottom of whatever page you're on 8) Notice that there is no form is and there is an error message alerting that reports cannot be submitted 9) Add an email address for your library (in either the email field or the replyto field). Refresh the OPAC problem report page. The form should now show, and the recipient field should say 'library'. 10) Complete the form and submit. Check the message_queue in the database and confirm the to_address is correct. Confirm there is a success message. 11) Add an email address for the syspref KohaAdminEmailAddress and refresh the OPAC problem report page again. The recipient field should now be a dropdown. Select the Koha Administrator option. 12) Complete the form and submit. Check the message_queue in the database and confirm the to_address is the value in KohaAdminEmailAddress. Confirm there is a success message. 13) Ensure all details in the message_queue are correct. 14) Log out of the OPAC 15) Click the Report a problem link again and confirm you are forced to log in Sponsored-by: Catalyst IT Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #174 from Jonathan Druart --- Created attachment 102359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102359&action=edit Bug 4461: Problem Report Koha objects Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Jonathan Druart changed: What|Removed |Added Attachment #102308|0 |1 is obsolete|| Attachment #102309|0 |1 is obsolete|| Attachment #102310|0 |1 is obsolete|| Attachment #102311|0 |1 is obsolete|| Attachment #102312|0 |1 is obsolete|| Attachment #102313|0 |1 is obsolete|| Attachment #102314|0 |1 is obsolete|| Attachment #102315|0 |1 is obsolete|| Attachment #102316|0 |1 is obsolete|| Attachment #102317|0 |1 is obsolete|| Attachment #102318|0 |1 is obsolete|| Attachment #102319|0 |1 is obsolete|| Attachment #102320|0 |1 is obsolete|| Attachment #102321|0 |1 is obsolete|| Attachment #102322|0 |1 is obsolete|| Attachment #102323|0 |1 is obsolete|| Attachment #102324|0 |1 is obsolete|| Attachment #102325|0 |1 is obsolete|| Attachment #102326|0 |1 is obsolete|| Attachment #102327|0 |1 is obsolete|| Attachment #102328|0 |1 is obsolete|| Attachment #102329|0 |1 is obsolete|| Attachment #102330|0 |1 is obsolete|| Attachment #102331|0 |1 is obsolete|| --- Comment #173 from Jonathan Druart --- Created attachment 102358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102358&action=edit Bug 4461: Database and syspref changes adding problem_reports table and OPACReportProblem syspref Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #172 from David Nind --- Note: Bug 25040 needs to be applied first for this to work correctly (see comment 146). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 David Nind changed: What|Removed |Added Attachment #102281|0 |1 is obsolete|| --- Comment #171 from David Nind --- Created attachment 102331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102331&action=edit Bug 4461: Fix OPAC link from staff QA: We have a security issue here, we should not make this link clickable from the staff side. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 David Nind changed: What|Removed |Added Attachment #102211|0 |1 is obsolete|| --- Comment #169 from David Nind --- Created attachment 102329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102329&action=edit Bug 4461: Fix status and borrowernumber fields in problem_reports and more status varchar(6) with readable statuses borrowernumber not null default 0 hide form if message successfully sent fixing hide viewed and hide closed filters adding recipient column Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 David Nind changed: What|Removed |Added Attachment #102210|0 |1 is obsolete|| --- Comment #168 from David Nind --- Created attachment 102328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102328&action=edit Bug 4461: DBIC Schema Files Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 David Nind changed: What|Removed |Added Attachment #102279|0 |1 is obsolete|| --- Comment #170 from David Nind --- Created attachment 102330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102330&action=edit Bug 4461: get_effective_email has been renamed inbound_email_address On commit 027051c938924a33a64014794705526ab68351af Bug 22823: Rename method with ->inbound_email_address Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 David Nind changed: What|Removed |Added Attachment #102206|0 |1 is obsolete|| --- Comment #164 from David Nind --- Created attachment 102324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102324&action=edit Bug 4461: Manage problem reports on the staff client Test plan: - Update database and upgrade schema files (if you haven't already). Restart memcached - Check your user's permissions and ensure the 'problem_reports' permission is ticked. Confirm the OPACReportProblem syspref is enabled - Log into the OPAC and submit a problem report - Log into the staff client - You should see a box at the bottom of the main page showing your pending problem report - Click the link and confirm it takes you to the new page for managing problem reports - Go to Administration - Confirm you can see a link to 'OPAC problem reports' under the 'Additional parameters' heading - Click 'OPAC problem reports' - Confirm your problem report is showing in the table - Open the OPAC in another tab and submit at least two more problem reports (so you should have at least three in the table after refreshing) - Try the different buttons - selecting multiple problem reports and using the big 'mark viewed', 'mark closed', 'mark new' buttons. Confirm there are no failures and that the number of selected problem reports is correct - select all, clear all, hide viewed, hide closed, hide new, show all - individual 'mark viewed', 'mark closed', 'mark new' buttons for each problem report. Confirm the status shows and the correct button is disabled while others are enabled - Confirm the problem page link works as expected Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 David Nind changed: What|Removed |Added Attachment #102209|0 |1 is obsolete|| --- Comment #167 from David Nind --- Created attachment 102327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102327&action=edit Bug 4461: Checks on library email before enqueuing letter Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 David Nind changed: What|Removed |Added Attachment #102208|0 |1 is obsolete|| --- Comment #166 from David Nind --- Created attachment 102326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102326&action=edit Bug 4461: Update license statements Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 David Nind changed: What|Removed |Added Attachment #102207|0 |1 is obsolete|| --- Comment #165 from David Nind --- Created attachment 102325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102325&action=edit Bug 4461: (follow-up) Add missing relationship accessor I think this was a simple case of Aliesha missing a file when commiting. So I could proceed with testing I just quickly re-implimented the patron relationship accessor. Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 David Nind changed: What|Removed |Added Attachment #102205|0 |1 is obsolete|| --- Comment #163 from David Nind --- Created attachment 102323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102323&action=edit Bug 4461: Add problem reports link to mainpage and admin home Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 David Nind changed: What|Removed |Added Attachment #102203|0 |1 is obsolete|| --- Comment #161 from David Nind --- Created attachment 102321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102321&action=edit Bug 4461: Use get_effective_email from bug 22823 Use the get_effective_email from Koha::Library to get an appropriate inbound address for the branch as aposed to using branchemail directly. Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 David Nind changed: What|Removed |Added Attachment #102201|0 |1 is obsolete|| --- Comment #159 from David Nind --- Created attachment 102319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102319&action=edit Bug 4461: Remove hard requirement on OpacKohaUrl Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 David Nind changed: What|Removed |Added Attachment #102200|0 |1 is obsolete|| --- Comment #158 from David Nind --- Created attachment 102318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102318&action=edit Bug 4461: Better error handling Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 David Nind changed: What|Removed |Added Attachment #102204|0 |1 is obsolete|| --- Comment #162 from David Nind --- Created attachment 102322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102322&action=edit Bug 4461: Adding user flags for managing OPAC problem reports Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 David Nind changed: What|Removed |Added Attachment #102202|0 |1 is obsolete|| --- Comment #160 from David Nind --- Created attachment 102320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102320&action=edit Bug 4461: Drop 'from_address' use 'reply_address' This patch adds support for using the reply-to field added in bug 10269 and drops 'from_address' as it will get defined at a later stage in the emailing process anyway. Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 David Nind changed: What|Removed |Added Attachment #102198|0 |1 is obsolete|| --- Comment #157 from David Nind --- Created attachment 102317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102317&action=edit Bug 4461: Simplify recipients code As the feature is now turned off without KohaAdminEmailAddress, we only need to check if the email address of the library if defined. Not that we should not check for $library->branchreplyto or ReplytoDefault, but only $library->branchemail, as we do everywhere else (I think) Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 David Nind changed: What|Removed |Added Attachment #102196|0 |1 is obsolete|| --- Comment #156 from David Nind --- Created attachment 102316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102316&action=edit Bug 4461: Redirect to 404 if KohaAdminEmailAddress is not defined Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 David Nind changed: What|Removed |Added Attachment #102195|0 |1 is obsolete|| --- Comment #155 from David Nind --- Created attachment 102315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102315&action=edit Bug 4461: Use our local_referer instead of HTTP_REFERER Cannot remember why exactly, but it seems that we should not use HTTP_REFERER directly. Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 David Nind changed: What|Removed |Added Attachment #102193|0 |1 is obsolete|| --- Comment #153 from David Nind --- Created attachment 102313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102313&action=edit Bug 4461: Rename report date with created_on And make it a timestamp type column Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 David Nind changed: What|Removed |Added Attachment #102194|0 |1 is obsolete|| --- Comment #154 from David Nind --- Created attachment 102314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102314&action=edit Bug 4461: Use KohaAdminEmailAddress pref as 'from' We usually do not specify the from_address on enqueuing the notice, but when sending it (from _send_message_by_email). That way a) the code is centralized (as we must use $patron->notice_email_address) and b) the email used is the one that is in the DB when the letter is effectively sent. Here I guess you need to give it when the notice is enqueued as you want to default to the koha admin address. I do not think it's a good idea, we should not send an email with "from" if not really sent by the user. We have the borrowernumber anyway to know who filled the form. Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 David Nind changed: What|Removed |Added Attachment #102192|0 |1 is obsolete|| --- Comment #152 from David Nind --- Created attachment 102312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102312&action=edit Bug 4461: (follow-up) Creating sample notice and other fixes - filters - capitalisation - atomic update Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 David Nind changed: What|Removed |Added Attachment #102191|0 |1 is obsolete|| --- Comment #151 from David Nind --- Created attachment 102311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102311&action=edit Bug 4461: (follow-up) Redirect to 404 if OPACProblemReport not enabled Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 David Nind changed: What|Removed |Added Attachment #102190|0 |1 is obsolete|| --- Comment #150 from David Nind --- Created attachment 102310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102310&action=edit Bug 4461: Submit a problem report To test: 1) Apply patch, update database, rebuild schema file 2) Restart koha-common and memcached 3) Confirm that your user has an email address. 4) Confirm that your library does NOT have an email address. 5) Confirm that syspref KohaAdminEmailAddress and syspref ReplytoDefault are not filled. Enable the OPACReportProblem syspref. 6) Log into OPAC 7) Click the 'Report a problem' link at the bottom of whatever page you're on 8) Notice that there is no form is and there is an error message alerting that reports cannot be submitted 9) Add an email address for your library (in either the email field or the replyto field). Refresh the OPAC problem report page. The form should now show, and the recipient field should say 'library'. 10) Complete the form and submit. Check the message_queue in the database and confirm the to_address is correct. Confirm there is a success message. 11) Add an email address for the syspref KohaAdminEmailAddress and refresh the OPAC problem report page again. The recipient field should now be a dropdown. Select the Koha Administrator option. 12) Complete the form and submit. Check the message_queue in the database and confirm the to_address is the value in KohaAdminEmailAddress. Confirm there is a success message. 13) Ensure all details in the message_queue are correct. 14) Log out of the OPAC 15) Click the Report a problem link again and confirm you are forced to log in Sponsored-by: Catalyst IT Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 David Nind changed: What|Removed |Added Attachment #102189|0 |1 is obsolete|| --- Comment #149 from David Nind --- Created attachment 102309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102309&action=edit Bug 4461: Problem Report Koha objects Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 David Nind changed: What|Removed |Added Attachment #102188|0 |1 is obsolete|| --- Comment #148 from David Nind --- Created attachment 102308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102308&action=edit Bug 4461: Database and syspref changes adding problem_reports table and OPACReportProblem syspref Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #147 from Jonathan Druart --- Created attachment 102281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102281&action=edit Bug 4461: Fix OPAC link from staff QA: We have a security issue here, we should not make this link clickable from the staff side. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #146 from David Nind --- Thanks Jonathan for figuring out the problem! Applying Bug 25040 before applying 4461 fixes the problem. When someone gets a chance to fix item 2 (pretty minor - but I don't know how to fix the template) from Comment 139 I'll happily sign off. David -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #145 from Jonathan Druart --- (In reply to David Nind from comment #141) > Created attachment 102253 [details] > Bug 4461: Error log when using MySQL 5.5 > > I've attached the error log when testing on koha-testing-docker with MySQL v > 5.5 (started with ku) when submitting a problem report when 'A librarian' is > selected. The important line was the first one: 135 Something wrong happened when sending the report problem: The method Koha::Library->get_effective_email is not covered by tests! Sorry David I missed that when rebasing the patches. That should be fixed by the last patch. I am resetting to NSO, but you will need to apply patch from bug 25040, if not pushed yet. I do not have time to retest this feature right now, if you face errors again, please to not spend too much time and FQA it immediatly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #144 from Jonathan Druart --- Created attachment 102279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102279&action=edit Bug 4461: get_effective_email has been renamed inbound_email_address On commit 027051c938924a33a64014794705526ab68351af Bug 22823: Rename method with ->inbound_email_address -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #143 from Jonathan Druart --- (In reply to David Nind from comment #140) > This is the error in the plack-error.log after submitting the problem report > in the OPAC (using MariaDB): > > 36 DBD::mysql::st execute failed: Incorrect datetime value: > 'current_timestamp()' for column > `koha_kohadev`.`problem_reports`.`created_on` at row 1 [for Statement > "INSERT INTO `problem_reports` ( `borrowernumber`, `branchcode`, `content`, > `created_on`, `problempage`, `recipient`, `title`, `username`) VALUES ( > ?, ?, ?, ?, ?, ?, ?, ? )" with ParamValues: 0="51", 1='CPL', 2="Test 145", > 3='current_timestamp()', 4="http://kohadev.myDNSname.org:8080/";, > 5="admin", 6="Test 145", 7='koha'] at > /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836. > 37 DBIx::Class::Storage::DBI::_dbh_execute(): Incorrect datetime value: > 'current_timestamp()' for column `koha_kohadev`.`problem_reports`. > `created_on` at row 1 at /kohadevbox/koha/Koha/Object.pm line 164 > 38 Something wrong happened when sending the report problem: Invalid value > passed, problem_reports.created_on=current_timestamp() expected type is > datetime at /kohadevbox/koha/opac/opac-reportproblem.pl line 131. This is coming from a bug in master, see bug 25040. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #142 from David Nind --- To clarify comments about MySQL and MariaDB, starting koha-testing-docker with: - ku: Server version = 5.5.62 MySQL Community Server (GPL) - ku-mdb: Server version = 10.4.12-MariaDB-1:10.4.12+maria~bionic mariadb.org binary distribution -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #141 from David Nind --- Created attachment 102253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102253&action=edit Bug 4461: Error log when using MySQL 5.5 I've attached the error log when testing on koha-testing-docker with MySQL v 5.5 (started with ku) when submitting a problem report when 'A librarian' is selected. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #140 from David Nind --- Also, the results from Comment 139 were from testing with koha-testing-dock and starting with ku (Koha using MySQL 5.5). If I test with ku-mdb (MariaDB) then I get different problems. With KohaAdminEmailAddress set and a library email address set I get this error message when submitting a problem report "[#% We really should avoid reaching this! %] Something wrong happened when sending the report. Please contact your library." Something has happened since I originally tested, as I didn't have this problem then. This is the error in the plack-error.log after submitting the problem report in the OPAC (using MariaDB): 36 DBD::mysql::st execute failed: Incorrect datetime value: 'current_timestamp()' for column `koha_kohadev`.`problem_reports`.`created_on` at row 1 [for Statement "INSERT INTO `problem_reports` ( `borrowernumber`, `branchcode`, `content`, `created_on`, `problempage`, `recipient`, `title`, `username`) VALUES ( ?, ?, ?, ?, ?, ?, ?, ? )" with ParamValues: 0="51", 1='CPL', 2="Test 145", 3='current_timestamp()', 4="http://kohadev.myDNSname.org:8080/";, 5="admin", 6="Test 145", 7='koha'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836. 37 DBIx::Class::Storage::DBI::_dbh_execute(): Incorrect datetime value: 'current_timestamp()' for column `koha_kohadev`.`problem_reports`. `created_on` at row 1 at /kohadevbox/koha/Koha/Object.pm line 164 38 Something wrong happened when sending the report problem: Invalid value passed, problem_reports.created_on=current_timestamp() expected type is datetime at /kohadevbox/koha/opac/opac-reportproblem.pl line 131. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #139 from David Nind --- I've retested again. Two issues I've identified: 1) If there is no library email address there is no drop down list on the report a problem page, which is the expected behavour. If there is an email address set for the library then there is a drop down list with 'A librarian' and 'Koha administrator' options. Koha administrator works fine, if you select 'A librarian' you get this error message when submitting "[#% We really should avoid reaching this! %] Something wrong happened when sending the report. Please contact your library." 2)In the staff interface the link to the problem page (in the 'Problem page') displays correctly, however the actual link is adding additional information before it, for example: - Displays as http://kohadev.myDNSname.org:8080/ - Actual link when you try to click on it: http://127.0.0.1:8081/cgi-bin/koha/admin/http%3A%2F%2Fkohadev.myDNSname.org%3A8080%2F -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #138 from Jonathan Druart --- (In reply to David Nind from comment #137) > I'm now getting this error message when trying to submit the form, no matter > what I do: > > [#% We really should avoid reaching this! %] Something wrong happened when > sending the report. Please contact your library. > > Note: I'm following the test plan in Comment 117 Do you see something relevant in the Koha log file? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 David Nind changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #137 from David Nind --- I'm now getting this error message when trying to submit the form, no matter what I do: [#% We really should avoid reaching this! %] Something wrong happened when sending the report. Please contact your library. Note: I'm following the test plan in Comment 117 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #135 from Jonathan Druart --- Created attachment 102210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102210&action=edit Bug 4461: DBIC Schema Files Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #133 from Jonathan Druart --- Created attachment 102208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102208&action=edit Bug 4461: Update license statements -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #132 from Jonathan Druart --- Created attachment 102207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102207&action=edit Bug 4461: (follow-up) Add missing relationship accessor I think this was a simple case of Aliesha missing a file when commiting. So I could proceed with testing I just quickly re-implimented the patron relationship accessor. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #134 from Jonathan Druart --- Created attachment 102209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102209&action=edit Bug 4461: Checks on library email before enqueuing letter -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #136 from Jonathan Druart --- Created attachment 102211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102211&action=edit Bug 4461: Fix status and borrowernumber fields in problem_reports and more status varchar(6) with readable statuses borrowernumber not null default 0 hide form if message successfully sent fixing hide viewed and hide closed filters adding recipient column -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #128 from Jonathan Druart --- Created attachment 102203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102203&action=edit Bug 4461: Use get_effective_email from bug 22823 Use the get_effective_email from Koha::Library to get an appropriate inbound address for the branch as aposed to using branchemail directly. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #131 from Jonathan Druart --- Created attachment 102206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102206&action=edit Bug 4461: Manage problem reports on the staff client Test plan: - Update database and upgrade schema files (if you haven't already). Restart memcached - Check your user's permissions and ensure the 'problem_reports' permission is ticked. Confirm the OPACReportProblem syspref is enabled - Log into the OPAC and submit a problem report - Log into the staff client - You should see a box at the bottom of the main page showing your pending problem report - Click the link and confirm it takes you to the new page for managing problem reports - Go to Administration - Confirm you can see a link to 'OPAC problem reports' under the 'Additional parameters' heading - Click 'OPAC problem reports' - Confirm your problem report is showing in the table - Open the OPAC in another tab and submit at least two more problem reports (so you should have at least three in the table after refreshing) - Try the different buttons - selecting multiple problem reports and using the big 'mark viewed', 'mark closed', 'mark new' buttons. Confirm there are no failures and that the number of selected problem reports is correct - select all, clear all, hide viewed, hide closed, hide new, show all - individual 'mark viewed', 'mark closed', 'mark new' buttons for each problem report. Confirm the status shows and the correct button is disabled while others are enabled - Confirm the problem page link works as expected Sponsored-by: Catalyst IT Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #130 from Jonathan Druart --- Created attachment 102205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102205&action=edit Bug 4461: Add problem reports link to mainpage and admin home Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #129 from Jonathan Druart --- Created attachment 102204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102204&action=edit Bug 4461: Adding user flags for managing OPAC problem reports Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #127 from Jonathan Druart --- Created attachment 102202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102202&action=edit Bug 4461: Drop 'from_address' use 'reply_address' This patch adds support for using the reply-to field added in bug 10269 and drops 'from_address' as it will get defined at a later stage in the emailing process anyway. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #124 from Jonathan Druart --- Created attachment 102198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102198&action=edit Bug 4461: Simplify recipients code As the feature is now turned off without KohaAdminEmailAddress, we only need to check if the email address of the library if defined. Not that we should not check for $library->branchreplyto or ReplytoDefault, but only $library->branchemail, as we do everywhere else (I think) Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #126 from Jonathan Druart --- Created attachment 102201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102201&action=edit Bug 4461: Remove hard requirement on OpacKohaUrl Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #125 from Jonathan Druart --- Created attachment 102200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102200&action=edit Bug 4461: Better error handling Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #123 from Jonathan Druart --- Created attachment 102196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102196&action=edit Bug 4461: Redirect to 404 if KohaAdminEmailAddress is not defined Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #121 from Jonathan Druart --- Created attachment 102194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102194&action=edit Bug 4461: Use KohaAdminEmailAddress pref as 'from' We usually do not specify the from_address on enqueuing the notice, but when sending it (from _send_message_by_email). That way a) the code is centralized (as we must use $patron->notice_email_address) and b) the email used is the one that is in the DB when the letter is effectively sent. Here I guess you need to give it when the notice is enqueued as you want to default to the koha admin address. I do not think it's a good idea, we should not send an email with "from" if not really sent by the user. We have the borrowernumber anyway to know who filled the form. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #120 from Jonathan Druart --- Created attachment 102193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102193&action=edit Bug 4461: Rename report date with created_on And make it a timestamp type column Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #122 from Jonathan Druart --- Created attachment 102195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102195&action=edit Bug 4461: Use our local_referer instead of HTTP_REFERER Cannot remember why exactly, but it seems that we should not use HTTP_REFERER directly. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #118 from Jonathan Druart --- Created attachment 102191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102191&action=edit Bug 4461: (follow-up) Redirect to 404 if OPACProblemReport not enabled Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Jonathan Druart changed: What|Removed |Added Attachment #100506|0 |1 is obsolete|| Attachment #100507|0 |1 is obsolete|| Attachment #100508|0 |1 is obsolete|| Attachment #100509|0 |1 is obsolete|| Attachment #100510|0 |1 is obsolete|| Attachment #100511|0 |1 is obsolete|| Attachment #100512|0 |1 is obsolete|| Attachment #100513|0 |1 is obsolete|| Attachment #100514|0 |1 is obsolete|| Attachment #100515|0 |1 is obsolete|| Attachment #100516|0 |1 is obsolete|| Attachment #100517|0 |1 is obsolete|| Attachment #100518|0 |1 is obsolete|| Attachment #100519|0 |1 is obsolete|| Attachment #100520|0 |1 is obsolete|| Attachment #100521|0 |1 is obsolete|| Attachment #100522|0 |1 is obsolete|| Attachment #100523|0 |1 is obsolete|| Attachment #100524|0 |1 is obsolete|| Attachment #100619|0 |1 is obsolete|| Attachment #100989|0 |1 is obsolete|| Attachment #100990|0 |1 is obsolete|| --- Comment #115 from Jonathan Druart --- Created attachment 102188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102188&action=edit Bug 4461: Database and syspref changes adding problem_reports table and OPACReportProblem syspref Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #117 from Jonathan Druart --- Created attachment 102190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102190&action=edit Bug 4461: Submit a problem report To test: 1) Apply patch, update database, rebuild schema file 2) Restart koha-common and memcached 3) Confirm that your user has an email address. 4) Confirm that your library does NOT have an email address. 5) Confirm that syspref KohaAdminEmailAddress and syspref ReplytoDefault are not filled. Enable the OPACReportProblem syspref. 6) Log into OPAC 7) Click the 'Report a problem' link at the bottom of whatever page you're on 8) Notice that there is no form is and there is an error message alerting that reports cannot be submitted 9) Add an email address for your library (in either the email field or the replyto field). Refresh the OPAC problem report page. The form should now show, and the recipient field should say 'library'. 10) Complete the form and submit. Check the message_queue in the database and confirm the to_address is correct. Confirm there is a success message. 11) Add an email address for the syspref KohaAdminEmailAddress and refresh the OPAC problem report page again. The recipient field should now be a dropdown. Select the Koha Administrator option. 12) Complete the form and submit. Check the message_queue in the database and confirm the to_address is the value in KohaAdminEmailAddress. Confirm there is a success message. 13) Ensure all details in the message_queue are correct. 14) Log out of the OPAC 15) Click the Report a problem link again and confirm you are forced to log in Sponsored-by: Catalyst IT Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #116 from Jonathan Druart --- Created attachment 102189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102189&action=edit Bug 4461: Problem Report Koha objects Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 --- Comment #119 from Jonathan Druart --- Created attachment 102192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102192&action=edit Bug 4461: (follow-up) Creating sample notice and other fixes - filters - capitalisation - atomic update Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/