Re: [PATCH v5 0/5] Add new driver for generic scaler
On 08/01/2012 09:35 AM, Sungchun Kang wrote: > I'm sorry to be so late. > Basically, I wonder important one thing. > What would you implement a device driver connected with gscaler. > For example, fimc-lite, mipi-csis. > As you know Exynos5 has local-path with gscaler > MIPI-CSIS => Fimc-lite => Gscaler > And, you should use media control framework. > So, We made exynos folder, and implement drivers with mc. > We use mdev that is virtual device driver for connecting gscaler, fimc-lite, > mipi-csis with MC. > This is camera path. > There are not only camera path but also rendering path. > Gscaler => FIMD or TV > Rendering path use mdev-0, > Camera path use mdev-1. > In conclusion, because we use to connect each other devices with MC, we made > exynos folder. > > And how you make to implement devices with MC? As you may know, these patches only add mem-to-mem functionality, which can be used together with the Exynos multi-format video codec. Remaining features, as you listed, are planned to be added later, in subsequent steps, after discussing it here on the mailing list. I think it's much better approach, than coming up with a complete huge driver with many API compliance issues. Especially that some drivers, like MIPI-CSIS or FIMC-LITE are already in the mainline kernel. As for the driver directory name, IMHO drivers/media/exynos is too generic, s5p-fimc, s5p-jpeg, s5p-tv also cover some Exynos SoCs. I don't think having drivers/media/exynos directory would be helpful in anything. Regards, Sylwester -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v5 0/5] Add new driver for generic scaler
On 07/31/2012 10:44 PM, Shaik Ameer Basha wrote: > -Original Message- > From: Shaik Ameer Basha [mailto:shaik.am...@samsung.com] > Sent: Tuesday, July 31, 2012 10:44 PM > To: linux-media@vger.kernel.org > Cc: sungchun.k...@samsung.com; khw0178@samsung.com; mche...@infradead.org; > laurent.pinch...@ideasonboard.com; sy0816.k...@samsung.com; > s.nawro...@samsung.com; > posc...@google.com; hverk...@xs4all.nl; alim.akh...@gmail.com; > prashant...@samsung.com; > jo...@samsung.com; shaik.sams...@gmail.com; shaik.am...@samsung.com > Subject: [PATCH v5 0/5] Add new driver for generic scaler > > This patch adds support for the gscaler device which is a new device > for scaling and color space conversion on EXYNOS5 SoCs. > > This device supports the followings as key feature. > 1) Input image format >- RGB888/565, YUV422 1P/2P, YUV420 2P/3P, TILE > 2) Output image format >- RGB888/565, YUV422 1P/2P, YUV420 2P/3P, YUV444 > 3) Input rotation >- 0/90/180/270 degree, X/Y Flip > 4) Scale ratio >- 1/16 scale down to 8 scale up > 5) CSC >- RGB to YUV / YUV to RGB > 6) Size >- 2048 x 2048 for tile or rotation >- 4800 x 3344 other case > > changes since v4: > - Rebased on latest media-tree git, branch staging/for_v3.6. > http://linuxtv.org/git/media_tree.git > - Addressed review comments from Hans Verkuil > http://www.mail-archive.com/linux-media@vger.kernel.org/msg49754.html > - Removed the "v4l: Add fourcc definitions for new formats" patch dependency. > > Shaik Ameer Basha (2): > v4l: Add new YVU420 multi planar fourcc definition > media: gscaler: Add Makefile for G-Scaler Driver > > Sungchun Kang (3): > media: gscaler: Add new driver for generic scaler > media: gscaler: Add core functionality for the G-Scaler driver > media: gscaler: Add m2m functionality for the G-Scaler driver > > Documentation/DocBook/media/v4l/pixfmt-yvu420m.xml | 154 +++ > Documentation/DocBook/media/v4l/pixfmt.xml |1 + > drivers/media/video/Kconfig|8 + > drivers/media/video/Makefile |2 + > drivers/media/video/exynos-gsc/Makefile|3 + > drivers/media/video/exynos-gsc/gsc-core.c | 1254 > > drivers/media/video/exynos-gsc/gsc-core.h | 532 + > drivers/media/video/exynos-gsc/gsc-m2m.c | 771 > drivers/media/video/exynos-gsc/gsc-regs.c | 425 +++ > drivers/media/video/exynos-gsc/gsc-regs.h | 172 +++ > include/linux/videodev2.h |1 + > 11 files changed, 3323 insertions(+), 0 deletions(-) > create mode 100644 Documentation/DocBook/media/v4l/pixfmt-yvu420m.xml > create mode 100644 drivers/media/video/exynos-gsc/Makefile > create mode 100644 drivers/media/video/exynos-gsc/gsc-core.c > create mode 100644 drivers/media/video/exynos-gsc/gsc-core.h > create mode 100644 drivers/media/video/exynos-gsc/gsc-m2m.c > create mode 100644 drivers/media/video/exynos-gsc/gsc-regs.c > create mode 100644 drivers/media/video/exynos-gsc/gsc-regs.h I'm sorry to be so late. Basically, I wonder important one thing. What would you implement a device driver connected with gscaler. For example, fimc-lite, mipi-csis. As you know Exynos5 has local-path with gscaler MIPI-CSIS => Fimc-lite => Gscaler And, you should use media control framework. So, We made exynos folder, and implement drivers with mc. We use mdev that is virtual device driver for connecting gscaler, fimc-lite, mipi-csis with MC. This is camera path. There are not only camera path but also rendering path. Gscaler => FIMD or TV Rendering path use mdev-0, Camera path use mdev-1. In conclusion, because we use to connect each other devices with MC, we made exynos folder. And how you make to implement devices with MC? -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v5 0/5] Add new driver for generic scaler
On 07/31/2012 03:44 PM, Shaik Ameer Basha wrote: > This patch adds support for the gscaler device which is a new device > for scaling and color space conversion on EXYNOS5 SoCs. > > This device supports the followings as key feature. > 1) Input image format >- RGB888/565, YUV422 1P/2P, YUV420 2P/3P, TILE > 2) Output image format >- RGB888/565, YUV422 1P/2P, YUV420 2P/3P, YUV444 > 3) Input rotation >- 0/90/180/270 degree, X/Y Flip > 4) Scale ratio >- 1/16 scale down to 8 scale up > 5) CSC >- RGB to YUV / YUV to RGB > 6) Size >- 2048 x 2048 for tile or rotation >- 4800 x 3344 other case > > changes since v4: > - Rebased on latest media-tree git, branch staging/for_v3.6. > http://linuxtv.org/git/media_tree.git > - Addressed review comments from Hans Verkuil > http://www.mail-archive.com/linux-media@vger.kernel.org/msg49754.html > - Removed the "v4l: Add fourcc definitions for new formats" patch dependency. > > Shaik Ameer Basha (2): > v4l: Add new YVU420 multi planar fourcc definition > media: gscaler: Add Makefile for G-Scaler Driver > > Sungchun Kang (3): > media: gscaler: Add new driver for generic scaler > media: gscaler: Add core functionality for the G-Scaler driver > media: gscaler: Add m2m functionality for the G-Scaler driver For the whole series: Acked-by: Sylwester Nawrocki > Documentation/DocBook/media/v4l/pixfmt-yvu420m.xml | 154 +++ > Documentation/DocBook/media/v4l/pixfmt.xml |1 + > drivers/media/video/Kconfig|8 + > drivers/media/video/Makefile |2 + > drivers/media/video/exynos-gsc/Makefile|3 + > drivers/media/video/exynos-gsc/gsc-core.c | 1254 > > drivers/media/video/exynos-gsc/gsc-core.h | 532 + > drivers/media/video/exynos-gsc/gsc-m2m.c | 771 > drivers/media/video/exynos-gsc/gsc-regs.c | 425 +++ > drivers/media/video/exynos-gsc/gsc-regs.h | 172 +++ > include/linux/videodev2.h |1 + > 11 files changed, 3323 insertions(+), 0 deletions(-) > create mode 100644 Documentation/DocBook/media/v4l/pixfmt-yvu420m.xml > create mode 100644 drivers/media/video/exynos-gsc/Makefile > create mode 100644 drivers/media/video/exynos-gsc/gsc-core.c > create mode 100644 drivers/media/video/exynos-gsc/gsc-core.h > create mode 100644 drivers/media/video/exynos-gsc/gsc-m2m.c > create mode 100644 drivers/media/video/exynos-gsc/gsc-regs.c > create mode 100644 drivers/media/video/exynos-gsc/gsc-regs.h -- Thanks, Sylwester -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v5 0/5] Add new driver for generic scaler
This patch adds support for the gscaler device which is a new device for scaling and color space conversion on EXYNOS5 SoCs. This device supports the followings as key feature. 1) Input image format - RGB888/565, YUV422 1P/2P, YUV420 2P/3P, TILE 2) Output image format - RGB888/565, YUV422 1P/2P, YUV420 2P/3P, YUV444 3) Input rotation - 0/90/180/270 degree, X/Y Flip 4) Scale ratio - 1/16 scale down to 8 scale up 5) CSC - RGB to YUV / YUV to RGB 6) Size - 2048 x 2048 for tile or rotation - 4800 x 3344 other case changes since v4: - Rebased on latest media-tree git, branch staging/for_v3.6. http://linuxtv.org/git/media_tree.git - Addressed review comments from Hans Verkuil http://www.mail-archive.com/linux-media@vger.kernel.org/msg49754.html - Removed the "v4l: Add fourcc definitions for new formats" patch dependency. Shaik Ameer Basha (2): v4l: Add new YVU420 multi planar fourcc definition media: gscaler: Add Makefile for G-Scaler Driver Sungchun Kang (3): media: gscaler: Add new driver for generic scaler media: gscaler: Add core functionality for the G-Scaler driver media: gscaler: Add m2m functionality for the G-Scaler driver Documentation/DocBook/media/v4l/pixfmt-yvu420m.xml | 154 +++ Documentation/DocBook/media/v4l/pixfmt.xml |1 + drivers/media/video/Kconfig|8 + drivers/media/video/Makefile |2 + drivers/media/video/exynos-gsc/Makefile|3 + drivers/media/video/exynos-gsc/gsc-core.c | 1254 drivers/media/video/exynos-gsc/gsc-core.h | 532 + drivers/media/video/exynos-gsc/gsc-m2m.c | 771 drivers/media/video/exynos-gsc/gsc-regs.c | 425 +++ drivers/media/video/exynos-gsc/gsc-regs.h | 172 +++ include/linux/videodev2.h |1 + 11 files changed, 3323 insertions(+), 0 deletions(-) create mode 100644 Documentation/DocBook/media/v4l/pixfmt-yvu420m.xml create mode 100644 drivers/media/video/exynos-gsc/Makefile create mode 100644 drivers/media/video/exynos-gsc/gsc-core.c create mode 100644 drivers/media/video/exynos-gsc/gsc-core.h create mode 100644 drivers/media/video/exynos-gsc/gsc-m2m.c create mode 100644 drivers/media/video/exynos-gsc/gsc-regs.c create mode 100644 drivers/media/video/exynos-gsc/gsc-regs.h -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
