[Mahara-contributors] [Bug 1546769] A patch has been submitted for review
Patch for "16.10_STABLE" branch: https://reviews.mahara.org/8022 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1546769 Title: The 'None' auth needs to be locked down or removed to avoid troubles with multi institutions Status in Mahara: In Progress Status in Mahara 16.04 series: In Progress Status in Mahara 16.10 series: In Progress Status in Mahara 17.04 series: In Progress Status in Mahara 17.10 series: In Progress Bug description: When there are multiple institutions/tenants on a mahara and one of the tenants decides to add the 'None' auth method to their institution it causes havoc for users on all institutions as if they accidentally enter their login details wrong they get logged in to institution with 'None' set as a new user rather than their normal institution/account. Things that need to be changed to avoid this problem: 1) When an institution tries to add the 'None' auth option it needs to check to see if there are any other institutions present and only allow it if institution count = 1 2) Conversely if the only institution uses 'None' auth then you shouldn't be allowed to add a new institution until that auth is removed 3) And when you are able to add "None" you should probably get some prominent message with "Do you really want to do this? You know, it means that anybody will be able to log in without any authorization" Also as part of this change it would be very good to add a ctime (and maybe userid) field to the auth_instance table to record when one adds/edits auth details to see when things changed as this human error can cause big problems for users. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1546769/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1560739] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/8024 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1560739 Title: Can't build CSS if you have npm gulp-bless version 3.1.0 Status in Mahara: In Progress Bug description: If you have the npm package "gulp-bless" at version 3.1.0 (which requires the "bless" package at 4.0.0), then Mahara's SASS compilation (make css) will error out. To replicate: 1. Clone a new Mahara repository, or in an existing Mahara repo rename your "node_modules" directory to "node_modules.bak" 2. Run "npm install" in this repo 3. Run "make css" Expected result: Successfully builds the CSS, with this output. (master)aaronw@vegas:~/www/mahara$ make css npm install npm WARN package.json mahara-themes@1.0.0 No repository field. npm WARN package.json gulp-minify-css@1.2.4 No repository field. Building CSS... [13:21:16] Using gulpfile ~/www/mahara/gulpfile.js [13:21:16] Starting 'css'... Compiling CSS for htdocs/theme/custom Compiling CSS for htdocs/theme/default Compiling CSS for htdocs/theme/modern Compiling CSS for htdocs/theme/ocean Compiling CSS for htdocs/theme/primaryschool Compiling CSS for htdocs/theme/raw Compiling CSS for htdocs/theme/subthemestarter [13:21:21] Finished 'css' after 5.72 s Done! Actual result: Errors out with this output. (master)aaronw@vegas:~/www/mahara-test$ make css npm install npm WARN package.json mahara-themes@1.0.0 No repository field. npm WARN package.json gulp-minify-css@1.2.4 No repository field. Building CSS... [13:22:42] Using gulpfile ~/www/mahara-test/gulpfile.js [13:22:42] Starting 'css'... Compiling CSS for htdocs/theme/custom Compiling CSS for htdocs/theme/default Compiling CSS for htdocs/theme/modern Compiling CSS for htdocs/theme/ocean Compiling CSS for htdocs/theme/primaryschool Compiling CSS for htdocs/theme/raw Compiling CSS for htdocs/theme/subthemestarter events.js:72 throw er; // Unhandled 'error' event ^ TypeError: Cannot call method 'reduce' of undefined at countRules (/home/aaronw/www/mahara-test/node_modules/gulp-bless/node_modules/bless/lib/count.js:26:18) at count (/home/aaronw/www/mahara-test/node_modules/gulp-bless/node_modules/bless/lib/count.js:44:14) at chunks$ (/home/aaronw/www/mahara-test/node_modules/gulp-bless/node_modules/bless/lib/chunk.js:52:46) at tryCatch (/home/aaronw/www/mahara-test/node_modules/gulp-bless/node_modules/bless/node_modules/babel-runtime/regenerator/runtime.js:72:40) at GeneratorFunctionPrototype.invoke [as _invoke] (/home/aaronw/www/mahara-test/node_modules/gulp-bless/node_modules/bless/node_modules/babel-runtime/regenerator/runtime.js:334:22) at GeneratorFunctionPrototype.prototype.(anonymous function) [as next] (/home/aaronw/www/mahara-test/node_modules/gulp-bless/node_modules/bless/node_modules/babel-runtime/regenerator/runtime.js:105:21) at chunk (/home/aaronw/www/mahara-test/node_modules/gulp-bless/node_modules/bless/lib/chunk.js:98:113) at Object.chunk (/home/aaronw/www/mahara-test/node_modules/gulp-bless/node_modules/bless/lib/index.js:34:33) at Transform._transform (/home/aaronw/www/mahara-test/node_modules/gulp-bless/index.js:33:36) at Transform._read (/home/aaronw/www/mahara-test/node_modules/gulp-bless/node_modules/through2/node_modules/readable-stream/lib/_stream_transform.js:184:10) npm WARN package.json mahara-themes@1.0.0 No repository field. npm WARN package.json gulp-minify-css@1.2.4 No repository field. [13:22:46] Using gulpfile ~/www/mahara-test/gulpfile.js [13:22:46] Starting 'css'... Compiling CSS for htdocs/theme/custom Compiling CSS for htdocs/theme/default Compiling CSS for htdocs/theme/modern Compiling CSS for htdocs/theme/ocean Compiling CSS for htdocs/theme/primaryschool Compiling CSS for htdocs/theme/raw Compiling CSS for htdocs/theme/subthemestarter events.js:72 throw er; // Unhandled 'error' event ^ TypeError: Cannot call method 'reduce' of undefined at countRules (/home/aaronw/www/mahara-test/node_modules/gulp-bless/node_modules/bless/lib/count.js:26:18) at count (/home/aaronw/www/mahara-test/node_modules/gulp-bless/node_modules/bless/lib/count.js:44:14) at chunks$ (/home/aaronw/www/mahara-test/node_modules/gulp-bless/node_modules/bless/lib/chunk.js:52:46) at tryCatch (/home/aaronw/www/mahara-test/node_modules/gulp-bless/node_modules/bless/node_modules/babel-runtime/regenerator/runtime.js:72:40) at GeneratorFunctionPrototype.invoke [as _invoke]
[Mahara-contributors] [Bug 1546769] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/8023 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1546769 Title: The 'None' auth needs to be locked down or removed to avoid troubles with multi institutions Status in Mahara: In Progress Status in Mahara 16.04 series: In Progress Status in Mahara 16.10 series: In Progress Status in Mahara 17.04 series: In Progress Status in Mahara 17.10 series: In Progress Bug description: When there are multiple institutions/tenants on a mahara and one of the tenants decides to add the 'None' auth method to their institution it causes havoc for users on all institutions as if they accidentally enter their login details wrong they get logged in to institution with 'None' set as a new user rather than their normal institution/account. Things that need to be changed to avoid this problem: 1) When an institution tries to add the 'None' auth option it needs to check to see if there are any other institutions present and only allow it if institution count = 1 2) Conversely if the only institution uses 'None' auth then you shouldn't be allowed to add a new institution until that auth is removed 3) And when you are able to add "None" you should probably get some prominent message with "Do you really want to do this? You know, it means that anybody will be able to log in without any authorization" Also as part of this change it would be very good to add a ctime (and maybe userid) field to the auth_instance table to record when one adds/edits auth details to see when things changed as this human error can cause big problems for users. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1546769/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1698251] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/8025 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1698251 Title: Improving gulp packages Status in Mahara: In Progress Bug description: Update NPM packages in package.json, it was last updated in https://bugs.launchpad.net/mahara/+bug/1617143 Investigate whether we still need blesscss, the reason that we added blesscss is because IE9 would only read up to certain number of selectors. Since we are officially support IE11+, we could possibly remove blesscss. If removal is sensible we can close https://bugs.launchpad.net/mahara/+bug/1560739 (?) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1698251/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1487274] Re: Elasticsearch choking on non-ASCII characters
I notice that on my local machine Mahara 17.04+ saves João Jiménez Māori in the title fields as 'João Jiménez Māori' and in the description fields as 'Joo Jimnez Māori' But on cluster machines in 16.10 it saves in the title fields as 'Joo Jimnez M<81>ori' in the description fields as 'Joo Jimnez M<81>ori' If I do a SELECT 'João Jiménez Māori' AS test; The both show the special chars correctly But if I do UPDATE view SET description = 'João Jiménez Māori' where id = 10; My local shows it like local above but cluster shows it like cluster above. So the cluster setup for postgres must be different in the way it handles special utf8 characters ** Changed in: mahara Milestone: 17.10.0 => 18.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1487274 Title: Elasticsearch choking on non-ASCII characters Status in Mahara: Confirmed Bug description: In 15.10 I've added code to "quarantine" records that Elasticsearch won't index. That is, if Elasticsearch errors out while processing a batch of records, then I re-try each record individually. And if it errors out while processing one of those individual records, I mark the record as quarantined, and keep it in the search_elasticsearch_queue table. I've backported that to one of our large 15.04 sites, and since then I've taken a look at the data in the records that have caused Elasticsearch to choke. They all contain non-ASCII characters, i.e. Unicode characters. These can be as simple as "e with an accent over it", all the way up to exotic ones like emoji and the Unicode snowman. I was not able to replicate this when testing on my local machine, but it is certainly in place on our production servers, and bugs such as Bug 1408577 make me think it's probably also present on some other servers as well. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1487274/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1422837] Re: XML RPC simpleXML limits payload size
** Changed in: mahara Milestone: 17.10.0 => 18.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1422837 Title: XML RPC simpleXML limits payload size Status in Mahara: Confirmed Bug description: Operating System: Ubuntu 14.04.1 LTS Mahara version: 1.9.3 Database: mysql Browser: chrome 40.0.2214.111 -- Steps to reproduce - you need a system capable of XMLRPC communication with Mahara (e.g. Moodle) 1) With Moodle - set up mahara networking / portfolios. 2) Open a course with a forum 3) Add 2 entries. One with an attachment under 5 MB. One with an attachment over 5 MB. On Each click "Export to portfolio" in the bottom. 4) Go through the screens to start export - ask it to do it now (i.e. not wait for cron). 5) Check the Mahara site to see what made it through successfully. -- simpleXML may not be the best parser for XMLRPC payloads in api/xmlrpc/lib.php function parse_payload($payload) { try { $xml = new SimpleXMLElement($payload); return $xml; } catch (Exception $e) { throw new MaharaException('Encrypted payload is not a valid XML document', 6002); } } This means if you send a large file (in our tests greater than approx 7mb) base 64 encoded over XMLRPC it will fail to parse. It didn't seem to make any difference if we increased the memory limit to 800M in php.ini or even by setting the php memory limit to 800M via PHP ini_set in function parse_payload - this suggests that there is a limit to what SimpleXML can handle regardless of the PHP memory limit. Note - 932 in my source code is the 'throw new exception' following $xml = new SimpleXMLElement($payload); called at [/vagrant/www/maharadev/mahara/lib/errors.php:465] #1 exception(MaharaException Object ([] => 1,[] => Encrypted payload is not a valid XML document,[] => ,[] => 6002,[] => /vagrant/www/maharadev/mahara/api/xmlrpc/lib.php,[] => 932,[] => Array ([0] => Array ([file] => /vagrant/www/maharadev/mahara/api/xmlrpc/lib.php,[line] => 921,[function] => parse_payload,[args] => Array ([0] =>ERROR 4: 4: remote server error: code: , message: A nonrecoverable error occurred. This probably means you have encountered a bug in the system #0 MaharaException->handle_exception() called at [/vagrant/www/maharadev/mahara/lib/errors.php:465] #1 exception(MaharaException Object ([] => 1,[] => Encrypted payload is not a valid XML document,[] => ,[] => 6002,[] => /vagrant/www/maharadev/mahara/api/xmlrpc/lib.php,[] => 932,[] => Array ([0] => Array ([file] => /vagrant/www/maharadev/mahara/api/xmlrpc/lib.php,[line] => 921,[function] => parse_payload,[args] => Array ([0] => To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1422837/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1421020] Re: Untie "Allow public pages" from "Allow public profiles"
** Changed in: mahara Milestone: 17.10.0 => 18.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1421020 Title: Untie "Allow public pages" from "Allow public profiles" Status in Mahara: Confirmed Bug description: This bug report is about two site settings (under "Site options -> General settings") 1. Allow public pages 2. Allow public profiles Currently, the behavior of these is tied together. If "Allow public pages" is turned on, it forces "Allow public profiles" to be on. If "Allow public pages" is turned off, then and only then, the admin can toggle "Allow public profiles" separately. As of Bug 814328, this behavior is reflected with Javascript that grays out "Allow public profiles" when it is being overridden. However, there's no ironclad reason why these two settings have to be tied together like this. There is at least one case on the forums, of a user wanting to allow public pages but *not* public profiles: https://mahara.org/interaction/forum/topic.php?id=6431=27235 Frankly, I think the reason these are tied together in the first place is a bug, not a feature. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1421020/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1422264] Re: IPv6 Compliance
** Changed in: mahara Milestone: 17.10.0 => 18.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1422264 Title: IPv6 Compliance Status in Mahara: Confirmed Bug description: Mahara: 15.04 DB: any Browser: any OS: any Currently, Mahara is not compliant with the IPv6 protocol. Some places that need to change (where IP addresses are validated/checked): - SAML auth - validate URL Syntax (preg_match for IPv6 also). - DB: table - host.ipaddress needs to cater for 128 bit address. - Peer bootstrap: 1) preg-match should also include IPv6 format; 2) use of PHP function gethostbyname(). - Zend third part library - current version only supports IPv4. We currently use version 1.10.6. MNET heavily relise on Zend. The latest Zend is on version 3. But there is a release for 1.12.11 - which still doesn't support IPv6 (as far as I can tell). To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1422264/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1422492] Re: Mahara doesn't ask you for your password before deleting your account or changing your username
A problem here is if the user logged in via SSO they don't have/know a password in Mahara ** Changed in: mahara Milestone: 17.10.0 => 18.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1422492 Title: Mahara doesn't ask you for your password before deleting your account or changing your username Status in Mahara: Confirmed Bug description: These, especially the first, seem like dangerous operations. Expected behavior is that Mahara would prompt for my current password to prevent someone deleting my user account if I left my account logged in. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1422492/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1261234] Re: A cron task to periodically clear the VERP bounce counts
** Changed in: mahara Milestone: 17.10.0 => 18.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1261234 Title: A cron task to periodically clear the VERP bounce counts Status in Mahara: Confirmed Bug description: Mahara has a VERP system to disable email addresses that have been bouncing. "Bounces_min" and "Bounces_ratio", and it disables an email when it has received more than "bounces_min" bounces and the ratio of bounced messages to all messages sent is greater than bounces_ratio. The thing is, these are *lifetime* numbers, and never get reset. This poses some difficulties once a site has been around for a few years, like mahara.org. We have some email addresses that have received thousands of messages. So, if we set bounces_threshold to something like the default "0.2" setting, then if one of those longtime addresses become invalid, we would continue to send hundreds of messages to it before we got around to disabling it. On the other hand, if we set bounces_threshold to 0, then we have the problem that the bounce count is cumulative and never gets reset. So, if we leave it at the default 5 emails, I could get disabled due to one bounce every three months over the course of a year and a half. Really, whether to disable someone's email should be based on how much it has been bouncing *recently*. So what we should do is add a cron task which sets the artefact_internal_profile_email.maillsent and artefact_internal_profile_email.bouncecount columns back to 0 periodically. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1261234/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1546769] Re: The 'None' auth needs to be locked down or removed to avoid troubles with multi institutions
The easiest thing to do is make auth return false if site is in production mode ** Changed in: mahara Status: Confirmed => In Progress ** Also affects: mahara/16.10 Importance: Undecided Status: New ** Also affects: mahara/17.10 Importance: High Assignee: Robert Lyon (robertl-9) Status: In Progress ** Also affects: mahara/16.04 Importance: Undecided Status: New ** Also affects: mahara/17.04 Importance: Undecided Status: New ** Changed in: mahara/17.04 Milestone: None => 17.04.4 ** Changed in: mahara/16.10 Milestone: None => 16.10.6 ** Changed in: mahara/16.04 Milestone: None => 16.04.9 ** Changed in: mahara/17.04 Importance: Undecided => High ** Changed in: mahara/16.10 Importance: Undecided => High ** Changed in: mahara/16.04 Importance: Undecided => High ** Changed in: mahara/17.04 Status: New => In Progress ** Changed in: mahara/16.04 Status: New => In Progress ** Changed in: mahara/16.10 Status: New => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1546769 Title: The 'None' auth needs to be locked down or removed to avoid troubles with multi institutions Status in Mahara: In Progress Status in Mahara 16.04 series: In Progress Status in Mahara 16.10 series: In Progress Status in Mahara 17.04 series: In Progress Status in Mahara 17.10 series: In Progress Bug description: When there are multiple institutions/tenants on a mahara and one of the tenants decides to add the 'None' auth method to their institution it causes havoc for users on all institutions as if they accidentally enter their login details wrong they get logged in to institution with 'None' set as a new user rather than their normal institution/account. Things that need to be changed to avoid this problem: 1) When an institution tries to add the 'None' auth option it needs to check to see if there are any other institutions present and only allow it if institution count = 1 2) Conversely if the only institution uses 'None' auth then you shouldn't be allowed to add a new institution until that auth is removed 3) And when you are able to add "None" you should probably get some prominent message with "Do you really want to do this? You know, it means that anybody will be able to log in without any authorization" Also as part of this change it would be very good to add a ctime (and maybe userid) field to the auth_instance table to record when one adds/edits auth details to see when things changed as this human error can cause big problems for users. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1546769/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1608305] Re: Can't delete a block in Safari
** Changed in: mahara Milestone: 17.10.0 => 18.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1608305 Title: Can't delete a block in Safari Status in Mahara: Incomplete Bug description: OS: X El Capitan Browser: Safari 9 Mahara: 16.10 Not able to delete a block/content created from Page editor when delete button is click Test step: 1. Log on as User 2. From Profile>Page 3. Click Edit on existing Page 4. Click on a content from the side panel>Block is added on the page 5. Edit and Delete button is displayed from the block 6. Click Delete Result: Block is not deleted To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1608305/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1413431] Re: Queue messages and send them out in small batches
** Changed in: mahara Milestone: 17.10.0 => 18.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1413431 Title: Queue messages and send them out in small batches Status in Mahara: Confirmed Bug description: When a Mahara training is taking place on a site and pages / collections are created in / shared with a group and "Shared page notifications" are turned on, a lot of emails can be generated. When they are sent out they can result in a mail server to reject them esp. if all users have the same email domain. It would be better if a queue was established and sent out in smaller batches so that mail servers don't blackmail the sender. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1413431/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1487274] Re: Elasticsearch choking on non-ASCII characters
Will push this problem out to see if elasticsearch, using elasticsearch- php, fixes things -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1487274 Title: Elasticsearch choking on non-ASCII characters Status in Mahara: Confirmed Bug description: In 15.10 I've added code to "quarantine" records that Elasticsearch won't index. That is, if Elasticsearch errors out while processing a batch of records, then I re-try each record individually. And if it errors out while processing one of those individual records, I mark the record as quarantined, and keep it in the search_elasticsearch_queue table. I've backported that to one of our large 15.04 sites, and since then I've taken a look at the data in the records that have caused Elasticsearch to choke. They all contain non-ASCII characters, i.e. Unicode characters. These can be as simple as "e with an accent over it", all the way up to exotic ones like emoji and the Unicode snowman. I was not able to replicate this when testing on my local machine, but it is certainly in place on our production servers, and bugs such as Bug 1408577 make me think it's probably also present on some other servers as well. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1487274/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1560739] Re: Can't build CSS if you have npm gulp-bless version 3.1.0
** Changed in: mahara Status: Confirmed => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1560739 Title: Can't build CSS if you have npm gulp-bless version 3.1.0 Status in Mahara: In Progress Bug description: If you have the npm package "gulp-bless" at version 3.1.0 (which requires the "bless" package at 4.0.0), then Mahara's SASS compilation (make css) will error out. To replicate: 1. Clone a new Mahara repository, or in an existing Mahara repo rename your "node_modules" directory to "node_modules.bak" 2. Run "npm install" in this repo 3. Run "make css" Expected result: Successfully builds the CSS, with this output. (master)aaronw@vegas:~/www/mahara$ make css npm install npm WARN package.json mahara-themes@1.0.0 No repository field. npm WARN package.json gulp-minify-css@1.2.4 No repository field. Building CSS... [13:21:16] Using gulpfile ~/www/mahara/gulpfile.js [13:21:16] Starting 'css'... Compiling CSS for htdocs/theme/custom Compiling CSS for htdocs/theme/default Compiling CSS for htdocs/theme/modern Compiling CSS for htdocs/theme/ocean Compiling CSS for htdocs/theme/primaryschool Compiling CSS for htdocs/theme/raw Compiling CSS for htdocs/theme/subthemestarter [13:21:21] Finished 'css' after 5.72 s Done! Actual result: Errors out with this output. (master)aaronw@vegas:~/www/mahara-test$ make css npm install npm WARN package.json mahara-themes@1.0.0 No repository field. npm WARN package.json gulp-minify-css@1.2.4 No repository field. Building CSS... [13:22:42] Using gulpfile ~/www/mahara-test/gulpfile.js [13:22:42] Starting 'css'... Compiling CSS for htdocs/theme/custom Compiling CSS for htdocs/theme/default Compiling CSS for htdocs/theme/modern Compiling CSS for htdocs/theme/ocean Compiling CSS for htdocs/theme/primaryschool Compiling CSS for htdocs/theme/raw Compiling CSS for htdocs/theme/subthemestarter events.js:72 throw er; // Unhandled 'error' event ^ TypeError: Cannot call method 'reduce' of undefined at countRules (/home/aaronw/www/mahara-test/node_modules/gulp-bless/node_modules/bless/lib/count.js:26:18) at count (/home/aaronw/www/mahara-test/node_modules/gulp-bless/node_modules/bless/lib/count.js:44:14) at chunks$ (/home/aaronw/www/mahara-test/node_modules/gulp-bless/node_modules/bless/lib/chunk.js:52:46) at tryCatch (/home/aaronw/www/mahara-test/node_modules/gulp-bless/node_modules/bless/node_modules/babel-runtime/regenerator/runtime.js:72:40) at GeneratorFunctionPrototype.invoke [as _invoke] (/home/aaronw/www/mahara-test/node_modules/gulp-bless/node_modules/bless/node_modules/babel-runtime/regenerator/runtime.js:334:22) at GeneratorFunctionPrototype.prototype.(anonymous function) [as next] (/home/aaronw/www/mahara-test/node_modules/gulp-bless/node_modules/bless/node_modules/babel-runtime/regenerator/runtime.js:105:21) at chunk (/home/aaronw/www/mahara-test/node_modules/gulp-bless/node_modules/bless/lib/chunk.js:98:113) at Object.chunk (/home/aaronw/www/mahara-test/node_modules/gulp-bless/node_modules/bless/lib/index.js:34:33) at Transform._transform (/home/aaronw/www/mahara-test/node_modules/gulp-bless/index.js:33:36) at Transform._read (/home/aaronw/www/mahara-test/node_modules/gulp-bless/node_modules/through2/node_modules/readable-stream/lib/_stream_transform.js:184:10) npm WARN package.json mahara-themes@1.0.0 No repository field. npm WARN package.json gulp-minify-css@1.2.4 No repository field. [13:22:46] Using gulpfile ~/www/mahara-test/gulpfile.js [13:22:46] Starting 'css'... Compiling CSS for htdocs/theme/custom Compiling CSS for htdocs/theme/default Compiling CSS for htdocs/theme/modern Compiling CSS for htdocs/theme/ocean Compiling CSS for htdocs/theme/primaryschool Compiling CSS for htdocs/theme/raw Compiling CSS for htdocs/theme/subthemestarter events.js:72 throw er; // Unhandled 'error' event ^ TypeError: Cannot call method 'reduce' of undefined at countRules (/home/aaronw/www/mahara-test/node_modules/gulp-bless/node_modules/bless/lib/count.js:26:18) at count (/home/aaronw/www/mahara-test/node_modules/gulp-bless/node_modules/bless/lib/count.js:44:14) at chunks$ (/home/aaronw/www/mahara-test/node_modules/gulp-bless/node_modules/bless/lib/chunk.js:52:46) at tryCatch (/home/aaronw/www/mahara-test/node_modules/gulp-bless/node_modules/bless/node_modules/babel-runtime/regenerator/runtime.js:72:40) at GeneratorFunctionPrototype.invoke [as _invoke]
[Mahara-contributors] [Bug 1677068] Re: Move from X-Frame-Options to Content-Security-Policy
** Changed in: mahara Milestone: 17.10.0 => 18.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1677068 Title: Move from X-Frame-Options to Content-Security-Policy Status in Mahara: Confirmed Bug description: Currently one cannot embed Mahara within an iframe on third party site This is due to: X-Frame-Options = SAMEORIGIN (see: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/X-Frame-Options) And we can't allow specific external sites to embed mahara in an iframe (well at least not for all major browsers) But good news there is: Content-Security-Policy (see: https://developer.mozilla.org/en-US/docs/Web/HTTP/CSP) Where we can specify which domains are allowed to show which things But bad news - to get it to work we'd need to do bad things in relation to inline javascript (see: https://www.html5rocks.com/en/tutorials/security/content-security-policy/) Also we'd need to detect that we are in an external iframe before the page loads so we can set the headers to allow the correct external site (via init.php) Currently we set the headers after $session starts and before we enable the $USER object So we'd need to add something to detect that we are in an iframe on an external site and that site is allowed to do this. NOTE: some of our pages load in iframes themselves (via pieform submission) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1677068/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1692389] Re: can't install in MariaDB 5.5.52
** Changed in: mahara Milestone: 17.10.0 => 18.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1692389 Title: can't install in MariaDB 5.5.52 Status in Mahara: New Bug description: I got error when installing Mahara interaction.forum Not installed 1.2.2 Failed to upgrade. https:///admin/upgrade.php [Mon May 22 09:49:01.760479 2017] [:error] [pid 43866] [client 137.189.62.47:31261] [DBG] f0 (lib/dml.php:157) mysqli error: [1709: Index column size too large. The maximum column size is 767 bytes.] in EXECUTE("CREATE INDEX inteforupost_pat_ix ON interaction_forum_post (path)")Command was: CREATE INDEX inteforupost_pat_ix ON interaction_forum_post (path), referer: i checked the settings is already on innodb_file_format = BARRACUDA; innodb_large_prefix = ON; To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1692389/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1698251] Re: Improving gulp packages
** Changed in: mahara Status: Confirmed => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1698251 Title: Improving gulp packages Status in Mahara: In Progress Bug description: Update NPM packages in package.json, it was last updated in https://bugs.launchpad.net/mahara/+bug/1617143 Investigate whether we still need blesscss, the reason that we added blesscss is because IE9 would only read up to certain number of selectors. Since we are officially support IE11+, we could possibly remove blesscss. If removal is sensible we can close https://bugs.launchpad.net/mahara/+bug/1560739 (?) To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1698251/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1682369] Re: Retracted text blocks in print preview overlap
** Changed in: mahara/17.10 Milestone: 17.10.0 => 18.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1682369 Title: Retracted text blocks in print preview overlap Status in Mahara: Incomplete Status in Mahara 17.04 series: Expired Status in Mahara 17.10 series: Incomplete Bug description: When printing a page with automatically retracted blocks the blocks overlap. They don't if the blocks are already opened when pressing the print button. I am using Chrome on a PC and working on https://master.dev.mahara.org/user/samtaylor/test-page-for-sam To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1682369/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1689685] Re: SAML SSO authentication doesn't work as SimpleSAMLphp generates non-existent AssertionConsumerServiceURL
** Changed in: mahara Milestone: 17.10.0 => 18.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1689685 Title: SAML SSO authentication doesn't work as SimpleSAMLphp generates non- existent AssertionConsumerServiceURL Status in Mahara: New Bug description: Wrong AssertionConsumerServiceURL is genereated in SAML2-AuthRequest. Mahara 16.10.3 and CentOS Linux release 7.2 Since 16.10.x release, the SimpleSAMLphp library is included as a managed dependency with the Mahara codebase. We noticed that before sending an AuthRequest to an IDP, it generates wrong AssertionConsumerServiceURL behaving like it is hosted separately with Mahara which ends up in SSO failure. In our case, it generates https://localhost/simplesaml/module.php/saml/sp/saml2-acs.php/default-sp instead of https://localhost/auth/saml/sp/saml2-acs.php/default-sp. We tracked down that it is generated using 'baseurlpath' => 'simplesaml/' defined in htdocs/auth/saml/config/config.php and $ar->setAssertionConsumerServiceURL(SimpleSAML_Module::getModuleURL('saml/sp/saml2-acs.php/' . $this->authId)); defined in htdocs/auth/saml/extlib/simplesamlphp/modules/saml/lib/Auth/Source/SP.php line 189. As a workaround, we have hacked the SimpleSAMLphp library for generating correct AssertionConsumerServiceURL which solves this issue. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1689685/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 903534] Re: Users can still login even if their only institution has expired
This problem has been fixed to some extent via https://bugs.launchpad.net/mahara/+bug/1580399 https://reviews.mahara.org/#/c/6671/ On can still log in if they belong to 1 institution but their auth method is associated to another institution - but as that is administrator's choice we will leave the administrator to set the user to use correct auth via admin screen rather than trying to guess what auth method they should/could be on on login ** Changed in: mahara Milestone: 17.10.0 => None ** Changed in: mahara Status: Confirmed => Won't Fix -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/903534 Title: Users can still login even if their only institution has expired Status in Mahara: Won't Fix Bug description: Institutions can have an expiry date. However, users who are only members of that institution can still login after the institution has expired. This is not easy to fix. There are lots of things to consider: - what happens when you are a member of more than one institution? - what happens when your auth instance is tied to an expired institution? - if you can still login, what happens to the content that's tied to an expired institution you are a member of? To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/903534/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1717822] [NEW] Spelling mistake in code for denying user login to expired institution
Public bug reported: To test: 1) Set up a new institution and set the expiry of institution in the past 2) Add 1 user to the institution - making sure the user is using the auth method 'internal' for that institution 3) Logout and login as that user You should see error: [WAR] a0 (auth/lib.php:1716) Undefined variable: authinstane ** Affects: mahara Importance: High Assignee: Robert Lyon (robertl-9) Status: In Progress ** Affects: mahara/15.04 Importance: High Status: New ** Affects: mahara/16.04 Importance: High Status: New ** Affects: mahara/16.10 Importance: High Status: New ** Affects: mahara/17.04 Importance: High Status: New ** Affects: mahara/17.10 Importance: High Assignee: Robert Lyon (robertl-9) Status: In Progress ** Affects: mahara/18.04 Importance: High Status: New ** Also affects: mahara/17.10 Importance: High Status: In Progress ** Also affects: mahara/16.04 Importance: Undecided Status: New ** Also affects: mahara/17.04 Importance: Undecided Status: New ** Also affects: mahara/18.04 Importance: Undecided Status: New ** Also affects: mahara/16.10 Importance: Undecided Status: New ** Also affects: mahara/15.04 Importance: Undecided Status: New ** Changed in: mahara/17.04 Importance: Undecided => High ** Changed in: mahara/16.10 Importance: Undecided => High ** Changed in: mahara/16.04 Importance: Undecided => High ** Changed in: mahara/15.04 Importance: Undecided => High ** Changed in: mahara/18.04 Importance: Undecided => High ** Changed in: mahara/17.10 Milestone: 18.04.0 => 17.10.0 ** Changed in: mahara/18.04 Milestone: None => 18.04.0 ** Changed in: mahara/17.04 Milestone: None => 17.04.4 ** Changed in: mahara/16.10 Milestone: None => 16.10.6 ** Changed in: mahara/16.04 Milestone: None => 16.04.9 ** Changed in: mahara/15.04 Milestone: None => 15.04.15 ** Changed in: mahara/17.10 Assignee: (unassigned) => Robert Lyon (robertl-9) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1717822 Title: Spelling mistake in code for denying user login to expired institution Status in Mahara: In Progress Status in Mahara 15.04 series: New Status in Mahara 16.04 series: New Status in Mahara 16.10 series: New Status in Mahara 17.04 series: New Status in Mahara 17.10 series: In Progress Status in Mahara 18.04 series: New Bug description: To test: 1) Set up a new institution and set the expiry of institution in the past 2) Add 1 user to the institution - making sure the user is using the auth method 'internal' for that institution 3) Logout and login as that user You should see error: [WAR] a0 (auth/lib.php:1716) Undefined variable: authinstane To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1717822/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1717822] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/8021 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1717822 Title: Spelling mistake in code for denying user login to expired institution Status in Mahara: In Progress Status in Mahara 15.04 series: New Status in Mahara 16.04 series: New Status in Mahara 16.10 series: New Status in Mahara 17.04 series: New Status in Mahara 17.10 series: In Progress Status in Mahara 18.04 series: New Bug description: To test: 1) Set up a new institution and set the expiry of institution in the past 2) Add 1 user to the institution - making sure the user is using the auth method 'internal' for that institution 3) Logout and login as that user You should see error: [WAR] a0 (auth/lib.php:1716) Undefined variable: authinstane To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1717822/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1706263] Re: Mahara17.04.2 fails to install when deployed against MariaDB v10.2.4 or higher
** Changed in: mahara/17.04 Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1706263 Title: Mahara17.04.2 fails to install when deployed against MariaDB v10.2.4 or higher Status in Mahara: Fix Committed Status in Mahara 17.04 series: Fix Committed Status in Mahara 17.10 series: Fix Committed Bug description: During the installation process the installation is halted due to an error. As a result further deploy+ent of the Mahara server is not possible. Used configuration Ubuntu 16.4LTS, Moodle 3.3.1, Mahara 17.04.2, MariaDB 10.2.6 Consulting the apache error log files gives back following information [Mon Jul 24 10:06:57.616387 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [INF] 2a (admin/upgrade.php:49) Starting Mahara installation..., referer: http://mahara.syntra-cloud.be/admin/index.php [Mon Jul 24 10:07:11.571057 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) mysqli error: [1064: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'rows BIGINT(10) NOT NULL DEFAULT 1,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.571082 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) iscustom TINYINT(1) NOT NULL DEFAULT 0,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.571094 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) ' at line 3] in EXECUTE("CREATE TABLE view_layout (, referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.571096 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) id BIGINT(10) NOT NULL auto_increment,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.571097 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) rows BIGINT(10) NOT NULL DEFAULT 1,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.571099 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) iscustom TINYINT(1) NOT NULL DEFAULT 0,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.571101 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) layoutmenuorder BIGINT(10) NOT NULL DEFAULT 0,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.571102 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) CONSTRAINT PRIMARY KEY (id), referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.571104 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) )ENGINE=innodb")Command was: CREATE TABLE view_layout (, referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.571106 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) id BIGINT(10) NOT NULL auto_increment,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.571108 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) rows BIGINT(10) NOT NULL DEFAULT 1,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.571109 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) iscustom TINYINT(1) NOT NULL DEFAULT 0,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.57 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) layoutmenuorder BIGINT(10) NOT NULL DEFAULT 0,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.571112 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) CONSTRAINT PRIMARY KEY (id), referer: http://mahara.syntra-cloud.be/admin/upgrade.php Looking into file htdocs/lib/db/install.xml (line726) – table view_layout A Quick analysis of the problem indicated the following The column rows in the table view_layout is causing a problem (as of MariaDB 10.2.4 rows is now a reserved keyword (https://mariadb.com/kb/en/mariadb/reserved-words/) To hotfix the issue I´ve updated the column rows to numrows in the following files after which the installation continues as expected and Mahara functioned properly. htdocs/lib/db/install.xml
[Mahara-contributors] [Bug 1706263] A change has been merged
Reviewed: https://reviews.mahara.org/8019 Committed: https://git.mahara.org/mahara/mahara/commit/1ed58578e6cc1f402f6ac1ed93776ff50359dbb7 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:17.04_STABLE commit 1ed58578e6cc1f402f6ac1ed93776ff50359dbb7 Author: Raoul DorissenDate: Wed Aug 2 09:49:23 2017 +1200 Bug 1706263: Updating db keywords to be escaped Added new keywords to be quoted when creating db queries Change-Id: I699bbbf949ab6014da515bfa9d45bd4f2310f309 behatnotneeded (cherry picked from commit ff8106115709d6f1dedcef40aff594852c675fe2) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1706263 Title: Mahara17.04.2 fails to install when deployed against MariaDB v10.2.4 or higher Status in Mahara: Fix Committed Status in Mahara 17.04 series: Fix Committed Status in Mahara 17.10 series: Fix Committed Bug description: During the installation process the installation is halted due to an error. As a result further deploy+ent of the Mahara server is not possible. Used configuration Ubuntu 16.4LTS, Moodle 3.3.1, Mahara 17.04.2, MariaDB 10.2.6 Consulting the apache error log files gives back following information [Mon Jul 24 10:06:57.616387 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [INF] 2a (admin/upgrade.php:49) Starting Mahara installation..., referer: http://mahara.syntra-cloud.be/admin/index.php [Mon Jul 24 10:07:11.571057 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) mysqli error: [1064: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'rows BIGINT(10) NOT NULL DEFAULT 1,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.571082 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) iscustom TINYINT(1) NOT NULL DEFAULT 0,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.571094 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) ' at line 3] in EXECUTE("CREATE TABLE view_layout (, referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.571096 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) id BIGINT(10) NOT NULL auto_increment,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.571097 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) rows BIGINT(10) NOT NULL DEFAULT 1,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.571099 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) iscustom TINYINT(1) NOT NULL DEFAULT 0,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.571101 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) layoutmenuorder BIGINT(10) NOT NULL DEFAULT 0,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.571102 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) CONSTRAINT PRIMARY KEY (id), referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.571104 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) )ENGINE=innodb")Command was: CREATE TABLE view_layout (, referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.571106 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) id BIGINT(10) NOT NULL auto_increment,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.571108 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) rows BIGINT(10) NOT NULL DEFAULT 1,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.571109 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) iscustom TINYINT(1) NOT NULL DEFAULT 0,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.57 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) layoutmenuorder BIGINT(10) NOT NULL DEFAULT 0,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.571112 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) CONSTRAINT PRIMARY KEY (id), referer: http://mahara.syntra-cloud.be/admin/upgrade.php Looking into file htdocs/lib/db/install.xml (line726) – table view_layout A Quick analysis of the problem indicated the following The column rows in the table
[Mahara-contributors] [Bug 1711497] Re: Is htdocs/view/urls.php still needed?
** Changed in: mahara Milestone: 17.10.0 => None -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1711497 Title: Is htdocs/view/urls.php still needed? Status in Mahara: Opinion Bug description: When we added the patch https://reviews.mahara.org/#/c/7453/11 we added a new file called htdocs/view/accessurl.php which seems very similar to htdocs/view/urls.php And from my initial looking it doesn't seem to be used anymore Do we still need it? To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1711497/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1681591] A patch has been submitted for review
Patch for "master" branch: https://reviews.mahara.org/8020 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1681591 Title: Reorganise where we have the profile links/information Status in Mahara: New Bug description: I am thinking of reorganising the placement of profile things. Ideas: - Move the navigation 'Profile' and 'Profile image' options from 'Main menu' (content section) to 'User menu' - Merge 'Profile' and 'Profile image' options into one 'Profile settings' page/link - Remove the profile page/dashboard page from list of 'Pages and collections' list To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1681591/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1681591] Re: Reorganise where we have the profile links/information
Added a patch https://reviews.mahara.org/#/c/8020/ to deal with first point - moving the menu items to user menu structure -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1681591 Title: Reorganise where we have the profile links/information Status in Mahara: New Bug description: I am thinking of reorganising the placement of profile things. Ideas: - Move the navigation 'Profile' and 'Profile image' options from 'Main menu' (content section) to 'User menu' - Merge 'Profile' and 'Profile image' options into one 'Profile settings' page/link - Remove the profile page/dashboard page from list of 'Pages and collections' list To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1681591/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1681591] Re: Reorganise where we have the profile links/information
** Changed in: mahara Milestone: 17.10.0 => 18.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1681591 Title: Reorganise where we have the profile links/information Status in Mahara: New Bug description: I am thinking of reorganising the placement of profile things. Ideas: - Move the navigation 'Profile' and 'Profile image' options from 'Main menu' (content section) to 'User menu' - Merge 'Profile' and 'Profile image' options into one 'Profile settings' page/link - Remove the profile page/dashboard page from list of 'Pages and collections' list To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1681591/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1717819] Re: Alter the minimum version to upgrade from
** Summary changed: - alter the minimum version to upgrade from + Alter the minimum version to upgrade from ** Description changed: We are meant to move up the minimum upgrade from version each time we do a release. But as the older versions are not compatible with PHP7 we should make our min upgrade from to be v15.04 - With a not saying if you need to upgrade from older version you will + With a note saying if you need to upgrade from older version you will need to do: version 'X' -> 15.04 upgrade then do any upgrading of php / sql server then version 15.04 -> 'Y' upgrade -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1717819 Title: Alter the minimum version to upgrade from Status in Mahara: In Progress Bug description: We are meant to move up the minimum upgrade from version each time we do a release. But as the older versions are not compatible with PHP7 we should make our min upgrade from to be v15.04 With a note saying if you need to upgrade from older version you will need to do: version 'X' -> 15.04 upgrade then do any upgrading of php / sql server then version 15.04 -> 'Y' upgrade To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1717819/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1717819] [NEW] alter the minimum version to upgrade from
Public bug reported: We are meant to move up the minimum upgrade from version each time we do a release. But as the older versions are not compatible with PHP7 we should make our min upgrade from to be v15.04 With a not saying if you need to upgrade from older version you will need to do: version 'X' -> 15.04 upgrade then do any upgrading of php / sql server then version 15.04 -> 'Y' upgrade ** Affects: mahara Importance: High Status: In Progress ** Changed in: mahara Milestone: None => 17.10.0 ** Changed in: mahara Status: New => In Progress ** Changed in: mahara Importance: Undecided => High -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1717819 Title: alter the minimum version to upgrade from Status in Mahara: In Progress Bug description: We are meant to move up the minimum upgrade from version each time we do a release. But as the older versions are not compatible with PHP7 we should make our min upgrade from to be v15.04 With a not saying if you need to upgrade from older version you will need to do: version 'X' -> 15.04 upgrade then do any upgrading of php / sql server then version 15.04 -> 'Y' upgrade To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1717819/+subscriptions ___ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
[Mahara-contributors] [Bug 1706263] Re: Mahara17.04.2 fails to install when deployed against MariaDB v10.2.4 or higher
** Changed in: mahara/17.10 Status: In Progress => Fix Committed ** Changed in: mahara/17.04 Status: Confirmed => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1706263 Title: Mahara17.04.2 fails to install when deployed against MariaDB v10.2.4 or higher Status in Mahara: Fix Committed Status in Mahara 17.04 series: In Progress Status in Mahara 17.10 series: Fix Committed Bug description: During the installation process the installation is halted due to an error. As a result further deploy+ent of the Mahara server is not possible. Used configuration Ubuntu 16.4LTS, Moodle 3.3.1, Mahara 17.04.2, MariaDB 10.2.6 Consulting the apache error log files gives back following information [Mon Jul 24 10:06:57.616387 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [INF] 2a (admin/upgrade.php:49) Starting Mahara installation..., referer: http://mahara.syntra-cloud.be/admin/index.php [Mon Jul 24 10:07:11.571057 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) mysqli error: [1064: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'rows BIGINT(10) NOT NULL DEFAULT 1,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.571082 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) iscustom TINYINT(1) NOT NULL DEFAULT 0,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.571094 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) ' at line 3] in EXECUTE("CREATE TABLE view_layout (, referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.571096 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) id BIGINT(10) NOT NULL auto_increment,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.571097 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) rows BIGINT(10) NOT NULL DEFAULT 1,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.571099 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) iscustom TINYINT(1) NOT NULL DEFAULT 0,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.571101 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) layoutmenuorder BIGINT(10) NOT NULL DEFAULT 0,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.571102 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) CONSTRAINT PRIMARY KEY (id), referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.571104 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) )ENGINE=innodb")Command was: CREATE TABLE view_layout (, referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.571106 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) id BIGINT(10) NOT NULL auto_increment,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.571108 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) rows BIGINT(10) NOT NULL DEFAULT 1,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.571109 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) iscustom TINYINT(1) NOT NULL DEFAULT 0,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.57 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) layoutmenuorder BIGINT(10) NOT NULL DEFAULT 0,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.571112 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) CONSTRAINT PRIMARY KEY (id), referer: http://mahara.syntra-cloud.be/admin/upgrade.php Looking into file htdocs/lib/db/install.xml (line726) – table view_layout A Quick analysis of the problem indicated the following The column rows in the table view_layout is causing a problem (as of MariaDB 10.2.4 rows is now a reserved keyword (https://mariadb.com/kb/en/mariadb/reserved-words/) To hotfix the issue I´ve updated the column rows to numrows in the following files after which the installation continues as
[Mahara-contributors] [Bug 1706263] A patch has been submitted for review
Patch for "17.04_STABLE" branch: https://reviews.mahara.org/8019 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1706263 Title: Mahara17.04.2 fails to install when deployed against MariaDB v10.2.4 or higher Status in Mahara: Fix Committed Status in Mahara 17.04 series: In Progress Status in Mahara 17.10 series: Fix Committed Bug description: During the installation process the installation is halted due to an error. As a result further deploy+ent of the Mahara server is not possible. Used configuration Ubuntu 16.4LTS, Moodle 3.3.1, Mahara 17.04.2, MariaDB 10.2.6 Consulting the apache error log files gives back following information [Mon Jul 24 10:06:57.616387 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [INF] 2a (admin/upgrade.php:49) Starting Mahara installation..., referer: http://mahara.syntra-cloud.be/admin/index.php [Mon Jul 24 10:07:11.571057 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) mysqli error: [1064: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'rows BIGINT(10) NOT NULL DEFAULT 1,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.571082 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) iscustom TINYINT(1) NOT NULL DEFAULT 0,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.571094 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) ' at line 3] in EXECUTE("CREATE TABLE view_layout (, referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.571096 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) id BIGINT(10) NOT NULL auto_increment,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.571097 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) rows BIGINT(10) NOT NULL DEFAULT 1,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.571099 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) iscustom TINYINT(1) NOT NULL DEFAULT 0,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.571101 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) layoutmenuorder BIGINT(10) NOT NULL DEFAULT 0,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.571102 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) CONSTRAINT PRIMARY KEY (id), referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.571104 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) )ENGINE=innodb")Command was: CREATE TABLE view_layout (, referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.571106 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) id BIGINT(10) NOT NULL auto_increment,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.571108 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) rows BIGINT(10) NOT NULL DEFAULT 1,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.571109 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) iscustom TINYINT(1) NOT NULL DEFAULT 0,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.57 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) layoutmenuorder BIGINT(10) NOT NULL DEFAULT 0,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.571112 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) CONSTRAINT PRIMARY KEY (id), referer: http://mahara.syntra-cloud.be/admin/upgrade.php Looking into file htdocs/lib/db/install.xml (line726) – table view_layout A Quick analysis of the problem indicated the following The column rows in the table view_layout is causing a problem (as of MariaDB 10.2.4 rows is now a reserved keyword (https://mariadb.com/kb/en/mariadb/reserved-words/) To hotfix the issue I´ve updated the column rows to numrows in the following files after which the installation continues as expected and Mahara functioned properly. htdocs/lib/db/install.xml (line726)
[Mahara-contributors] [Bug 1706263] A change has been merged
Reviewed: https://reviews.mahara.org/7912 Committed: https://git.mahara.org/mahara/mahara/commit/ff8106115709d6f1dedcef40aff594852c675fe2 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch:master commit ff8106115709d6f1dedcef40aff594852c675fe2 Author: Raoul DorissenDate: Wed Aug 2 09:49:23 2017 +1200 Bug 1706263: Updating db keywords to be escaped Added new keywords to be quoted when creating db queries Change-Id: I699bbbf949ab6014da515bfa9d45bd4f2310f309 behatnotneeded -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1706263 Title: Mahara17.04.2 fails to install when deployed against MariaDB v10.2.4 or higher Status in Mahara: Fix Committed Status in Mahara 17.04 series: In Progress Status in Mahara 17.10 series: Fix Committed Bug description: During the installation process the installation is halted due to an error. As a result further deploy+ent of the Mahara server is not possible. Used configuration Ubuntu 16.4LTS, Moodle 3.3.1, Mahara 17.04.2, MariaDB 10.2.6 Consulting the apache error log files gives back following information [Mon Jul 24 10:06:57.616387 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [INF] 2a (admin/upgrade.php:49) Starting Mahara installation..., referer: http://mahara.syntra-cloud.be/admin/index.php [Mon Jul 24 10:07:11.571057 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) mysqli error: [1064: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'rows BIGINT(10) NOT NULL DEFAULT 1,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.571082 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) iscustom TINYINT(1) NOT NULL DEFAULT 0,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.571094 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) ' at line 3] in EXECUTE("CREATE TABLE view_layout (, referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.571096 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) id BIGINT(10) NOT NULL auto_increment,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.571097 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) rows BIGINT(10) NOT NULL DEFAULT 1,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.571099 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) iscustom TINYINT(1) NOT NULL DEFAULT 0,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.571101 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) layoutmenuorder BIGINT(10) NOT NULL DEFAULT 0,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.571102 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) CONSTRAINT PRIMARY KEY (id), referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.571104 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) )ENGINE=innodb")Command was: CREATE TABLE view_layout (, referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.571106 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) id BIGINT(10) NOT NULL auto_increment,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.571108 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) rows BIGINT(10) NOT NULL DEFAULT 1,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.571109 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) iscustom TINYINT(1) NOT NULL DEFAULT 0,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.57 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) layoutmenuorder BIGINT(10) NOT NULL DEFAULT 0,, referer: http://mahara.syntra-cloud.be/admin/upgrade.php [Mon Jul 24 10:07:11.571112 2017] [:error] [pid 38507] [client 81.165.22.67:55069] [DBG] 98 (lib/dml.php:157) CONSTRAINT PRIMARY KEY (id), referer: http://mahara.syntra-cloud.be/admin/upgrade.php Looking into file htdocs/lib/db/install.xml (line726) – table view_layout A Quick analysis of the problem indicated the following The column rows in the table view_layout is causing a problem (as of MariaDB 10.2.4 rows is now a