[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: [WIP]Support Browser protocol at OAP
codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc) will **decrease** coverage by `53.16%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #4228 +/- ## - Coverage 53.16% 0.00% -53.17% Files 816 161 -655 Lines 204503986-16464 Branches 1969 470 -1499 - Hits 10872 0-10872 + Misses 86973986 -4711 + Partials881 0 -881 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | ... and [776 more](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: [WIP]Support Browser protocol at OAP
codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc) will **decrease** coverage by `53.16%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #4228 +/- ## - Coverage 53.16% 0.00% -53.17% Files 816 165 -651 Lines 204504040-16410 Branches 1969 474 -1495 - Hits 10872 0-10872 + Misses 86974040 -4657 + Partials881 0 -881 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [778 more](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: [WIP]Support Browser protocol at OAP
codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc) will **decrease** coverage by `53.16%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #4228 +/- ## - Coverage 53.16% 0.00% -53.17% Files 816 163 -653 Lines 204504028-16422 Branches 1969 474 -1495 - Hits 10872 0-10872 + Misses 86974028 -4669 + Partials881 0 -881 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | ... and [778 more](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: [WIP]Support Browser protocol at OAP
codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc) will **decrease** coverage by `53.16%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #4228 +/- ## - Coverage 53.16% 0.00% -53.17% Files 816 151 -665 Lines 204503751-16699 Branches 1969 441 -1528 - Hits 10872 0-10872 + Misses 86973751 -4946 + Partials881 0 -881 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | ... and [784 more](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov-io edited a comment on pull request #4228: [WIP]Support Browser protocol at OAP
codecov-io edited a comment on pull request #4228: URL: https://github.com/apache/skywalking/pull/4228#issuecomment-575036602 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=h1) Report > Merging [#4228](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc) will **decrease** coverage by `0.69%`. > The diff coverage is `20.11%`. [](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#4228 +/- ## - Coverage 53.16% 52.46% -0.70% - Complexity 3159 3176 +17 Files 816 1516 +700 Lines 2045032350 +11900 Branches 1969 3511+1542 + Hits 1087216973+6101 - Misses 869714579+5882 + Partials881 798 -83 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4228?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../skywalking/oap/server/core/analysis/NodeType.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvTm9kZVR5cGUuamF2YQ==) | `50.00% <0.00%> (-4.55%)` | `6.00 <0.00> (-1.00)` | | | [...server/core/analysis/metrics/ErrorRateMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9FcnJvclJhdGVNZXRyaWNzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...oap/server/core/browser/source/BrowserAppPerf.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFBlcmYuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...re/browser/source/BrowserAppSingleVersionPerf.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFNpbmdsZVZlcnNpb25QZXJmLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...ing/oap/server/core/source/DefaultScopeDefine.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0RlZmF1bHRTY29wZURlZmluZS5qYXZh) | `68.96% <ø> (ø)` | `21.00 <0.00> (ø)` | | | [...ider/parser/errorlog/BrowserErrorLogDecorator.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9Ccm93c2VyRXJyb3JMb2dEZWNvcmF0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...ser/provider/parser/errorlog/ErrorLogAnalyzer.java](https://codecov.io/gh/apache/skywalking/pull/4228/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctYnJvd3Nlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9icm93c2VyL3Byb3ZpZGVyL3BhcnNlci9lcnJvcmxvZy9FcnJvckxvZ0FuYWx5emVyLmphdmE=) | `0.00% <0.00%> (ø)` |
[GitHub] [skywalking] arugal commented on a change in pull request #5269: Support !=, like filter expressions in OAL
arugal commented on a change in pull request #5269:
URL: https://github.com/apache/skywalking/pull/5269#discussion_r467540358
##
File path:
oap-server/oal-rt/src/main/java/org/apache/skywalking/oal/rt/OALRuntime.java
##
@@ -150,6 +151,12 @@ public void start(ClassLoader currentClassLoader) throws
ModuleStartException, O
throw new ModuleStartException("load metrics functions error.", e);
}
+try {
+FilterMatchers.INSTANCE.init();
Review comment:
The `start` method is called more than once
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [skywalking] tristaZero commented on pull request #5153: Support Apache ShardingSphere-Elasticjob
tristaZero commented on pull request #5153: URL: https://github.com/apache/skywalking/pull/5153#issuecomment-671007480 > @tristaZero Friendly Ping, PR is ready. Hi @zhaoyuguang Thanks for your reminder. Apache ShardingSphere ElasticJob-3.0.0-alpha has been released successfully [1]. @wu-sheng It is the time to considering merging this PR, thanks. [1] https://mvnrepository.com/artifact/org.apache.shardingsphere.elasticjob/elasticjob-lite This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] wu-sheng edited a comment on issue #5266: Clean Up and Improve protobufs in skywalking-data-collect-protocol
wu-sheng edited a comment on issue #5266: URL: https://github.com/apache/skywalking/issues/5266#issuecomment-671006364 Adding a package declerance should not affact java. Could you give me an example of the trace proto? I could change and do a test locally, to see whethet there is a chance of not using new API. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #5266: Clean Up and Improve protobufs in skywalking-data-collect-protocol
wu-sheng commented on issue #5266: URL: https://github.com/apache/skywalking/issues/5266#issuecomment-671006364 I will do a test whether there is a chance to change the naming style. Also, a package declerance should not affact java. Could you give me an example of the trace proto? I could change and do a test locally, to see whethet there is a chance of not using new API. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] dio commented on issue #5266: Clean Up and Improve protobufs in skywalking-data-collect-protocol
dio commented on issue #5266: URL: https://github.com/apache/skywalking/issues/5266#issuecomment-671006141 It doesn't block technically, but if someone finds out, for example, we don't have package name defined in each of our *.proto. Probably they will raise their eyebrows. The package declaration in the .proto file is the namespace used by the protobuf language. The recommended name pattern will be something like `package company_name.project_name`. As an example, the well-known types are defined in the `google.protobuf` namespace. The lack of a package declaration means that all declarations in your *.proto file are in the top-level global namespace, which seems very highly prone to namespace conflicts. The "new set of APIs" plan above eases the pain if we want to make the linter happy, while we still have the "current" version generates compatible code. However, in the end, It's up to you for sure, whether we want to follow a certain style-guide "approved" by the industry or not. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #5254: Support spring-kafka
wu-sheng commented on pull request #5254: URL: https://github.com/apache/skywalking/pull/5254#issuecomment-671003532 Your test case fails. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[skywalking-kubernetes] tag v3.1.0 created (now d383403)
This is an automated email from the ASF dual-hosted git repository. innerpeacez pushed a change to tag v3.1.0 in repository https://gitbox.apache.org/repos/asf/skywalking-kubernetes.git. at d383403 (commit) No new revisions were added by this update.
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
codecov[bot] edited a comment on pull request #5276: URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) Report > Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc) will **decrease** coverage by `0.21%`. > The diff coverage is `19.64%`. [](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5276 +/- ## - Coverage 53.16% 52.94% -0.22% + Complexity 3159 3153 -6 Files 816 821 +5 Lines 2045020537 +87 Branches 1969 1979 +10 + Hits 1087210874 +2 - Misses 8697 8777 +80 - Partials881 886 +5 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.45% <10.20%> (-4.29%)` | `11.00 <1.00> (+1.00)` | :arrow_down: | | [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | | | [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | | | [...earch7/query/ProfileThreadSnapshotQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9Qcm9maWxlVGhyZWFkU25hcHNob3RRdWVyeUVzN0RBTy5qYXZh) | `50.00% <0.00%> (-50.00%)` | `1.00% <0.00%> (-2.00%)` | | | [...rg/apache/skywalking/apm/agent/core/os/OSUtil.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvb3MvT1NVdGlsLmphdmE=) | `62.71% <0.00%> (-5.09%)` | `10.00% <0.00%> (-2.00%)` | | | [...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==) | `86.66% <0.00%> (-3.34%)` | `8.00% <0.00%> (-1.00%)` | | | [...kywalking/apm/agent/core/jvm/JVMMetricsSender.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTU1ldHJpY3NTZW5kZXIuamF2YQ==) | `82.35% <0.00%> (-2.95%)` |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
codecov[bot] edited a comment on pull request #5276: URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) Report > Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc) will **decrease** coverage by `0.24%`. > The diff coverage is `19.64%`. [](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5276 +/- ## - Coverage 53.16% 52.91% -0.25% + Complexity 3159 3152 -7 Files 816 821 +5 Lines 2045020537 +87 Branches 1969 1979 +10 - Hits 1087210867 -5 - Misses 8697 8783 +86 - Partials881 887 +6 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.45% <10.20%> (-4.29%)` | `11.00 <1.00> (+1.00)` | :arrow_down: | | [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | | | [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | | | [...earch7/query/ProfileThreadSnapshotQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9Qcm9maWxlVGhyZWFkU25hcHNob3RRdWVyeUVzN0RBTy5qYXZh) | `50.00% <0.00%> (-50.00%)` | `1.00% <0.00%> (-2.00%)` | | | [...apm/agent/core/remote/ServiceManagementClient.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VNYW5hZ2VtZW50Q2xpZW50LmphdmE=) | `60.37% <0.00%> (-13.21%)` | `9.00% <0.00%> (-1.00%)` | | | [...rg/apache/skywalking/apm/agent/core/os/OSUtil.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvb3MvT1NVdGlsLmphdmE=) | `62.71% <0.00%> (-5.09%)` | `10.00% <0.00%> (-2.00%)` | | | [...g/oap/server/telemetry/prometheus/BaseMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdGVsZW1ldHJ5L3RlbGVtZXRyeS1wcm9tZXRoZXVzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvdGVsZW1ldHJ5L3Byb21ldGhldXMvQmFzZU1ldHJpY3MuamF2YQ==) | `86.66% <0.00%>
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
codecov[bot] edited a comment on pull request #5276: URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) Report > Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc) will **decrease** coverage by `9.75%`. > The diff coverage is `19.64%`. [](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5276 +/- ## - Coverage 53.16% 43.40% -9.76% + Complexity 3159 2490 -669 Files 816 821 +5 Lines 2045020537 +87 Branches 1969 1979 +10 - Hits 10872 8915-1957 - Misses 869710974+2277 + Partials881 648 -233 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.45% <10.20%> (-4.29%)` | `11.00 <1.00> (+1.00)` | :arrow_down: | | [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | | | [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | ... and [137 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree-more) | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
codecov[bot] edited a comment on pull request #5276: URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) Report > Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc) will **decrease** coverage by `9.74%`. > The diff coverage is `19.64%`. [](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5276 +/- ## - Coverage 53.16% 43.42% -9.75% + Complexity 3159 2490 -669 Files 816 819 +3 Lines 2045020531 +81 Branches 1969 1979 +10 - Hits 10872 8915-1957 - Misses 869710968+2271 + Partials881 648 -233 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.45% <10.20%> (-4.29%)` | `11.00 <1.00> (+1.00)` | :arrow_down: | | [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | | | [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | ... and [135 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree-more) | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
codecov[bot] edited a comment on pull request #5276: URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) Report > Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc) will **decrease** coverage by `9.81%`. > The diff coverage is `19.64%`. [](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5276 +/- ## - Coverage 53.16% 43.34% -9.82% + Complexity 3159 2483 -676 Files 816 818 +2 Lines 2045020492 +42 Branches 1969 1978 +9 - Hits 10872 8883-1989 - Misses 869710965+2268 + Partials881 644 -237 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.45% <10.20%> (-4.29%)` | `11.00 <1.00> (+1.00)` | :arrow_down: | | [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | | | [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | ... and [140 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree-more) | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
codecov[bot] edited a comment on pull request #5276: URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
codecov[bot] edited a comment on pull request #5276: URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) Report > Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc) will **decrease** coverage by `9.65%`. > The diff coverage is `19.64%`. [](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5276 +/- ## - Coverage 53.16% 43.50% -9.66% + Complexity 3159 2490 -669 Files 816 818 +2 Lines 2045020492 +42 Branches 1969 1978 +9 - Hits 10872 8915-1957 - Misses 869710929+2232 + Partials881 648 -233 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.45% <10.20%> (-4.29%)` | `11.00 <1.00> (+1.00)` | :arrow_down: | | [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | | | [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | ... and [136 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree-more) | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
codecov[bot] edited a comment on pull request #5276: URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) Report > Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc) will **decrease** coverage by `0.31%`. > The diff coverage is `19.64%`. [](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5276 +/- ## - Coverage 53.16% 52.85% -0.32% + Complexity 3159 3153 -6 Files 816 821 +5 Lines 2045020537 +87 Branches 1969 1979 +10 - Hits 1087210854 -18 - Misses 8697 8801 +104 - Partials881 882 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.45% <10.20%> (-4.29%)` | `11.00 <1.00> (+1.00)` | :arrow_down: | | [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | | | [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | | | [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.43% <0.00%> (-65.86%)` | `1.00% <0.00%> (-7.00%)` | | | [...kywalking/apm/agent/core/jvm/JVMMetricsSender.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTU1ldHJpY3NTZW5kZXIuamF2YQ==) | `82.35% <0.00%> (-2.95%)` | `11.00% <0.00%> (ø%)` | | | [...ore/plugin/bootstrap/BootstrapPluginLogBridge.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2Jvb3RzdHJhcC9Cb290c3RyYXBQbHVnaW5Mb2dCcmlkZ2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | | | [...m/agent/core/conf/RuntimeContextConfiguration.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9SdW50aW1lQ29udGV4dENvbmZpZ3VyYXRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
codecov[bot] edited a comment on pull request #5276: URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) Report > Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc) will **decrease** coverage by `10.69%`. > The diff coverage is `19.64%`. [](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5276 +/- ## = - Coverage 53.16% 42.46% -10.70% + Complexity 3159 2404 -755 = Files 816 801 -15 Lines 2045020047 -403 Branches 1969 1943 -26 = - Hits 10872 8513 -2359 - Misses 869710917 +2220 + Partials881 617 -264 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.00% <10.20%> (-4.74%)` | `11.00 <1.00> (+1.00)` | :arrow_down: | | [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | | | [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | ... and [163
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
codecov[bot] edited a comment on pull request #5276: URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
codecov[bot] edited a comment on pull request #5276: URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) Report > Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc) will **decrease** coverage by `12.42%`. > The diff coverage is `19.64%`. [](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5276 +/- ## = - Coverage 53.16% 40.73% -12.43% + Complexity 3159 2344 -815 = Files 816 801 -15 Lines 2045020047 -403 Branches 1969 1943 -26 = - Hits 10872 8167 -2705 - Misses 869711285 +2588 + Partials881 595 -286 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.00% <10.20%> (-4.74%)` | `11.00 <1.00> (+1.00)` | :arrow_down: | | [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | | | [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | ... and [174
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5274: make CPUMetricsAccessor SPI switchable and suppport other jvm
codecov[bot] edited a comment on pull request #5274: URL: https://github.com/apache/skywalking/pull/5274#issuecomment-670979080 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=h1) Report > Merging [#5274](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc) will **decrease** coverage by `0.48%`. > The diff coverage is `42.10%`. [](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5274 +/- ## - Coverage 53.16% 52.67% -0.49% + Complexity 3159 3132 -27 Files 816 1486 +670 Lines 2045032060 +11610 Branches 1969 3513+1544 + Hits 1087216889+6017 - Misses 869714358+5661 + Partials881 813 -68 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...walking/apm/agent/core/jvm/cpu/JmxCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9KbXhDcHVBY2Nlc3Nvci5qYXZh) | `35.29% <35.29%> (ø)` | `4.00 <4.00> (?)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `79.62% <100.00%> (+0.38%)` | `0.00 <0.00> (ø)` | | | [...skywalking/apm/agent/core/jvm/cpu/CPUProvider.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9DUFVQcm92aWRlci5qYXZh) | `92.85% <100.00%> (+19.52%)` | `3.00 <0.00> (ø)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | | | [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `12.16% <0.00%> (-77.84%)` | `2.00% <0.00%> (ø%)` | | | [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-61.54%)` | `0.00% <0.00%> (-3.00%)` | | | [...r/storage/plugin/influxdb/query/TopologyQuery.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Ub3BvbG9neVF1ZXJ5LmphdmE=) | `3.50% <0.00%> (-59.65%)` | `2.00% <0.00%> (-12.00%)` | | | [...er/sharing/server/ReceiverGRPCHandlerRegister.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvUmVjZWl2ZXJHUlBDSGFuZGxlclJlZ2lzdGVyLmphdmE=) | `30.76% <0.00%> (-46.16%)` | `2.00% <0.00%> (-3.00%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
codecov[bot] edited a comment on pull request #5276: URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) Report > Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc) will **decrease** coverage by `12.52%`. > The diff coverage is `19.64%`. [](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5276 +/- ## = - Coverage 53.16% 40.63% -12.53% + Complexity 3159 2336 -823 = Files 816 801 -15 Lines 2045020047 -403 Branches 1969 1943 -26 = - Hits 10872 8147 -2725 - Misses 869711306 +2609 + Partials881 594 -287 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.00% <10.20%> (-4.74%)` | `11.00 <1.00> (+1.00)` | :arrow_down: | | [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | | | [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | ... and [179
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
codecov[bot] edited a comment on pull request #5276: URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) Report > Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc) will **decrease** coverage by `0.31%`. > The diff coverage is `19.64%`. [](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5276 +/- ## - Coverage 53.16% 52.85% -0.32% + Complexity 3159 3153 -6 Files 816 821 +5 Lines 2045020537 +87 Branches 1969 1979 +10 - Hits 1087210854 -18 - Misses 8697 8801 +104 - Partials881 882 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.45% <10.20%> (-4.29%)` | `11.00 <1.00> (+1.00)` | :arrow_down: | | [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | | | [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | | | [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.43% <0.00%> (-65.86%)` | `1.00% <0.00%> (-7.00%)` | | | [...kywalking/apm/agent/core/jvm/JVMMetricsSender.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTU1ldHJpY3NTZW5kZXIuamF2YQ==) | `82.35% <0.00%> (-2.95%)` | `11.00% <0.00%> (ø%)` | | | [...ore/plugin/bootstrap/BootstrapPluginLogBridge.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2Jvb3RzdHJhcC9Cb290c3RyYXBQbHVnaW5Mb2dCcmlkZ2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | | | [...lking/apm/agent/core/plugin/match/PrefixMatch.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL1ByZWZpeE1hdGNoLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | | | ... and
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
codecov[bot] edited a comment on pull request #5276: URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) Report > Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc) will **decrease** coverage by `13.30%`. > The diff coverage is `19.64%`. [](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5276 +/- ## = - Coverage 53.16% 39.86% -13.31% + Complexity 3159 2301 -858 = Files 816 801 -15 Lines 2045020044 -406 Branches 1969 1943 -26 = - Hits 10872 7990 -2882 - Misses 869711462 +2765 + Partials881 592 -289 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.00% <10.20%> (-4.74%)` | `11.00 <1.00> (+1.00)` | :arrow_down: | | [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | | | [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | ... and [197
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
codecov[bot] edited a comment on pull request #5276: URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
codecov[bot] edited a comment on pull request #5276: URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) Report > Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc) will **decrease** coverage by `14.80%`. > The diff coverage is `19.64%`. [](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5276 +/- ## = - Coverage 53.16% 38.35% -14.81% + Complexity 3159 2202 -957 = Files 816 801 -15 Lines 2045020010 -440 Branches 1969 1942 -27 = - Hits 10872 7675 -3197 - Misses 869711762 +3065 + Partials881 573 -308 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.00% <10.20%> (-4.74%)` | `11.00 <1.00> (+1.00)` | :arrow_down: | | [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | | | [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | ... and [217
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
codecov[bot] edited a comment on pull request #5276: URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) Report > Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc) will **decrease** coverage by `0.30%`. > The diff coverage is `19.64%`. [](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5276 +/- ## - Coverage 53.16% 52.86% -0.31% + Complexity 3159 3153 -6 Files 816 820 +4 Lines 2045020533 +83 Branches 1969 1979 +10 - Hits 1087210854 -18 - Misses 8697 8797 +100 - Partials881 882 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.45% <10.20%> (-4.29%)` | `11.00 <1.00> (+1.00)` | :arrow_down: | | [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | | | [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | | | [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.43% <0.00%> (-65.86%)` | `1.00% <0.00%> (-7.00%)` | | | [...kywalking/apm/agent/core/jvm/JVMMetricsSender.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTU1ldHJpY3NTZW5kZXIuamF2YQ==) | `82.35% <0.00%> (-2.95%)` | `11.00% <0.00%> (ø%)` | | | [...m/agent/core/conf/RuntimeContextConfiguration.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9SdW50aW1lQ29udGV4dENvbmZpZ3VyYXRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | | | [...apm/agent/core/context/RuntimeContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9SdW50aW1lQ29udGV4dFNuYXBzaG90LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | | | ... and [2
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
codecov[bot] edited a comment on pull request #5276: URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) Report > Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc) will **decrease** coverage by `0.30%`. > The diff coverage is `19.64%`. [](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5276 +/- ## - Coverage 53.16% 52.86% -0.31% + Complexity 3159 3153 -6 Files 816 820 +4 Lines 2045020533 +83 Branches 1969 1979 +10 - Hits 1087210854 -18 - Misses 8697 8797 +100 - Partials881 882 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.45% <10.20%> (-4.29%)` | `11.00 <1.00> (+1.00)` | :arrow_down: | | [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | | | [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | | | [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.43% <0.00%> (-65.86%)` | `1.00% <0.00%> (-7.00%)` | | | [...kywalking/apm/agent/core/jvm/JVMMetricsSender.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTU1ldHJpY3NTZW5kZXIuamF2YQ==) | `82.35% <0.00%> (-2.95%)` | `11.00% <0.00%> (ø%)` | | | [...lking/apm/agent/core/plugin/match/PrefixMatch.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL1ByZWZpeE1hdGNoLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | | | [...ore/plugin/bootstrap/BootstrapPluginLogBridge.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2Jvb3RzdHJhcC9Cb290c3RyYXBQbHVnaW5Mb2dCcmlkZ2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | | | ... and
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
codecov[bot] edited a comment on pull request #5276: URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) Report > Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc) will **decrease** coverage by `0.30%`. > The diff coverage is `19.64%`. [](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5276 +/- ## - Coverage 53.16% 52.86% -0.31% + Complexity 3159 3153 -6 Files 816 820 +4 Lines 2045020533 +83 Branches 1969 1979 +10 - Hits 1087210854 -18 - Misses 8697 8797 +100 - Partials881 882 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.45% <10.20%> (-4.29%)` | `11.00 <1.00> (+1.00)` | :arrow_down: | | [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | | | [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | | | [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.43% <0.00%> (-65.86%)` | `1.00% <0.00%> (-7.00%)` | | | [...kywalking/apm/agent/core/jvm/JVMMetricsSender.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTU1ldHJpY3NTZW5kZXIuamF2YQ==) | `82.35% <0.00%> (-2.95%)` | `11.00% <0.00%> (ø%)` | | | [...ore/plugin/bootstrap/BootstrapPluginLogBridge.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2Jvb3RzdHJhcC9Cb290c3RyYXBQbHVnaW5Mb2dCcmlkZ2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | | | [...m/agent/core/conf/RuntimeContextConfiguration.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9SdW50aW1lQ29udGV4dENvbmZpZ3VyYXRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
codecov[bot] edited a comment on pull request #5276: URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) Report > Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc) will **decrease** coverage by `14.71%`. > The diff coverage is `19.64%`. [](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5276 +/- ## = - Coverage 53.16% 38.44% -14.72% + Complexity 3159 2202 -957 = Files 816 798 -18 Lines 2045019962 -488 Branches 1969 1938 -31 = - Hits 10872 7675 -3197 - Misses 869711714 +3017 + Partials881 573 -308 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.00% <10.20%> (-4.74%)` | `11.00 <1.00> (+1.00)` | :arrow_down: | | [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | | | [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | ... and [216
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
codecov[bot] edited a comment on pull request #5276: URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
codecov[bot] edited a comment on pull request #5276: URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
codecov[bot] edited a comment on pull request #5276: URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) Report > Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc) will **decrease** coverage by `0.30%`. > The diff coverage is `19.64%`. [](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5276 +/- ## - Coverage 53.16% 52.86% -0.31% + Complexity 3159 3153 -6 Files 816 820 +4 Lines 2045020533 +83 Branches 1969 1979 +10 - Hits 1087210854 -18 - Misses 8697 8797 +100 - Partials881 882 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.45% <10.20%> (-4.29%)` | `11.00 <1.00> (+1.00)` | :arrow_down: | | [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | | | [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | | | [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.43% <0.00%> (-65.86%)` | `1.00% <0.00%> (-7.00%)` | | | [...kywalking/apm/agent/core/jvm/JVMMetricsSender.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTU1ldHJpY3NTZW5kZXIuamF2YQ==) | `82.35% <0.00%> (-2.95%)` | `11.00% <0.00%> (ø%)` | | | [...apm/agent/core/context/RuntimeContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9SdW50aW1lQ29udGV4dFNuYXBzaG90LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | | | [...lking/apm/agent/core/plugin/match/PrefixMatch.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL1ByZWZpeE1hdGNoLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | | | ... and [2
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
codecov[bot] edited a comment on pull request #5276: URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) Report > Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc) will **decrease** coverage by `0.30%`. > The diff coverage is `19.64%`. [](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5276 +/- ## - Coverage 53.16% 52.86% -0.31% + Complexity 3159 3153 -6 Files 816 820 +4 Lines 2045020533 +83 Branches 1969 1979 +10 - Hits 1087210854 -18 - Misses 8697 8797 +100 - Partials881 882 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.45% <10.20%> (-4.29%)` | `11.00 <1.00> (+1.00)` | :arrow_down: | | [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | | | [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | | | [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.43% <0.00%> (-65.86%)` | `1.00% <0.00%> (-7.00%)` | | | [...kywalking/apm/agent/core/jvm/JVMMetricsSender.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTU1ldHJpY3NTZW5kZXIuamF2YQ==) | `82.35% <0.00%> (-2.95%)` | `11.00% <0.00%> (ø%)` | | | [...lking/apm/agent/core/plugin/match/PrefixMatch.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL1ByZWZpeE1hdGNoLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | | | [...m/agent/core/conf/RuntimeContextConfiguration.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9SdW50aW1lQ29udGV4dENvbmZpZ3VyYXRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | | | ... and [2
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
codecov[bot] edited a comment on pull request #5276: URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
codecov[bot] edited a comment on pull request #5276: URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) Report > Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc) will **decrease** coverage by `0.30%`. > The diff coverage is `19.64%`. [](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5276 +/- ## - Coverage 53.16% 52.86% -0.31% + Complexity 3159 3153 -6 Files 816 820 +4 Lines 2045020533 +83 Branches 1969 1979 +10 - Hits 1087210854 -18 - Misses 8697 8797 +100 - Partials881 882 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.45% <10.20%> (-4.29%)` | `11.00 <1.00> (+1.00)` | :arrow_down: | | [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | | | [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | | | [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.43% <0.00%> (-65.86%)` | `1.00% <0.00%> (-7.00%)` | | | [...kywalking/apm/agent/core/jvm/JVMMetricsSender.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTU1ldHJpY3NTZW5kZXIuamF2YQ==) | `82.35% <0.00%> (-2.95%)` | `11.00% <0.00%> (ø%)` | | | [...lking/apm/agent/core/plugin/match/PrefixMatch.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL1ByZWZpeE1hdGNoLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | | | [...apm/agent/core/context/RuntimeContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9SdW50aW1lQ29udGV4dFNuYXBzaG90LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | | | ... and [2
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
codecov[bot] edited a comment on pull request #5276: URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) Report > Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc) will **decrease** coverage by `0.34%`. > The diff coverage is `19.64%`. [](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5276 +/- ## - Coverage 53.16% 52.81% -0.35% + Complexity 3159 3147 -12 Files 816 818 +2 Lines 2045020527 +77 Branches 1969 1979 +10 - Hits 1087210842 -30 - Misses 8697 8802 +105 - Partials881 883 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.45% <10.20%> (-4.29%)` | `11.00 <1.00> (+1.00)` | :arrow_down: | | [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | | | [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | | | [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.43% <0.00%> (-65.86%)` | `1.00% <0.00%> (-7.00%)` | | | [...earch7/query/ProfileThreadSnapshotQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9Qcm9maWxlVGhyZWFkU25hcHNob3RRdWVyeUVzN0RBTy5qYXZh) | `50.00% <0.00%> (-50.00%)` | `1.00% <0.00%> (-2.00%)` | | | [...apm/agent/core/remote/ServiceManagementClient.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VNYW5hZ2VtZW50Q2xpZW50LmphdmE=) | `60.37% <0.00%> (-13.21%)` | `9.00% <0.00%> (-1.00%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
codecov[bot] edited a comment on pull request #5276: URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) Report > Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc) will **decrease** coverage by `0.92%`. > The diff coverage is `19.64%`. [](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5276 +/- ## - Coverage 53.16% 52.24% -0.93% + Complexity 3159 3109 -50 Files 816 818 +2 Lines 2045020527 +77 Branches 1969 1979 +10 - Hits 1087210724 -148 - Misses 8697 8920 +223 - Partials881 883 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.45% <10.20%> (-4.29%)` | `11.00 <1.00> (+1.00)` | :arrow_down: | | [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | | | [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | | | [.../storage/plugin/jdbc/mysql/MySQLTraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUcmFjZVF1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...ge/plugin/jdbc/mysql/MySQLAggregationQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxBZ2dyZWdhdGlvblF1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...storage/plugin/jdbc/mysql/MySQLTableInstaller.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUYWJsZUluc3RhbGxlci5qYXZh) | `0.00% <0.00%> (-94.34%)` | `0.00% <0.00%> (-14.00%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
codecov[bot] edited a comment on pull request #5276: URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) Report > Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc) will **decrease** coverage by `2.33%`. > The diff coverage is `19.64%`. [](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5276 +/- ## - Coverage 53.16% 50.83% -2.34% + Complexity 3159 3065 -94 Files 816 816 Lines 2045020499 +49 Branches 1969 1978 +9 - Hits 1087210420 -452 - Misses 8697 9201 +504 + Partials881 878 -3 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.45% <10.20%> (-4.29%)` | `11.00 <1.00> (+1.00)` | :arrow_down: | | [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | | | [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | | | [.../storage/plugin/jdbc/mysql/MySQLTraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUcmFjZVF1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...ge/plugin/jdbc/mysql/MySQLAggregationQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxBZ2dyZWdhdGlvblF1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...storage/plugin/jdbc/mysql/MySQLTableInstaller.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUYWJsZUluc3RhbGxlci5qYXZh) | `0.00% <0.00%> (-94.34%)` | `0.00% <0.00%> (-14.00%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
codecov[bot] edited a comment on pull request #5276: URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) Report > Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc) will **decrease** coverage by `1.61%`. > The diff coverage is `19.64%`. [](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5276 +/- ## - Coverage 53.16% 51.54% -1.62% + Complexity 3159 3087 -72 Files 816 818 +2 Lines 2045020527 +77 Branches 1969 1979 +10 - Hits 1087210581 -291 - Misses 8697 9064 +367 - Partials881 882 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.45% <10.20%> (-4.29%)` | `11.00 <1.00> (+1.00)` | :arrow_down: | | [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | | | [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | | | [.../storage/plugin/jdbc/mysql/MySQLTraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUcmFjZVF1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...ge/plugin/jdbc/mysql/MySQLAggregationQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxBZ2dyZWdhdGlvblF1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...storage/plugin/jdbc/mysql/MySQLTableInstaller.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUYWJsZUluc3RhbGxlci5qYXZh) | `0.00% <0.00%> (-94.34%)` | `0.00% <0.00%> (-14.00%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
codecov[bot] edited a comment on pull request #5276: URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) Report > Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc) will **decrease** coverage by `1.58%`. > The diff coverage is `19.64%`. [](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5276 +/- ## - Coverage 53.16% 51.57% -1.59% + Complexity 3159 3088 -71 Files 816 818 +2 Lines 2045020527 +77 Branches 1969 1979 +10 - Hits 1087210587 -285 - Misses 8697 9058 +361 - Partials881 882 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `45.45% <10.20%> (-4.29%)` | `11.00 <1.00> (+1.00)` | :arrow_down: | | [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | | | [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | | | [.../storage/plugin/jdbc/mysql/MySQLTraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUcmFjZVF1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...ge/plugin/jdbc/mysql/MySQLAggregationQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxBZ2dyZWdhdGlvblF1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...storage/plugin/jdbc/mysql/MySQLTableInstaller.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUYWJsZUluc3RhbGxlci5qYXZh) | `0.00% <0.00%> (-94.34%)` | `0.00% <0.00%> (-14.00%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
codecov[bot] edited a comment on pull request #5276: URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) Report > Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc) will **decrease** coverage by `15.05%`. > The diff coverage is `19.64%`. [](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5276 +/- ## = - Coverage 53.16% 38.11% -15.06% + Complexity 3159 2218 -941 = Files 816 800 -16 Lines 2045020046 -404 Branches 1969 1944 -25 = - Hits 10872 7640 -3232 - Misses 869711817 +3120 + Partials881 589 -292 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `44.54% <10.20%> (-5.19%)` | `11.00 <1.00> (+1.00)` | :arrow_down: | | [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | | | [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | ... and [214
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
codecov[bot] edited a comment on pull request #5276: URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) Report > Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc) will **decrease** coverage by `15.09%`. > The diff coverage is `19.64%`. [](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5276 +/- ## = - Coverage 53.16% 38.06% -15.10% + Complexity 3159 2217 -942 = Files 816 800 -16 Lines 2045020036 -414 Branches 1969 1944 -25 = - Hits 10872 7627 -3245 - Misses 869711819 +3122 + Partials881 590 -291 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `44.54% <10.20%> (-5.19%)` | `11.00 <1.00> (+1.00)` | :arrow_down: | | [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | | | [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | ... and [217
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
codecov[bot] edited a comment on pull request #5276: URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
codecov[bot] edited a comment on pull request #5276: URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) Report > Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc) will **decrease** coverage by `23.41%`. > The diff coverage is `19.64%`. [](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5276 +/- ## = - Coverage 53.16% 29.75% -23.42% + Complexity 3159 1775 -1384 = Files 816 793 -23 Lines 2045019787 -663 Branches 1969 1924 -45 = - Hits 10872 5887 -4985 - Misses 869713449 +4752 + Partials881 451 -430 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `42.72% <10.20%> (-7.01%)` | `11.00 <1.00> (+1.00)` | :arrow_down: | | [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | | | [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | | | [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [303 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree-more)
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
codecov[bot] edited a comment on pull request #5276: URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
codecov[bot] edited a comment on pull request #5276: URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) Report > Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc) will **decrease** coverage by `22.01%`. > The diff coverage is `19.64%`. [](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5276 +/- ## = - Coverage 53.16% 31.14% -22.02% + Complexity 3159 1892 -1267 = Files 816 800 -16 Lines 2045020006 -444 Branches 1969 1941 -28 = - Hits 10872 6231 -4641 - Misses 869713305 +4608 + Partials881 470 -411 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `44.09% <10.20%> (-5.65%)` | `11.00 <1.00> (+1.00)` | :arrow_down: | | [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | | | [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | | | [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [272 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree-more)
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
codecov[bot] edited a comment on pull request #5276: URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
codecov[bot] edited a comment on pull request #5276: URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
codecov[bot] edited a comment on pull request #5276: URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) Report > Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc) will **decrease** coverage by `53.16%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5276 +/- ## - Coverage 53.16% 0.00% -53.17% Files 816 160 -656 Lines 204503946-16504 Branches 1969 466 -1503 - Hits 10872 0-10872 + Misses 86973946 -4751 + Partials881 0 -881 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | ... and [776 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
codecov[bot] edited a comment on pull request #5276: URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) Report > Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc) will **decrease** coverage by `23.62%`. > The diff coverage is `19.64%`. [](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5276 +/- ## = - Coverage 53.16% 29.53% -23.63% + Complexity 3159 1776 -1383 = Files 816 799 -17 Lines 2045019934 -516 Branches 1969 1939 -30 = - Hits 10872 5888 -4984 - Misses 869713596 +4899 + Partials881 450 -431 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `42.72% <10.20%> (-7.01%)` | `11.00 <1.00> (+1.00)` | :arrow_down: | | [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | | | [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | | | [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [300 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree-more)
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
codecov[bot] edited a comment on pull request #5276: URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) Report > Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc) will **decrease** coverage by `23.60%`. > The diff coverage is `19.64%`. [](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5276 +/- ## = - Coverage 53.16% 29.55% -23.61% + Complexity 3159 1776 -1383 = Files 816 799 -17 Lines 2045019934 -516 Branches 1969 1939 -30 = - Hits 10872 5892 -4980 - Misses 869713593 +4896 + Partials881 449 -432 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...king/oap/server/core/alarm/provider/AlarmRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGUuamF2YQ==) | `9.09% <ø> (ø)` | `1.00 <0.00> (ø)` | | | [...re/analysis/meter/function/AvgLabeledFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnTGFiZWxlZEZ1bmN0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | | | [...ng/oap/server/core/alarm/provider/RunningRule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdW5uaW5nUnVsZS5qYXZh) | `44.09% <10.20%> (-5.65%)` | `11.00 <1.00> (+1.00)` | :arrow_down: | | [...p/server/core/alarm/provider/MetricsValueType.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9NZXRyaWNzVmFsdWVUeXBlLmphdmE=) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | | | [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `58.92% <100.00%> (+3.15%)` | `3.00 <0.00> (ø)` | | | [...rver/core/analysis/meter/function/AvgFunction.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnRnVuY3Rpb24uamF2YQ==) | `72.60% <100.00%> (ø)` | `14.00 <1.00> (ø)` | | | [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [299 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree-more)
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
codecov[bot] edited a comment on pull request #5276: URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) Report > Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc) will **decrease** coverage by `53.16%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5276 +/- ## - Coverage 53.16% 0.00% -53.17% Files 816 155 -661 Lines 204503810-16640 Branches 1969 442 -1527 - Hits 10872 0-10872 + Misses 86973810 -4887 + Partials881 0 -881 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | ... and [781 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
codecov[bot] edited a comment on pull request #5276: URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) Report > Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc) will **decrease** coverage by `53.16%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5276 +/- ## - Coverage 53.16% 0.00% -53.17% Files 816 168 -648 Lines 204504105-16345 Branches 1969 481 -1488 - Hits 10872 0-10872 + Misses 86974105 -4592 + Partials881 0 -881 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [774 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5274: make CPUMetricsAccessor SPI switchable and suppport other jvm
codecov[bot] edited a comment on pull request #5274: URL: https://github.com/apache/skywalking/pull/5274#issuecomment-670979080 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=h1) Report > Merging [#5274](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc) will **decrease** coverage by `0.89%`. > The diff coverage is `36.84%`. [](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5274 +/- ## - Coverage 53.16% 52.27% -0.90% + Complexity 3159 3132 -27 Files 816 821 +5 Lines 2045020523 +73 Branches 1969 1965 -4 - Hits 1087210728 -144 - Misses 8697 8921 +224 + Partials881 874 -7 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...walking/apm/agent/core/jvm/cpu/JmxCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9KbXhDcHVBY2Nlc3Nvci5qYXZh) | `32.35% <32.35%> (ø)` | `4.00 <4.00> (?)` | | | [...skywalking/apm/agent/core/jvm/cpu/CPUProvider.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9DUFVQcm92aWRlci5qYXZh) | `85.71% <66.66%> (+12.38%)` | `3.00 <0.00> (ø)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `79.62% <100.00%> (+0.38%)` | `0.00 <0.00> (ø)` | | | [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | | | [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-61.54%)` | `0.00% <0.00%> (-3.00%)` | | | [...r/storage/plugin/influxdb/query/TopologyQuery.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Ub3BvbG9neVF1ZXJ5LmphdmE=) | `3.50% <0.00%> (-59.65%)` | `2.00% <0.00%> (-12.00%)` | | | [...er/sharing/server/ReceiverGRPCHandlerRegister.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvUmVjZWl2ZXJHUlBDSGFuZGxlclJlZ2lzdGVyLmphdmE=) | `30.76% <0.00%> (-46.16%)` | `2.00% <0.00%> (-3.00%)` | | | [...ap/server/core/server/GRPCHandlerRegisterImpl.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL0dSUENIYW5kbGVyUmVnaXN0ZXJJbXBsLmphdmE=) | `62.50% <0.00%> (-25.00%)` | `2.00% <0.00%> (-1.00%)` | | | [...ing/apm/agent/core/jvm/cpu/CPUMetricsAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9DUFVNZXRyaWNzQWNjZXNzb3IuamF2YQ==) | `76.92% <0.00%> (-23.08%)` | `2.00% <0.00%> (-1.00%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
codecov[bot] edited a comment on pull request #5276: URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) Report > Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc) will **decrease** coverage by `53.16%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5276 +/- ## - Coverage 53.16% 0.00% -53.17% Files 816 161 -655 Lines 204503957-16493 Branches 1969 457 -1512 - Hits 10872 0-10872 + Misses 86973957 -4740 + Partials881 0 -881 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | ... and [779 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
codecov[bot] edited a comment on pull request #5276: URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) Report > Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc) will **decrease** coverage by `53.16%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5276 +/- ## - Coverage 53.16% 0.00% -53.17% Files 816 166 -650 Lines 204504093-16357 Branches 1969 481 -1488 - Hits 10872 0-10872 + Misses 86974093 -4604 + Partials881 0 -881 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | ... and [774 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
codecov[bot] edited a comment on pull request #5276: URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5276: Add labeled metrics to alarm system
codecov[bot] edited a comment on pull request #5276: URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] commented on pull request #5276: Add labeled metrics to alarm system
codecov[bot] commented on pull request #5276: URL: https://github.com/apache/skywalking/pull/5276#issuecomment-670992443 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=h1) Report > Merging [#5276](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc) will **decrease** coverage by `53.16%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5276 +/- ## - Coverage 53.16% 0.00% -53.17% Files 816 151 -665 Lines 204503751-16699 Branches 1969 441 -1528 - Hits 10872 0-10872 + Misses 86973751 -4946 + Partials881 0 -881 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5276?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | ... and [784 more](https://codecov.io/gh/apache/skywalking/pull/5276/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5274: make CPUMetricsAccessor SPI switchable and suppport other jvm
codecov[bot] edited a comment on pull request #5274: URL: https://github.com/apache/skywalking/pull/5274#issuecomment-670979080 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=h1) Report > Merging [#5274](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc) will **decrease** coverage by `0.88%`. > The diff coverage is `36.84%`. [](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5274 +/- ## - Coverage 53.16% 52.28% -0.89% + Complexity 3159 3132 -27 Files 816 820 +4 Lines 2045020519 +69 Branches 1969 1965 -4 - Hits 1087210728 -144 - Misses 8697 8917 +220 + Partials881 874 -7 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...walking/apm/agent/core/jvm/cpu/JmxCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9KbXhDcHVBY2Nlc3Nvci5qYXZh) | `32.35% <32.35%> (ø)` | `4.00 <4.00> (?)` | | | [...skywalking/apm/agent/core/jvm/cpu/CPUProvider.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9DUFVQcm92aWRlci5qYXZh) | `85.71% <66.66%> (+12.38%)` | `3.00 <0.00> (ø)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `79.62% <100.00%> (+0.38%)` | `0.00 <0.00> (ø)` | | | [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | | | [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-61.54%)` | `0.00% <0.00%> (-3.00%)` | | | [...r/storage/plugin/influxdb/query/TopologyQuery.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Ub3BvbG9neVF1ZXJ5LmphdmE=) | `3.50% <0.00%> (-59.65%)` | `2.00% <0.00%> (-12.00%)` | | | [...er/sharing/server/ReceiverGRPCHandlerRegister.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvUmVjZWl2ZXJHUlBDSGFuZGxlclJlZ2lzdGVyLmphdmE=) | `30.76% <0.00%> (-46.16%)` | `2.00% <0.00%> (-3.00%)` | | | [...ap/server/core/server/GRPCHandlerRegisterImpl.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL0dSUENIYW5kbGVyUmVnaXN0ZXJJbXBsLmphdmE=) | `62.50% <0.00%> (-25.00%)` | `2.00% <0.00%> (-1.00%)` | | | [...ing/apm/agent/core/jvm/cpu/CPUMetricsAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9DUFVNZXRyaWNzQWNjZXNzb3IuamF2YQ==) | `76.92% <0.00%> (-23.08%)` | `2.00% <0.00%> (-1.00%)` | | |
[skywalking] branch labeled-alarm updated (2f4554f -> 3ec59c3)
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch labeled-alarm in repository https://gitbox.apache.org/repos/asf/skywalking.git. from 2f4554f Add labeled metrics to alarm system add b0bb7cf Query all of labels once selected labels condition is absent. (#5202) add 3ec59c3 Merge branch 'master' into labeled-alarm No new revisions were added by this update. Summary of changes: .../core/storage/query/IMetricsQueryDAO.java | 61 ++ .../core/storage/query/MetricsQueryUtilTest.java | 123 + .../elasticsearch/query/MetricsQueryEsDAO.java | 40 +-- .../plugin/influxdb/query/MetricsQuery.java| 30 + .../plugin/jdbc/h2/dao/H2MetricsQueryDAO.java | 30 + 5 files changed, 195 insertions(+), 89 deletions(-) create mode 100644 oap-server/server-core/src/test/java/org/apache/skywalking/oap/server/core/storage/query/MetricsQueryUtilTest.java
[GitHub] [skywalking] hanahmily opened a new pull request #5276: Add labeled metrics to alarm system
hanahmily opened a new pull request #5276: URL: https://github.com/apache/skywalking/pull/5276 - Related issues #5186 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[skywalking] 01/01: Add labeled metrics to alarm system
This is an automated email from the ASF dual-hosted git repository.
hanahmily pushed a commit to branch labeled-alarm
in repository https://gitbox.apache.org/repos/asf/skywalking.git
commit 2f4554fa5bc313f00727c0f1b29e85f35b8fc5f7
Author: Gao Hongtao
AuthorDate: Sun Aug 9 09:15:55 2020 +0800
Add labeled metrics to alarm system
Signed-off-by: Gao Hongtao
---
docs/en/setup/backend/backend-alarm.md | 16 +++
.../oap/server/core/alarm/provider/AlarmRule.java | 4 +
.../core/alarm/provider/MetricsValueType.java | 2 +-
.../server/core/alarm/provider/RulesReader.java| 4 +
.../server/core/alarm/provider/RunningRule.java| 121 +++--
.../core/alarm/provider/RunningRuleTest.java | 111 +++
.../core/analysis/meter/function/AvgFunction.java | 3 +-
.../meter/function/AvgLabeledFunction.java | 3 +-
.../core/analysis/metrics/LabeledValueHolder.java} | 9 +-
9 files changed, 233 insertions(+), 40 deletions(-)
diff --git a/docs/en/setup/backend/backend-alarm.md
b/docs/en/setup/backend/backend-alarm.md
index 387b193..9224022 100644
--- a/docs/en/setup/backend/backend-alarm.md
+++ b/docs/en/setup/backend/backend-alarm.md
@@ -24,6 +24,12 @@ Alarm rule is constituted by following keys
- **Exclude names**. The following entity names are excluded in this rule.
Please follow [Entity name define](#entity-name).
- **Include names regex**. Provide a regex to include the entity names. If
both setting the include name list and include name regex, both rules will take
effect.
- **Exclude names regex**. Provide a regex to exclude the exclude names. If
both setting the exclude name list and exclude name regex, both rules will take
effect.
+- **Include labels**. The following labels of the metric are included in this
rule.
+- **Exclude labels**. The following labels of the metric are excluded in this
rule.
+- **Include labels regex**. Provide a regex to include labels. If both setting
the include label list and include label regex, both rules will take effect.
+- **Exclude labels regex**. Provide a regex to exclude labels. If both setting
the exclude label list and exclude label regex, both rules will take effect.
+*The settings of labels is required by meter-system which intends to store
metrics from label-system platform, just like Prometheus, Micrometer, etc.
+The function supports the above four settings should implement
`LabeledValueHolder`.*
- **Threshold**. The target value.
For multiple values metrics, such as **percentile**, the threshold is an
array. Described like `value1, value2, value3, value4, value5`.
Each value could the threshold for each value of the metrics. Set the value to
`-` if don't want to trigger alarm by this or some of the values.
@@ -75,6 +81,16 @@ rules:
count: 3
silence-period: 5
message: Percentile response time of service {name} alarm in 3 minutes of
last 10 minutes, due to more than one condition of p50 > 1000, p75 > 1000, p90
> 1000, p95 > 1000, p99 > 1000
+ meter_service_status_code_rule:
+metrics-name: meter_status_code
+exclude-labels:
+ - "200"
+op: ">"
+threshold: 10
+period: 10
+count: 3
+silence-period: 5
+message: The request number of entity {name} non-200 status is more than
expected.
```
### Default alarm rules
diff --git
a/oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/AlarmRule.java
b/oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/AlarmRule.java
index f895972..9667ba7 100644
---
a/oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/AlarmRule.java
+++
b/oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/AlarmRule.java
@@ -41,6 +41,10 @@ public class AlarmRule {
private String includeNamesRegex;
private ArrayList excludeNames;
private String excludeNamesRegex;
+private ArrayList includeLabels;
+private String includeLabelsRegex;
+private ArrayList excludeLabels;
+private String excludeLabelsRegex;
private String threshold;
private String op;
private int period;
diff --git
a/oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/MetricsValueType.java
b/oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/MetricsValueType.java
index 040b693..23ad115 100644
---
a/oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/MetricsValueType.java
+++
b/oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/MetricsValueType.java
@@ -19,5 +19,5 @@
package org.apache.skywalking.oap.server.core.alarm.provider;
public enum MetricsValueType {
-LONG, INT, DOUBLE, MULTI_INTS
+LONG, INT,
[skywalking] branch labeled-alarm created (now 2f4554f)
This is an automated email from the ASF dual-hosted git repository. hanahmily pushed a change to branch labeled-alarm in repository https://gitbox.apache.org/repos/asf/skywalking.git. at 2f4554f Add labeled metrics to alarm system This branch includes the following new commits: new 2f4554f Add labeled metrics to alarm system The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5274: make CPUMetricsAccessor SPI switchable and suppport other jvm
codecov[bot] edited a comment on pull request #5274: URL: https://github.com/apache/skywalking/pull/5274#issuecomment-670979080 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5274: make CPUMetricsAccessor SPI switchable and suppport other jvm
codecov[bot] edited a comment on pull request #5274: URL: https://github.com/apache/skywalking/pull/5274#issuecomment-670979080 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=h1) Report > Merging [#5274](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc) will **decrease** coverage by `1.71%`. > The diff coverage is `36.84%`. [](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5274 +/- ## - Coverage 53.16% 51.44% -1.72% + Complexity 3159 3104 -55 Files 816 820 +4 Lines 2045020519 +69 Branches 1969 1965 -4 - Hits 1087210557 -315 - Misses 8697 9098 +401 + Partials881 864 -17 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...walking/apm/agent/core/jvm/cpu/JmxCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9KbXhDcHVBY2Nlc3Nvci5qYXZh) | `32.35% <32.35%> (ø)` | `4.00 <4.00> (?)` | | | [...skywalking/apm/agent/core/jvm/cpu/CPUProvider.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9DUFVQcm92aWRlci5qYXZh) | `85.71% <66.66%> (+12.38%)` | `3.00 <0.00> (ø)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `79.62% <100.00%> (+0.38%)` | `0.00 <0.00> (ø)` | | | [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | | | [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | | | [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | | | [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-61.54%)` | `0.00% <0.00%> (-3.00%)` | | | [...r/storage/plugin/influxdb/query/TopologyQuery.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Ub3BvbG9neVF1ZXJ5LmphdmE=) | `3.50% <0.00%> (-59.65%)` | `2.00% <0.00%> (-12.00%)` | | | [...gin/elasticsearch/query/ProfileTaskQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tRdWVyeUVzREFPLmphdmE=) | `28.57% <0.00%> (-59.19%)` | `2.00% <0.00%> (-7.00%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5274: make CPUMetricsAccessor SPI switchable and suppport other jvm
codecov[bot] edited a comment on pull request #5274: URL: https://github.com/apache/skywalking/pull/5274#issuecomment-670979080 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=h1) Report > Merging [#5274](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc) will **decrease** coverage by `3.61%`. > The diff coverage is `36.84%`. [](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5274 +/- ## - Coverage 53.16% 49.54% -3.62% + Complexity 3159 3029 -130 Files 816 818 +2 Lines 2045020499 +49 Branches 1969 1964 -5 - Hits 1087210156 -716 - Misses 8697 9497 +800 + Partials881 846 -35 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...walking/apm/agent/core/jvm/cpu/JmxCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9KbXhDcHVBY2Nlc3Nvci5qYXZh) | `32.35% <32.35%> (ø)` | `4.00 <4.00> (?)` | | | [...skywalking/apm/agent/core/jvm/cpu/CPUProvider.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9DUFVQcm92aWRlci5qYXZh) | `85.71% <66.66%> (+12.38%)` | `3.00 <0.00> (ø)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `79.62% <100.00%> (+0.38%)` | `0.00 <0.00> (ø)` | | | [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...torage/plugin/elasticsearch/base/StorageEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ticsearch7/client/ElasticSearch7UpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdVcGRhdGVSZXF1ZXN0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | | | [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5274: make CPUMetricsAccessor SPI switchable and suppport other jvm
codecov[bot] edited a comment on pull request #5274: URL: https://github.com/apache/skywalking/pull/5274#issuecomment-670979080 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=h1) Report > Merging [#5274](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc) will **decrease** coverage by `1.04%`. > The diff coverage is `36.84%`. [](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5274 +/- ## - Coverage 53.16% 52.11% -1.05% + Complexity 3159 3126 -33 Files 816 820 +4 Lines 2045020519 +69 Branches 1969 1965 -4 - Hits 1087210694 -178 - Misses 8697 8960 +263 + Partials881 865 -16 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...walking/apm/agent/core/jvm/cpu/JmxCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9KbXhDcHVBY2Nlc3Nvci5qYXZh) | `32.35% <32.35%> (ø)` | `4.00 <4.00> (?)` | | | [...skywalking/apm/agent/core/jvm/cpu/CPUProvider.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9DUFVQcm92aWRlci5qYXZh) | `85.71% <66.66%> (+12.38%)` | `3.00 <0.00> (ø)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `79.62% <100.00%> (+0.38%)` | `0.00 <0.00> (ø)` | | | [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | | | [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-61.54%)` | `0.00% <0.00%> (-3.00%)` | | | [...r/storage/plugin/influxdb/query/TopologyQuery.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Ub3BvbG9neVF1ZXJ5LmphdmE=) | `3.50% <0.00%> (-59.65%)` | `2.00% <0.00%> (-12.00%)` | | | [...er/sharing/server/ReceiverGRPCHandlerRegister.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctc2hhcmluZy1zZXJ2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvc2hhcmluZy9zZXJ2ZXIvUmVjZWl2ZXJHUlBDSGFuZGxlclJlZ2lzdGVyLmphdmE=) | `30.76% <0.00%> (-46.16%)` | `2.00% <0.00%> (-3.00%)` | | | [...ge/plugin/elasticsearch/query/TraceQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvVHJhY2VRdWVyeUVzREFPLmphdmE=) | `4.05% <0.00%> (-31.09%)` | `1.00% <0.00%> (-2.00%)` | | | [...ap/server/core/server/GRPCHandlerRegisterImpl.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL0dSUENIYW5kbGVyUmVnaXN0ZXJJbXBsLmphdmE=) | `62.50% <0.00%> (-25.00%)` | `2.00% <0.00%> (-1.00%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5274: make CPUMetricsAccessor SPI switchable and suppport other jvm
codecov[bot] edited a comment on pull request #5274: URL: https://github.com/apache/skywalking/pull/5274#issuecomment-670979080 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=h1) Report > Merging [#5274](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc) will **decrease** coverage by `1.77%`. > The diff coverage is `36.84%`. [](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5274 +/- ## - Coverage 53.16% 51.39% -1.78% + Complexity 3159 3103 -56 Files 816 818 +2 Lines 2045020513 +63 Branches 1969 1965 -4 - Hits 1087210542 -330 - Misses 8697 9107 +410 + Partials881 864 -17 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...walking/apm/agent/core/jvm/cpu/JmxCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9KbXhDcHVBY2Nlc3Nvci5qYXZh) | `32.35% <32.35%> (ø)` | `4.00 <4.00> (?)` | | | [...skywalking/apm/agent/core/jvm/cpu/CPUProvider.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9DUFVQcm92aWRlci5qYXZh) | `85.71% <66.66%> (+12.38%)` | `3.00 <0.00> (ø)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `79.62% <100.00%> (+0.38%)` | `0.00 <0.00> (ø)` | | | [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | | | [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | | | [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | | | [...er/core/server/auth/AuthenticationInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc2VydmVyL2F1dGgvQXV0aGVudGljYXRpb25JbnRlcmNlcHRvci5qYXZh) | `0.00% <0.00%> (-61.54%)` | `0.00% <0.00%> (-3.00%)` | | | [...r/storage/plugin/influxdb/query/TopologyQuery.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Ub3BvbG9neVF1ZXJ5LmphdmE=) | `3.50% <0.00%> (-59.65%)` | `2.00% <0.00%> (-12.00%)` | | | [...gin/elasticsearch/query/ProfileTaskQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tRdWVyeUVzREFPLmphdmE=) | `28.57% <0.00%> (-59.19%)` | `2.00% <0.00%> (-7.00%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5274: make CPUMetricsAccessor SPI switchable and suppport other jvm
codecov[bot] edited a comment on pull request #5274: URL: https://github.com/apache/skywalking/pull/5274#issuecomment-670979080 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5274: make CPUMetricsAccessor SPI switchable and suppport other jvm
codecov[bot] edited a comment on pull request #5274: URL: https://github.com/apache/skywalking/pull/5274#issuecomment-670979080 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=h1) Report > Merging [#5274](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc) will **decrease** coverage by `4.49%`. > The diff coverage is `36.84%`. [](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5274 +/- ## - Coverage 53.16% 48.67% -4.50% + Complexity 3159 2986 -173 Files 816 815 -1 Lines 2045020449 -1 Branches 1969 1963 -6 - Hits 10872 9953 -919 - Misses 8697 9655 +958 + Partials881 841 -40 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...walking/apm/agent/core/jvm/cpu/JmxCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9KbXhDcHVBY2Nlc3Nvci5qYXZh) | `32.35% <32.35%> (ø)` | `4.00 <4.00> (?)` | | | [...skywalking/apm/agent/core/jvm/cpu/CPUProvider.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9DUFVQcm92aWRlci5qYXZh) | `85.71% <66.66%> (+12.38%)` | `3.00 <0.00> (ø)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `79.62% <100.00%> (+0.38%)` | `0.00 <0.00> (ø)` | | | [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...torage/plugin/elasticsearch/base/StorageEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ticsearch7/client/ElasticSearch7UpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdVcGRhdGVSZXF1ZXN0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | | | [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00% <0.00%> (-6.00%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5274: make CPUMetricsAccessor SPI switchable and suppport other jvm
codecov[bot] edited a comment on pull request #5274: URL: https://github.com/apache/skywalking/pull/5274#issuecomment-670979080 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=h1) Report > Merging [#5274](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc) will **decrease** coverage by `8.48%`. > The diff coverage is `36.84%`. [](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5274 +/- ## - Coverage 53.16% 44.67% -8.49% + Complexity 3159 2742 -417 Files 816 799 -17 Lines 2045019976 -474 Branches 1969 1927 -42 - Hits 10872 8925-1947 - Misses 869710300+1603 + Partials881 751 -130 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...walking/apm/agent/core/jvm/cpu/JmxCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9KbXhDcHVBY2Nlc3Nvci5qYXZh) | `32.35% <32.35%> (ø)` | `4.00 <4.00> (?)` | | | [...skywalking/apm/agent/core/jvm/cpu/CPUProvider.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9DUFVQcm92aWRlci5qYXZh) | `85.71% <66.66%> (+12.38%)` | `3.00 <0.00> (ø)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `79.62% <100.00%> (+0.38%)` | `0.00 <0.00> (ø)` | | | [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...erver/storage/plugin/elasticsearch/base/EsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Fc0RBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | | | [...storage/plugin/elasticsearch/base/RecordEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9SZWNvcmRFc0RBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5274: make CPUMetricsAccessor SPI switchable and suppport other jvm
codecov[bot] edited a comment on pull request #5274: URL: https://github.com/apache/skywalking/pull/5274#issuecomment-670979080 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=h1) Report > Merging [#5274](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc) will **decrease** coverage by `5.63%`. > The diff coverage is `36.84%`. [](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5274 +/- ## - Coverage 53.16% 47.52% -5.64% + Complexity 3159 2855 -304 Files 816 799 -17 Lines 2045020012 -438 Branches 1969 1928 -41 - Hits 10872 9511-1361 - Misses 8697 9691 +994 + Partials881 810 -71 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...walking/apm/agent/core/jvm/cpu/JmxCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9KbXhDcHVBY2Nlc3Nvci5qYXZh) | `32.35% <32.35%> (ø)` | `4.00 <4.00> (?)` | | | [...skywalking/apm/agent/core/jvm/cpu/CPUProvider.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9DUFVQcm92aWRlci5qYXZh) | `85.71% <66.66%> (+12.38%)` | `3.00 <0.00> (ø)` | | | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `79.62% <100.00%> (+0.38%)` | `0.00 <0.00> (ø)` | | | [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...erver/storage/plugin/elasticsearch/base/EsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Fc0RBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | | | [...storage/plugin/elasticsearch/base/RecordEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9SZWNvcmRFc0RBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...torage/plugin/elasticsearch/base/MetricsEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9NZXRyaWNzRXNEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | |
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5274: make CPUMetricsAccessor SPI switchable and suppport other jvm
codecov[bot] edited a comment on pull request #5274: URL: https://github.com/apache/skywalking/pull/5274#issuecomment-670979080 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=h1) Report > Merging [#5274](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc) will **decrease** coverage by `22.08%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5274 +/- ## = - Coverage 53.16% 31.07% -22.09% + Complexity 3159 1856 -1303 = Files 816 799 -17 Lines 2045019932 -518 Branches 1969 1925 -44 = - Hits 10872 6194 -4678 - Misses 869713279 +4582 + Partials881 459 -422 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-79.25%)` | `0.00 <0.00> (ø)` | | | [...skywalking/apm/agent/core/jvm/cpu/CPUProvider.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9DUFVQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-73.34%)` | `0.00 <0.00> (-3.00)` | | | [...walking/apm/agent/core/jvm/cpu/JmxCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9KbXhDcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | ... and [276 more](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5274: make CPUMetricsAccessor SPI switchable and suppport other jvm
codecov[bot] edited a comment on pull request #5274: URL: https://github.com/apache/skywalking/pull/5274#issuecomment-670979080 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=h1) Report > Merging [#5274](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc) will **decrease** coverage by `23.38%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5274 +/- ## = - Coverage 53.16% 29.77% -23.39% + Complexity 3159 1793 -1366 = Files 816 799 -17 Lines 2045019906 -544 Branches 1969 1924 -45 = - Hits 10872 5928 -4944 - Misses 869713535 +4838 + Partials881 443 -438 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-79.25%)` | `0.00 <0.00> (ø)` | | | [...skywalking/apm/agent/core/jvm/cpu/CPUProvider.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9DUFVQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-73.34%)` | `0.00 <0.00> (-3.00)` | | | [...walking/apm/agent/core/jvm/cpu/JmxCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9KbXhDcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [306 more](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5274: make CPUMetricsAccessor SPI switchable and suppport other jvm
codecov[bot] edited a comment on pull request #5274: URL: https://github.com/apache/skywalking/pull/5274#issuecomment-670979080 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=h1) Report > Merging [#5274](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc) will **decrease** coverage by `21.43%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5274 +/- ## = - Coverage 53.16% 31.72% -21.44% + Complexity 3159 1907 -1252 = Files 816 799 -17 Lines 2045019966 -484 Branches 1969 1926 -43 = - Hits 10872 6335 -4537 - Misses 869713162 +4465 + Partials881 469 -412 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-79.25%)` | `0.00 <0.00> (ø)` | | | [...skywalking/apm/agent/core/jvm/cpu/CPUProvider.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9DUFVQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-73.34%)` | `0.00 <0.00> (-3.00)` | | | [...walking/apm/agent/core/jvm/cpu/JmxCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9KbXhDcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | ... and [267 more](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree-more) | | -- [Continue to review full report at
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5274: make CPUMetricsAccessor SPI switchable and suppport other jvm
codecov[bot] edited a comment on pull request #5274: URL: https://github.com/apache/skywalking/pull/5274#issuecomment-670979080 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5274: make CPUMetricsAccessor SPI switchable and suppport other jvm
codecov[bot] edited a comment on pull request #5274: URL: https://github.com/apache/skywalking/pull/5274#issuecomment-670979080 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=h1) Report > Merging [#5274](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc) will **decrease** coverage by `53.16%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5274 +/- ## - Coverage 53.16% 0.00% -53.17% Files 816 166 -650 Lines 204504122-16328 Branches 1969 487 -1482 - Hits 10872 0-10872 + Misses 86974122 -4575 + Partials881 0 -881 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-79.25%)` | `0.00 <0.00> (ø)` | | | [...skywalking/apm/agent/core/jvm/cpu/CPUProvider.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9DUFVQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-73.34%)` | `0.00 <0.00> (-3.00)` | | | [...walking/apm/agent/core/jvm/cpu/JmxCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9KbXhDcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [784 more](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=continue).
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5274: make CPUMetricsAccessor SPI switchable and suppport other jvm
codecov[bot] edited a comment on pull request #5274: URL: https://github.com/apache/skywalking/pull/5274#issuecomment-670979080 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=h1) Report > Merging [#5274](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc) will **decrease** coverage by `53.16%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5274 +/- ## - Coverage 53.16% 0.00% -53.17% Files 816 168 -648 Lines 204504134-16316 Branches 1969 487 -1482 - Hits 10872 0-10872 + Misses 86974134 -4563 + Partials881 0 -881 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-79.25%)` | `0.00 <0.00> (ø)` | | | [...skywalking/apm/agent/core/jvm/cpu/CPUProvider.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9DUFVQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-73.34%)` | `0.00 <0.00> (-3.00)` | | | [...walking/apm/agent/core/jvm/cpu/JmxCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9KbXhDcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [784 more](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=continue).
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5274: make CPUMetricsAccessor SPI switchable and suppport other jvm
codecov[bot] edited a comment on pull request #5274: URL: https://github.com/apache/skywalking/pull/5274#issuecomment-670979080 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=h1) Report > Merging [#5274](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc) will **decrease** coverage by `53.16%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5274 +/- ## - Coverage 53.16% 0.00% -53.17% Files 816 165 -651 Lines 204504116-16334 Branches 1969 487 -1482 - Hits 10872 0-10872 + Misses 86974116 -4581 + Partials881 0 -881 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-79.25%)` | `0.00 <0.00> (ø)` | | | [...skywalking/apm/agent/core/jvm/cpu/CPUProvider.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9DUFVQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-73.34%)` | `0.00 <0.00> (-3.00)` | | | [...walking/apm/agent/core/jvm/cpu/JmxCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9KbXhDcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [785 more](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=continue).
[GitHub] [skywalking] wu-sheng commented on pull request #5275: add ignore *.log for hs_err_pid*.log/replay_pid*.log
wu-sheng commented on pull request #5275: URL: https://github.com/apache/skywalking/pull/5275#issuecomment-670990993 You could have many files, such as dump file. It is not reasonable to add ignore for all. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5274: make CPUMetricsAccessor SPI switchable and suppport other jvm
codecov[bot] edited a comment on pull request #5274: URL: https://github.com/apache/skywalking/pull/5274#issuecomment-670979080 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=h1) Report > Merging [#5274](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc) will **decrease** coverage by `53.16%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5274 +/- ## - Coverage 53.16% 0.00% -53.17% Files 816 163 -653 Lines 204504080-16370 Branches 1969 482 -1487 - Hits 10872 0-10872 + Misses 86974080 -4617 + Partials881 0 -881 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-79.25%)` | `0.00 <0.00> (ø)` | | | [...skywalking/apm/agent/core/jvm/cpu/CPUProvider.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9DUFVQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-73.34%)` | `0.00 <0.00> (-3.00)` | | | [...walking/apm/agent/core/jvm/cpu/JmxCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9KbXhDcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [787 more](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=continue).
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5274: make CPUMetricsAccessor SPI switchable and suppport other jvm
codecov[bot] edited a comment on pull request #5274: URL: https://github.com/apache/skywalking/pull/5274#issuecomment-670979080 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5274: make CPUMetricsAccessor SPI switchable and suppport other jvm
codecov[bot] edited a comment on pull request #5274: URL: https://github.com/apache/skywalking/pull/5274#issuecomment-670979080 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=h1) Report > Merging [#5274](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc) will **decrease** coverage by `53.16%`. > The diff coverage is `0.00%`. [](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #5274 +/- ## - Coverage 53.16% 0.00% -53.17% Files 816 158 -658 Lines 204503975-16475 Branches 1969 471 -1498 - Hits 10872 0-10872 + Misses 86973975 -4722 + Partials881 0 -881 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../apache/skywalking/apm/agent/core/conf/Config.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9Db25maWcuamF2YQ==) | `0.00% <0.00%> (-79.25%)` | `0.00 <0.00> (ø)` | | | [...skywalking/apm/agent/core/jvm/cpu/CPUProvider.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9DUFVQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-73.34%)` | `0.00 <0.00> (-3.00)` | | | [...walking/apm/agent/core/jvm/cpu/JmxCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9KbXhDcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | | | [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | | | [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | | | [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | | | ... and [788 more](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=continue).
[GitHub] [skywalking] wu-sheng edited a comment on issue #5266: Clean Up and Improve protobufs in skywalking-data-collect-protocol
wu-sheng edited a comment on issue #5266: URL: https://github.com/apache/skywalking/issues/5266#issuecomment-670989879 What new API? Envoy existing proto is in sake case, but generated java codes are camel case. But still, it is high risk. Anyway. Breaking generated codes a would affect the existing agent codes a lot. There are too many agents, I expect don't change in that case. @dio I think this is not a block for envoy side, right? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5274: make CPUMetricsAccessor SPI switchable and suppport other jvm
codecov[bot] edited a comment on pull request #5274: URL: https://github.com/apache/skywalking/pull/5274#issuecomment-670979080 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=h1) Report > Merging [#5274](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc) will **increase** coverage by `0.04%`. > The diff coverage is `8.10%`. [](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5274 +/- ## + Coverage 53.16% 53.21% +0.04% Complexity 3159 3159 Files 816 1485 +669 Lines 2045032021 +11571 Branches 1969 3518+1549 + Hits 1087217039+6167 - Misses 869714171+5474 + Partials881 811 -70 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5274?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...walking/apm/agent/core/jvm/cpu/JmxCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9KbXhDcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...skywalking/apm/agent/core/jvm/cpu/CPUProvider.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9DUFVQcm92aWRlci5qYXZh) | `71.42% <100.00%> (-1.91%)` | `3.00 <0.00> (ø)` | | | [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `12.16% <0.00%> (-77.84%)` | `2.00% <0.00%> (ø%)` | | | [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `20.75% <0.00%> (-37.15%)` | `2.00% <0.00%> (ø%)` | | | [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `66.66% <0.00%> (-33.34%)` | `2.00% <0.00%> (ø%)` | | | [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `80.00% <0.00%> (-20.00%)` | `2.00% <0.00%> (ø%)` | | | [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `80.00% <0.00%> (-20.00%)` | `2.00% <0.00%> (ø%)` | | | [...ticsearch7/client/ElasticSearch7UpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdVcGRhdGVSZXF1ZXN0LmphdmE=) | `80.00% <0.00%> (-20.00%)` | `2.00% <0.00%> (ø%)` | | | [...ticsearch7/client/ElasticSearch7InsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/5274/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdJbnNlcnRSZXF1ZXN0LmphdmE=) | `83.33% <0.00%> (-16.67%)` | `2.00% <0.00%> (ø%)` | | |
[GitHub] [skywalking] qxo commented on pull request #5275: add ignore *.log for hs_err_pid*.log/replay_pid*.log
qxo commented on pull request #5275: URL: https://github.com/apache/skywalking/pull/5275#issuecomment-670990184 > That is unexpected, why we need to ignore those? We don't have tests for JVM crashing. The ignore file is not for all caees, it just ignore for tool config or test generated files. 当构建时内存不足就会产生这些临时文件, we should ignore it just like target dir. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #5266: Clean Up and Improve protobufs in skywalking-data-collect-protocol
wu-sheng commented on issue #5266: URL: https://github.com/apache/skywalking/issues/5266#issuecomment-670989879 What new API? Envoy existing proto is in sake case, but generated java codes are camel case. Anyway. Breaking generated codes a would affect the existing agent codes a lot. There are too many agents, I expect don't change in that case. @dio I think this is not a block for envoy side, right? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5269: Support !=, like filter expressions in OAL
codecov[bot] edited a comment on pull request #5269: URL: https://github.com/apache/skywalking/pull/5269#issuecomment-670856618 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5269?src=pr=h1) Report > Merging [#5269](https://codecov.io/gh/apache/skywalking/pull/5269?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc) will **increase** coverage by `0.08%`. > The diff coverage is `70.68%`. [](https://codecov.io/gh/apache/skywalking/pull/5269?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5269 +/- ## + Coverage 53.16% 53.25% +0.08% - Complexity 3159 3167 +8 Files 816 821 +5 Lines 2045020455 +5 Branches 1969 1965 -4 + Hits 1087210893 +21 + Misses 8697 8681 -16 Partials881 881 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5269?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...lysis/metrics/expression/BooleanNotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5269/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0Jvb2xlYW5Ob3RFcXVhbE1hdGNoLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...r/core/analysis/metrics/expression/EqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5269/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0VxdWFsTWF0Y2guamF2YQ==) | `100.00% <ø> (+75.00%)` | `2.00 <0.00> (-2.00)` | :arrow_up: | | [...analysis/metrics/expression/GreaterEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5269/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0dyZWF0ZXJFcXVhbE1hdGNoLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...core/analysis/metrics/expression/GreaterMatch.java](https://codecov.io/gh/apache/skywalking/pull/5269/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0dyZWF0ZXJNYXRjaC5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...re/analysis/metrics/expression/LessEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5269/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0xlc3NFcXVhbE1hdGNoLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...er/core/analysis/metrics/expression/LessMatch.java](https://codecov.io/gh/apache/skywalking/pull/5269/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0xlc3NNYXRjaC5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...er/core/analysis/metrics/expression/LikeMatch.java](https://codecov.io/gh/apache/skywalking/pull/5269/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0xpa2VNYXRjaC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5269/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/5269/diff?src=pr=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `62.75% <50.00%> (-0.21%)` | `29.00 <0.00> (ø)` | | | [...core/analysis/metrics/expression/BooleanMatch.java](https://codecov.io/gh/apache/skywalking/pull/5269/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0Jvb2xlYW5NYXRjaC5qYXZh) | `66.66% <66.66%> (ø)` | `3.00 <3.00> (?)` | | | ... and [15 more](https://codecov.io/gh/apache/skywalking/pull/5269/diff?src=pr=tree-more) | | --
[GitHub] [skywalking] wu-sheng commented on pull request #5275: add ignore *.log for hs_err_pid*.log/replay_pid*.log
wu-sheng commented on pull request #5275: URL: https://github.com/apache/skywalking/pull/5275#issuecomment-670989431 That is unexpected, why we need to ignore those? We don't have tests for JVM crashing. The ignore file is not for all caees, it just ignore for tool config or test generated files. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] wu-sheng closed pull request #5275: add ignore *.log for hs_err_pid*.log/replay_pid*.log
wu-sheng closed pull request #5275: URL: https://github.com/apache/skywalking/pull/5275 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] qxo commented on pull request #5275: add ignore *.log for hs_err_pid*.log/replay_pid*.log
qxo commented on pull request #5275: URL: https://github.com/apache/skywalking/pull/5275#issuecomment-670989292 > This pr conflicts with master. And where are these logs from? hs_err_pid*.log/replay_pid*.log generated when jvm crash on maven build. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5269: Support !=, like filter expressions in OAL
codecov[bot] edited a comment on pull request #5269: URL: https://github.com/apache/skywalking/pull/5269#issuecomment-670856618 # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5269?src=pr=h1) Report > Merging [#5269](https://codecov.io/gh/apache/skywalking/pull/5269?src=pr=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/b0bb7cf3beb9caa0c8647227c38598b946d8e0c0=desc) will **increase** coverage by `0.08%`. > The diff coverage is `70.68%`. [](https://codecov.io/gh/apache/skywalking/pull/5269?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#5269 +/- ## + Coverage 53.16% 53.25% +0.08% - Complexity 3159 3167 +8 Files 816 821 +5 Lines 2045020455 +5 Branches 1969 1965 -4 + Hits 1087210893 +21 + Misses 8697 8681 -16 Partials881 881 ``` | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5269?src=pr=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...lysis/metrics/expression/BooleanNotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5269/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0Jvb2xlYW5Ob3RFcXVhbE1hdGNoLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...r/core/analysis/metrics/expression/EqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5269/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0VxdWFsTWF0Y2guamF2YQ==) | `100.00% <ø> (+75.00%)` | `2.00 <0.00> (-2.00)` | :arrow_up: | | [...analysis/metrics/expression/GreaterEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5269/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0dyZWF0ZXJFcXVhbE1hdGNoLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...core/analysis/metrics/expression/GreaterMatch.java](https://codecov.io/gh/apache/skywalking/pull/5269/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0dyZWF0ZXJNYXRjaC5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...re/analysis/metrics/expression/LessEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5269/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0xlc3NFcXVhbE1hdGNoLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...er/core/analysis/metrics/expression/LessMatch.java](https://codecov.io/gh/apache/skywalking/pull/5269/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0xlc3NNYXRjaC5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | | | [...er/core/analysis/metrics/expression/LikeMatch.java](https://codecov.io/gh/apache/skywalking/pull/5269/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0xpa2VNYXRjaC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [...ore/analysis/metrics/expression/NotEqualMatch.java](https://codecov.io/gh/apache/skywalking/pull/5269/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL05vdEVxdWFsTWF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | | | [.../java/org/apache/skywalking/oal/rt/OALRuntime.java](https://codecov.io/gh/apache/skywalking/pull/5269/diff?src=pr=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L09BTFJ1bnRpbWUuamF2YQ==) | `62.75% <50.00%> (-0.21%)` | `29.00 <0.00> (ø)` | | | [...core/analysis/metrics/expression/BooleanMatch.java](https://codecov.io/gh/apache/skywalking/pull/5269/diff?src=pr=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9leHByZXNzaW9uL0Jvb2xlYW5NYXRjaC5qYXZh) | `66.66% <66.66%> (ø)` | `3.00 <3.00> (?)` | | | ... and [15 more](https://codecov.io/gh/apache/skywalking/pull/5269/diff?src=pr=tree-more) | | --
[GitHub] [skywalking] wu-sheng commented on a change in pull request #5274: make CPUMetricsAccessor SPI switchable and suppport other jvm
wu-sheng commented on a change in pull request #5274:
URL: https://github.com/apache/skywalking/pull/5274#discussion_r467518542
##
File path:
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/jvm/cpu/CPUProvider.java
##
@@ -30,10 +30,11 @@
CPUProvider() {
int processorNum = ProcessorUtil.getNumberOfProcessors();
try {
-this.cpuMetricsAccessor = (CPUMetricsAccessor)
CPUProvider.class.getClassLoader()
-
.loadClass("org.apache.skywalking.apm.agent.core.jvm.cpu.SunCpuAccessor")
-
.getConstructor(int.class)
-
.newInstance(processorNum);
+
//-Dskywalking.cpu_provider=org.apache.skywalking.apm.agent.core.jvm.cpu.JmxCpuAccessor
+final String cpuAccessorCls =
System.getProperty("skywalking.cpu_provider",
Review comment:
This is a wrong way to extend.
1. System properties are supported for config injection in the Config.java.
1. Why use try catch and config at the same time?
1. Take a reference from memory gc access. The different accessors should be
used based on JVM automatical detection.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #5275: add ignore *.log for hs_err_pid*.log/replay_pid*.log
wu-sheng commented on pull request #5275: URL: https://github.com/apache/skywalking/pull/5275#issuecomment-670988037 This pr conflicts with master. And where are these logs from? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [skywalking] dio commented on issue #5266: Clean Up and Improve protobufs in skywalking-data-collect-protocol
dio commented on issue #5266: URL: https://github.com/apache/skywalking/issues/5266#issuecomment-670984844 Seems like it is easier to introduce a new set of APIs? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
